From: Fabio Forni <development@redaril.me>
Cc: Fabio Forni <development@redaril.me>,
Mark Brown <broonie@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC 1/3] ASoC: simple-card: Do not print "parse error" twice
Date: Tue, 13 Jan 2026 00:12:22 +0100 [thread overview]
Message-ID: <20260112231855.193030-2-development@redaril.me> (raw)
In-Reply-To: <20260112231855.193030-1-development@redaril.me>
If an error occurred on line 747, we'd print "parse error" and then go
to the `err` label, where we print the same message.
Let's remove the duplicated print.
Signed-off-by: Fabio Forni <development@redaril.me>
---
sound/soc/generic/simple-card.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c
index 5af6d1b308f2..8d36cbbfca1d 100644
--- a/sound/soc/generic/simple-card.c
+++ b/sound/soc/generic/simple-card.c
@@ -745,10 +745,8 @@ static int simple_probe(struct platform_device *pdev)
if (np && of_device_is_available(np)) {
ret = simple_parse_of(priv, li);
- if (ret < 0) {
- dev_err_probe(dev, ret, "parse error\n");
+ if (ret < 0)
goto err;
- }
} else {
struct simple_util_info *cinfo;
--
2.52.0
next prev parent reply other threads:[~2026-01-12 23:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 23:12 [RFC 0/3] simple-card: Improve probe's error messages Fabio Forni
2026-01-12 23:12 ` Fabio Forni [this message]
2026-01-13 2:29 ` [RFC 1/3] ASoC: simple-card: Do not print "parse error" twice Kuninori Morimoto
2026-01-13 8:24 ` Fabio
2026-01-12 23:12 ` [RFC 2/3] ASoC: simple-card: Replace "parse error" with a more descriptive msg Fabio Forni
2026-01-12 23:12 ` [RFC 3/3] ASoC: simple-card: Split alloc and init logics in probe function Fabio Forni
2026-01-13 2:33 ` Kuninori Morimoto
2026-01-13 22:31 ` Fabio
2026-01-20 6:32 ` Kuninori Morimoto
2026-01-24 10:23 ` Fabio
2026-01-26 0:56 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112231855.193030-2-development@redaril.me \
--to=development@redaril.me \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox