From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.unwrap.rs (mail.unwrap.rs [172.232.15.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C7F320385 for ; Wed, 14 Jan 2026 02:56:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=172.232.15.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768359374; cv=none; b=OpARe179RSG4caqzhnEFzQpxuhJOptzmAR1pk6xg+rJ+uwI87eOc4r46ksN3FTcTQSG9JMOaSk8H3walhJaiLgMAQxRC1B6J3RkPQ8ke7BSxDmO87h5zaXAGGPRzlF+0lsJYDs9y0mxqqiNq3Jhwa21gHDMsbsDGClgs+2g+Ykw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768359374; c=relaxed/simple; bh=9EhXfKEsiO99DFG4Or4PWBIn5H8mSq9LQbb85lpYTKs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hS8lvc1pnEXFrzZ13ZBTUK2Hbi2bami/a1Y+HeXMRPHkCO1diB2AU48CZB5ofczBrn4l5U4u8jCIihBjm63AjKUFTQbkj15vLehumjbUYHR34XFARLKu8SA0Kja+FfHfbQ2ytvRPZj0x9+aOKUyCXWaaI+y3MzzXpVqoUjN6P/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs; spf=pass smtp.mailfrom=unwrap.rs; arc=none smtp.client-ip=172.232.15.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=unwrap.rs Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=unwrap.rs From: Cole Leavitt To: linux-sound@vger.kernel.org Cc: ckeepax@opensource.cirrus.com, sbinding@opensource.cirrus.com, broonie@kernel.org, patches@opensource.cirrus.com, cole@unwrap.rs Subject: [PATCH v2] ASoC: sdw_utils: cs42l43: Enable Headphone pin for LINEOUT jack type Date: Tue, 13 Jan 2026 19:55:18 -0700 Message-ID: <20260114025518.28519-1-cole@unwrap.rs> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260113084402.10427-1-cole@unwrap.rs> References: <20260113084402.10427-1-cole@unwrap.rs> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The CS42L43 codec's load detection can return different impedance values that map to either HEADPHONE or LINEOUT jack types. However, the soc_jack_pins array only maps SND_JACK_HEADPHONE to the "Headphone" DAPM pin, not SND_JACK_LINEOUT. When headphones are detected with an impedance that maps to LINEOUT (such as impedance value 0x2), the driver reports SND_JACK_LINEOUT. Since this doesn't match the jack pin mask, the "Headphone" DAPM pin is not activated, and no audio is routed to the headphone outputs. Fix by adding SND_JACK_LINEOUT to the Headphone pin mask, so that both headphone and line-out detection properly enable the headphone output path. This fixes no audio output on devices like the Lenovo ThinkPad P16 Gen 3 where headphones are detected with LINEOUT impedance. Fixes: d74bad3b7452 ("ASoC: intel: sof_sdw_cs42l43: Create separate jacks for hp and mic") Reviewed-by: Charles Keepax Signed-off-by: Cole Leavitt --- Changes in v2: - Fixed Fixes tag to reference correct commit d74bad3b7452 - Added Reviewed-by from Charles Keepax --- sound/soc/sdw_utils/soc_sdw_cs42l43.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sdw_utils/soc_sdw_cs42l43.c b/sound/soc/sdw_utils/soc_sdw_cs42l43.c index 4c954501e500..2685ff4f0932 100644 --- a/sound/soc/sdw_utils/soc_sdw_cs42l43.c +++ b/sound/soc/sdw_utils/soc_sdw_cs42l43.c @@ -44,7 +44,7 @@ static const struct snd_soc_dapm_route cs42l43_dmic_map[] = { static struct snd_soc_jack_pin soc_jack_pins[] = { { .pin = "Headphone", - .mask = SND_JACK_HEADPHONE, + .mask = SND_JACK_HEADPHONE | SND_JACK_LINEOUT, }, { .pin = "Headset Mic", -- 2.52.0