From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com,
pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org,
patches@opensource.cirrus.com
Subject: [PATCH 1/6] ASoC: SDCA: Remove outdated todo comment
Date: Wed, 4 Feb 2026 12:59:38 +0000 [thread overview]
Message-ID: <20260204125944.1134011-2-ckeepax@opensource.cirrus.com> (raw)
In-Reply-To: <20260204125944.1134011-1-ckeepax@opensource.cirrus.com>
Support for -cn- properties has already been added, however the TODO
comment noting this feature was required was not removed. Remove the
now redundant comment.
Fixes: 50a479527ef01 ("ASoC: SDCA: Add support for -cn- value properties")
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
---
sound/soc/sdca/sdca_functions.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c
index 80c71116e6d4c..f97dde912d590 100644
--- a/sound/soc/sdca/sdca_functions.c
+++ b/sound/soc/sdca/sdca_functions.c
@@ -911,10 +911,6 @@ static int find_sdca_control_value(struct device *dev, struct sdca_entity *entit
return 0;
}
-/*
- * TODO: Add support for -cn- properties, allowing different channels to have
- * different defaults etc.
- */
static int find_sdca_entity_control(struct device *dev, struct sdca_entity *entity,
struct fwnode_handle *control_node,
struct sdca_control *control)
--
2.47.3
next prev parent reply other threads:[~2026-02-04 13:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 12:59 [PATCH 0/6] Minor SDCA Fixes Charles Keepax
2026-02-04 12:59 ` Charles Keepax [this message]
2026-02-04 12:59 ` [PATCH 2/6] ASoC: SDCA: Handle volatile controls correctly Charles Keepax
2026-02-04 12:59 ` [PATCH 3/6] ASoC: SDCA: Still process most of the jack detect if control is missing Charles Keepax
2026-02-04 12:59 ` [PATCH 4/6] ASoC: SDCA: Rearrange FDL file messages Charles Keepax
2026-02-04 12:59 ` [PATCH 5/6] ASoC: SDCA: Add regmap defaults for specification defined values Charles Keepax
2026-02-04 12:59 ` [PATCH 6/6] ASoC: SDCA: Limit values user can write to Selected Mode Charles Keepax
2026-02-04 13:58 ` [PATCH 0/6] Minor SDCA Fixes Pierre-Louis Bossart
2026-02-05 11:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204125944.1134011-2-ckeepax@opensource.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox