From: Yauhen Kharuzhy <jekhor@gmail.com>
To: Oder Chiou <oder_chiou@realtek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
Hans de Goede <hansg@kernel.org>,
Yauhen Kharuzhy <jekhor@gmail.com>
Subject: [PATCH 4/7] ASoC: rt5677: Report error if the ID register cannot be read
Date: Wed, 11 Feb 2026 02:18:36 +0200 [thread overview]
Message-ID: <20260211002255.4090440-5-jekhor@gmail.com> (raw)
In-Reply-To: <20260211002255.4090440-1-jekhor@gmail.com>
To make error messages clearer, report if the ID register failed to be
read via I2C during probing.
Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
---
sound/soc/codecs/rt5677.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index 6628c7ca5a8a..845385c1fb88 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5602,7 +5602,13 @@ static int rt5677_i2c_probe(struct i2c_client *i2c)
return ret;
}
- regmap_read(rt5677->regmap, RT5677_VENDOR_ID2, &val);
+ ret = regmap_read(rt5677->regmap, RT5677_VENDOR_ID2, &val);
+ if (ret) {
+ dev_err(&i2c->dev,
+ "Failed to read ID register: %d\n", ret);
+ return -ENODEV;
+ }
+
if (val != RT5677_DEVICE_ID) {
dev_err(&i2c->dev,
"Device with ID register %#x is not rt5677\n", val);
--
2.51.0
next prev parent reply other threads:[~2026-02-11 0:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-11 0:18 ASoC rt5677: Prepare to support Lenovo Yoga Book tablets Yauhen Kharuzhy
2026-02-11 0:18 ` [PATCH 1/7] ASoC: rt5677: Add 10EC5677 ACPI ID as supported Yauhen Kharuzhy
2026-02-25 19:06 ` Mark Brown
2026-02-11 0:18 ` [PATCH 2/7] ASoC: rt5677: Allow it to be defined as an I2C board Yauhen Kharuzhy
2026-02-11 0:18 ` [PATCH 3/7] ASoC: rt5677: Fix typo in the header file Yauhen Kharuzhy
2026-02-11 0:18 ` Yauhen Kharuzhy [this message]
2026-02-11 0:18 ` [PATCH 5/7] ASoC: rt5677: Set up ACPI GPIO pins mapping table Yauhen Kharuzhy
2026-02-11 0:18 ` [PATCH 6/7] ASoC: rt5677: Reset the codec during probing Yauhen Kharuzhy
2026-02-11 0:18 ` [PATCH 7/7] ASoC: rt5677-spi: Add SPI device ID matching table Yauhen Kharuzhy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260211002255.4090440-5-jekhor@gmail.com \
--to=jekhor@gmail.com \
--cc=broonie@kernel.org \
--cc=hansg@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox