public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Yauhen Kharuzhy <jekhor@gmail.com>
To: Oder Chiou <oder_chiou@realtek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hans de Goede <hansg@kernel.org>,
	Yauhen Kharuzhy <jekhor@gmail.com>
Subject: [PATCH 6/7] ASoC: rt5677: Reset the codec during probing
Date: Wed, 11 Feb 2026 02:18:38 +0200	[thread overview]
Message-ID: <20260211002255.4090440-7-jekhor@gmail.com> (raw)
In-Reply-To: <20260211002255.4090440-1-jekhor@gmail.com>

To ensure that the codec is in a known state, reset it during driver
initialization.

Signed-off-by: Yauhen Kharuzhy <jekhor@gmail.com>
---
 sound/soc/codecs/rt5677.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c
index f56ac267f53b..60a93c3fe2e7 100644
--- a/sound/soc/codecs/rt5677.c
+++ b/sound/soc/codecs/rt5677.c
@@ -5581,14 +5581,21 @@ static int rt5677_i2c_probe(struct i2c_client *i2c)
 		dev_err(&i2c->dev, "Failed to request POW_LDO2: %d\n", ret);
 		return ret;
 	}
+
 	rt5677->reset_pin = devm_gpiod_get_optional(&i2c->dev,
-			"realtek,reset", GPIOD_OUT_LOW);
+			"realtek,reset", GPIOD_OUT_HIGH);
+
 	if (IS_ERR(rt5677->reset_pin)) {
 		ret = PTR_ERR(rt5677->reset_pin);
 		dev_err(&i2c->dev, "Failed to request RESET: %d\n", ret);
 		return ret;
 	}
 
+	if (rt5677->reset_pin) {
+		msleep(1);
+		gpiod_set_value_cansleep(rt5677->reset_pin, 0);
+	}
+
 	if (rt5677->pow_ldo2 || rt5677->reset_pin) {
 		/* Wait a while until I2C bus becomes available. The datasheet
 		 * does not specify the exact we should wait but startup
-- 
2.51.0


  parent reply	other threads:[~2026-02-11  0:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11  0:18 ASoC rt5677: Prepare to support Lenovo Yoga Book tablets Yauhen Kharuzhy
2026-02-11  0:18 ` [PATCH 1/7] ASoC: rt5677: Add 10EC5677 ACPI ID as supported Yauhen Kharuzhy
2026-02-25 19:06   ` Mark Brown
2026-02-11  0:18 ` [PATCH 2/7] ASoC: rt5677: Allow it to be defined as an I2C board Yauhen Kharuzhy
2026-02-11  0:18 ` [PATCH 3/7] ASoC: rt5677: Fix typo in the header file Yauhen Kharuzhy
2026-02-11  0:18 ` [PATCH 4/7] ASoC: rt5677: Report error if the ID register cannot be read Yauhen Kharuzhy
2026-02-11  0:18 ` [PATCH 5/7] ASoC: rt5677: Set up ACPI GPIO pins mapping table Yauhen Kharuzhy
2026-02-11  0:18 ` Yauhen Kharuzhy [this message]
2026-02-11  0:18 ` [PATCH 7/7] ASoC: rt5677-spi: Add SPI device ID matching table Yauhen Kharuzhy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211002255.4090440-7-jekhor@gmail.com \
    --to=jekhor@gmail.com \
    --cc=broonie@kernel.org \
    --cc=hansg@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=oder_chiou@realtek.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox