* [PATCH] ASoC: amd: add DMIC support for RPL platform
@ 2026-02-05 2:07 Mingyou Chen
2026-02-06 17:51 ` Mark Brown
0 siblings, 1 reply; 19+ messages in thread
From: Mingyou Chen @ 2026-02-05 2:07 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
linux-kernel, linux-sound
Cc: Mingyou Chen
Add DMIC support for the AMD RPL platform. The drivers are derived on
the YC platform driver.
Signed-off-by: Mingyou Chen <qby140326@gmail.com>
---
sound/soc/amd/Kconfig | 11 +
sound/soc/amd/rpl/Makefile | 4 +
sound/soc/amd/rpl/rpl-acp6x-mach.c | 131 +++++
sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c | 454 ++++++++++++++++++
sound/soc/amd/rpl/rpl-pci-acp6x.c | 123 ++++-
sound/soc/amd/rpl/rpl_acp6x.h | 90 +++-
.../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 420 +++++++++++++++-
7 files changed, 1221 insertions(+), 12 deletions(-)
create mode 100644 sound/soc/amd/rpl/rpl-acp6x-mach.c
create mode 100644 sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index fd35a03aadcb..da2940e94a7e 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -134,6 +134,17 @@ config SND_SOC_AMD_RPL_ACP6x
Say m if you have such a device.
If unsure select "N".
+config SND_SOC_AMD_RPL_MACH
+ tristate "AMD RPL support for DMIC"
+ select SND_SOC_DMIC
+ depends on SND_SOC_AMD_ACP6x && ACPI
+ help
+ This option enables machine driver for AMD RPL platform
+ using dmic. ACP IP has PDM Decoder block with DMA controller.
+ DMIC can be connected directly to ACP IP.
+ Say m if you have such a device.
+ If unsure select "N".
+
config SND_SOC_AMD_ACP63_TOPLEVEL
tristate "support for AMD platforms with ACP version >= 6.3"
default SND_AMD_ACP_CONFIG
diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
index a3825c5be4e7..b1190fcdf1f6 100644
--- a/sound/soc/amd/rpl/Makefile
+++ b/sound/soc/amd/rpl/Makefile
@@ -1,5 +1,9 @@
# SPDX-License-Identifier: GPL-2.0+
# RPL platform Support
snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
+snd-rpl-acp6x-pdm-dma-y := rpl-acp6x-pdm-dma.o
+snd-soc-rpl-acp6x-mach-y := rpl-acp6x-mach.o
obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
+obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-acp6x-pdm-dma.o
+obj-$(CONFIG_SND_SOC_AMD_RPL_MACH) += snd-soc-rpl-acp6x-mach.o
diff --git a/sound/soc/amd/rpl/rpl-acp6x-mach.c b/sound/soc/amd/rpl/rpl-acp6x-mach.c
new file mode 100644
index 000000000000..71a384b9a36c
--- /dev/null
+++ b/sound/soc/amd/rpl/rpl-acp6x-mach.c
@@ -0,0 +1,131 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Machine driver for AMD RPL platform using DMIC
+ *
+ * Copyright 2025 Advanced Micro Devices, Inc.
+ */
+
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <linux/module.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <linux/io.h>
+#include <linux/dmi.h>
+#include <linux/acpi.h>
+
+#include "rpl_acp6x.h"
+
+#define DRV_NAME "acp_rpl_mach"
+
+SND_SOC_DAILINK_DEF(acp6x_pdm,
+ DAILINK_COMP_ARRAY(COMP_CPU("acp_rpl_pdm_dma.0")));
+
+SND_SOC_DAILINK_DEF(dmic_codec,
+ DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
+ "dmic-hifi")));
+
+SND_SOC_DAILINK_DEF(pdm_platform,
+ DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_rpl_pdm_dma.0")));
+
+static struct snd_soc_dai_link acp6x_dai_pdm[] = {
+ {
+ .name = "rpl-acp6x-dmic-capture",
+ .stream_name = "DMIC capture",
+ .capture_only = 1,
+ SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
+ },
+};
+
+static struct snd_soc_card acp6x_card = {
+ .name = "acp6x",
+ .owner = THIS_MODULE,
+ .dai_link = acp6x_dai_pdm,
+ .num_links = 1,
+};
+
+static const struct dmi_system_id rpl_acp_quirk_table[] = {
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
+ }
+ },
+ {}
+};
+
+static int acp6x_probe(struct platform_device *pdev)
+{
+ const struct dmi_system_id *dmi_id;
+ struct acp6x_pdm *machine = NULL;
+ struct snd_soc_card *card;
+ struct acpi_device *adev;
+ acpi_handle handle;
+ acpi_integer dmic_status;
+ int ret;
+ bool is_dmic_enable, wov_en;
+
+ /* IF WOV entry not found, enable dmic based on AcpDmicConnected entry*/
+ is_dmic_enable = false;
+ wov_en = true;
+ /* check the parent device's firmware node has _DSD or not */
+ adev = ACPI_COMPANION(pdev->dev.parent);
+ if (adev) {
+ const union acpi_object *obj;
+
+ if (!acpi_dev_get_property(adev, "AcpDmicConnected", ACPI_TYPE_INTEGER, &obj) &&
+ obj->integer.value == 1)
+ is_dmic_enable = true;
+ }
+
+ handle = ACPI_HANDLE(pdev->dev.parent);
+ ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
+ if (!ACPI_FAILURE(ret)) {
+ wov_en = dmic_status;
+ if (!wov_en)
+ return -ENODEV;
+ } else {
+ /* Incase of ACPI method read failure then jump to check_dmi_entry */
+ goto check_dmi_entry;
+ }
+
+ if (is_dmic_enable)
+ platform_set_drvdata(pdev, &acp6x_card);
+
+check_dmi_entry:
+ /* check for any DMI overrides */
+ dmi_id = dmi_first_match(rpl_acp_quirk_table);
+ if (dmi_id)
+ platform_set_drvdata(pdev, dmi_id->driver_data);
+
+ card = platform_get_drvdata(pdev);
+ if (!card)
+ return -ENODEV;
+ dev_info(&pdev->dev, "Enabling ACP DMIC support via %s", dmi_id ? "DMI" : "ACPI");
+ acp6x_card.dev = &pdev->dev;
+
+ snd_soc_card_set_drvdata(card, machine);
+ ret = devm_snd_soc_register_card(&pdev->dev, card);
+ if (ret) {
+ return dev_err_probe(&pdev->dev, ret,
+ "snd_soc_register_card(%s) failed\n",
+ card->name);
+ }
+ return 0;
+}
+
+static struct platform_driver rpl_acp6x_mach_driver = {
+ .driver = {
+ .name = "acp_rpl_mach",
+ .pm = &snd_soc_pm_ops,
+ },
+ .probe = acp6x_probe,
+};
+
+module_platform_driver(rpl_acp6x_mach_driver);
+
+MODULE_DESCRIPTION("AMD RPL support for DMIC");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
+
diff --git a/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
new file mode 100644
index 000000000000..2ae6d388e488
--- /dev/null
+++ b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
@@ -0,0 +1,454 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * AMD ALSA SoC RPL PDM Driver
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/bitfield.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <linux/pm_runtime.h>
+
+#include "rpl_acp6x.h"
+
+#define DRV_NAME "acp_rpl_pdm_dma"
+
+static int pdm_gain = 3;
+module_param(pdm_gain, int, 0644);
+MODULE_PARM_DESC(pdm_gain, "Gain control (0-3)");
+
+static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
+ .info = SNDRV_PCM_INFO_INTERLEAVED |
+ SNDRV_PCM_INFO_BLOCK_TRANSFER |
+ SNDRV_PCM_INFO_MMAP |
+ SNDRV_PCM_INFO_MMAP_VALID |
+ SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+ .formats = SNDRV_PCM_FMTBIT_S32_LE,
+ .channels_min = 2,
+ .channels_max = 2,
+ .rates = SNDRV_PCM_RATE_48000,
+ .rate_min = 48000,
+ .rate_max = 48000,
+ .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
+ .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
+ .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
+ .periods_min = CAPTURE_MIN_NUM_PERIODS,
+ .periods_max = CAPTURE_MAX_NUM_PERIODS,
+};
+
+static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
+ u32 watermark_size, void __iomem *acp_base)
+{
+ rpl_acp_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
+ rpl_acp_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
+ rpl_acp_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
+ rpl_acp_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
+}
+
+static void acp6x_enable_pdm_clock(void __iomem *acp_base)
+{
+ u32 pdm_clk_enable, pdm_ctrl;
+
+ pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
+ pdm_ctrl = 0x00;
+
+ rpl_acp_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
+ pdm_ctrl = rpl_acp_readl(acp_base + ACP_WOV_MISC_CTRL);
+ pdm_ctrl &= ~ACP_WOV_GAIN_CONTROL;
+ pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, clamp(pdm_gain, 0, 3));
+ rpl_acp_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
+}
+
+static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
+{
+ u32 ext_int_ctrl;
+
+ ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
+ ext_int_ctrl |= PDM_DMA_INTR_MASK;
+ rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
+}
+
+static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
+{
+ u32 ext_int_ctrl;
+
+ ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
+ ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
+ rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
+}
+
+static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
+{
+ bool pdm_dma_status;
+ u32 pdm_enable, pdm_dma_enable;
+
+ pdm_dma_status = false;
+ pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
+ pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable & ACP_PDM_DMA_EN_STATUS))
+ pdm_dma_status = true;
+
+ return pdm_dma_status;
+}
+
+static int acp6x_start_pdm_dma(void __iomem *acp_base)
+{
+ u32 pdm_enable;
+ u32 pdm_dma_enable;
+ int timeout;
+
+ pdm_enable = 0x01;
+ pdm_dma_enable = 0x01;
+
+ acp6x_enable_pdm_clock(acp_base);
+ rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
+ rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ timeout = 0;
+ while (++timeout < ACP_COUNTER) {
+ pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
+ return 0;
+ udelay(DELAY_US);
+ }
+ return -ETIMEDOUT;
+}
+
+static int acp6x_stop_pdm_dma(void __iomem *acp_base)
+{
+ u32 pdm_enable, pdm_dma_enable;
+ int timeout;
+
+ pdm_enable = 0x00;
+ pdm_dma_enable = 0x00;
+
+ pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
+ pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ if (pdm_dma_enable & 0x01) {
+ pdm_dma_enable = 0x02;
+ rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ timeout = 0;
+ while (++timeout < ACP_COUNTER) {
+ pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+ if ((pdm_dma_enable & 0x02) == 0x00)
+ break;
+ udelay(DELAY_US);
+ }
+ if (timeout == ACP_COUNTER)
+ return -ETIMEDOUT;
+ }
+ if (pdm_enable == ACP_PDM_ENABLE) {
+ pdm_enable = ACP_PDM_DISABLE;
+ rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
+ }
+ rpl_acp_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
+ return 0;
+}
+
+static void acp6x_config_dma(struct rpl_pdm_stream_instance *rtd, int direction)
+{
+ u16 page_idx;
+ u32 low, high, val;
+ dma_addr_t addr;
+
+ addr = rtd->dma_addr;
+ val = PDM_PTE_OFFSET;
+
+ /* Group Enable */
+ rpl_acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
+ ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
+ rpl_acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
+ ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
+ for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
+ /* Load the low address of page int ACP SRAM through SRBM */
+ low = lower_32_bits(addr);
+ high = upper_32_bits(addr);
+
+ rpl_acp_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
+ high |= BIT(31);
+ rpl_acp_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
+ val += 8;
+ addr += PAGE_SIZE;
+ }
+}
+
+static int acp6x_pdm_dma_open(struct snd_soc_component *component,
+ struct snd_pcm_substream *substream)
+{
+ struct snd_pcm_runtime *runtime;
+ struct rpl_pdm_dev_data *adata;
+ struct rpl_pdm_stream_instance *pdm_data;
+ int ret;
+
+ runtime = substream->runtime;
+ adata = dev_get_drvdata(component->dev);
+ pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
+ if (!pdm_data)
+ return -EINVAL;
+
+ if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+ runtime->hw = acp6x_pdm_hardware_capture;
+
+ ret = snd_pcm_hw_constraint_integer(runtime,
+ SNDRV_PCM_HW_PARAM_PERIODS);
+ if (ret < 0) {
+ dev_err(component->dev, "set integer constraint failed\n");
+ kfree(pdm_data);
+ return ret;
+ }
+
+ acp6x_enable_pdm_interrupts(adata->acp6x_base);
+
+ if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+ adata->capture_stream = substream;
+
+ pdm_data->acp6x_base = adata->acp6x_base;
+ runtime->private_data = pdm_data;
+ return ret;
+}
+
+static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
+ struct snd_pcm_substream *substream,
+ struct snd_pcm_hw_params *params)
+{
+ struct rpl_pdm_stream_instance *rtd;
+ size_t size, period_bytes;
+
+ rtd = substream->runtime->private_data;
+ if (!rtd)
+ return -EINVAL;
+ size = params_buffer_bytes(params);
+ period_bytes = params_period_bytes(params);
+ rtd->dma_addr = substream->runtime->dma_addr;
+ rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
+ acp6x_config_dma(rtd, substream->stream);
+ acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
+ period_bytes, rtd->acp6x_base);
+ return 0;
+}
+
+static u64 acp6x_pdm_get_byte_count(struct rpl_pdm_stream_instance *rtd,
+ int direction)
+{
+ union rpl_acp_pdm_dma_count byte_count;
+
+ byte_count.bcount.high =
+ rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
+ byte_count.bcount.low =
+ rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
+ return byte_count.bytescount;
+}
+
+static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
+ struct snd_pcm_substream *stream)
+{
+ struct rpl_pdm_stream_instance *rtd;
+ u32 pos, buffersize;
+ u64 bytescount;
+
+ rtd = stream->runtime->private_data;
+ buffersize = frames_to_bytes(stream->runtime,
+ stream->runtime->buffer_size);
+ bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
+ if (bytescount > rtd->bytescount)
+ bytescount -= rtd->bytescount;
+ pos = do_div(bytescount, buffersize);
+ return bytes_to_frames(stream->runtime, pos);
+}
+
+static int acp6x_pdm_dma_new(struct snd_soc_component *component,
+ struct snd_soc_pcm_runtime *rtd)
+{
+ struct device *parent = component->dev->parent;
+
+ snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+ parent, MIN_BUFFER, MAX_BUFFER);
+ return 0;
+}
+
+static int acp6x_pdm_dma_close(struct snd_soc_component *component,
+ struct snd_pcm_substream *substream)
+{
+ struct rpl_pdm_dev_data *adata = dev_get_drvdata(component->dev);
+
+ acp6x_disable_pdm_interrupts(adata->acp6x_base);
+ adata->capture_stream = NULL;
+ return 0;
+}
+
+static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
+ int cmd, struct snd_soc_dai *dai)
+{
+ struct rpl_pdm_stream_instance *rtd;
+ int ret;
+ bool pdm_status;
+ unsigned int ch_mask;
+
+ rtd = substream->runtime->private_data;
+ ret = 0;
+ switch (substream->runtime->channels) {
+ case TWO_CH:
+ ch_mask = 0x00;
+ break;
+ default:
+ return -EINVAL;
+ }
+ switch (cmd) {
+ case SNDRV_PCM_TRIGGER_START:
+ case SNDRV_PCM_TRIGGER_RESUME:
+ case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+ rpl_acp_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
+ rpl_acp_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
+ ACP_WOV_PDM_DECIMATION_FACTOR);
+ rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
+ pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
+ if (!pdm_status)
+ ret = acp6x_start_pdm_dma(rtd->acp6x_base);
+ break;
+ case SNDRV_PCM_TRIGGER_STOP:
+ case SNDRV_PCM_TRIGGER_SUSPEND:
+ case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+ pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
+ if (pdm_status)
+ ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
+ break;
+ default:
+ ret = -EINVAL;
+ break;
+ }
+ return ret;
+}
+
+static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
+ .trigger = acp6x_pdm_dai_trigger,
+};
+
+static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
+ .capture = {
+ .rates = SNDRV_PCM_RATE_48000,
+ .formats = SNDRV_PCM_FMTBIT_S32_LE,
+ .channels_min = 2,
+ .channels_max = 2,
+ .rate_min = 48000,
+ .rate_max = 48000,
+ },
+ .ops = &acp6x_pdm_dai_ops,
+};
+
+static const struct snd_soc_component_driver acp6x_pdm_component = {
+ .name = DRV_NAME,
+ .open = acp6x_pdm_dma_open,
+ .close = acp6x_pdm_dma_close,
+ .hw_params = acp6x_pdm_dma_hw_params,
+ .pointer = acp6x_pdm_dma_pointer,
+ .pcm_construct = acp6x_pdm_dma_new,
+ .legacy_dai_naming = 1,
+};
+
+static int acp6x_pdm_audio_probe(struct platform_device *pdev)
+{
+ struct resource *res;
+ struct rpl_pdm_dev_data *adata;
+ int status;
+
+ res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ if (!res) {
+ dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
+ return -ENODEV;
+ }
+
+ adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
+ if (!adata)
+ return -ENOMEM;
+
+ adata->acp6x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+ if (!adata->acp6x_base)
+ return -ENOMEM;
+
+ adata->capture_stream = NULL;
+
+ dev_set_drvdata(&pdev->dev, adata);
+ status = devm_snd_soc_register_component(&pdev->dev,
+ &acp6x_pdm_component,
+ &acp6x_pdm_dai_driver, 1);
+ if (status) {
+ dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
+
+ return -ENODEV;
+ }
+ pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
+ pm_runtime_use_autosuspend(&pdev->dev);
+ pm_runtime_mark_last_busy(&pdev->dev);
+ pm_runtime_set_active(&pdev->dev);
+ pm_runtime_enable(&pdev->dev);
+ return 0;
+}
+
+static void acp6x_pdm_audio_remove(struct platform_device *pdev)
+{
+ pm_runtime_disable(&pdev->dev);
+}
+
+static int acp6x_pdm_resume(struct device *dev)
+{
+ struct rpl_pdm_dev_data *adata;
+ struct snd_pcm_runtime *runtime;
+ struct rpl_pdm_stream_instance *rtd;
+ u32 period_bytes, buffer_len;
+
+ adata = dev_get_drvdata(dev);
+ if (adata->capture_stream && adata->capture_stream->runtime) {
+ runtime = adata->capture_stream->runtime;
+ rtd = runtime->private_data;
+ period_bytes = frames_to_bytes(runtime, runtime->period_size);
+ buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
+ acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
+ acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
+ period_bytes, adata->acp6x_base);
+ }
+ acp6x_enable_pdm_interrupts(adata->acp6x_base);
+ return 0;
+}
+
+static int acp6x_pdm_suspend(struct device *dev)
+{
+ struct rpl_pdm_dev_data *adata;
+
+ adata = dev_get_drvdata(dev);
+ acp6x_disable_pdm_interrupts(adata->acp6x_base);
+ return 0;
+}
+
+static int acp6x_pdm_runtime_resume(struct device *dev)
+{
+ struct rpl_pdm_dev_data *adata;
+
+ adata = dev_get_drvdata(dev);
+ acp6x_enable_pdm_interrupts(adata->acp6x_base);
+ return 0;
+}
+
+static const struct dev_pm_ops acp6x_pdm_pm_ops = {
+ RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
+ SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
+};
+
+static struct platform_driver acp6x_pdm_dma_driver = {
+ .probe = acp6x_pdm_audio_probe,
+ .remove = acp6x_pdm_audio_remove,
+ .driver = {
+ .name = "acp_rpl_pdm_dma",
+ .pm = pm_ptr(&acp6x_pdm_pm_ops),
+ },
+};
+
+module_platform_driver(acp6x_pdm_dma_driver);
+
+MODULE_DESCRIPTION("AMD ACP6x RPL PDM Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
index e3afe9172bdf..9a0d9920ad8e 100644
--- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
+++ b/sound/soc/amd/rpl/rpl-pci-acp6x.c
@@ -10,12 +10,16 @@
#include <linux/io.h>
#include <linux/delay.h>
#include <linux/platform_device.h>
+#include <sound/pcm.h>
#include <linux/pm_runtime.h>
#include "rpl_acp6x.h"
struct rpl_dev_data {
void __iomem *acp6x_base;
+ struct resource *res;
+ bool acp6x_audio_mode;
+ struct platform_device *pdev[ACP6x_DEVS];
};
static int rpl_power_on(void __iomem *acp_base)
@@ -64,6 +68,19 @@ static int rpl_reset(void __iomem *acp_base)
return -ETIMEDOUT;
}
+static void rpl_enable_interrupts(void __iomem *acp_base)
+{
+ rpl_acp_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
+}
+
+static void rpl_disable_interrupts(void __iomem *acp_base)
+{
+ rpl_acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
+ ACP_EXTERNAL_INTR_STAT);
+ rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
+ rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
+}
+
static int rpl_init(void __iomem *acp_base)
{
int ret;
@@ -82,6 +99,7 @@ static int rpl_init(void __iomem *acp_base)
return ret;
}
rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
+ rpl_enable_interrupts(acp_base);
return 0;
}
@@ -89,6 +107,7 @@ static int rpl_deinit(void __iomem *acp_base)
{
int ret;
+ rpl_disable_interrupts(acp_base);
/* Reset */
ret = rpl_reset(acp_base);
if (ret) {
@@ -100,13 +119,45 @@ static int rpl_deinit(void __iomem *acp_base)
return 0;
}
+static irqreturn_t rpl_irq_handler(int irq, void *dev_id)
+{
+ struct rpl_dev_data *adata;
+ struct rpl_pdm_dev_data *rpl_pdm_data;
+ u32 val;
+
+ adata = dev_id;
+ if (!adata)
+ return IRQ_NONE;
+
+ val = rpl_acp_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
+ if (val & BIT(PDM_DMA_STAT)) {
+ rpl_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
+ rpl_acp_writel(BIT(PDM_DMA_STAT), adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
+ if (rpl_pdm_data->capture_stream)
+ snd_pcm_period_elapsed(rpl_pdm_data->capture_stream);
+ return IRQ_HANDLED;
+ }
+ return IRQ_NONE;
+}
+
static int snd_rpl_probe(struct pci_dev *pci,
const struct pci_device_id *pci_id)
{
struct rpl_dev_data *adata;
+ struct platform_device_info pdevinfo[ACP6x_DEVS];
+ int index = 0;
+ int val = 0x00;
+ unsigned int irqflags, flag;
u32 addr;
int ret;
+ irqflags = IRQF_SHARED;
+
+ /* Return if acp config flag is defined */
+ flag = snd_amd_acp_find_config(pci);
+ if (flag)
+ return -ENODEV;
+
/* RPL device check */
switch (pci->revision) {
case 0x62:
@@ -145,12 +196,78 @@ static int snd_rpl_probe(struct pci_dev *pci,
ret = rpl_init(adata->acp6x_base);
if (ret)
goto release_regions;
+
+ val = rpl_acp_readl(adata->acp6x_base + ACP_PIN_CONFIG);
+ switch (val) {
+ case ACP_CONFIG_0:
+ case ACP_CONFIG_1:
+ case ACP_CONFIG_2:
+ case ACP_CONFIG_3:
+ case ACP_CONFIG_9:
+ case ACP_CONFIG_15:
+ dev_info(&pci->dev, "Audio Mode %d\n", val);
+ break;
+ default:
+ adata->res = devm_kzalloc(&pci->dev,
+ sizeof(struct resource),
+ GFP_KERNEL);
+ if (!adata->res) {
+ ret = -ENOMEM;
+ goto de_init;
+ }
+
+ adata->res->name = "acp_iomem";
+ adata->res->flags = IORESOURCE_MEM;
+ adata->res->start = addr;
+ adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
+
+ adata->acp6x_audio_mode = ACP6x_PDM_MODE;
+
+ memset(&pdevinfo, 0, sizeof(pdevinfo));
+ pdevinfo[0].name = "acp_rpl_pdm_dma";
+ pdevinfo[0].id = 0;
+ pdevinfo[0].parent = &pci->dev;
+ pdevinfo[0].num_res = 1;
+ pdevinfo[0].res = adata->res;
+
+ pdevinfo[1].name = "dmic-codec";
+ pdevinfo[1].id = 0;
+ pdevinfo[1].parent = &pci->dev;
+
+ pdevinfo[2].name = "acp_rpl_mach";
+ pdevinfo[2].id = 0;
+ pdevinfo[2].parent = &pci->dev;
+
+ for (index = 0; index < ACP6x_DEVS; index++) {
+ adata->pdev[index] =
+ platform_device_register_full(&pdevinfo[index]);
+ if (IS_ERR(adata->pdev[index])) {
+ dev_err(&pci->dev, "cannot register %s device\n",
+ pdevinfo[index].name);
+ ret = PTR_ERR(adata->pdev[index]);
+ goto unregister_devs;
+ }
+ }
+ break;
+ }
+ ret = devm_request_irq(&pci->dev, pci->irq, rpl_irq_handler,
+ irqflags, "ACP_PCI_IRQ", adata);
+ if (ret) {
+ dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
+ goto unregister_devs;
+ }
pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
pm_runtime_use_autosuspend(&pci->dev);
pm_runtime_put_noidle(&pci->dev);
pm_runtime_allow(&pci->dev);
return 0;
+unregister_devs:
+ for (--index; index >= 0; index--)
+ platform_device_unregister(adata->pdev[index]);
+de_init:
+ if (rpl_deinit(adata->acp6x_base))
+ dev_err(&pci->dev, "ACP de-init failed\n");
release_regions:
pci_release_regions(pci);
disable_pci:
@@ -191,9 +308,13 @@ static const struct dev_pm_ops rpl_pm = {
static void snd_rpl_remove(struct pci_dev *pci)
{
struct rpl_dev_data *adata;
- int ret;
+ int ret, index;
adata = pci_get_drvdata(pci);
+ if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
+ for (index = 0; index < ACP6x_DEVS; index++)
+ platform_device_unregister(adata->pdev[index]);
+ }
ret = rpl_deinit(adata->acp6x_base);
if (ret)
dev_err(&pci->dev, "ACP de-init failed\n");
diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
index f5816a33632e..d470927c1e35 100644
--- a/sound/soc/amd/rpl/rpl_acp6x.h
+++ b/sound/soc/amd/rpl/rpl_acp6x.h
@@ -9,15 +9,46 @@
#define ACP_DEVICE_ID 0x15E2
#define ACP6x_PHY_BASE_ADDRESS 0x1240000
+#define ACP6x_REG_START 0x1240000
+#define ACP6x_REG_END 0x1250200
+#define ACP6x_DEVS 3
+#define ACP6x_PDM_MODE 1
-#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
-#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
-#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
-#define ACP_PGFSM_STATUS_MASK 3
-#define ACP_POWERED_ON 0
-#define ACP_POWER_ON_IN_PROGRESS 1
-#define ACP_POWERED_OFF 2
-#define ACP_POWER_OFF_IN_PROGRESS 3
+#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
+#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
+#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
+#define ACP_PGFSM_STATUS_MASK 3
+#define ACP_POWERED_ON 0
+#define ACP_POWER_ON_IN_PROGRESS 1
+#define ACP_POWERED_OFF 2
+#define ACP_POWER_OFF_IN_PROGRESS 3
+
+#define ACP_ERROR_MASK 0x20000000
+#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
+#define PDM_DMA_STAT 0x10
+
+#define PDM_DMA_INTR_MASK 0x10000
+#define ACP_ERROR_STAT 29
+#define PDM_DECIMATION_FACTOR 2
+#define ACP_PDM_CLK_FREQ_MASK 7
+#define ACP_WOV_GAIN_CONTROL GENMASK(4, 3)
+#define ACP_PDM_ENABLE 1
+#define ACP_PDM_DISABLE 0
+#define ACP_PDM_DMA_EN_STATUS 2
+#define TWO_CH 2
+
+#define ACP_SRAM_PTE_OFFSET 0x03800000
+#define PAGE_SIZE_4K_ENABLE 2
+#define PDM_PTE_OFFSET 0
+#define PDM_MEM_WINDOW_START 0x4000000
+
+#define CAPTURE_MIN_NUM_PERIODS 4
+#define CAPTURE_MAX_NUM_PERIODS 4
+#define CAPTURE_MAX_PERIOD_SIZE 8192
+#define CAPTURE_MIN_PERIOD_SIZE 4096
+
+#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
+#define MIN_BUFFER MAX_BUFFER
#define DELAY_US 5
#define ACP_COUNTER 20000
@@ -25,6 +56,47 @@
/* time in ms for runtime suspend delay */
#define ACP_SUSPEND_DELAY_MS 2000
+enum rpl_acp_config {
+ ACP_CONFIG_0 = 0,
+ ACP_CONFIG_1,
+ ACP_CONFIG_2,
+ ACP_CONFIG_3,
+ ACP_CONFIG_4,
+ ACP_CONFIG_5,
+ ACP_CONFIG_6,
+ ACP_CONFIG_7,
+ ACP_CONFIG_8,
+ ACP_CONFIG_9,
+ ACP_CONFIG_10,
+ ACP_CONFIG_11,
+ ACP_CONFIG_12,
+ ACP_CONFIG_13,
+ ACP_CONFIG_14,
+ ACP_CONFIG_15,
+};
+
+struct rpl_pdm_dev_data {
+ u32 pdm_irq;
+ void __iomem *acp6x_base;
+ struct snd_pcm_substream *capture_stream;
+};
+
+struct rpl_pdm_stream_instance {
+ u16 num_pages;
+ u16 channels;
+ dma_addr_t dma_addr;
+ u64 bytescount;
+ void __iomem *acp6x_base;
+};
+
+union rpl_acp_pdm_dma_count {
+ struct {
+ u32 low;
+ u32 high;
+ } bcount;
+ u64 bytescount;
+};
+
static inline u32 rpl_acp_readl(void __iomem *base_addr)
{
return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
@@ -34,3 +106,5 @@ static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
{
writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
}
+
+int snd_amd_acp_find_config(struct pci_dev *pci);
diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
index 456498f5396d..44994a925149 100644
--- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
+++ b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
@@ -8,14 +8,114 @@
#ifndef _rpl_acp6x_OFFSET_HEADER
#define _rpl_acp6x_OFFSET_HEADER
+/* Registers from ACP_DMA block */
+#define ACP_DMA_CNTL_0 0x1240000
+#define ACP_DMA_CNTL_1 0x1240004
+#define ACP_DMA_CNTL_2 0x1240008
+#define ACP_DMA_CNTL_3 0x124000C
+#define ACP_DMA_CNTL_4 0x1240010
+#define ACP_DMA_CNTL_5 0x1240014
+#define ACP_DMA_CNTL_6 0x1240018
+#define ACP_DMA_CNTL_7 0x124001C
+#define ACP_DMA_DSCR_STRT_IDX_0 0x1240020
+#define ACP_DMA_DSCR_STRT_IDX_1 0x1240024
+#define ACP_DMA_DSCR_STRT_IDX_2 0x1240028
+#define ACP_DMA_DSCR_STRT_IDX_3 0x124002C
+#define ACP_DMA_DSCR_STRT_IDX_4 0x1240030
+#define ACP_DMA_DSCR_STRT_IDX_5 0x1240034
+#define ACP_DMA_DSCR_STRT_IDX_6 0x1240038
+#define ACP_DMA_DSCR_STRT_IDX_7 0x124003C
+#define ACP_DMA_DSCR_CNT_0 0x1240040
+#define ACP_DMA_DSCR_CNT_1 0x1240044
+#define ACP_DMA_DSCR_CNT_2 0x1240048
+#define ACP_DMA_DSCR_CNT_3 0x124004C
+#define ACP_DMA_DSCR_CNT_4 0x1240050
+#define ACP_DMA_DSCR_CNT_5 0x1240054
+#define ACP_DMA_DSCR_CNT_6 0x1240058
+#define ACP_DMA_DSCR_CNT_7 0x124005C
+#define ACP_DMA_PRIO_0 0x1240060
+#define ACP_DMA_PRIO_1 0x1240064
+#define ACP_DMA_PRIO_2 0x1240068
+#define ACP_DMA_PRIO_3 0x124006C
+#define ACP_DMA_PRIO_4 0x1240070
+#define ACP_DMA_PRIO_5 0x1240074
+#define ACP_DMA_PRIO_6 0x1240078
+#define ACP_DMA_PRIO_7 0x124007C
+#define ACP_DMA_CUR_DSCR_0 0x1240080
+#define ACP_DMA_CUR_DSCR_1 0x1240084
+#define ACP_DMA_CUR_DSCR_2 0x1240088
+#define ACP_DMA_CUR_DSCR_3 0x124008C
+#define ACP_DMA_CUR_DSCR_4 0x1240090
+#define ACP_DMA_CUR_DSCR_5 0x1240094
+#define ACP_DMA_CUR_DSCR_6 0x1240098
+#define ACP_DMA_CUR_DSCR_7 0x124009C
+#define ACP_DMA_CUR_TRANS_CNT_0 0x12400A0
+#define ACP_DMA_CUR_TRANS_CNT_1 0x12400A4
+#define ACP_DMA_CUR_TRANS_CNT_2 0x12400A8
+#define ACP_DMA_CUR_TRANS_CNT_3 0x12400AC
+#define ACP_DMA_CUR_TRANS_CNT_4 0x12400B0
+#define ACP_DMA_CUR_TRANS_CNT_5 0x12400B4
+#define ACP_DMA_CUR_TRANS_CNT_6 0x12400B8
+#define ACP_DMA_CUR_TRANS_CNT_7 0x12400BC
+#define ACP_DMA_ERR_STS_0 0x12400C0
+#define ACP_DMA_ERR_STS_1 0x12400C4
+#define ACP_DMA_ERR_STS_2 0x12400C8
+#define ACP_DMA_ERR_STS_3 0x12400CC
+#define ACP_DMA_ERR_STS_4 0x12400D0
+#define ACP_DMA_ERR_STS_5 0x12400D4
+#define ACP_DMA_ERR_STS_6 0x12400D8
+#define ACP_DMA_ERR_STS_7 0x12400DC
+#define ACP_DMA_DESC_BASE_ADDR 0x12400E0
+#define ACP_DMA_DESC_MAX_NUM_DSCR 0x12400E4
+#define ACP_DMA_CH_STS 0x12400E8
+#define ACP_DMA_CH_GROUP 0x12400EC
+#define ACP_DMA_CH_RST_STS 0x12400F0
+
+/* Registers from ACP_AXI2AXIATU block */
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1 0x1240C00
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1 0x1240C04
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2 0x1240C08
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2 0x1240C0C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3 0x1240C10
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3 0x1240C14
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4 0x1240C18
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4 0x1240C1C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5 0x1240C20
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5 0x1240C24
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6 0x1240C28
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6 0x1240C2C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7 0x1240C30
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7 0x1240C34
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8 0x1240C38
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8 0x1240C3C
+#define ACPAXI2AXI_ATU_CTRL 0x1240C40
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9 0x1240C44
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9 0x1240C48
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10 0x1240C4C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10 0x1240C50
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11 0x1240C54
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11 0x1240C58
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12 0x1240C5C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12 0x1240C60
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13 0x1240C64
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13 0x1240C68
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14 0x1240C6C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14 0x1240C70
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15 0x1240C74
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15 0x1240C78
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16 0x1240C7C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16 0x1240C80
+
/* Registers from ACP_CLKRST block */
#define ACP_SOFT_RESET 0x1241000
#define ACP_CONTROL 0x1241004
#define ACP_STATUS 0x1241008
#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
-#define ACP_PGFSM_CONTROL 0x124101C
-#define ACP_PGFSM_STATUS 0x1241020
-#define ACP_CLKMUX_SEL 0x1241024
+#define ACP_ZSC_DSP_CTRL 0x1241014
+#define ACP_ZSC_STS 0x1241018
+#define ACP_PGFSM_CONTROL 0x1241024
+#define ACP_PGFSM_STATUS 0x1241028
+#define ACP_CLKMUX_SEL 0x124102C
/* Registers from ACP_AON block */
#define ACP_PME_EN 0x1241400
@@ -26,5 +126,319 @@
#define ACP_PAD_PULLDOWN_CTRL 0x1241448
#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
#define ACP_PAD_SCHMEN_CTRL 0x1241450
+#define ACP_SW_PAD_KEEPER_EN 0x1241454
+#define ACP_SW_WAKE_EN 0x1241458
+#define ACP_I2S_WAKE_EN 0x124145C
+#define ACP_SW1_WAKE_EN 0x1241460
+
+/* Registers from ACP_P1_MISC block */
+#define ACP_EXTERNAL_INTR_ENB 0x1241A00
+#define ACP_EXTERNAL_INTR_CNTL 0x1241A04
+#define ACP_EXTERNAL_INTR_CNTL1 0x1241A08
+#define ACP_EXTERNAL_INTR_STAT 0x1241A0C
+#define ACP_EXTERNAL_INTR_STAT1 0x1241A10
+#define ACP_ERROR_STATUS 0x1241A4C
+#define ACP_P1_SW_I2S_ERROR_REASON 0x1241A50
+#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL 0x1241A6C
+#define ACP_P1_SW_I2S_TX_DMA_POS 0x1241A70
+#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL 0x1241A74
+#define ACP_P1_SW_I2S_RX_DMA_POS 0x1241A78
+#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL 0x1241A7C
+#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS 0x1241A80
+#define ACP_SCRATCH_REG_BASE_ADDR 0x1241A84
+#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL 0x1241A88
+#define ACP_P1_SW_BT_TX_DMA_POS 0x1241A8C
+#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL 0x1241A90
+#define ACP_P1_SW_HS_TX_DMA_POS 0x1241A94
+#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL 0x1241A98
+#define ACP_P1_SW_BT_RX_DMA_POS 0x1241A9C
+#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL 0x1241AA0
+#define ACP_P1_SW_HS_RX_DMA_POS 0x1241AA4
+
+/* Registers from ACP_AUDIO_BUFFERS block */
+#define ACP_I2S_RX_RINGBUFADDR 0x1242000
+#define ACP_I2S_RX_RINGBUFSIZE 0x1242004
+#define ACP_I2S_RX_LINKPOSITIONCNTR 0x1242008
+#define ACP_I2S_RX_FIFOADDR 0x124200C
+#define ACP_I2S_RX_FIFOSIZE 0x1242010
+#define ACP_I2S_RX_DMA_SIZE 0x1242014
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1242018
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW 0x124201C
+#define ACP_I2S_RX_INTR_WATERMARK_SIZE 0x1242020
+#define ACP_I2S_TX_RINGBUFADDR 0x1242024
+#define ACP_I2S_TX_RINGBUFSIZE 0x1242028
+#define ACP_I2S_TX_LINKPOSITIONCNTR 0x124202C
+#define ACP_I2S_TX_FIFOADDR 0x1242030
+#define ACP_I2S_TX_FIFOSIZE 0x1242034
+#define ACP_I2S_TX_DMA_SIZE 0x1242038
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x124203C
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1242040
+#define ACP_I2S_TX_INTR_WATERMARK_SIZE 0x1242044
+#define ACP_BT_RX_RINGBUFADDR 0x1242048
+#define ACP_BT_RX_RINGBUFSIZE 0x124204C
+#define ACP_BT_RX_LINKPOSITIONCNTR 0x1242050
+#define ACP_BT_RX_FIFOADDR 0x1242054
+#define ACP_BT_RX_FIFOSIZE 0x1242058
+#define ACP_BT_RX_DMA_SIZE 0x124205C
+#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1242060
+#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW 0x1242064
+#define ACP_BT_RX_INTR_WATERMARK_SIZE 0x1242068
+#define ACP_BT_TX_RINGBUFADDR 0x124206C
+#define ACP_BT_TX_RINGBUFSIZE 0x1242070
+#define ACP_BT_TX_LINKPOSITIONCNTR 0x1242074
+#define ACP_BT_TX_FIFOADDR 0x1242078
+#define ACP_BT_TX_FIFOSIZE 0x124207C
+#define ACP_BT_TX_DMA_SIZE 0x1242080
+#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1242084
+#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW 0x1242088
+#define ACP_BT_TX_INTR_WATERMARK_SIZE 0x124208C
+#define ACP_HS_RX_RINGBUFADDR 0x1242090
+#define ACP_HS_RX_RINGBUFSIZE 0x1242094
+#define ACP_HS_RX_LINKPOSITIONCNTR 0x1242098
+#define ACP_HS_RX_FIFOADDR 0x124209C
+#define ACP_HS_RX_FIFOSIZE 0x12420A0
+#define ACP_HS_RX_DMA_SIZE 0x12420A4
+#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH 0x12420A8
+#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW 0x12420AC
+#define ACP_HS_RX_INTR_WATERMARK_SIZE 0x12420B0
+#define ACP_HS_TX_RINGBUFADDR 0x12420B4
+#define ACP_HS_TX_RINGBUFSIZE 0x12420B8
+#define ACP_HS_TX_LINKPOSITIONCNTR 0x12420BC
+#define ACP_HS_TX_FIFOADDR 0x12420C0
+#define ACP_HS_TX_FIFOSIZE 0x12420C4
+#define ACP_HS_TX_DMA_SIZE 0x12420C8
+#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH 0x12420CC
+#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW 0x12420D0
+#define ACP_HS_TX_INTR_WATERMARK_SIZE 0x12420D4
+
+/* Registers from ACP_I2S_TDM block */
+#define ACP_I2STDM_IER 0x1242400
+#define ACP_I2STDM_IRER 0x1242404
+#define ACP_I2STDM_RXFRMT 0x1242408
+#define ACP_I2STDM_ITER 0x124240C
+#define ACP_I2STDM_TXFRMT 0x1242410
+#define ACP_I2STDM0_MSTRCLKGEN 0x1242414
+#define ACP_I2STDM1_MSTRCLKGEN 0x1242418
+#define ACP_I2STDM2_MSTRCLKGEN 0x124241C
+#define ACP_I2STDM_REFCLKGEN 0x1242420
+
+/* Registers from ACP_BT_TDM block */
+#define ACP_BTTDM_IER 0x1242800
+#define ACP_BTTDM_IRER 0x1242804
+#define ACP_BTTDM_RXFRMT 0x1242808
+#define ACP_BTTDM_ITER 0x124280C
+#define ACP_BTTDM_TXFRMT 0x1242810
+#define ACP_HSTDM_IER 0x1242814
+#define ACP_HSTDM_IRER 0x1242818
+#define ACP_HSTDM_RXFRMT 0x124281C
+#define ACP_HSTDM_ITER 0x1242820
+#define ACP_HSTDM_TXFRMT 0x1242824
+
+/* Registers from ACP_WOV block */
+#define ACP_WOV_PDM_ENABLE 0x1242C04
+#define ACP_WOV_PDM_DMA_ENABLE 0x1242C08
+#define ACP_WOV_RX_RINGBUFADDR 0x1242C0C
+#define ACP_WOV_RX_RINGBUFSIZE 0x1242C10
+#define ACP_WOV_RX_LINKPOSITIONCNTR 0x1242C14
+#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH 0x1242C18
+#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW 0x1242C1C
+#define ACP_WOV_RX_INTR_WATERMARK_SIZE 0x1242C20
+#define ACP_WOV_PDM_FIFO_FLUSH 0x1242C24
+#define ACP_WOV_PDM_NO_OF_CHANNELS 0x1242C28
+#define ACP_WOV_PDM_DECIMATION_FACTOR 0x1242C2C
+#define ACP_WOV_PDM_VAD_CTRL 0x1242C30
+#define ACP_WOV_WAKE 0x1242C54
+#define ACP_WOV_BUFFER_STATUS 0x1242C58
+#define ACP_WOV_MISC_CTRL 0x1242C5C
+#define ACP_WOV_CLK_CTRL 0x1242C60
+#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN 0x1242C64
+#define ACP_WOV_ERROR_STATUS_REGISTER 0x1242C68
+#define ACP_PDM_CLKDIV 0x1242C6C
+
+/* Registers from ACP_P1_AUDIO_BUFFERS block */
+#define ACP_P1_I2S_RX_RINGBUFADDR 0x1243A00
+#define ACP_P1_I2S_RX_RINGBUFSIZE 0x1243A04
+#define ACP_P1_I2S_RX_LINKPOSITIONCNTR 0x1243A08
+#define ACP_P1_I2S_RX_FIFOADDR 0x1243A0C
+#define ACP_P1_I2S_RX_FIFOSIZE 0x1243A10
+#define ACP_P1_I2S_RX_DMA_SIZE 0x1243A14
+#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1243A18
+#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW 0x1243A1C
+#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE 0x1243A20
+#define ACP_P1_I2S_TX_RINGBUFADDR 0x1243A24
+#define ACP_P1_I2S_TX_RINGBUFSIZE 0x1243A28
+#define ACP_P1_I2S_TX_LINKPOSITIONCNTR 0x1243A2C
+#define ACP_P1_I2S_TX_FIFOADDR 0x1243A30
+#define ACP_P1_I2S_TX_FIFOSIZE 0x1243A34
+#define ACP_P1_I2S_TX_DMA_SIZE 0x1243A38
+#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x1243A3C
+#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1243A40
+#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE 0x1243A44
+#define ACP_P1_BT_RX_RINGBUFADDR 0x1243A48
+#define ACP_P1_BT_RX_RINGBUFSIZE 0x1243A4C
+#define ACP_P1_BT_RX_LINKPOSITIONCNTR 0x1243A50
+#define ACP_P1_BT_RX_FIFOADDR 0x1243A54
+#define ACP_P1_BT_RX_FIFOSIZE 0x1243A58
+#define ACP_P1_BT_RX_DMA_SIZE 0x1243A5C
+#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1243A60
+#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW 0x1243A64
+#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE 0x1243A68
+#define ACP_P1_BT_TX_RINGBUFADDR 0x1243A6C
+#define ACP_P1_BT_TX_RINGBUFSIZE 0x1243A70
+#define ACP_P1_BT_TX_LINKPOSITIONCNTR 0x1243A74
+#define ACP_P1_BT_TX_FIFOADDR 0x1243A78
+#define ACP_P1_BT_TX_FIFOSIZE 0x1243A7C
+#define ACP_P1_BT_TX_DMA_SIZE 0x1243A80
+#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1243A84
+#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW 0x1243A88
+#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE 0x1243A8C
+#define ACP_P1_HS_RX_RINGBUFADDR 0x1243A90
+#define ACP_P1_HS_RX_RINGBUFSIZE 0x1243A94
+#define ACP_P1_HS_RX_LINKPOSITIONCNTR 0x1243A98
+#define ACP_P1_HS_RX_FIFOADDR 0x1243A9C
+#define ACP_P1_HS_RX_FIFOSIZE 0x1243AA0
+#define ACP_P1_HS_RX_DMA_SIZE 0x1243AA4
+#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH 0x1243AA8
+#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW 0x1243AAC
+#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE 0x1243AB0
+#define ACP_P1_HS_TX_RINGBUFADDR 0x1243AB4
+#define ACP_P1_HS_TX_RINGBUFSIZE 0x1243AB8
+#define ACP_P1_HS_TX_LINKPOSITIONCNTR 0x1243ABC
+#define ACP_P1_HS_TX_FIFOADDR 0x1243AC0
+#define ACP_P1_HS_TX_FIFOSIZE 0x1243AC4
+#define ACP_P1_HS_TX_DMA_SIZE 0x1243AC8
+#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH 0x1243ACC
+#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW 0x1243AD0
+#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE 0x1243AD4
+/* Registers from ACP_SCRATCH block */
+#define ACP_SCRATCH_REG_0 0x1250000
+#define ACP_SCRATCH_REG_1 0x1250004
+#define ACP_SCRATCH_REG_2 0x1250008
+#define ACP_SCRATCH_REG_3 0x125000C
+#define ACP_SCRATCH_REG_4 0x1250010
+#define ACP_SCRATCH_REG_5 0x1250014
+#define ACP_SCRATCH_REG_6 0x1250018
+#define ACP_SCRATCH_REG_7 0x125001C
+#define ACP_SCRATCH_REG_8 0x1250020
+#define ACP_SCRATCH_REG_9 0x1250024
+#define ACP_SCRATCH_REG_10 0x1250028
+#define ACP_SCRATCH_REG_11 0x125002C
+#define ACP_SCRATCH_REG_12 0x1250030
+#define ACP_SCRATCH_REG_13 0x1250034
+#define ACP_SCRATCH_REG_14 0x1250038
+#define ACP_SCRATCH_REG_15 0x125003C
+#define ACP_SCRATCH_REG_16 0x1250040
+#define ACP_SCRATCH_REG_17 0x1250044
+#define ACP_SCRATCH_REG_18 0x1250048
+#define ACP_SCRATCH_REG_19 0x125004C
+#define ACP_SCRATCH_REG_20 0x1250050
+#define ACP_SCRATCH_REG_21 0x1250054
+#define ACP_SCRATCH_REG_22 0x1250058
+#define ACP_SCRATCH_REG_23 0x125005C
+#define ACP_SCRATCH_REG_24 0x1250060
+#define ACP_SCRATCH_REG_25 0x1250064
+#define ACP_SCRATCH_REG_26 0x1250068
+#define ACP_SCRATCH_REG_27 0x125006C
+#define ACP_SCRATCH_REG_28 0x1250070
+#define ACP_SCRATCH_REG_29 0x1250074
+#define ACP_SCRATCH_REG_30 0x1250078
+#define ACP_SCRATCH_REG_31 0x125007C
+#define ACP_SCRATCH_REG_32 0x1250080
+#define ACP_SCRATCH_REG_33 0x1250084
+#define ACP_SCRATCH_REG_34 0x1250088
+#define ACP_SCRATCH_REG_35 0x125008C
+#define ACP_SCRATCH_REG_36 0x1250090
+#define ACP_SCRATCH_REG_37 0x1250094
+#define ACP_SCRATCH_REG_38 0x1250098
+#define ACP_SCRATCH_REG_39 0x125009C
+#define ACP_SCRATCH_REG_40 0x12500A0
+#define ACP_SCRATCH_REG_41 0x12500A4
+#define ACP_SCRATCH_REG_42 0x12500A8
+#define ACP_SCRATCH_REG_43 0x12500AC
+#define ACP_SCRATCH_REG_44 0x12500B0
+#define ACP_SCRATCH_REG_45 0x12500B4
+#define ACP_SCRATCH_REG_46 0x12500B8
+#define ACP_SCRATCH_REG_47 0x12500BC
+#define ACP_SCRATCH_REG_48 0x12500C0
+#define ACP_SCRATCH_REG_49 0x12500C4
+#define ACP_SCRATCH_REG_50 0x12500C8
+#define ACP_SCRATCH_REG_51 0x12500CC
+#define ACP_SCRATCH_REG_52 0x12500D0
+#define ACP_SCRATCH_REG_53 0x12500D4
+#define ACP_SCRATCH_REG_54 0x12500D8
+#define ACP_SCRATCH_REG_55 0x12500DC
+#define ACP_SCRATCH_REG_56 0x12500E0
+#define ACP_SCRATCH_REG_57 0x12500E4
+#define ACP_SCRATCH_REG_58 0x12500E8
+#define ACP_SCRATCH_REG_59 0x12500EC
+#define ACP_SCRATCH_REG_60 0x12500F0
+#define ACP_SCRATCH_REG_61 0x12500F4
+#define ACP_SCRATCH_REG_62 0x12500F8
+#define ACP_SCRATCH_REG_63 0x12500FC
+#define ACP_SCRATCH_REG_64 0x1250100
+#define ACP_SCRATCH_REG_65 0x1250104
+#define ACP_SCRATCH_REG_66 0x1250108
+#define ACP_SCRATCH_REG_67 0x125010C
+#define ACP_SCRATCH_REG_68 0x1250110
+#define ACP_SCRATCH_REG_69 0x1250114
+#define ACP_SCRATCH_REG_70 0x1250118
+#define ACP_SCRATCH_REG_71 0x125011C
+#define ACP_SCRATCH_REG_72 0x1250120
+#define ACP_SCRATCH_REG_73 0x1250124
+#define ACP_SCRATCH_REG_74 0x1250128
+#define ACP_SCRATCH_REG_75 0x125012C
+#define ACP_SCRATCH_REG_76 0x1250130
+#define ACP_SCRATCH_REG_77 0x1250134
+#define ACP_SCRATCH_REG_78 0x1250138
+#define ACP_SCRATCH_REG_79 0x125013C
+#define ACP_SCRATCH_REG_80 0x1250140
+#define ACP_SCRATCH_REG_81 0x1250144
+#define ACP_SCRATCH_REG_82 0x1250148
+#define ACP_SCRATCH_REG_83 0x125014C
+#define ACP_SCRATCH_REG_84 0x1250150
+#define ACP_SCRATCH_REG_85 0x1250154
+#define ACP_SCRATCH_REG_86 0x1250158
+#define ACP_SCRATCH_REG_87 0x125015C
+#define ACP_SCRATCH_REG_88 0x1250160
+#define ACP_SCRATCH_REG_89 0x1250164
+#define ACP_SCRATCH_REG_90 0x1250168
+#define ACP_SCRATCH_REG_91 0x125016C
+#define ACP_SCRATCH_REG_92 0x1250170
+#define ACP_SCRATCH_REG_93 0x1250174
+#define ACP_SCRATCH_REG_94 0x1250178
+#define ACP_SCRATCH_REG_95 0x125017C
+#define ACP_SCRATCH_REG_96 0x1250180
+#define ACP_SCRATCH_REG_97 0x1250184
+#define ACP_SCRATCH_REG_98 0x1250188
+#define ACP_SCRATCH_REG_99 0x125018C
+#define ACP_SCRATCH_REG_100 0x1250190
+#define ACP_SCRATCH_REG_101 0x1250194
+#define ACP_SCRATCH_REG_102 0x1250198
+#define ACP_SCRATCH_REG_103 0x125019C
+#define ACP_SCRATCH_REG_104 0x12501A0
+#define ACP_SCRATCH_REG_105 0x12501A4
+#define ACP_SCRATCH_REG_106 0x12501A8
+#define ACP_SCRATCH_REG_107 0x12501AC
+#define ACP_SCRATCH_REG_108 0x12501B0
+#define ACP_SCRATCH_REG_109 0x12501B4
+#define ACP_SCRATCH_REG_110 0x12501B8
+#define ACP_SCRATCH_REG_111 0x12501BC
+#define ACP_SCRATCH_REG_112 0x12501C0
+#define ACP_SCRATCH_REG_113 0x12501C4
+#define ACP_SCRATCH_REG_114 0x12501C8
+#define ACP_SCRATCH_REG_115 0x12501CC
+#define ACP_SCRATCH_REG_116 0x12501D0
+#define ACP_SCRATCH_REG_117 0x12501D4
+#define ACP_SCRATCH_REG_118 0x12501D8
+#define ACP_SCRATCH_REG_119 0x12501DC
+#define ACP_SCRATCH_REG_120 0x12501E0
+#define ACP_SCRATCH_REG_121 0x12501E4
+#define ACP_SCRATCH_REG_122 0x12501E8
+#define ACP_SCRATCH_REG_123 0x12501EC
+#define ACP_SCRATCH_REG_124 0x12501F0
+#define ACP_SCRATCH_REG_125 0x12501F4
+#define ACP_SCRATCH_REG_126 0x12501F8
+#define ACP_SCRATCH_REG_127 0x12501FC
+#define ACP_SCRATCH_REG_128 0x1250200
#endif
--
2.51.2
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-05 2:07 [PATCH] ASoC: amd: add DMIC support for RPL platform Mingyou Chen
@ 2026-02-06 17:51 ` Mark Brown
2026-02-07 1:44 ` qby140326
0 siblings, 1 reply; 19+ messages in thread
From: Mark Brown @ 2026-02-06 17:51 UTC (permalink / raw)
To: Mingyou Chen
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Vijendar Mukunda, Mario Limonciello
[-- Attachment #1: Type: text/plain, Size: 59302 bytes --]
On Thu, Feb 05, 2026 at 10:07:03AM +0800, Mingyou Chen wrote:
> Add DMIC support for the AMD RPL platform. The drivers are derived on
> the YC platform driver.
Copying in some of the AMD people - there's no MAINTAINERS entry for the
AMD ASoC drivers, it'd probably be good to add one so people are more
likely to CC you on changes.
> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
> ---
> sound/soc/amd/Kconfig | 11 +
> sound/soc/amd/rpl/Makefile | 4 +
> sound/soc/amd/rpl/rpl-acp6x-mach.c | 131 +++++
> sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c | 454 ++++++++++++++++++
> sound/soc/amd/rpl/rpl-pci-acp6x.c | 123 ++++-
> sound/soc/amd/rpl/rpl_acp6x.h | 90 +++-
> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 420 +++++++++++++++-
> 7 files changed, 1221 insertions(+), 12 deletions(-)
> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-mach.c
> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index fd35a03aadcb..da2940e94a7e 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -134,6 +134,17 @@ config SND_SOC_AMD_RPL_ACP6x
> Say m if you have such a device.
> If unsure select "N".
>
> +config SND_SOC_AMD_RPL_MACH
> + tristate "AMD RPL support for DMIC"
> + select SND_SOC_DMIC
> + depends on SND_SOC_AMD_ACP6x && ACPI
> + help
> + This option enables machine driver for AMD RPL platform
> + using dmic. ACP IP has PDM Decoder block with DMA controller.
> + DMIC can be connected directly to ACP IP.
> + Say m if you have such a device.
> + If unsure select "N".
> +
> config SND_SOC_AMD_ACP63_TOPLEVEL
> tristate "support for AMD platforms with ACP version >= 6.3"
> default SND_AMD_ACP_CONFIG
> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
> index a3825c5be4e7..b1190fcdf1f6 100644
> --- a/sound/soc/amd/rpl/Makefile
> +++ b/sound/soc/amd/rpl/Makefile
> @@ -1,5 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0+
> # RPL platform Support
> snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
> +snd-rpl-acp6x-pdm-dma-y := rpl-acp6x-pdm-dma.o
> +snd-soc-rpl-acp6x-mach-y := rpl-acp6x-mach.o
>
> obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
> +obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-acp6x-pdm-dma.o
> +obj-$(CONFIG_SND_SOC_AMD_RPL_MACH) += snd-soc-rpl-acp6x-mach.o
> diff --git a/sound/soc/amd/rpl/rpl-acp6x-mach.c b/sound/soc/amd/rpl/rpl-acp6x-mach.c
> new file mode 100644
> index 000000000000..71a384b9a36c
> --- /dev/null
> +++ b/sound/soc/amd/rpl/rpl-acp6x-mach.c
> @@ -0,0 +1,131 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Machine driver for AMD RPL platform using DMIC
> + *
> + * Copyright 2025 Advanced Micro Devices, Inc.
> + */
> +
> +#include <sound/soc.h>
> +#include <sound/soc-dapm.h>
> +#include <linux/module.h>
> +#include <sound/pcm.h>
> +#include <sound/pcm_params.h>
> +#include <linux/io.h>
> +#include <linux/dmi.h>
> +#include <linux/acpi.h>
> +
> +#include "rpl_acp6x.h"
> +
> +#define DRV_NAME "acp_rpl_mach"
> +
> +SND_SOC_DAILINK_DEF(acp6x_pdm,
> + DAILINK_COMP_ARRAY(COMP_CPU("acp_rpl_pdm_dma.0")));
> +
> +SND_SOC_DAILINK_DEF(dmic_codec,
> + DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
> + "dmic-hifi")));
> +
> +SND_SOC_DAILINK_DEF(pdm_platform,
> + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_rpl_pdm_dma.0")));
> +
> +static struct snd_soc_dai_link acp6x_dai_pdm[] = {
> + {
> + .name = "rpl-acp6x-dmic-capture",
> + .stream_name = "DMIC capture",
> + .capture_only = 1,
> + SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
> + },
> +};
> +
> +static struct snd_soc_card acp6x_card = {
> + .name = "acp6x",
> + .owner = THIS_MODULE,
> + .dai_link = acp6x_dai_pdm,
> + .num_links = 1,
> +};
> +
> +static const struct dmi_system_id rpl_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
> + }
> + },
> + {}
> +};
> +
> +static int acp6x_probe(struct platform_device *pdev)
> +{
> + const struct dmi_system_id *dmi_id;
> + struct acp6x_pdm *machine = NULL;
> + struct snd_soc_card *card;
> + struct acpi_device *adev;
> + acpi_handle handle;
> + acpi_integer dmic_status;
> + int ret;
> + bool is_dmic_enable, wov_en;
> +
> + /* IF WOV entry not found, enable dmic based on AcpDmicConnected entry*/
> + is_dmic_enable = false;
> + wov_en = true;
> + /* check the parent device's firmware node has _DSD or not */
> + adev = ACPI_COMPANION(pdev->dev.parent);
> + if (adev) {
> + const union acpi_object *obj;
> +
> + if (!acpi_dev_get_property(adev, "AcpDmicConnected", ACPI_TYPE_INTEGER, &obj) &&
> + obj->integer.value == 1)
> + is_dmic_enable = true;
> + }
> +
> + handle = ACPI_HANDLE(pdev->dev.parent);
> + ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
> + if (!ACPI_FAILURE(ret)) {
> + wov_en = dmic_status;
> + if (!wov_en)
> + return -ENODEV;
> + } else {
> + /* Incase of ACPI method read failure then jump to check_dmi_entry */
> + goto check_dmi_entry;
> + }
> +
> + if (is_dmic_enable)
> + platform_set_drvdata(pdev, &acp6x_card);
> +
> +check_dmi_entry:
> + /* check for any DMI overrides */
> + dmi_id = dmi_first_match(rpl_acp_quirk_table);
> + if (dmi_id)
> + platform_set_drvdata(pdev, dmi_id->driver_data);
> +
> + card = platform_get_drvdata(pdev);
> + if (!card)
> + return -ENODEV;
> + dev_info(&pdev->dev, "Enabling ACP DMIC support via %s", dmi_id ? "DMI" : "ACPI");
> + acp6x_card.dev = &pdev->dev;
> +
> + snd_soc_card_set_drvdata(card, machine);
> + ret = devm_snd_soc_register_card(&pdev->dev, card);
> + if (ret) {
> + return dev_err_probe(&pdev->dev, ret,
> + "snd_soc_register_card(%s) failed\n",
> + card->name);
> + }
> + return 0;
> +}
> +
> +static struct platform_driver rpl_acp6x_mach_driver = {
> + .driver = {
> + .name = "acp_rpl_mach",
> + .pm = &snd_soc_pm_ops,
> + },
> + .probe = acp6x_probe,
> +};
> +
> +module_platform_driver(rpl_acp6x_mach_driver);
> +
> +MODULE_DESCRIPTION("AMD RPL support for DMIC");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);
> +
> diff --git a/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
> new file mode 100644
> index 000000000000..2ae6d388e488
> --- /dev/null
> +++ b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
> @@ -0,0 +1,454 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * AMD ALSA SoC RPL PDM Driver
> + *
> + * Copyright 2021 Advanced Micro Devices, Inc.
> + */
> +
> +#include <linux/platform_device.h>
> +#include <linux/module.h>
> +#include <linux/bitfield.h>
> +#include <linux/err.h>
> +#include <linux/io.h>
> +#include <sound/pcm_params.h>
> +#include <sound/soc.h>
> +#include <sound/soc-dai.h>
> +#include <linux/pm_runtime.h>
> +
> +#include "rpl_acp6x.h"
> +
> +#define DRV_NAME "acp_rpl_pdm_dma"
> +
> +static int pdm_gain = 3;
> +module_param(pdm_gain, int, 0644);
> +MODULE_PARM_DESC(pdm_gain, "Gain control (0-3)");
> +
> +static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
> + .info = SNDRV_PCM_INFO_INTERLEAVED |
> + SNDRV_PCM_INFO_BLOCK_TRANSFER |
> + SNDRV_PCM_INFO_MMAP |
> + SNDRV_PCM_INFO_MMAP_VALID |
> + SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
> + .channels_min = 2,
> + .channels_max = 2,
> + .rates = SNDRV_PCM_RATE_48000,
> + .rate_min = 48000,
> + .rate_max = 48000,
> + .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
> + .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
> + .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
> + .periods_min = CAPTURE_MIN_NUM_PERIODS,
> + .periods_max = CAPTURE_MAX_NUM_PERIODS,
> +};
> +
> +static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
> + u32 watermark_size, void __iomem *acp_base)
> +{
> + rpl_acp_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
> + rpl_acp_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
> + rpl_acp_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
> + rpl_acp_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
> +}
> +
> +static void acp6x_enable_pdm_clock(void __iomem *acp_base)
> +{
> + u32 pdm_clk_enable, pdm_ctrl;
> +
> + pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
> + pdm_ctrl = 0x00;
> +
> + rpl_acp_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
> + pdm_ctrl = rpl_acp_readl(acp_base + ACP_WOV_MISC_CTRL);
> + pdm_ctrl &= ~ACP_WOV_GAIN_CONTROL;
> + pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, clamp(pdm_gain, 0, 3));
> + rpl_acp_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
> +}
> +
> +static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
> +{
> + u32 ext_int_ctrl;
> +
> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
> + ext_int_ctrl |= PDM_DMA_INTR_MASK;
> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
> +}
> +
> +static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
> +{
> + u32 ext_int_ctrl;
> +
> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
> + ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
> +}
> +
> +static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
> +{
> + bool pdm_dma_status;
> + u32 pdm_enable, pdm_dma_enable;
> +
> + pdm_dma_status = false;
> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable & ACP_PDM_DMA_EN_STATUS))
> + pdm_dma_status = true;
> +
> + return pdm_dma_status;
> +}
> +
> +static int acp6x_start_pdm_dma(void __iomem *acp_base)
> +{
> + u32 pdm_enable;
> + u32 pdm_dma_enable;
> + int timeout;
> +
> + pdm_enable = 0x01;
> + pdm_dma_enable = 0x01;
> +
> + acp6x_enable_pdm_clock(acp_base);
> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + timeout = 0;
> + while (++timeout < ACP_COUNTER) {
> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
> + return 0;
> + udelay(DELAY_US);
> + }
> + return -ETIMEDOUT;
> +}
> +
> +static int acp6x_stop_pdm_dma(void __iomem *acp_base)
> +{
> + u32 pdm_enable, pdm_dma_enable;
> + int timeout;
> +
> + pdm_enable = 0x00;
> + pdm_dma_enable = 0x00;
> +
> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + if (pdm_dma_enable & 0x01) {
> + pdm_dma_enable = 0x02;
> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + timeout = 0;
> + while (++timeout < ACP_COUNTER) {
> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
> + if ((pdm_dma_enable & 0x02) == 0x00)
> + break;
> + udelay(DELAY_US);
> + }
> + if (timeout == ACP_COUNTER)
> + return -ETIMEDOUT;
> + }
> + if (pdm_enable == ACP_PDM_ENABLE) {
> + pdm_enable = ACP_PDM_DISABLE;
> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
> + }
> + rpl_acp_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
> + return 0;
> +}
> +
> +static void acp6x_config_dma(struct rpl_pdm_stream_instance *rtd, int direction)
> +{
> + u16 page_idx;
> + u32 low, high, val;
> + dma_addr_t addr;
> +
> + addr = rtd->dma_addr;
> + val = PDM_PTE_OFFSET;
> +
> + /* Group Enable */
> + rpl_acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
> + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
> + rpl_acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
> + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
> + for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
> + /* Load the low address of page int ACP SRAM through SRBM */
> + low = lower_32_bits(addr);
> + high = upper_32_bits(addr);
> +
> + rpl_acp_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
> + high |= BIT(31);
> + rpl_acp_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
> + val += 8;
> + addr += PAGE_SIZE;
> + }
> +}
> +
> +static int acp6x_pdm_dma_open(struct snd_soc_component *component,
> + struct snd_pcm_substream *substream)
> +{
> + struct snd_pcm_runtime *runtime;
> + struct rpl_pdm_dev_data *adata;
> + struct rpl_pdm_stream_instance *pdm_data;
> + int ret;
> +
> + runtime = substream->runtime;
> + adata = dev_get_drvdata(component->dev);
> + pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
> + if (!pdm_data)
> + return -EINVAL;
> +
> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
> + runtime->hw = acp6x_pdm_hardware_capture;
> +
> + ret = snd_pcm_hw_constraint_integer(runtime,
> + SNDRV_PCM_HW_PARAM_PERIODS);
> + if (ret < 0) {
> + dev_err(component->dev, "set integer constraint failed\n");
> + kfree(pdm_data);
> + return ret;
> + }
> +
> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
> +
> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
> + adata->capture_stream = substream;
> +
> + pdm_data->acp6x_base = adata->acp6x_base;
> + runtime->private_data = pdm_data;
> + return ret;
> +}
> +
> +static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
> + struct snd_pcm_substream *substream,
> + struct snd_pcm_hw_params *params)
> +{
> + struct rpl_pdm_stream_instance *rtd;
> + size_t size, period_bytes;
> +
> + rtd = substream->runtime->private_data;
> + if (!rtd)
> + return -EINVAL;
> + size = params_buffer_bytes(params);
> + period_bytes = params_period_bytes(params);
> + rtd->dma_addr = substream->runtime->dma_addr;
> + rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
> + acp6x_config_dma(rtd, substream->stream);
> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
> + period_bytes, rtd->acp6x_base);
> + return 0;
> +}
> +
> +static u64 acp6x_pdm_get_byte_count(struct rpl_pdm_stream_instance *rtd,
> + int direction)
> +{
> + union rpl_acp_pdm_dma_count byte_count;
> +
> + byte_count.bcount.high =
> + rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
> + byte_count.bcount.low =
> + rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
> + return byte_count.bytescount;
> +}
> +
> +static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
> + struct snd_pcm_substream *stream)
> +{
> + struct rpl_pdm_stream_instance *rtd;
> + u32 pos, buffersize;
> + u64 bytescount;
> +
> + rtd = stream->runtime->private_data;
> + buffersize = frames_to_bytes(stream->runtime,
> + stream->runtime->buffer_size);
> + bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
> + if (bytescount > rtd->bytescount)
> + bytescount -= rtd->bytescount;
> + pos = do_div(bytescount, buffersize);
> + return bytes_to_frames(stream->runtime, pos);
> +}
> +
> +static int acp6x_pdm_dma_new(struct snd_soc_component *component,
> + struct snd_soc_pcm_runtime *rtd)
> +{
> + struct device *parent = component->dev->parent;
> +
> + snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
> + parent, MIN_BUFFER, MAX_BUFFER);
> + return 0;
> +}
> +
> +static int acp6x_pdm_dma_close(struct snd_soc_component *component,
> + struct snd_pcm_substream *substream)
> +{
> + struct rpl_pdm_dev_data *adata = dev_get_drvdata(component->dev);
> +
> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
> + adata->capture_stream = NULL;
> + return 0;
> +}
> +
> +static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
> + int cmd, struct snd_soc_dai *dai)
> +{
> + struct rpl_pdm_stream_instance *rtd;
> + int ret;
> + bool pdm_status;
> + unsigned int ch_mask;
> +
> + rtd = substream->runtime->private_data;
> + ret = 0;
> + switch (substream->runtime->channels) {
> + case TWO_CH:
> + ch_mask = 0x00;
> + break;
> + default:
> + return -EINVAL;
> + }
> + switch (cmd) {
> + case SNDRV_PCM_TRIGGER_START:
> + case SNDRV_PCM_TRIGGER_RESUME:
> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> + rpl_acp_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
> + rpl_acp_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
> + ACP_WOV_PDM_DECIMATION_FACTOR);
> + rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
> + if (!pdm_status)
> + ret = acp6x_start_pdm_dma(rtd->acp6x_base);
> + break;
> + case SNDRV_PCM_TRIGGER_STOP:
> + case SNDRV_PCM_TRIGGER_SUSPEND:
> + case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
> + if (pdm_status)
> + ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
> + break;
> + default:
> + ret = -EINVAL;
> + break;
> + }
> + return ret;
> +}
> +
> +static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
> + .trigger = acp6x_pdm_dai_trigger,
> +};
> +
> +static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
> + .capture = {
> + .rates = SNDRV_PCM_RATE_48000,
> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
> + .channels_min = 2,
> + .channels_max = 2,
> + .rate_min = 48000,
> + .rate_max = 48000,
> + },
> + .ops = &acp6x_pdm_dai_ops,
> +};
> +
> +static const struct snd_soc_component_driver acp6x_pdm_component = {
> + .name = DRV_NAME,
> + .open = acp6x_pdm_dma_open,
> + .close = acp6x_pdm_dma_close,
> + .hw_params = acp6x_pdm_dma_hw_params,
> + .pointer = acp6x_pdm_dma_pointer,
> + .pcm_construct = acp6x_pdm_dma_new,
> + .legacy_dai_naming = 1,
> +};
> +
> +static int acp6x_pdm_audio_probe(struct platform_device *pdev)
> +{
> + struct resource *res;
> + struct rpl_pdm_dev_data *adata;
> + int status;
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res) {
> + dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
> + return -ENODEV;
> + }
> +
> + adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
> + if (!adata)
> + return -ENOMEM;
> +
> + adata->acp6x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
> + if (!adata->acp6x_base)
> + return -ENOMEM;
> +
> + adata->capture_stream = NULL;
> +
> + dev_set_drvdata(&pdev->dev, adata);
> + status = devm_snd_soc_register_component(&pdev->dev,
> + &acp6x_pdm_component,
> + &acp6x_pdm_dai_driver, 1);
> + if (status) {
> + dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
> +
> + return -ENODEV;
> + }
> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
> + pm_runtime_use_autosuspend(&pdev->dev);
> + pm_runtime_mark_last_busy(&pdev->dev);
> + pm_runtime_set_active(&pdev->dev);
> + pm_runtime_enable(&pdev->dev);
> + return 0;
> +}
> +
> +static void acp6x_pdm_audio_remove(struct platform_device *pdev)
> +{
> + pm_runtime_disable(&pdev->dev);
> +}
> +
> +static int acp6x_pdm_resume(struct device *dev)
> +{
> + struct rpl_pdm_dev_data *adata;
> + struct snd_pcm_runtime *runtime;
> + struct rpl_pdm_stream_instance *rtd;
> + u32 period_bytes, buffer_len;
> +
> + adata = dev_get_drvdata(dev);
> + if (adata->capture_stream && adata->capture_stream->runtime) {
> + runtime = adata->capture_stream->runtime;
> + rtd = runtime->private_data;
> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
> + buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
> + acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
> + period_bytes, adata->acp6x_base);
> + }
> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
> + return 0;
> +}
> +
> +static int acp6x_pdm_suspend(struct device *dev)
> +{
> + struct rpl_pdm_dev_data *adata;
> +
> + adata = dev_get_drvdata(dev);
> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
> + return 0;
> +}
> +
> +static int acp6x_pdm_runtime_resume(struct device *dev)
> +{
> + struct rpl_pdm_dev_data *adata;
> +
> + adata = dev_get_drvdata(dev);
> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
> + return 0;
> +}
> +
> +static const struct dev_pm_ops acp6x_pdm_pm_ops = {
> + RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
> + SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
> +};
> +
> +static struct platform_driver acp6x_pdm_dma_driver = {
> + .probe = acp6x_pdm_audio_probe,
> + .remove = acp6x_pdm_audio_remove,
> + .driver = {
> + .name = "acp_rpl_pdm_dma",
> + .pm = pm_ptr(&acp6x_pdm_pm_ops),
> + },
> +};
> +
> +module_platform_driver(acp6x_pdm_dma_driver);
> +
> +MODULE_DESCRIPTION("AMD ACP6x RPL PDM Driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:" DRV_NAME);
> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
> index e3afe9172bdf..9a0d9920ad8e 100644
> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
> +++ b/sound/soc/amd/rpl/rpl-pci-acp6x.c
> @@ -10,12 +10,16 @@
> #include <linux/io.h>
> #include <linux/delay.h>
> #include <linux/platform_device.h>
> +#include <sound/pcm.h>
> #include <linux/pm_runtime.h>
>
> #include "rpl_acp6x.h"
>
> struct rpl_dev_data {
> void __iomem *acp6x_base;
> + struct resource *res;
> + bool acp6x_audio_mode;
> + struct platform_device *pdev[ACP6x_DEVS];
> };
>
> static int rpl_power_on(void __iomem *acp_base)
> @@ -64,6 +68,19 @@ static int rpl_reset(void __iomem *acp_base)
> return -ETIMEDOUT;
> }
>
> +static void rpl_enable_interrupts(void __iomem *acp_base)
> +{
> + rpl_acp_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
> +}
> +
> +static void rpl_disable_interrupts(void __iomem *acp_base)
> +{
> + rpl_acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
> + ACP_EXTERNAL_INTR_STAT);
> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
> +}
> +
> static int rpl_init(void __iomem *acp_base)
> {
> int ret;
> @@ -82,6 +99,7 @@ static int rpl_init(void __iomem *acp_base)
> return ret;
> }
> rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
> + rpl_enable_interrupts(acp_base);
> return 0;
> }
>
> @@ -89,6 +107,7 @@ static int rpl_deinit(void __iomem *acp_base)
> {
> int ret;
>
> + rpl_disable_interrupts(acp_base);
> /* Reset */
> ret = rpl_reset(acp_base);
> if (ret) {
> @@ -100,13 +119,45 @@ static int rpl_deinit(void __iomem *acp_base)
> return 0;
> }
>
> +static irqreturn_t rpl_irq_handler(int irq, void *dev_id)
> +{
> + struct rpl_dev_data *adata;
> + struct rpl_pdm_dev_data *rpl_pdm_data;
> + u32 val;
> +
> + adata = dev_id;
> + if (!adata)
> + return IRQ_NONE;
> +
> + val = rpl_acp_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
> + if (val & BIT(PDM_DMA_STAT)) {
> + rpl_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
> + rpl_acp_writel(BIT(PDM_DMA_STAT), adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
> + if (rpl_pdm_data->capture_stream)
> + snd_pcm_period_elapsed(rpl_pdm_data->capture_stream);
> + return IRQ_HANDLED;
> + }
> + return IRQ_NONE;
> +}
> +
> static int snd_rpl_probe(struct pci_dev *pci,
> const struct pci_device_id *pci_id)
> {
> struct rpl_dev_data *adata;
> + struct platform_device_info pdevinfo[ACP6x_DEVS];
> + int index = 0;
> + int val = 0x00;
> + unsigned int irqflags, flag;
> u32 addr;
> int ret;
>
> + irqflags = IRQF_SHARED;
> +
> + /* Return if acp config flag is defined */
> + flag = snd_amd_acp_find_config(pci);
> + if (flag)
> + return -ENODEV;
> +
> /* RPL device check */
> switch (pci->revision) {
> case 0x62:
> @@ -145,12 +196,78 @@ static int snd_rpl_probe(struct pci_dev *pci,
> ret = rpl_init(adata->acp6x_base);
> if (ret)
> goto release_regions;
> +
> + val = rpl_acp_readl(adata->acp6x_base + ACP_PIN_CONFIG);
> + switch (val) {
> + case ACP_CONFIG_0:
> + case ACP_CONFIG_1:
> + case ACP_CONFIG_2:
> + case ACP_CONFIG_3:
> + case ACP_CONFIG_9:
> + case ACP_CONFIG_15:
> + dev_info(&pci->dev, "Audio Mode %d\n", val);
> + break;
> + default:
> + adata->res = devm_kzalloc(&pci->dev,
> + sizeof(struct resource),
> + GFP_KERNEL);
> + if (!adata->res) {
> + ret = -ENOMEM;
> + goto de_init;
> + }
> +
> + adata->res->name = "acp_iomem";
> + adata->res->flags = IORESOURCE_MEM;
> + adata->res->start = addr;
> + adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
> +
> + adata->acp6x_audio_mode = ACP6x_PDM_MODE;
> +
> + memset(&pdevinfo, 0, sizeof(pdevinfo));
> + pdevinfo[0].name = "acp_rpl_pdm_dma";
> + pdevinfo[0].id = 0;
> + pdevinfo[0].parent = &pci->dev;
> + pdevinfo[0].num_res = 1;
> + pdevinfo[0].res = adata->res;
> +
> + pdevinfo[1].name = "dmic-codec";
> + pdevinfo[1].id = 0;
> + pdevinfo[1].parent = &pci->dev;
> +
> + pdevinfo[2].name = "acp_rpl_mach";
> + pdevinfo[2].id = 0;
> + pdevinfo[2].parent = &pci->dev;
> +
> + for (index = 0; index < ACP6x_DEVS; index++) {
> + adata->pdev[index] =
> + platform_device_register_full(&pdevinfo[index]);
> + if (IS_ERR(adata->pdev[index])) {
> + dev_err(&pci->dev, "cannot register %s device\n",
> + pdevinfo[index].name);
> + ret = PTR_ERR(adata->pdev[index]);
> + goto unregister_devs;
> + }
> + }
> + break;
> + }
> + ret = devm_request_irq(&pci->dev, pci->irq, rpl_irq_handler,
> + irqflags, "ACP_PCI_IRQ", adata);
> + if (ret) {
> + dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
> + goto unregister_devs;
> + }
> pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
> pm_runtime_use_autosuspend(&pci->dev);
> pm_runtime_put_noidle(&pci->dev);
> pm_runtime_allow(&pci->dev);
>
> return 0;
> +unregister_devs:
> + for (--index; index >= 0; index--)
> + platform_device_unregister(adata->pdev[index]);
> +de_init:
> + if (rpl_deinit(adata->acp6x_base))
> + dev_err(&pci->dev, "ACP de-init failed\n");
> release_regions:
> pci_release_regions(pci);
> disable_pci:
> @@ -191,9 +308,13 @@ static const struct dev_pm_ops rpl_pm = {
> static void snd_rpl_remove(struct pci_dev *pci)
> {
> struct rpl_dev_data *adata;
> - int ret;
> + int ret, index;
>
> adata = pci_get_drvdata(pci);
> + if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
> + for (index = 0; index < ACP6x_DEVS; index++)
> + platform_device_unregister(adata->pdev[index]);
> + }
> ret = rpl_deinit(adata->acp6x_base);
> if (ret)
> dev_err(&pci->dev, "ACP de-init failed\n");
> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
> index f5816a33632e..d470927c1e35 100644
> --- a/sound/soc/amd/rpl/rpl_acp6x.h
> +++ b/sound/soc/amd/rpl/rpl_acp6x.h
> @@ -9,15 +9,46 @@
>
> #define ACP_DEVICE_ID 0x15E2
> #define ACP6x_PHY_BASE_ADDRESS 0x1240000
> +#define ACP6x_REG_START 0x1240000
> +#define ACP6x_REG_END 0x1250200
> +#define ACP6x_DEVS 3
> +#define ACP6x_PDM_MODE 1
>
> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
> -#define ACP_PGFSM_STATUS_MASK 3
> -#define ACP_POWERED_ON 0
> -#define ACP_POWER_ON_IN_PROGRESS 1
> -#define ACP_POWERED_OFF 2
> -#define ACP_POWER_OFF_IN_PROGRESS 3
> +#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
> +#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
> +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
> +#define ACP_PGFSM_STATUS_MASK 3
> +#define ACP_POWERED_ON 0
> +#define ACP_POWER_ON_IN_PROGRESS 1
> +#define ACP_POWERED_OFF 2
> +#define ACP_POWER_OFF_IN_PROGRESS 3
> +
> +#define ACP_ERROR_MASK 0x20000000
> +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
> +#define PDM_DMA_STAT 0x10
> +
> +#define PDM_DMA_INTR_MASK 0x10000
> +#define ACP_ERROR_STAT 29
> +#define PDM_DECIMATION_FACTOR 2
> +#define ACP_PDM_CLK_FREQ_MASK 7
> +#define ACP_WOV_GAIN_CONTROL GENMASK(4, 3)
> +#define ACP_PDM_ENABLE 1
> +#define ACP_PDM_DISABLE 0
> +#define ACP_PDM_DMA_EN_STATUS 2
> +#define TWO_CH 2
> +
> +#define ACP_SRAM_PTE_OFFSET 0x03800000
> +#define PAGE_SIZE_4K_ENABLE 2
> +#define PDM_PTE_OFFSET 0
> +#define PDM_MEM_WINDOW_START 0x4000000
> +
> +#define CAPTURE_MIN_NUM_PERIODS 4
> +#define CAPTURE_MAX_NUM_PERIODS 4
> +#define CAPTURE_MAX_PERIOD_SIZE 8192
> +#define CAPTURE_MIN_PERIOD_SIZE 4096
> +
> +#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
> +#define MIN_BUFFER MAX_BUFFER
>
> #define DELAY_US 5
> #define ACP_COUNTER 20000
> @@ -25,6 +56,47 @@
> /* time in ms for runtime suspend delay */
> #define ACP_SUSPEND_DELAY_MS 2000
>
> +enum rpl_acp_config {
> + ACP_CONFIG_0 = 0,
> + ACP_CONFIG_1,
> + ACP_CONFIG_2,
> + ACP_CONFIG_3,
> + ACP_CONFIG_4,
> + ACP_CONFIG_5,
> + ACP_CONFIG_6,
> + ACP_CONFIG_7,
> + ACP_CONFIG_8,
> + ACP_CONFIG_9,
> + ACP_CONFIG_10,
> + ACP_CONFIG_11,
> + ACP_CONFIG_12,
> + ACP_CONFIG_13,
> + ACP_CONFIG_14,
> + ACP_CONFIG_15,
> +};
> +
> +struct rpl_pdm_dev_data {
> + u32 pdm_irq;
> + void __iomem *acp6x_base;
> + struct snd_pcm_substream *capture_stream;
> +};
> +
> +struct rpl_pdm_stream_instance {
> + u16 num_pages;
> + u16 channels;
> + dma_addr_t dma_addr;
> + u64 bytescount;
> + void __iomem *acp6x_base;
> +};
> +
> +union rpl_acp_pdm_dma_count {
> + struct {
> + u32 low;
> + u32 high;
> + } bcount;
> + u64 bytescount;
> +};
> +
> static inline u32 rpl_acp_readl(void __iomem *base_addr)
> {
> return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
> @@ -34,3 +106,5 @@ static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
> {
> writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
> }
> +
> +int snd_amd_acp_find_config(struct pci_dev *pci);
> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> index 456498f5396d..44994a925149 100644
> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> +++ b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> @@ -8,14 +8,114 @@
> #ifndef _rpl_acp6x_OFFSET_HEADER
> #define _rpl_acp6x_OFFSET_HEADER
>
> +/* Registers from ACP_DMA block */
> +#define ACP_DMA_CNTL_0 0x1240000
> +#define ACP_DMA_CNTL_1 0x1240004
> +#define ACP_DMA_CNTL_2 0x1240008
> +#define ACP_DMA_CNTL_3 0x124000C
> +#define ACP_DMA_CNTL_4 0x1240010
> +#define ACP_DMA_CNTL_5 0x1240014
> +#define ACP_DMA_CNTL_6 0x1240018
> +#define ACP_DMA_CNTL_7 0x124001C
> +#define ACP_DMA_DSCR_STRT_IDX_0 0x1240020
> +#define ACP_DMA_DSCR_STRT_IDX_1 0x1240024
> +#define ACP_DMA_DSCR_STRT_IDX_2 0x1240028
> +#define ACP_DMA_DSCR_STRT_IDX_3 0x124002C
> +#define ACP_DMA_DSCR_STRT_IDX_4 0x1240030
> +#define ACP_DMA_DSCR_STRT_IDX_5 0x1240034
> +#define ACP_DMA_DSCR_STRT_IDX_6 0x1240038
> +#define ACP_DMA_DSCR_STRT_IDX_7 0x124003C
> +#define ACP_DMA_DSCR_CNT_0 0x1240040
> +#define ACP_DMA_DSCR_CNT_1 0x1240044
> +#define ACP_DMA_DSCR_CNT_2 0x1240048
> +#define ACP_DMA_DSCR_CNT_3 0x124004C
> +#define ACP_DMA_DSCR_CNT_4 0x1240050
> +#define ACP_DMA_DSCR_CNT_5 0x1240054
> +#define ACP_DMA_DSCR_CNT_6 0x1240058
> +#define ACP_DMA_DSCR_CNT_7 0x124005C
> +#define ACP_DMA_PRIO_0 0x1240060
> +#define ACP_DMA_PRIO_1 0x1240064
> +#define ACP_DMA_PRIO_2 0x1240068
> +#define ACP_DMA_PRIO_3 0x124006C
> +#define ACP_DMA_PRIO_4 0x1240070
> +#define ACP_DMA_PRIO_5 0x1240074
> +#define ACP_DMA_PRIO_6 0x1240078
> +#define ACP_DMA_PRIO_7 0x124007C
> +#define ACP_DMA_CUR_DSCR_0 0x1240080
> +#define ACP_DMA_CUR_DSCR_1 0x1240084
> +#define ACP_DMA_CUR_DSCR_2 0x1240088
> +#define ACP_DMA_CUR_DSCR_3 0x124008C
> +#define ACP_DMA_CUR_DSCR_4 0x1240090
> +#define ACP_DMA_CUR_DSCR_5 0x1240094
> +#define ACP_DMA_CUR_DSCR_6 0x1240098
> +#define ACP_DMA_CUR_DSCR_7 0x124009C
> +#define ACP_DMA_CUR_TRANS_CNT_0 0x12400A0
> +#define ACP_DMA_CUR_TRANS_CNT_1 0x12400A4
> +#define ACP_DMA_CUR_TRANS_CNT_2 0x12400A8
> +#define ACP_DMA_CUR_TRANS_CNT_3 0x12400AC
> +#define ACP_DMA_CUR_TRANS_CNT_4 0x12400B0
> +#define ACP_DMA_CUR_TRANS_CNT_5 0x12400B4
> +#define ACP_DMA_CUR_TRANS_CNT_6 0x12400B8
> +#define ACP_DMA_CUR_TRANS_CNT_7 0x12400BC
> +#define ACP_DMA_ERR_STS_0 0x12400C0
> +#define ACP_DMA_ERR_STS_1 0x12400C4
> +#define ACP_DMA_ERR_STS_2 0x12400C8
> +#define ACP_DMA_ERR_STS_3 0x12400CC
> +#define ACP_DMA_ERR_STS_4 0x12400D0
> +#define ACP_DMA_ERR_STS_5 0x12400D4
> +#define ACP_DMA_ERR_STS_6 0x12400D8
> +#define ACP_DMA_ERR_STS_7 0x12400DC
> +#define ACP_DMA_DESC_BASE_ADDR 0x12400E0
> +#define ACP_DMA_DESC_MAX_NUM_DSCR 0x12400E4
> +#define ACP_DMA_CH_STS 0x12400E8
> +#define ACP_DMA_CH_GROUP 0x12400EC
> +#define ACP_DMA_CH_RST_STS 0x12400F0
> +
> +/* Registers from ACP_AXI2AXIATU block */
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1 0x1240C00
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1 0x1240C04
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2 0x1240C08
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2 0x1240C0C
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3 0x1240C10
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3 0x1240C14
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4 0x1240C18
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4 0x1240C1C
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5 0x1240C20
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5 0x1240C24
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6 0x1240C28
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6 0x1240C2C
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7 0x1240C30
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7 0x1240C34
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8 0x1240C38
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8 0x1240C3C
> +#define ACPAXI2AXI_ATU_CTRL 0x1240C40
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9 0x1240C44
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9 0x1240C48
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10 0x1240C4C
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10 0x1240C50
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11 0x1240C54
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11 0x1240C58
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12 0x1240C5C
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12 0x1240C60
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13 0x1240C64
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13 0x1240C68
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14 0x1240C6C
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14 0x1240C70
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15 0x1240C74
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15 0x1240C78
> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16 0x1240C7C
> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16 0x1240C80
> +
> /* Registers from ACP_CLKRST block */
> #define ACP_SOFT_RESET 0x1241000
> #define ACP_CONTROL 0x1241004
> #define ACP_STATUS 0x1241008
> #define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
> -#define ACP_PGFSM_CONTROL 0x124101C
> -#define ACP_PGFSM_STATUS 0x1241020
> -#define ACP_CLKMUX_SEL 0x1241024
> +#define ACP_ZSC_DSP_CTRL 0x1241014
> +#define ACP_ZSC_STS 0x1241018
> +#define ACP_PGFSM_CONTROL 0x1241024
> +#define ACP_PGFSM_STATUS 0x1241028
> +#define ACP_CLKMUX_SEL 0x124102C
>
> /* Registers from ACP_AON block */
> #define ACP_PME_EN 0x1241400
> @@ -26,5 +126,319 @@
> #define ACP_PAD_PULLDOWN_CTRL 0x1241448
> #define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
> #define ACP_PAD_SCHMEN_CTRL 0x1241450
> +#define ACP_SW_PAD_KEEPER_EN 0x1241454
> +#define ACP_SW_WAKE_EN 0x1241458
> +#define ACP_I2S_WAKE_EN 0x124145C
> +#define ACP_SW1_WAKE_EN 0x1241460
> +
> +/* Registers from ACP_P1_MISC block */
> +#define ACP_EXTERNAL_INTR_ENB 0x1241A00
> +#define ACP_EXTERNAL_INTR_CNTL 0x1241A04
> +#define ACP_EXTERNAL_INTR_CNTL1 0x1241A08
> +#define ACP_EXTERNAL_INTR_STAT 0x1241A0C
> +#define ACP_EXTERNAL_INTR_STAT1 0x1241A10
> +#define ACP_ERROR_STATUS 0x1241A4C
> +#define ACP_P1_SW_I2S_ERROR_REASON 0x1241A50
> +#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL 0x1241A6C
> +#define ACP_P1_SW_I2S_TX_DMA_POS 0x1241A70
> +#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL 0x1241A74
> +#define ACP_P1_SW_I2S_RX_DMA_POS 0x1241A78
> +#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL 0x1241A7C
> +#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS 0x1241A80
> +#define ACP_SCRATCH_REG_BASE_ADDR 0x1241A84
> +#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL 0x1241A88
> +#define ACP_P1_SW_BT_TX_DMA_POS 0x1241A8C
> +#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL 0x1241A90
> +#define ACP_P1_SW_HS_TX_DMA_POS 0x1241A94
> +#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL 0x1241A98
> +#define ACP_P1_SW_BT_RX_DMA_POS 0x1241A9C
> +#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL 0x1241AA0
> +#define ACP_P1_SW_HS_RX_DMA_POS 0x1241AA4
> +
> +/* Registers from ACP_AUDIO_BUFFERS block */
> +#define ACP_I2S_RX_RINGBUFADDR 0x1242000
> +#define ACP_I2S_RX_RINGBUFSIZE 0x1242004
> +#define ACP_I2S_RX_LINKPOSITIONCNTR 0x1242008
> +#define ACP_I2S_RX_FIFOADDR 0x124200C
> +#define ACP_I2S_RX_FIFOSIZE 0x1242010
> +#define ACP_I2S_RX_DMA_SIZE 0x1242014
> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1242018
> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW 0x124201C
> +#define ACP_I2S_RX_INTR_WATERMARK_SIZE 0x1242020
> +#define ACP_I2S_TX_RINGBUFADDR 0x1242024
> +#define ACP_I2S_TX_RINGBUFSIZE 0x1242028
> +#define ACP_I2S_TX_LINKPOSITIONCNTR 0x124202C
> +#define ACP_I2S_TX_FIFOADDR 0x1242030
> +#define ACP_I2S_TX_FIFOSIZE 0x1242034
> +#define ACP_I2S_TX_DMA_SIZE 0x1242038
> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x124203C
> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1242040
> +#define ACP_I2S_TX_INTR_WATERMARK_SIZE 0x1242044
> +#define ACP_BT_RX_RINGBUFADDR 0x1242048
> +#define ACP_BT_RX_RINGBUFSIZE 0x124204C
> +#define ACP_BT_RX_LINKPOSITIONCNTR 0x1242050
> +#define ACP_BT_RX_FIFOADDR 0x1242054
> +#define ACP_BT_RX_FIFOSIZE 0x1242058
> +#define ACP_BT_RX_DMA_SIZE 0x124205C
> +#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1242060
> +#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW 0x1242064
> +#define ACP_BT_RX_INTR_WATERMARK_SIZE 0x1242068
> +#define ACP_BT_TX_RINGBUFADDR 0x124206C
> +#define ACP_BT_TX_RINGBUFSIZE 0x1242070
> +#define ACP_BT_TX_LINKPOSITIONCNTR 0x1242074
> +#define ACP_BT_TX_FIFOADDR 0x1242078
> +#define ACP_BT_TX_FIFOSIZE 0x124207C
> +#define ACP_BT_TX_DMA_SIZE 0x1242080
> +#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1242084
> +#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW 0x1242088
> +#define ACP_BT_TX_INTR_WATERMARK_SIZE 0x124208C
> +#define ACP_HS_RX_RINGBUFADDR 0x1242090
> +#define ACP_HS_RX_RINGBUFSIZE 0x1242094
> +#define ACP_HS_RX_LINKPOSITIONCNTR 0x1242098
> +#define ACP_HS_RX_FIFOADDR 0x124209C
> +#define ACP_HS_RX_FIFOSIZE 0x12420A0
> +#define ACP_HS_RX_DMA_SIZE 0x12420A4
> +#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH 0x12420A8
> +#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW 0x12420AC
> +#define ACP_HS_RX_INTR_WATERMARK_SIZE 0x12420B0
> +#define ACP_HS_TX_RINGBUFADDR 0x12420B4
> +#define ACP_HS_TX_RINGBUFSIZE 0x12420B8
> +#define ACP_HS_TX_LINKPOSITIONCNTR 0x12420BC
> +#define ACP_HS_TX_FIFOADDR 0x12420C0
> +#define ACP_HS_TX_FIFOSIZE 0x12420C4
> +#define ACP_HS_TX_DMA_SIZE 0x12420C8
> +#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH 0x12420CC
> +#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW 0x12420D0
> +#define ACP_HS_TX_INTR_WATERMARK_SIZE 0x12420D4
> +
> +/* Registers from ACP_I2S_TDM block */
> +#define ACP_I2STDM_IER 0x1242400
> +#define ACP_I2STDM_IRER 0x1242404
> +#define ACP_I2STDM_RXFRMT 0x1242408
> +#define ACP_I2STDM_ITER 0x124240C
> +#define ACP_I2STDM_TXFRMT 0x1242410
> +#define ACP_I2STDM0_MSTRCLKGEN 0x1242414
> +#define ACP_I2STDM1_MSTRCLKGEN 0x1242418
> +#define ACP_I2STDM2_MSTRCLKGEN 0x124241C
> +#define ACP_I2STDM_REFCLKGEN 0x1242420
> +
> +/* Registers from ACP_BT_TDM block */
> +#define ACP_BTTDM_IER 0x1242800
> +#define ACP_BTTDM_IRER 0x1242804
> +#define ACP_BTTDM_RXFRMT 0x1242808
> +#define ACP_BTTDM_ITER 0x124280C
> +#define ACP_BTTDM_TXFRMT 0x1242810
> +#define ACP_HSTDM_IER 0x1242814
> +#define ACP_HSTDM_IRER 0x1242818
> +#define ACP_HSTDM_RXFRMT 0x124281C
> +#define ACP_HSTDM_ITER 0x1242820
> +#define ACP_HSTDM_TXFRMT 0x1242824
> +
> +/* Registers from ACP_WOV block */
> +#define ACP_WOV_PDM_ENABLE 0x1242C04
> +#define ACP_WOV_PDM_DMA_ENABLE 0x1242C08
> +#define ACP_WOV_RX_RINGBUFADDR 0x1242C0C
> +#define ACP_WOV_RX_RINGBUFSIZE 0x1242C10
> +#define ACP_WOV_RX_LINKPOSITIONCNTR 0x1242C14
> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH 0x1242C18
> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW 0x1242C1C
> +#define ACP_WOV_RX_INTR_WATERMARK_SIZE 0x1242C20
> +#define ACP_WOV_PDM_FIFO_FLUSH 0x1242C24
> +#define ACP_WOV_PDM_NO_OF_CHANNELS 0x1242C28
> +#define ACP_WOV_PDM_DECIMATION_FACTOR 0x1242C2C
> +#define ACP_WOV_PDM_VAD_CTRL 0x1242C30
> +#define ACP_WOV_WAKE 0x1242C54
> +#define ACP_WOV_BUFFER_STATUS 0x1242C58
> +#define ACP_WOV_MISC_CTRL 0x1242C5C
> +#define ACP_WOV_CLK_CTRL 0x1242C60
> +#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN 0x1242C64
> +#define ACP_WOV_ERROR_STATUS_REGISTER 0x1242C68
> +#define ACP_PDM_CLKDIV 0x1242C6C
> +
> +/* Registers from ACP_P1_AUDIO_BUFFERS block */
> +#define ACP_P1_I2S_RX_RINGBUFADDR 0x1243A00
> +#define ACP_P1_I2S_RX_RINGBUFSIZE 0x1243A04
> +#define ACP_P1_I2S_RX_LINKPOSITIONCNTR 0x1243A08
> +#define ACP_P1_I2S_RX_FIFOADDR 0x1243A0C
> +#define ACP_P1_I2S_RX_FIFOSIZE 0x1243A10
> +#define ACP_P1_I2S_RX_DMA_SIZE 0x1243A14
> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1243A18
> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW 0x1243A1C
> +#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE 0x1243A20
> +#define ACP_P1_I2S_TX_RINGBUFADDR 0x1243A24
> +#define ACP_P1_I2S_TX_RINGBUFSIZE 0x1243A28
> +#define ACP_P1_I2S_TX_LINKPOSITIONCNTR 0x1243A2C
> +#define ACP_P1_I2S_TX_FIFOADDR 0x1243A30
> +#define ACP_P1_I2S_TX_FIFOSIZE 0x1243A34
> +#define ACP_P1_I2S_TX_DMA_SIZE 0x1243A38
> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x1243A3C
> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1243A40
> +#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE 0x1243A44
> +#define ACP_P1_BT_RX_RINGBUFADDR 0x1243A48
> +#define ACP_P1_BT_RX_RINGBUFSIZE 0x1243A4C
> +#define ACP_P1_BT_RX_LINKPOSITIONCNTR 0x1243A50
> +#define ACP_P1_BT_RX_FIFOADDR 0x1243A54
> +#define ACP_P1_BT_RX_FIFOSIZE 0x1243A58
> +#define ACP_P1_BT_RX_DMA_SIZE 0x1243A5C
> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1243A60
> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW 0x1243A64
> +#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE 0x1243A68
> +#define ACP_P1_BT_TX_RINGBUFADDR 0x1243A6C
> +#define ACP_P1_BT_TX_RINGBUFSIZE 0x1243A70
> +#define ACP_P1_BT_TX_LINKPOSITIONCNTR 0x1243A74
> +#define ACP_P1_BT_TX_FIFOADDR 0x1243A78
> +#define ACP_P1_BT_TX_FIFOSIZE 0x1243A7C
> +#define ACP_P1_BT_TX_DMA_SIZE 0x1243A80
> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1243A84
> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW 0x1243A88
> +#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE 0x1243A8C
> +#define ACP_P1_HS_RX_RINGBUFADDR 0x1243A90
> +#define ACP_P1_HS_RX_RINGBUFSIZE 0x1243A94
> +#define ACP_P1_HS_RX_LINKPOSITIONCNTR 0x1243A98
> +#define ACP_P1_HS_RX_FIFOADDR 0x1243A9C
> +#define ACP_P1_HS_RX_FIFOSIZE 0x1243AA0
> +#define ACP_P1_HS_RX_DMA_SIZE 0x1243AA4
> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH 0x1243AA8
> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW 0x1243AAC
> +#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE 0x1243AB0
> +#define ACP_P1_HS_TX_RINGBUFADDR 0x1243AB4
> +#define ACP_P1_HS_TX_RINGBUFSIZE 0x1243AB8
> +#define ACP_P1_HS_TX_LINKPOSITIONCNTR 0x1243ABC
> +#define ACP_P1_HS_TX_FIFOADDR 0x1243AC0
> +#define ACP_P1_HS_TX_FIFOSIZE 0x1243AC4
> +#define ACP_P1_HS_TX_DMA_SIZE 0x1243AC8
> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH 0x1243ACC
> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW 0x1243AD0
> +#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE 0x1243AD4
>
> +/* Registers from ACP_SCRATCH block */
> +#define ACP_SCRATCH_REG_0 0x1250000
> +#define ACP_SCRATCH_REG_1 0x1250004
> +#define ACP_SCRATCH_REG_2 0x1250008
> +#define ACP_SCRATCH_REG_3 0x125000C
> +#define ACP_SCRATCH_REG_4 0x1250010
> +#define ACP_SCRATCH_REG_5 0x1250014
> +#define ACP_SCRATCH_REG_6 0x1250018
> +#define ACP_SCRATCH_REG_7 0x125001C
> +#define ACP_SCRATCH_REG_8 0x1250020
> +#define ACP_SCRATCH_REG_9 0x1250024
> +#define ACP_SCRATCH_REG_10 0x1250028
> +#define ACP_SCRATCH_REG_11 0x125002C
> +#define ACP_SCRATCH_REG_12 0x1250030
> +#define ACP_SCRATCH_REG_13 0x1250034
> +#define ACP_SCRATCH_REG_14 0x1250038
> +#define ACP_SCRATCH_REG_15 0x125003C
> +#define ACP_SCRATCH_REG_16 0x1250040
> +#define ACP_SCRATCH_REG_17 0x1250044
> +#define ACP_SCRATCH_REG_18 0x1250048
> +#define ACP_SCRATCH_REG_19 0x125004C
> +#define ACP_SCRATCH_REG_20 0x1250050
> +#define ACP_SCRATCH_REG_21 0x1250054
> +#define ACP_SCRATCH_REG_22 0x1250058
> +#define ACP_SCRATCH_REG_23 0x125005C
> +#define ACP_SCRATCH_REG_24 0x1250060
> +#define ACP_SCRATCH_REG_25 0x1250064
> +#define ACP_SCRATCH_REG_26 0x1250068
> +#define ACP_SCRATCH_REG_27 0x125006C
> +#define ACP_SCRATCH_REG_28 0x1250070
> +#define ACP_SCRATCH_REG_29 0x1250074
> +#define ACP_SCRATCH_REG_30 0x1250078
> +#define ACP_SCRATCH_REG_31 0x125007C
> +#define ACP_SCRATCH_REG_32 0x1250080
> +#define ACP_SCRATCH_REG_33 0x1250084
> +#define ACP_SCRATCH_REG_34 0x1250088
> +#define ACP_SCRATCH_REG_35 0x125008C
> +#define ACP_SCRATCH_REG_36 0x1250090
> +#define ACP_SCRATCH_REG_37 0x1250094
> +#define ACP_SCRATCH_REG_38 0x1250098
> +#define ACP_SCRATCH_REG_39 0x125009C
> +#define ACP_SCRATCH_REG_40 0x12500A0
> +#define ACP_SCRATCH_REG_41 0x12500A4
> +#define ACP_SCRATCH_REG_42 0x12500A8
> +#define ACP_SCRATCH_REG_43 0x12500AC
> +#define ACP_SCRATCH_REG_44 0x12500B0
> +#define ACP_SCRATCH_REG_45 0x12500B4
> +#define ACP_SCRATCH_REG_46 0x12500B8
> +#define ACP_SCRATCH_REG_47 0x12500BC
> +#define ACP_SCRATCH_REG_48 0x12500C0
> +#define ACP_SCRATCH_REG_49 0x12500C4
> +#define ACP_SCRATCH_REG_50 0x12500C8
> +#define ACP_SCRATCH_REG_51 0x12500CC
> +#define ACP_SCRATCH_REG_52 0x12500D0
> +#define ACP_SCRATCH_REG_53 0x12500D4
> +#define ACP_SCRATCH_REG_54 0x12500D8
> +#define ACP_SCRATCH_REG_55 0x12500DC
> +#define ACP_SCRATCH_REG_56 0x12500E0
> +#define ACP_SCRATCH_REG_57 0x12500E4
> +#define ACP_SCRATCH_REG_58 0x12500E8
> +#define ACP_SCRATCH_REG_59 0x12500EC
> +#define ACP_SCRATCH_REG_60 0x12500F0
> +#define ACP_SCRATCH_REG_61 0x12500F4
> +#define ACP_SCRATCH_REG_62 0x12500F8
> +#define ACP_SCRATCH_REG_63 0x12500FC
> +#define ACP_SCRATCH_REG_64 0x1250100
> +#define ACP_SCRATCH_REG_65 0x1250104
> +#define ACP_SCRATCH_REG_66 0x1250108
> +#define ACP_SCRATCH_REG_67 0x125010C
> +#define ACP_SCRATCH_REG_68 0x1250110
> +#define ACP_SCRATCH_REG_69 0x1250114
> +#define ACP_SCRATCH_REG_70 0x1250118
> +#define ACP_SCRATCH_REG_71 0x125011C
> +#define ACP_SCRATCH_REG_72 0x1250120
> +#define ACP_SCRATCH_REG_73 0x1250124
> +#define ACP_SCRATCH_REG_74 0x1250128
> +#define ACP_SCRATCH_REG_75 0x125012C
> +#define ACP_SCRATCH_REG_76 0x1250130
> +#define ACP_SCRATCH_REG_77 0x1250134
> +#define ACP_SCRATCH_REG_78 0x1250138
> +#define ACP_SCRATCH_REG_79 0x125013C
> +#define ACP_SCRATCH_REG_80 0x1250140
> +#define ACP_SCRATCH_REG_81 0x1250144
> +#define ACP_SCRATCH_REG_82 0x1250148
> +#define ACP_SCRATCH_REG_83 0x125014C
> +#define ACP_SCRATCH_REG_84 0x1250150
> +#define ACP_SCRATCH_REG_85 0x1250154
> +#define ACP_SCRATCH_REG_86 0x1250158
> +#define ACP_SCRATCH_REG_87 0x125015C
> +#define ACP_SCRATCH_REG_88 0x1250160
> +#define ACP_SCRATCH_REG_89 0x1250164
> +#define ACP_SCRATCH_REG_90 0x1250168
> +#define ACP_SCRATCH_REG_91 0x125016C
> +#define ACP_SCRATCH_REG_92 0x1250170
> +#define ACP_SCRATCH_REG_93 0x1250174
> +#define ACP_SCRATCH_REG_94 0x1250178
> +#define ACP_SCRATCH_REG_95 0x125017C
> +#define ACP_SCRATCH_REG_96 0x1250180
> +#define ACP_SCRATCH_REG_97 0x1250184
> +#define ACP_SCRATCH_REG_98 0x1250188
> +#define ACP_SCRATCH_REG_99 0x125018C
> +#define ACP_SCRATCH_REG_100 0x1250190
> +#define ACP_SCRATCH_REG_101 0x1250194
> +#define ACP_SCRATCH_REG_102 0x1250198
> +#define ACP_SCRATCH_REG_103 0x125019C
> +#define ACP_SCRATCH_REG_104 0x12501A0
> +#define ACP_SCRATCH_REG_105 0x12501A4
> +#define ACP_SCRATCH_REG_106 0x12501A8
> +#define ACP_SCRATCH_REG_107 0x12501AC
> +#define ACP_SCRATCH_REG_108 0x12501B0
> +#define ACP_SCRATCH_REG_109 0x12501B4
> +#define ACP_SCRATCH_REG_110 0x12501B8
> +#define ACP_SCRATCH_REG_111 0x12501BC
> +#define ACP_SCRATCH_REG_112 0x12501C0
> +#define ACP_SCRATCH_REG_113 0x12501C4
> +#define ACP_SCRATCH_REG_114 0x12501C8
> +#define ACP_SCRATCH_REG_115 0x12501CC
> +#define ACP_SCRATCH_REG_116 0x12501D0
> +#define ACP_SCRATCH_REG_117 0x12501D4
> +#define ACP_SCRATCH_REG_118 0x12501D8
> +#define ACP_SCRATCH_REG_119 0x12501DC
> +#define ACP_SCRATCH_REG_120 0x12501E0
> +#define ACP_SCRATCH_REG_121 0x12501E4
> +#define ACP_SCRATCH_REG_122 0x12501E8
> +#define ACP_SCRATCH_REG_123 0x12501EC
> +#define ACP_SCRATCH_REG_124 0x12501F0
> +#define ACP_SCRATCH_REG_125 0x12501F4
> +#define ACP_SCRATCH_REG_126 0x12501F8
> +#define ACP_SCRATCH_REG_127 0x12501FC
> +#define ACP_SCRATCH_REG_128 0x1250200
> #endif
> --
> 2.51.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-06 17:51 ` Mark Brown
@ 2026-02-07 1:44 ` qby140326
2026-02-07 5:50 ` Mukunda,Vijendar
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: qby140326 @ 2026-02-07 1:44 UTC (permalink / raw)
To: Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Vijendar Mukunda, Mario Limonciello,
Venkata Prasad Potturu
Hi Mark,
Since I don't work for AMD, I'm not in a position to decide who should
be officially responsible for this.
I have checked the git history via `git shortlog -sne --since="1 year
ago" sound/soc/amd/`, I've seen Vijendar and Venkata are the most
active contributors to the sound/soc/amd/ folder. I have CC-ed them in
this email. I'll leave it to the AMD team to coordinate and submit a
proper MAINTAINERS entry.
Best regards, Mingyou Chen
On 2/7/26 01:51, Mark Brown wrote:
> On Thu, Feb 05, 2026 at 10:07:03AM +0800, Mingyou Chen wrote:
>> Add DMIC support for the AMD RPL platform. The drivers are derived on
>> the YC platform driver.
> Copying in some of the AMD people - there's no MAINTAINERS entry for the
> AMD ASoC drivers, it'd probably be good to add one so people are more
> likely to CC you on changes.
>
>> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
>> ---
>> sound/soc/amd/Kconfig | 11 +
>> sound/soc/amd/rpl/Makefile | 4 +
>> sound/soc/amd/rpl/rpl-acp6x-mach.c | 131 +++++
>> sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c | 454 ++++++++++++++++++
>> sound/soc/amd/rpl/rpl-pci-acp6x.c | 123 ++++-
>> sound/soc/amd/rpl/rpl_acp6x.h | 90 +++-
>> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 420 +++++++++++++++-
>> 7 files changed, 1221 insertions(+), 12 deletions(-)
>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-mach.c
>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>
>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>> index fd35a03aadcb..da2940e94a7e 100644
>> --- a/sound/soc/amd/Kconfig
>> +++ b/sound/soc/amd/Kconfig
>> @@ -134,6 +134,17 @@ config SND_SOC_AMD_RPL_ACP6x
>> Say m if you have such a device.
>> If unsure select "N".
>>
>> +config SND_SOC_AMD_RPL_MACH
>> + tristate "AMD RPL support for DMIC"
>> + select SND_SOC_DMIC
>> + depends on SND_SOC_AMD_ACP6x && ACPI
>> + help
>> + This option enables machine driver for AMD RPL platform
>> + using dmic. ACP IP has PDM Decoder block with DMA controller.
>> + DMIC can be connected directly to ACP IP.
>> + Say m if you have such a device.
>> + If unsure select "N".
>> +
>> config SND_SOC_AMD_ACP63_TOPLEVEL
>> tristate "support for AMD platforms with ACP version >= 6.3"
>> default SND_AMD_ACP_CONFIG
>> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
>> index a3825c5be4e7..b1190fcdf1f6 100644
>> --- a/sound/soc/amd/rpl/Makefile
>> +++ b/sound/soc/amd/rpl/Makefile
>> @@ -1,5 +1,9 @@
>> # SPDX-License-Identifier: GPL-2.0+
>> # RPL platform Support
>> snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
>> +snd-rpl-acp6x-pdm-dma-y := rpl-acp6x-pdm-dma.o
>> +snd-soc-rpl-acp6x-mach-y := rpl-acp6x-mach.o
>>
>> obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
>> +obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-acp6x-pdm-dma.o
>> +obj-$(CONFIG_SND_SOC_AMD_RPL_MACH) += snd-soc-rpl-acp6x-mach.o
>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-mach.c b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>> new file mode 100644
>> index 000000000000..71a384b9a36c
>> --- /dev/null
>> +++ b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>> @@ -0,0 +1,131 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * Machine driver for AMD RPL platform using DMIC
>> + *
>> + * Copyright 2025 Advanced Micro Devices, Inc.
>> + */
>> +
>> +#include <sound/soc.h>
>> +#include <sound/soc-dapm.h>
>> +#include <linux/module.h>
>> +#include <sound/pcm.h>
>> +#include <sound/pcm_params.h>
>> +#include <linux/io.h>
>> +#include <linux/dmi.h>
>> +#include <linux/acpi.h>
>> +
>> +#include "rpl_acp6x.h"
>> +
>> +#define DRV_NAME "acp_rpl_mach"
>> +
>> +SND_SOC_DAILINK_DEF(acp6x_pdm,
>> + DAILINK_COMP_ARRAY(COMP_CPU("acp_rpl_pdm_dma.0")));
>> +
>> +SND_SOC_DAILINK_DEF(dmic_codec,
>> + DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
>> + "dmic-hifi")));
>> +
>> +SND_SOC_DAILINK_DEF(pdm_platform,
>> + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_rpl_pdm_dma.0")));
>> +
>> +static struct snd_soc_dai_link acp6x_dai_pdm[] = {
>> + {
>> + .name = "rpl-acp6x-dmic-capture",
>> + .stream_name = "DMIC capture",
>> + .capture_only = 1,
>> + SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
>> + },
>> +};
>> +
>> +static struct snd_soc_card acp6x_card = {
>> + .name = "acp6x",
>> + .owner = THIS_MODULE,
>> + .dai_link = acp6x_dai_pdm,
>> + .num_links = 1,
>> +};
>> +
>> +static const struct dmi_system_id rpl_acp_quirk_table[] = {
>> + {
>> + .driver_data = &acp6x_card,
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
>> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
>> + }
>> + },
>> + {}
>> +};
>> +
>> +static int acp6x_probe(struct platform_device *pdev)
>> +{
>> + const struct dmi_system_id *dmi_id;
>> + struct acp6x_pdm *machine = NULL;
>> + struct snd_soc_card *card;
>> + struct acpi_device *adev;
>> + acpi_handle handle;
>> + acpi_integer dmic_status;
>> + int ret;
>> + bool is_dmic_enable, wov_en;
>> +
>> + /* IF WOV entry not found, enable dmic based on AcpDmicConnected entry*/
>> + is_dmic_enable = false;
>> + wov_en = true;
>> + /* check the parent device's firmware node has _DSD or not */
>> + adev = ACPI_COMPANION(pdev->dev.parent);
>> + if (adev) {
>> + const union acpi_object *obj;
>> +
>> + if (!acpi_dev_get_property(adev, "AcpDmicConnected", ACPI_TYPE_INTEGER, &obj) &&
>> + obj->integer.value == 1)
>> + is_dmic_enable = true;
>> + }
>> +
>> + handle = ACPI_HANDLE(pdev->dev.parent);
>> + ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
>> + if (!ACPI_FAILURE(ret)) {
>> + wov_en = dmic_status;
>> + if (!wov_en)
>> + return -ENODEV;
>> + } else {
>> + /* Incase of ACPI method read failure then jump to check_dmi_entry */
>> + goto check_dmi_entry;
>> + }
>> +
>> + if (is_dmic_enable)
>> + platform_set_drvdata(pdev, &acp6x_card);
>> +
>> +check_dmi_entry:
>> + /* check for any DMI overrides */
>> + dmi_id = dmi_first_match(rpl_acp_quirk_table);
>> + if (dmi_id)
>> + platform_set_drvdata(pdev, dmi_id->driver_data);
>> +
>> + card = platform_get_drvdata(pdev);
>> + if (!card)
>> + return -ENODEV;
>> + dev_info(&pdev->dev, "Enabling ACP DMIC support via %s", dmi_id ? "DMI" : "ACPI");
>> + acp6x_card.dev = &pdev->dev;
>> +
>> + snd_soc_card_set_drvdata(card, machine);
>> + ret = devm_snd_soc_register_card(&pdev->dev, card);
>> + if (ret) {
>> + return dev_err_probe(&pdev->dev, ret,
>> + "snd_soc_register_card(%s) failed\n",
>> + card->name);
>> + }
>> + return 0;
>> +}
>> +
>> +static struct platform_driver rpl_acp6x_mach_driver = {
>> + .driver = {
>> + .name = "acp_rpl_mach",
>> + .pm = &snd_soc_pm_ops,
>> + },
>> + .probe = acp6x_probe,
>> +};
>> +
>> +module_platform_driver(rpl_acp6x_mach_driver);
>> +
>> +MODULE_DESCRIPTION("AMD RPL support for DMIC");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:" DRV_NAME);
>> +
>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>> new file mode 100644
>> index 000000000000..2ae6d388e488
>> --- /dev/null
>> +++ b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>> @@ -0,0 +1,454 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * AMD ALSA SoC RPL PDM Driver
>> + *
>> + * Copyright 2021 Advanced Micro Devices, Inc.
>> + */
>> +
>> +#include <linux/platform_device.h>
>> +#include <linux/module.h>
>> +#include <linux/bitfield.h>
>> +#include <linux/err.h>
>> +#include <linux/io.h>
>> +#include <sound/pcm_params.h>
>> +#include <sound/soc.h>
>> +#include <sound/soc-dai.h>
>> +#include <linux/pm_runtime.h>
>> +
>> +#include "rpl_acp6x.h"
>> +
>> +#define DRV_NAME "acp_rpl_pdm_dma"
>> +
>> +static int pdm_gain = 3;
>> +module_param(pdm_gain, int, 0644);
>> +MODULE_PARM_DESC(pdm_gain, "Gain control (0-3)");
>> +
>> +static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
>> + .info = SNDRV_PCM_INFO_INTERLEAVED |
>> + SNDRV_PCM_INFO_BLOCK_TRANSFER |
>> + SNDRV_PCM_INFO_MMAP |
>> + SNDRV_PCM_INFO_MMAP_VALID |
>> + SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>> + .channels_min = 2,
>> + .channels_max = 2,
>> + .rates = SNDRV_PCM_RATE_48000,
>> + .rate_min = 48000,
>> + .rate_max = 48000,
>> + .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
>> + .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
>> + .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
>> + .periods_min = CAPTURE_MIN_NUM_PERIODS,
>> + .periods_max = CAPTURE_MAX_NUM_PERIODS,
>> +};
>> +
>> +static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
>> + u32 watermark_size, void __iomem *acp_base)
>> +{
>> + rpl_acp_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
>> + rpl_acp_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
>> + rpl_acp_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
>> + rpl_acp_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
>> +}
>> +
>> +static void acp6x_enable_pdm_clock(void __iomem *acp_base)
>> +{
>> + u32 pdm_clk_enable, pdm_ctrl;
>> +
>> + pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
>> + pdm_ctrl = 0x00;
>> +
>> + rpl_acp_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
>> + pdm_ctrl = rpl_acp_readl(acp_base + ACP_WOV_MISC_CTRL);
>> + pdm_ctrl &= ~ACP_WOV_GAIN_CONTROL;
>> + pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, clamp(pdm_gain, 0, 3));
>> + rpl_acp_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
>> +}
>> +
>> +static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
>> +{
>> + u32 ext_int_ctrl;
>> +
>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>> + ext_int_ctrl |= PDM_DMA_INTR_MASK;
>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>> +}
>> +
>> +static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
>> +{
>> + u32 ext_int_ctrl;
>> +
>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>> + ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>> +}
>> +
>> +static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
>> +{
>> + bool pdm_dma_status;
>> + u32 pdm_enable, pdm_dma_enable;
>> +
>> + pdm_dma_status = false;
>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable & ACP_PDM_DMA_EN_STATUS))
>> + pdm_dma_status = true;
>> +
>> + return pdm_dma_status;
>> +}
>> +
>> +static int acp6x_start_pdm_dma(void __iomem *acp_base)
>> +{
>> + u32 pdm_enable;
>> + u32 pdm_dma_enable;
>> + int timeout;
>> +
>> + pdm_enable = 0x01;
>> + pdm_dma_enable = 0x01;
>> +
>> + acp6x_enable_pdm_clock(acp_base);
>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + timeout = 0;
>> + while (++timeout < ACP_COUNTER) {
>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
>> + return 0;
>> + udelay(DELAY_US);
>> + }
>> + return -ETIMEDOUT;
>> +}
>> +
>> +static int acp6x_stop_pdm_dma(void __iomem *acp_base)
>> +{
>> + u32 pdm_enable, pdm_dma_enable;
>> + int timeout;
>> +
>> + pdm_enable = 0x00;
>> + pdm_dma_enable = 0x00;
>> +
>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + if (pdm_dma_enable & 0x01) {
>> + pdm_dma_enable = 0x02;
>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + timeout = 0;
>> + while (++timeout < ACP_COUNTER) {
>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>> + if ((pdm_dma_enable & 0x02) == 0x00)
>> + break;
>> + udelay(DELAY_US);
>> + }
>> + if (timeout == ACP_COUNTER)
>> + return -ETIMEDOUT;
>> + }
>> + if (pdm_enable == ACP_PDM_ENABLE) {
>> + pdm_enable = ACP_PDM_DISABLE;
>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>> + }
>> + rpl_acp_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
>> + return 0;
>> +}
>> +
>> +static void acp6x_config_dma(struct rpl_pdm_stream_instance *rtd, int direction)
>> +{
>> + u16 page_idx;
>> + u32 low, high, val;
>> + dma_addr_t addr;
>> +
>> + addr = rtd->dma_addr;
>> + val = PDM_PTE_OFFSET;
>> +
>> + /* Group Enable */
>> + rpl_acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
>> + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
>> + rpl_acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
>> + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
>> + for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
>> + /* Load the low address of page int ACP SRAM through SRBM */
>> + low = lower_32_bits(addr);
>> + high = upper_32_bits(addr);
>> +
>> + rpl_acp_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
>> + high |= BIT(31);
>> + rpl_acp_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
>> + val += 8;
>> + addr += PAGE_SIZE;
>> + }
>> +}
>> +
>> +static int acp6x_pdm_dma_open(struct snd_soc_component *component,
>> + struct snd_pcm_substream *substream)
>> +{
>> + struct snd_pcm_runtime *runtime;
>> + struct rpl_pdm_dev_data *adata;
>> + struct rpl_pdm_stream_instance *pdm_data;
>> + int ret;
>> +
>> + runtime = substream->runtime;
>> + adata = dev_get_drvdata(component->dev);
>> + pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
>> + if (!pdm_data)
>> + return -EINVAL;
>> +
>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>> + runtime->hw = acp6x_pdm_hardware_capture;
>> +
>> + ret = snd_pcm_hw_constraint_integer(runtime,
>> + SNDRV_PCM_HW_PARAM_PERIODS);
>> + if (ret < 0) {
>> + dev_err(component->dev, "set integer constraint failed\n");
>> + kfree(pdm_data);
>> + return ret;
>> + }
>> +
>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>> +
>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>> + adata->capture_stream = substream;
>> +
>> + pdm_data->acp6x_base = adata->acp6x_base;
>> + runtime->private_data = pdm_data;
>> + return ret;
>> +}
>> +
>> +static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
>> + struct snd_pcm_substream *substream,
>> + struct snd_pcm_hw_params *params)
>> +{
>> + struct rpl_pdm_stream_instance *rtd;
>> + size_t size, period_bytes;
>> +
>> + rtd = substream->runtime->private_data;
>> + if (!rtd)
>> + return -EINVAL;
>> + size = params_buffer_bytes(params);
>> + period_bytes = params_period_bytes(params);
>> + rtd->dma_addr = substream->runtime->dma_addr;
>> + rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
>> + acp6x_config_dma(rtd, substream->stream);
>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
>> + period_bytes, rtd->acp6x_base);
>> + return 0;
>> +}
>> +
>> +static u64 acp6x_pdm_get_byte_count(struct rpl_pdm_stream_instance *rtd,
>> + int direction)
>> +{
>> + union rpl_acp_pdm_dma_count byte_count;
>> +
>> + byte_count.bcount.high =
>> + rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
>> + byte_count.bcount.low =
>> + rpl_acp_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
>> + return byte_count.bytescount;
>> +}
>> +
>> +static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
>> + struct snd_pcm_substream *stream)
>> +{
>> + struct rpl_pdm_stream_instance *rtd;
>> + u32 pos, buffersize;
>> + u64 bytescount;
>> +
>> + rtd = stream->runtime->private_data;
>> + buffersize = frames_to_bytes(stream->runtime,
>> + stream->runtime->buffer_size);
>> + bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
>> + if (bytescount > rtd->bytescount)
>> + bytescount -= rtd->bytescount;
>> + pos = do_div(bytescount, buffersize);
>> + return bytes_to_frames(stream->runtime, pos);
>> +}
>> +
>> +static int acp6x_pdm_dma_new(struct snd_soc_component *component,
>> + struct snd_soc_pcm_runtime *rtd)
>> +{
>> + struct device *parent = component->dev->parent;
>> +
>> + snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
>> + parent, MIN_BUFFER, MAX_BUFFER);
>> + return 0;
>> +}
>> +
>> +static int acp6x_pdm_dma_close(struct snd_soc_component *component,
>> + struct snd_pcm_substream *substream)
>> +{
>> + struct rpl_pdm_dev_data *adata = dev_get_drvdata(component->dev);
>> +
>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>> + adata->capture_stream = NULL;
>> + return 0;
>> +}
>> +
>> +static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
>> + int cmd, struct snd_soc_dai *dai)
>> +{
>> + struct rpl_pdm_stream_instance *rtd;
>> + int ret;
>> + bool pdm_status;
>> + unsigned int ch_mask;
>> +
>> + rtd = substream->runtime->private_data;
>> + ret = 0;
>> + switch (substream->runtime->channels) {
>> + case TWO_CH:
>> + ch_mask = 0x00;
>> + break;
>> + default:
>> + return -EINVAL;
>> + }
>> + switch (cmd) {
>> + case SNDRV_PCM_TRIGGER_START:
>> + case SNDRV_PCM_TRIGGER_RESUME:
>> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>> + rpl_acp_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
>> + rpl_acp_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
>> + ACP_WOV_PDM_DECIMATION_FACTOR);
>> + rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>> + if (!pdm_status)
>> + ret = acp6x_start_pdm_dma(rtd->acp6x_base);
>> + break;
>> + case SNDRV_PCM_TRIGGER_STOP:
>> + case SNDRV_PCM_TRIGGER_SUSPEND:
>> + case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>> + if (pdm_status)
>> + ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
>> + break;
>> + default:
>> + ret = -EINVAL;
>> + break;
>> + }
>> + return ret;
>> +}
>> +
>> +static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
>> + .trigger = acp6x_pdm_dai_trigger,
>> +};
>> +
>> +static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
>> + .capture = {
>> + .rates = SNDRV_PCM_RATE_48000,
>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>> + .channels_min = 2,
>> + .channels_max = 2,
>> + .rate_min = 48000,
>> + .rate_max = 48000,
>> + },
>> + .ops = &acp6x_pdm_dai_ops,
>> +};
>> +
>> +static const struct snd_soc_component_driver acp6x_pdm_component = {
>> + .name = DRV_NAME,
>> + .open = acp6x_pdm_dma_open,
>> + .close = acp6x_pdm_dma_close,
>> + .hw_params = acp6x_pdm_dma_hw_params,
>> + .pointer = acp6x_pdm_dma_pointer,
>> + .pcm_construct = acp6x_pdm_dma_new,
>> + .legacy_dai_naming = 1,
>> +};
>> +
>> +static int acp6x_pdm_audio_probe(struct platform_device *pdev)
>> +{
>> + struct resource *res;
>> + struct rpl_pdm_dev_data *adata;
>> + int status;
>> +
>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + if (!res) {
>> + dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
>> + return -ENODEV;
>> + }
>> +
>> + adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
>> + if (!adata)
>> + return -ENOMEM;
>> +
>> + adata->acp6x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
>> + if (!adata->acp6x_base)
>> + return -ENOMEM;
>> +
>> + adata->capture_stream = NULL;
>> +
>> + dev_set_drvdata(&pdev->dev, adata);
>> + status = devm_snd_soc_register_component(&pdev->dev,
>> + &acp6x_pdm_component,
>> + &acp6x_pdm_dai_driver, 1);
>> + if (status) {
>> + dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
>> +
>> + return -ENODEV;
>> + }
>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
>> + pm_runtime_use_autosuspend(&pdev->dev);
>> + pm_runtime_mark_last_busy(&pdev->dev);
>> + pm_runtime_set_active(&pdev->dev);
>> + pm_runtime_enable(&pdev->dev);
>> + return 0;
>> +}
>> +
>> +static void acp6x_pdm_audio_remove(struct platform_device *pdev)
>> +{
>> + pm_runtime_disable(&pdev->dev);
>> +}
>> +
>> +static int acp6x_pdm_resume(struct device *dev)
>> +{
>> + struct rpl_pdm_dev_data *adata;
>> + struct snd_pcm_runtime *runtime;
>> + struct rpl_pdm_stream_instance *rtd;
>> + u32 period_bytes, buffer_len;
>> +
>> + adata = dev_get_drvdata(dev);
>> + if (adata->capture_stream && adata->capture_stream->runtime) {
>> + runtime = adata->capture_stream->runtime;
>> + rtd = runtime->private_data;
>> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
>> + buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
>> + acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
>> + period_bytes, adata->acp6x_base);
>> + }
>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>> + return 0;
>> +}
>> +
>> +static int acp6x_pdm_suspend(struct device *dev)
>> +{
>> + struct rpl_pdm_dev_data *adata;
>> +
>> + adata = dev_get_drvdata(dev);
>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>> + return 0;
>> +}
>> +
>> +static int acp6x_pdm_runtime_resume(struct device *dev)
>> +{
>> + struct rpl_pdm_dev_data *adata;
>> +
>> + adata = dev_get_drvdata(dev);
>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>> + return 0;
>> +}
>> +
>> +static const struct dev_pm_ops acp6x_pdm_pm_ops = {
>> + RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
>> + SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
>> +};
>> +
>> +static struct platform_driver acp6x_pdm_dma_driver = {
>> + .probe = acp6x_pdm_audio_probe,
>> + .remove = acp6x_pdm_audio_remove,
>> + .driver = {
>> + .name = "acp_rpl_pdm_dma",
>> + .pm = pm_ptr(&acp6x_pdm_pm_ops),
>> + },
>> +};
>> +
>> +module_platform_driver(acp6x_pdm_dma_driver);
>> +
>> +MODULE_DESCRIPTION("AMD ACP6x RPL PDM Driver");
>> +MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:" DRV_NAME);
>> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>> index e3afe9172bdf..9a0d9920ad8e 100644
>> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
>> +++ b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>> @@ -10,12 +10,16 @@
>> #include <linux/io.h>
>> #include <linux/delay.h>
>> #include <linux/platform_device.h>
>> +#include <sound/pcm.h>
>> #include <linux/pm_runtime.h>
>>
>> #include "rpl_acp6x.h"
>>
>> struct rpl_dev_data {
>> void __iomem *acp6x_base;
>> + struct resource *res;
>> + bool acp6x_audio_mode;
>> + struct platform_device *pdev[ACP6x_DEVS];
>> };
>>
>> static int rpl_power_on(void __iomem *acp_base)
>> @@ -64,6 +68,19 @@ static int rpl_reset(void __iomem *acp_base)
>> return -ETIMEDOUT;
>> }
>>
>> +static void rpl_enable_interrupts(void __iomem *acp_base)
>> +{
>> + rpl_acp_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
>> +}
>> +
>> +static void rpl_disable_interrupts(void __iomem *acp_base)
>> +{
>> + rpl_acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
>> + ACP_EXTERNAL_INTR_STAT);
>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
>> +}
>> +
>> static int rpl_init(void __iomem *acp_base)
>> {
>> int ret;
>> @@ -82,6 +99,7 @@ static int rpl_init(void __iomem *acp_base)
>> return ret;
>> }
>> rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
>> + rpl_enable_interrupts(acp_base);
>> return 0;
>> }
>>
>> @@ -89,6 +107,7 @@ static int rpl_deinit(void __iomem *acp_base)
>> {
>> int ret;
>>
>> + rpl_disable_interrupts(acp_base);
>> /* Reset */
>> ret = rpl_reset(acp_base);
>> if (ret) {
>> @@ -100,13 +119,45 @@ static int rpl_deinit(void __iomem *acp_base)
>> return 0;
>> }
>>
>> +static irqreturn_t rpl_irq_handler(int irq, void *dev_id)
>> +{
>> + struct rpl_dev_data *adata;
>> + struct rpl_pdm_dev_data *rpl_pdm_data;
>> + u32 val;
>> +
>> + adata = dev_id;
>> + if (!adata)
>> + return IRQ_NONE;
>> +
>> + val = rpl_acp_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>> + if (val & BIT(PDM_DMA_STAT)) {
>> + rpl_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
>> + rpl_acp_writel(BIT(PDM_DMA_STAT), adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>> + if (rpl_pdm_data->capture_stream)
>> + snd_pcm_period_elapsed(rpl_pdm_data->capture_stream);
>> + return IRQ_HANDLED;
>> + }
>> + return IRQ_NONE;
>> +}
>> +
>> static int snd_rpl_probe(struct pci_dev *pci,
>> const struct pci_device_id *pci_id)
>> {
>> struct rpl_dev_data *adata;
>> + struct platform_device_info pdevinfo[ACP6x_DEVS];
>> + int index = 0;
>> + int val = 0x00;
>> + unsigned int irqflags, flag;
>> u32 addr;
>> int ret;
>>
>> + irqflags = IRQF_SHARED;
>> +
>> + /* Return if acp config flag is defined */
>> + flag = snd_amd_acp_find_config(pci);
>> + if (flag)
>> + return -ENODEV;
>> +
>> /* RPL device check */
>> switch (pci->revision) {
>> case 0x62:
>> @@ -145,12 +196,78 @@ static int snd_rpl_probe(struct pci_dev *pci,
>> ret = rpl_init(adata->acp6x_base);
>> if (ret)
>> goto release_regions;
>> +
>> + val = rpl_acp_readl(adata->acp6x_base + ACP_PIN_CONFIG);
>> + switch (val) {
>> + case ACP_CONFIG_0:
>> + case ACP_CONFIG_1:
>> + case ACP_CONFIG_2:
>> + case ACP_CONFIG_3:
>> + case ACP_CONFIG_9:
>> + case ACP_CONFIG_15:
>> + dev_info(&pci->dev, "Audio Mode %d\n", val);
>> + break;
>> + default:
>> + adata->res = devm_kzalloc(&pci->dev,
>> + sizeof(struct resource),
>> + GFP_KERNEL);
>> + if (!adata->res) {
>> + ret = -ENOMEM;
>> + goto de_init;
>> + }
>> +
>> + adata->res->name = "acp_iomem";
>> + adata->res->flags = IORESOURCE_MEM;
>> + adata->res->start = addr;
>> + adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
>> +
>> + adata->acp6x_audio_mode = ACP6x_PDM_MODE;
>> +
>> + memset(&pdevinfo, 0, sizeof(pdevinfo));
>> + pdevinfo[0].name = "acp_rpl_pdm_dma";
>> + pdevinfo[0].id = 0;
>> + pdevinfo[0].parent = &pci->dev;
>> + pdevinfo[0].num_res = 1;
>> + pdevinfo[0].res = adata->res;
>> +
>> + pdevinfo[1].name = "dmic-codec";
>> + pdevinfo[1].id = 0;
>> + pdevinfo[1].parent = &pci->dev;
>> +
>> + pdevinfo[2].name = "acp_rpl_mach";
>> + pdevinfo[2].id = 0;
>> + pdevinfo[2].parent = &pci->dev;
>> +
>> + for (index = 0; index < ACP6x_DEVS; index++) {
>> + adata->pdev[index] =
>> + platform_device_register_full(&pdevinfo[index]);
>> + if (IS_ERR(adata->pdev[index])) {
>> + dev_err(&pci->dev, "cannot register %s device\n",
>> + pdevinfo[index].name);
>> + ret = PTR_ERR(adata->pdev[index]);
>> + goto unregister_devs;
>> + }
>> + }
>> + break;
>> + }
>> + ret = devm_request_irq(&pci->dev, pci->irq, rpl_irq_handler,
>> + irqflags, "ACP_PCI_IRQ", adata);
>> + if (ret) {
>> + dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
>> + goto unregister_devs;
>> + }
>> pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
>> pm_runtime_use_autosuspend(&pci->dev);
>> pm_runtime_put_noidle(&pci->dev);
>> pm_runtime_allow(&pci->dev);
>>
>> return 0;
>> +unregister_devs:
>> + for (--index; index >= 0; index--)
>> + platform_device_unregister(adata->pdev[index]);
>> +de_init:
>> + if (rpl_deinit(adata->acp6x_base))
>> + dev_err(&pci->dev, "ACP de-init failed\n");
>> release_regions:
>> pci_release_regions(pci);
>> disable_pci:
>> @@ -191,9 +308,13 @@ static const struct dev_pm_ops rpl_pm = {
>> static void snd_rpl_remove(struct pci_dev *pci)
>> {
>> struct rpl_dev_data *adata;
>> - int ret;
>> + int ret, index;
>>
>> adata = pci_get_drvdata(pci);
>> + if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
>> + for (index = 0; index < ACP6x_DEVS; index++)
>> + platform_device_unregister(adata->pdev[index]);
>> + }
>> ret = rpl_deinit(adata->acp6x_base);
>> if (ret)
>> dev_err(&pci->dev, "ACP de-init failed\n");
>> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
>> index f5816a33632e..d470927c1e35 100644
>> --- a/sound/soc/amd/rpl/rpl_acp6x.h
>> +++ b/sound/soc/amd/rpl/rpl_acp6x.h
>> @@ -9,15 +9,46 @@
>>
>> #define ACP_DEVICE_ID 0x15E2
>> #define ACP6x_PHY_BASE_ADDRESS 0x1240000
>> +#define ACP6x_REG_START 0x1240000
>> +#define ACP6x_REG_END 0x1250200
>> +#define ACP6x_DEVS 3
>> +#define ACP6x_PDM_MODE 1
>>
>> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>> -#define ACP_PGFSM_STATUS_MASK 3
>> -#define ACP_POWERED_ON 0
>> -#define ACP_POWER_ON_IN_PROGRESS 1
>> -#define ACP_POWERED_OFF 2
>> -#define ACP_POWER_OFF_IN_PROGRESS 3
>> +#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>> +#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>> +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>> +#define ACP_PGFSM_STATUS_MASK 3
>> +#define ACP_POWERED_ON 0
>> +#define ACP_POWER_ON_IN_PROGRESS 1
>> +#define ACP_POWERED_OFF 2
>> +#define ACP_POWER_OFF_IN_PROGRESS 3
>> +
>> +#define ACP_ERROR_MASK 0x20000000
>> +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
>> +#define PDM_DMA_STAT 0x10
>> +
>> +#define PDM_DMA_INTR_MASK 0x10000
>> +#define ACP_ERROR_STAT 29
>> +#define PDM_DECIMATION_FACTOR 2
>> +#define ACP_PDM_CLK_FREQ_MASK 7
>> +#define ACP_WOV_GAIN_CONTROL GENMASK(4, 3)
>> +#define ACP_PDM_ENABLE 1
>> +#define ACP_PDM_DISABLE 0
>> +#define ACP_PDM_DMA_EN_STATUS 2
>> +#define TWO_CH 2
>> +
>> +#define ACP_SRAM_PTE_OFFSET 0x03800000
>> +#define PAGE_SIZE_4K_ENABLE 2
>> +#define PDM_PTE_OFFSET 0
>> +#define PDM_MEM_WINDOW_START 0x4000000
>> +
>> +#define CAPTURE_MIN_NUM_PERIODS 4
>> +#define CAPTURE_MAX_NUM_PERIODS 4
>> +#define CAPTURE_MAX_PERIOD_SIZE 8192
>> +#define CAPTURE_MIN_PERIOD_SIZE 4096
>> +
>> +#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
>> +#define MIN_BUFFER MAX_BUFFER
>>
>> #define DELAY_US 5
>> #define ACP_COUNTER 20000
>> @@ -25,6 +56,47 @@
>> /* time in ms for runtime suspend delay */
>> #define ACP_SUSPEND_DELAY_MS 2000
>>
>> +enum rpl_acp_config {
>> + ACP_CONFIG_0 = 0,
>> + ACP_CONFIG_1,
>> + ACP_CONFIG_2,
>> + ACP_CONFIG_3,
>> + ACP_CONFIG_4,
>> + ACP_CONFIG_5,
>> + ACP_CONFIG_6,
>> + ACP_CONFIG_7,
>> + ACP_CONFIG_8,
>> + ACP_CONFIG_9,
>> + ACP_CONFIG_10,
>> + ACP_CONFIG_11,
>> + ACP_CONFIG_12,
>> + ACP_CONFIG_13,
>> + ACP_CONFIG_14,
>> + ACP_CONFIG_15,
>> +};
>> +
>> +struct rpl_pdm_dev_data {
>> + u32 pdm_irq;
>> + void __iomem *acp6x_base;
>> + struct snd_pcm_substream *capture_stream;
>> +};
>> +
>> +struct rpl_pdm_stream_instance {
>> + u16 num_pages;
>> + u16 channels;
>> + dma_addr_t dma_addr;
>> + u64 bytescount;
>> + void __iomem *acp6x_base;
>> +};
>> +
>> +union rpl_acp_pdm_dma_count {
>> + struct {
>> + u32 low;
>> + u32 high;
>> + } bcount;
>> + u64 bytescount;
>> +};
>> +
>> static inline u32 rpl_acp_readl(void __iomem *base_addr)
>> {
>> return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
>> @@ -34,3 +106,5 @@ static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
>> {
>> writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
>> }
>> +
>> +int snd_amd_acp_find_config(struct pci_dev *pci);
>> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>> index 456498f5396d..44994a925149 100644
>> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>> +++ b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>> @@ -8,14 +8,114 @@
>> #ifndef _rpl_acp6x_OFFSET_HEADER
>> #define _rpl_acp6x_OFFSET_HEADER
>>
>> +/* Registers from ACP_DMA block */
>> +#define ACP_DMA_CNTL_0 0x1240000
>> +#define ACP_DMA_CNTL_1 0x1240004
>> +#define ACP_DMA_CNTL_2 0x1240008
>> +#define ACP_DMA_CNTL_3 0x124000C
>> +#define ACP_DMA_CNTL_4 0x1240010
>> +#define ACP_DMA_CNTL_5 0x1240014
>> +#define ACP_DMA_CNTL_6 0x1240018
>> +#define ACP_DMA_CNTL_7 0x124001C
>> +#define ACP_DMA_DSCR_STRT_IDX_0 0x1240020
>> +#define ACP_DMA_DSCR_STRT_IDX_1 0x1240024
>> +#define ACP_DMA_DSCR_STRT_IDX_2 0x1240028
>> +#define ACP_DMA_DSCR_STRT_IDX_3 0x124002C
>> +#define ACP_DMA_DSCR_STRT_IDX_4 0x1240030
>> +#define ACP_DMA_DSCR_STRT_IDX_5 0x1240034
>> +#define ACP_DMA_DSCR_STRT_IDX_6 0x1240038
>> +#define ACP_DMA_DSCR_STRT_IDX_7 0x124003C
>> +#define ACP_DMA_DSCR_CNT_0 0x1240040
>> +#define ACP_DMA_DSCR_CNT_1 0x1240044
>> +#define ACP_DMA_DSCR_CNT_2 0x1240048
>> +#define ACP_DMA_DSCR_CNT_3 0x124004C
>> +#define ACP_DMA_DSCR_CNT_4 0x1240050
>> +#define ACP_DMA_DSCR_CNT_5 0x1240054
>> +#define ACP_DMA_DSCR_CNT_6 0x1240058
>> +#define ACP_DMA_DSCR_CNT_7 0x124005C
>> +#define ACP_DMA_PRIO_0 0x1240060
>> +#define ACP_DMA_PRIO_1 0x1240064
>> +#define ACP_DMA_PRIO_2 0x1240068
>> +#define ACP_DMA_PRIO_3 0x124006C
>> +#define ACP_DMA_PRIO_4 0x1240070
>> +#define ACP_DMA_PRIO_5 0x1240074
>> +#define ACP_DMA_PRIO_6 0x1240078
>> +#define ACP_DMA_PRIO_7 0x124007C
>> +#define ACP_DMA_CUR_DSCR_0 0x1240080
>> +#define ACP_DMA_CUR_DSCR_1 0x1240084
>> +#define ACP_DMA_CUR_DSCR_2 0x1240088
>> +#define ACP_DMA_CUR_DSCR_3 0x124008C
>> +#define ACP_DMA_CUR_DSCR_4 0x1240090
>> +#define ACP_DMA_CUR_DSCR_5 0x1240094
>> +#define ACP_DMA_CUR_DSCR_6 0x1240098
>> +#define ACP_DMA_CUR_DSCR_7 0x124009C
>> +#define ACP_DMA_CUR_TRANS_CNT_0 0x12400A0
>> +#define ACP_DMA_CUR_TRANS_CNT_1 0x12400A4
>> +#define ACP_DMA_CUR_TRANS_CNT_2 0x12400A8
>> +#define ACP_DMA_CUR_TRANS_CNT_3 0x12400AC
>> +#define ACP_DMA_CUR_TRANS_CNT_4 0x12400B0
>> +#define ACP_DMA_CUR_TRANS_CNT_5 0x12400B4
>> +#define ACP_DMA_CUR_TRANS_CNT_6 0x12400B8
>> +#define ACP_DMA_CUR_TRANS_CNT_7 0x12400BC
>> +#define ACP_DMA_ERR_STS_0 0x12400C0
>> +#define ACP_DMA_ERR_STS_1 0x12400C4
>> +#define ACP_DMA_ERR_STS_2 0x12400C8
>> +#define ACP_DMA_ERR_STS_3 0x12400CC
>> +#define ACP_DMA_ERR_STS_4 0x12400D0
>> +#define ACP_DMA_ERR_STS_5 0x12400D4
>> +#define ACP_DMA_ERR_STS_6 0x12400D8
>> +#define ACP_DMA_ERR_STS_7 0x12400DC
>> +#define ACP_DMA_DESC_BASE_ADDR 0x12400E0
>> +#define ACP_DMA_DESC_MAX_NUM_DSCR 0x12400E4
>> +#define ACP_DMA_CH_STS 0x12400E8
>> +#define ACP_DMA_CH_GROUP 0x12400EC
>> +#define ACP_DMA_CH_RST_STS 0x12400F0
>> +
>> +/* Registers from ACP_AXI2AXIATU block */
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1 0x1240C00
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1 0x1240C04
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2 0x1240C08
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2 0x1240C0C
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3 0x1240C10
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3 0x1240C14
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4 0x1240C18
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4 0x1240C1C
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5 0x1240C20
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5 0x1240C24
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6 0x1240C28
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6 0x1240C2C
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7 0x1240C30
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7 0x1240C34
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8 0x1240C38
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8 0x1240C3C
>> +#define ACPAXI2AXI_ATU_CTRL 0x1240C40
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9 0x1240C44
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9 0x1240C48
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10 0x1240C4C
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10 0x1240C50
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11 0x1240C54
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11 0x1240C58
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12 0x1240C5C
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12 0x1240C60
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13 0x1240C64
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13 0x1240C68
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14 0x1240C6C
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14 0x1240C70
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15 0x1240C74
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15 0x1240C78
>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16 0x1240C7C
>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16 0x1240C80
>> +
>> /* Registers from ACP_CLKRST block */
>> #define ACP_SOFT_RESET 0x1241000
>> #define ACP_CONTROL 0x1241004
>> #define ACP_STATUS 0x1241008
>> #define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
>> -#define ACP_PGFSM_CONTROL 0x124101C
>> -#define ACP_PGFSM_STATUS 0x1241020
>> -#define ACP_CLKMUX_SEL 0x1241024
>> +#define ACP_ZSC_DSP_CTRL 0x1241014
>> +#define ACP_ZSC_STS 0x1241018
>> +#define ACP_PGFSM_CONTROL 0x1241024
>> +#define ACP_PGFSM_STATUS 0x1241028
>> +#define ACP_CLKMUX_SEL 0x124102C
>>
>> /* Registers from ACP_AON block */
>> #define ACP_PME_EN 0x1241400
>> @@ -26,5 +126,319 @@
>> #define ACP_PAD_PULLDOWN_CTRL 0x1241448
>> #define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
>> #define ACP_PAD_SCHMEN_CTRL 0x1241450
>> +#define ACP_SW_PAD_KEEPER_EN 0x1241454
>> +#define ACP_SW_WAKE_EN 0x1241458
>> +#define ACP_I2S_WAKE_EN 0x124145C
>> +#define ACP_SW1_WAKE_EN 0x1241460
>> +
>> +/* Registers from ACP_P1_MISC block */
>> +#define ACP_EXTERNAL_INTR_ENB 0x1241A00
>> +#define ACP_EXTERNAL_INTR_CNTL 0x1241A04
>> +#define ACP_EXTERNAL_INTR_CNTL1 0x1241A08
>> +#define ACP_EXTERNAL_INTR_STAT 0x1241A0C
>> +#define ACP_EXTERNAL_INTR_STAT1 0x1241A10
>> +#define ACP_ERROR_STATUS 0x1241A4C
>> +#define ACP_P1_SW_I2S_ERROR_REASON 0x1241A50
>> +#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL 0x1241A6C
>> +#define ACP_P1_SW_I2S_TX_DMA_POS 0x1241A70
>> +#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL 0x1241A74
>> +#define ACP_P1_SW_I2S_RX_DMA_POS 0x1241A78
>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL 0x1241A7C
>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS 0x1241A80
>> +#define ACP_SCRATCH_REG_BASE_ADDR 0x1241A84
>> +#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL 0x1241A88
>> +#define ACP_P1_SW_BT_TX_DMA_POS 0x1241A8C
>> +#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL 0x1241A90
>> +#define ACP_P1_SW_HS_TX_DMA_POS 0x1241A94
>> +#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL 0x1241A98
>> +#define ACP_P1_SW_BT_RX_DMA_POS 0x1241A9C
>> +#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL 0x1241AA0
>> +#define ACP_P1_SW_HS_RX_DMA_POS 0x1241AA4
>> +
>> +/* Registers from ACP_AUDIO_BUFFERS block */
>> +#define ACP_I2S_RX_RINGBUFADDR 0x1242000
>> +#define ACP_I2S_RX_RINGBUFSIZE 0x1242004
>> +#define ACP_I2S_RX_LINKPOSITIONCNTR 0x1242008
>> +#define ACP_I2S_RX_FIFOADDR 0x124200C
>> +#define ACP_I2S_RX_FIFOSIZE 0x1242010
>> +#define ACP_I2S_RX_DMA_SIZE 0x1242014
>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1242018
>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW 0x124201C
>> +#define ACP_I2S_RX_INTR_WATERMARK_SIZE 0x1242020
>> +#define ACP_I2S_TX_RINGBUFADDR 0x1242024
>> +#define ACP_I2S_TX_RINGBUFSIZE 0x1242028
>> +#define ACP_I2S_TX_LINKPOSITIONCNTR 0x124202C
>> +#define ACP_I2S_TX_FIFOADDR 0x1242030
>> +#define ACP_I2S_TX_FIFOSIZE 0x1242034
>> +#define ACP_I2S_TX_DMA_SIZE 0x1242038
>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x124203C
>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1242040
>> +#define ACP_I2S_TX_INTR_WATERMARK_SIZE 0x1242044
>> +#define ACP_BT_RX_RINGBUFADDR 0x1242048
>> +#define ACP_BT_RX_RINGBUFSIZE 0x124204C
>> +#define ACP_BT_RX_LINKPOSITIONCNTR 0x1242050
>> +#define ACP_BT_RX_FIFOADDR 0x1242054
>> +#define ACP_BT_RX_FIFOSIZE 0x1242058
>> +#define ACP_BT_RX_DMA_SIZE 0x124205C
>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1242060
>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW 0x1242064
>> +#define ACP_BT_RX_INTR_WATERMARK_SIZE 0x1242068
>> +#define ACP_BT_TX_RINGBUFADDR 0x124206C
>> +#define ACP_BT_TX_RINGBUFSIZE 0x1242070
>> +#define ACP_BT_TX_LINKPOSITIONCNTR 0x1242074
>> +#define ACP_BT_TX_FIFOADDR 0x1242078
>> +#define ACP_BT_TX_FIFOSIZE 0x124207C
>> +#define ACP_BT_TX_DMA_SIZE 0x1242080
>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1242084
>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW 0x1242088
>> +#define ACP_BT_TX_INTR_WATERMARK_SIZE 0x124208C
>> +#define ACP_HS_RX_RINGBUFADDR 0x1242090
>> +#define ACP_HS_RX_RINGBUFSIZE 0x1242094
>> +#define ACP_HS_RX_LINKPOSITIONCNTR 0x1242098
>> +#define ACP_HS_RX_FIFOADDR 0x124209C
>> +#define ACP_HS_RX_FIFOSIZE 0x12420A0
>> +#define ACP_HS_RX_DMA_SIZE 0x12420A4
>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH 0x12420A8
>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW 0x12420AC
>> +#define ACP_HS_RX_INTR_WATERMARK_SIZE 0x12420B0
>> +#define ACP_HS_TX_RINGBUFADDR 0x12420B4
>> +#define ACP_HS_TX_RINGBUFSIZE 0x12420B8
>> +#define ACP_HS_TX_LINKPOSITIONCNTR 0x12420BC
>> +#define ACP_HS_TX_FIFOADDR 0x12420C0
>> +#define ACP_HS_TX_FIFOSIZE 0x12420C4
>> +#define ACP_HS_TX_DMA_SIZE 0x12420C8
>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH 0x12420CC
>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW 0x12420D0
>> +#define ACP_HS_TX_INTR_WATERMARK_SIZE 0x12420D4
>> +
>> +/* Registers from ACP_I2S_TDM block */
>> +#define ACP_I2STDM_IER 0x1242400
>> +#define ACP_I2STDM_IRER 0x1242404
>> +#define ACP_I2STDM_RXFRMT 0x1242408
>> +#define ACP_I2STDM_ITER 0x124240C
>> +#define ACP_I2STDM_TXFRMT 0x1242410
>> +#define ACP_I2STDM0_MSTRCLKGEN 0x1242414
>> +#define ACP_I2STDM1_MSTRCLKGEN 0x1242418
>> +#define ACP_I2STDM2_MSTRCLKGEN 0x124241C
>> +#define ACP_I2STDM_REFCLKGEN 0x1242420
>> +
>> +/* Registers from ACP_BT_TDM block */
>> +#define ACP_BTTDM_IER 0x1242800
>> +#define ACP_BTTDM_IRER 0x1242804
>> +#define ACP_BTTDM_RXFRMT 0x1242808
>> +#define ACP_BTTDM_ITER 0x124280C
>> +#define ACP_BTTDM_TXFRMT 0x1242810
>> +#define ACP_HSTDM_IER 0x1242814
>> +#define ACP_HSTDM_IRER 0x1242818
>> +#define ACP_HSTDM_RXFRMT 0x124281C
>> +#define ACP_HSTDM_ITER 0x1242820
>> +#define ACP_HSTDM_TXFRMT 0x1242824
>> +
>> +/* Registers from ACP_WOV block */
>> +#define ACP_WOV_PDM_ENABLE 0x1242C04
>> +#define ACP_WOV_PDM_DMA_ENABLE 0x1242C08
>> +#define ACP_WOV_RX_RINGBUFADDR 0x1242C0C
>> +#define ACP_WOV_RX_RINGBUFSIZE 0x1242C10
>> +#define ACP_WOV_RX_LINKPOSITIONCNTR 0x1242C14
>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH 0x1242C18
>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW 0x1242C1C
>> +#define ACP_WOV_RX_INTR_WATERMARK_SIZE 0x1242C20
>> +#define ACP_WOV_PDM_FIFO_FLUSH 0x1242C24
>> +#define ACP_WOV_PDM_NO_OF_CHANNELS 0x1242C28
>> +#define ACP_WOV_PDM_DECIMATION_FACTOR 0x1242C2C
>> +#define ACP_WOV_PDM_VAD_CTRL 0x1242C30
>> +#define ACP_WOV_WAKE 0x1242C54
>> +#define ACP_WOV_BUFFER_STATUS 0x1242C58
>> +#define ACP_WOV_MISC_CTRL 0x1242C5C
>> +#define ACP_WOV_CLK_CTRL 0x1242C60
>> +#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN 0x1242C64
>> +#define ACP_WOV_ERROR_STATUS_REGISTER 0x1242C68
>> +#define ACP_PDM_CLKDIV 0x1242C6C
>> +
>> +/* Registers from ACP_P1_AUDIO_BUFFERS block */
>> +#define ACP_P1_I2S_RX_RINGBUFADDR 0x1243A00
>> +#define ACP_P1_I2S_RX_RINGBUFSIZE 0x1243A04
>> +#define ACP_P1_I2S_RX_LINKPOSITIONCNTR 0x1243A08
>> +#define ACP_P1_I2S_RX_FIFOADDR 0x1243A0C
>> +#define ACP_P1_I2S_RX_FIFOSIZE 0x1243A10
>> +#define ACP_P1_I2S_RX_DMA_SIZE 0x1243A14
>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1243A18
>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW 0x1243A1C
>> +#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE 0x1243A20
>> +#define ACP_P1_I2S_TX_RINGBUFADDR 0x1243A24
>> +#define ACP_P1_I2S_TX_RINGBUFSIZE 0x1243A28
>> +#define ACP_P1_I2S_TX_LINKPOSITIONCNTR 0x1243A2C
>> +#define ACP_P1_I2S_TX_FIFOADDR 0x1243A30
>> +#define ACP_P1_I2S_TX_FIFOSIZE 0x1243A34
>> +#define ACP_P1_I2S_TX_DMA_SIZE 0x1243A38
>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x1243A3C
>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1243A40
>> +#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE 0x1243A44
>> +#define ACP_P1_BT_RX_RINGBUFADDR 0x1243A48
>> +#define ACP_P1_BT_RX_RINGBUFSIZE 0x1243A4C
>> +#define ACP_P1_BT_RX_LINKPOSITIONCNTR 0x1243A50
>> +#define ACP_P1_BT_RX_FIFOADDR 0x1243A54
>> +#define ACP_P1_BT_RX_FIFOSIZE 0x1243A58
>> +#define ACP_P1_BT_RX_DMA_SIZE 0x1243A5C
>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1243A60
>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW 0x1243A64
>> +#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE 0x1243A68
>> +#define ACP_P1_BT_TX_RINGBUFADDR 0x1243A6C
>> +#define ACP_P1_BT_TX_RINGBUFSIZE 0x1243A70
>> +#define ACP_P1_BT_TX_LINKPOSITIONCNTR 0x1243A74
>> +#define ACP_P1_BT_TX_FIFOADDR 0x1243A78
>> +#define ACP_P1_BT_TX_FIFOSIZE 0x1243A7C
>> +#define ACP_P1_BT_TX_DMA_SIZE 0x1243A80
>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1243A84
>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW 0x1243A88
>> +#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE 0x1243A8C
>> +#define ACP_P1_HS_RX_RINGBUFADDR 0x1243A90
>> +#define ACP_P1_HS_RX_RINGBUFSIZE 0x1243A94
>> +#define ACP_P1_HS_RX_LINKPOSITIONCNTR 0x1243A98
>> +#define ACP_P1_HS_RX_FIFOADDR 0x1243A9C
>> +#define ACP_P1_HS_RX_FIFOSIZE 0x1243AA0
>> +#define ACP_P1_HS_RX_DMA_SIZE 0x1243AA4
>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH 0x1243AA8
>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW 0x1243AAC
>> +#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE 0x1243AB0
>> +#define ACP_P1_HS_TX_RINGBUFADDR 0x1243AB4
>> +#define ACP_P1_HS_TX_RINGBUFSIZE 0x1243AB8
>> +#define ACP_P1_HS_TX_LINKPOSITIONCNTR 0x1243ABC
>> +#define ACP_P1_HS_TX_FIFOADDR 0x1243AC0
>> +#define ACP_P1_HS_TX_FIFOSIZE 0x1243AC4
>> +#define ACP_P1_HS_TX_DMA_SIZE 0x1243AC8
>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH 0x1243ACC
>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW 0x1243AD0
>> +#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE 0x1243AD4
>>
>> +/* Registers from ACP_SCRATCH block */
>> +#define ACP_SCRATCH_REG_0 0x1250000
>> +#define ACP_SCRATCH_REG_1 0x1250004
>> +#define ACP_SCRATCH_REG_2 0x1250008
>> +#define ACP_SCRATCH_REG_3 0x125000C
>> +#define ACP_SCRATCH_REG_4 0x1250010
>> +#define ACP_SCRATCH_REG_5 0x1250014
>> +#define ACP_SCRATCH_REG_6 0x1250018
>> +#define ACP_SCRATCH_REG_7 0x125001C
>> +#define ACP_SCRATCH_REG_8 0x1250020
>> +#define ACP_SCRATCH_REG_9 0x1250024
>> +#define ACP_SCRATCH_REG_10 0x1250028
>> +#define ACP_SCRATCH_REG_11 0x125002C
>> +#define ACP_SCRATCH_REG_12 0x1250030
>> +#define ACP_SCRATCH_REG_13 0x1250034
>> +#define ACP_SCRATCH_REG_14 0x1250038
>> +#define ACP_SCRATCH_REG_15 0x125003C
>> +#define ACP_SCRATCH_REG_16 0x1250040
>> +#define ACP_SCRATCH_REG_17 0x1250044
>> +#define ACP_SCRATCH_REG_18 0x1250048
>> +#define ACP_SCRATCH_REG_19 0x125004C
>> +#define ACP_SCRATCH_REG_20 0x1250050
>> +#define ACP_SCRATCH_REG_21 0x1250054
>> +#define ACP_SCRATCH_REG_22 0x1250058
>> +#define ACP_SCRATCH_REG_23 0x125005C
>> +#define ACP_SCRATCH_REG_24 0x1250060
>> +#define ACP_SCRATCH_REG_25 0x1250064
>> +#define ACP_SCRATCH_REG_26 0x1250068
>> +#define ACP_SCRATCH_REG_27 0x125006C
>> +#define ACP_SCRATCH_REG_28 0x1250070
>> +#define ACP_SCRATCH_REG_29 0x1250074
>> +#define ACP_SCRATCH_REG_30 0x1250078
>> +#define ACP_SCRATCH_REG_31 0x125007C
>> +#define ACP_SCRATCH_REG_32 0x1250080
>> +#define ACP_SCRATCH_REG_33 0x1250084
>> +#define ACP_SCRATCH_REG_34 0x1250088
>> +#define ACP_SCRATCH_REG_35 0x125008C
>> +#define ACP_SCRATCH_REG_36 0x1250090
>> +#define ACP_SCRATCH_REG_37 0x1250094
>> +#define ACP_SCRATCH_REG_38 0x1250098
>> +#define ACP_SCRATCH_REG_39 0x125009C
>> +#define ACP_SCRATCH_REG_40 0x12500A0
>> +#define ACP_SCRATCH_REG_41 0x12500A4
>> +#define ACP_SCRATCH_REG_42 0x12500A8
>> +#define ACP_SCRATCH_REG_43 0x12500AC
>> +#define ACP_SCRATCH_REG_44 0x12500B0
>> +#define ACP_SCRATCH_REG_45 0x12500B4
>> +#define ACP_SCRATCH_REG_46 0x12500B8
>> +#define ACP_SCRATCH_REG_47 0x12500BC
>> +#define ACP_SCRATCH_REG_48 0x12500C0
>> +#define ACP_SCRATCH_REG_49 0x12500C4
>> +#define ACP_SCRATCH_REG_50 0x12500C8
>> +#define ACP_SCRATCH_REG_51 0x12500CC
>> +#define ACP_SCRATCH_REG_52 0x12500D0
>> +#define ACP_SCRATCH_REG_53 0x12500D4
>> +#define ACP_SCRATCH_REG_54 0x12500D8
>> +#define ACP_SCRATCH_REG_55 0x12500DC
>> +#define ACP_SCRATCH_REG_56 0x12500E0
>> +#define ACP_SCRATCH_REG_57 0x12500E4
>> +#define ACP_SCRATCH_REG_58 0x12500E8
>> +#define ACP_SCRATCH_REG_59 0x12500EC
>> +#define ACP_SCRATCH_REG_60 0x12500F0
>> +#define ACP_SCRATCH_REG_61 0x12500F4
>> +#define ACP_SCRATCH_REG_62 0x12500F8
>> +#define ACP_SCRATCH_REG_63 0x12500FC
>> +#define ACP_SCRATCH_REG_64 0x1250100
>> +#define ACP_SCRATCH_REG_65 0x1250104
>> +#define ACP_SCRATCH_REG_66 0x1250108
>> +#define ACP_SCRATCH_REG_67 0x125010C
>> +#define ACP_SCRATCH_REG_68 0x1250110
>> +#define ACP_SCRATCH_REG_69 0x1250114
>> +#define ACP_SCRATCH_REG_70 0x1250118
>> +#define ACP_SCRATCH_REG_71 0x125011C
>> +#define ACP_SCRATCH_REG_72 0x1250120
>> +#define ACP_SCRATCH_REG_73 0x1250124
>> +#define ACP_SCRATCH_REG_74 0x1250128
>> +#define ACP_SCRATCH_REG_75 0x125012C
>> +#define ACP_SCRATCH_REG_76 0x1250130
>> +#define ACP_SCRATCH_REG_77 0x1250134
>> +#define ACP_SCRATCH_REG_78 0x1250138
>> +#define ACP_SCRATCH_REG_79 0x125013C
>> +#define ACP_SCRATCH_REG_80 0x1250140
>> +#define ACP_SCRATCH_REG_81 0x1250144
>> +#define ACP_SCRATCH_REG_82 0x1250148
>> +#define ACP_SCRATCH_REG_83 0x125014C
>> +#define ACP_SCRATCH_REG_84 0x1250150
>> +#define ACP_SCRATCH_REG_85 0x1250154
>> +#define ACP_SCRATCH_REG_86 0x1250158
>> +#define ACP_SCRATCH_REG_87 0x125015C
>> +#define ACP_SCRATCH_REG_88 0x1250160
>> +#define ACP_SCRATCH_REG_89 0x1250164
>> +#define ACP_SCRATCH_REG_90 0x1250168
>> +#define ACP_SCRATCH_REG_91 0x125016C
>> +#define ACP_SCRATCH_REG_92 0x1250170
>> +#define ACP_SCRATCH_REG_93 0x1250174
>> +#define ACP_SCRATCH_REG_94 0x1250178
>> +#define ACP_SCRATCH_REG_95 0x125017C
>> +#define ACP_SCRATCH_REG_96 0x1250180
>> +#define ACP_SCRATCH_REG_97 0x1250184
>> +#define ACP_SCRATCH_REG_98 0x1250188
>> +#define ACP_SCRATCH_REG_99 0x125018C
>> +#define ACP_SCRATCH_REG_100 0x1250190
>> +#define ACP_SCRATCH_REG_101 0x1250194
>> +#define ACP_SCRATCH_REG_102 0x1250198
>> +#define ACP_SCRATCH_REG_103 0x125019C
>> +#define ACP_SCRATCH_REG_104 0x12501A0
>> +#define ACP_SCRATCH_REG_105 0x12501A4
>> +#define ACP_SCRATCH_REG_106 0x12501A8
>> +#define ACP_SCRATCH_REG_107 0x12501AC
>> +#define ACP_SCRATCH_REG_108 0x12501B0
>> +#define ACP_SCRATCH_REG_109 0x12501B4
>> +#define ACP_SCRATCH_REG_110 0x12501B8
>> +#define ACP_SCRATCH_REG_111 0x12501BC
>> +#define ACP_SCRATCH_REG_112 0x12501C0
>> +#define ACP_SCRATCH_REG_113 0x12501C4
>> +#define ACP_SCRATCH_REG_114 0x12501C8
>> +#define ACP_SCRATCH_REG_115 0x12501CC
>> +#define ACP_SCRATCH_REG_116 0x12501D0
>> +#define ACP_SCRATCH_REG_117 0x12501D4
>> +#define ACP_SCRATCH_REG_118 0x12501D8
>> +#define ACP_SCRATCH_REG_119 0x12501DC
>> +#define ACP_SCRATCH_REG_120 0x12501E0
>> +#define ACP_SCRATCH_REG_121 0x12501E4
>> +#define ACP_SCRATCH_REG_122 0x12501E8
>> +#define ACP_SCRATCH_REG_123 0x12501EC
>> +#define ACP_SCRATCH_REG_124 0x12501F0
>> +#define ACP_SCRATCH_REG_125 0x12501F4
>> +#define ACP_SCRATCH_REG_126 0x12501F8
>> +#define ACP_SCRATCH_REG_127 0x12501FC
>> +#define ACP_SCRATCH_REG_128 0x1250200
>> #endif
>> --
>> 2.51.2
>>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-07 1:44 ` qby140326
@ 2026-02-07 5:50 ` Mukunda,Vijendar
2026-02-07 12:45 ` Mark Brown
2026-02-11 9:22 ` Mukunda,Vijendar
2 siblings, 0 replies; 19+ messages in thread
From: Mukunda,Vijendar @ 2026-02-07 5:50 UTC (permalink / raw)
To: qby140326, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Mario Limonciello, Venkata Prasad Potturu
On 07/02/26 07:14, qby140326 wrote:
> Hi Mark,
>
> Since I don't work for AMD, I'm not in a position to decide who should be
> officially responsible for this.
>
> I have checked the git history via `git shortlog -sne --since="1 year ago"
> sound/soc/amd/`, I've seen Vijendar and Venkata are the most
> active contributors to the sound/soc/amd/ folder. I have CC-ed them in this
> email. I'll leave it to the AMD team to coordinate and submit a proper
> MAINTAINERS entry.
>
> Best regards, Mingyou Chen
Originally RPL platform was targeted to support Desktop without ACP PDM IO.
Later there are some new variants got introduced where PDM IO support is
included.
We will review the patch.
-
Vijendar
>
> On 2/7/26 01:51, Mark Brown wrote:
>> On Thu, Feb 05, 2026 at 10:07:03AM +0800, Mingyou Chen wrote:
>>> Add DMIC support for the AMD RPL platform. The drivers are derived on
>>> the YC platform driver.
>> Copying in some of the AMD people - there's no MAINTAINERS entry for the
>> AMD ASoC drivers, it'd probably be good to add one so people are more
>> likely to CC you on changes.
>>
>>> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
>>> ---
>>> sound/soc/amd/Kconfig | 11 +
>>> sound/soc/amd/rpl/Makefile | 4 +
>>> sound/soc/amd/rpl/rpl-acp6x-mach.c | 131 +++++
>>> sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c | 454 ++++++++++++++++++
>>> sound/soc/amd/rpl/rpl-pci-acp6x.c | 123 ++++-
>>> sound/soc/amd/rpl/rpl_acp6x.h | 90 +++-
>>> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 420 +++++++++++++++-
>>> 7 files changed, 1221 insertions(+), 12 deletions(-)
>>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>>
>>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>>> index fd35a03aadcb..da2940e94a7e 100644
>>> --- a/sound/soc/amd/Kconfig
>>> +++ b/sound/soc/amd/Kconfig
>>> @@ -134,6 +134,17 @@ config SND_SOC_AMD_RPL_ACP6x
>>> Say m if you have such a device.
>>> If unsure select "N".
>>> +config SND_SOC_AMD_RPL_MACH
>>> + tristate "AMD RPL support for DMIC"
>>> + select SND_SOC_DMIC
>>> + depends on SND_SOC_AMD_ACP6x && ACPI
>>> + help
>>> + This option enables machine driver for AMD RPL platform
>>> + using dmic. ACP IP has PDM Decoder block with DMA controller.
>>> + DMIC can be connected directly to ACP IP.
>>> + Say m if you have such a device.
>>> + If unsure select "N".
>>> +
>>> config SND_SOC_AMD_ACP63_TOPLEVEL
>>> tristate "support for AMD platforms with ACP version >= 6.3"
>>> default SND_AMD_ACP_CONFIG
>>> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
>>> index a3825c5be4e7..b1190fcdf1f6 100644
>>> --- a/sound/soc/amd/rpl/Makefile
>>> +++ b/sound/soc/amd/rpl/Makefile
>>> @@ -1,5 +1,9 @@
>>> # SPDX-License-Identifier: GPL-2.0+
>>> # RPL platform Support
>>> snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
>>> +snd-rpl-acp6x-pdm-dma-y := rpl-acp6x-pdm-dma.o
>>> +snd-soc-rpl-acp6x-mach-y := rpl-acp6x-mach.o
>>> obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
>>> +obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-acp6x-pdm-dma.o
>>> +obj-$(CONFIG_SND_SOC_AMD_RPL_MACH) += snd-soc-rpl-acp6x-mach.o
>>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> new file mode 100644
>>> index 000000000000..71a384b9a36c
>>> --- /dev/null
>>> +++ b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> @@ -0,0 +1,131 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Machine driver for AMD RPL platform using DMIC
>>> + *
>>> + * Copyright 2025 Advanced Micro Devices, Inc.
>>> + */
>>> +
>>> +#include <sound/soc.h>
>>> +#include <sound/soc-dapm.h>
>>> +#include <linux/module.h>
>>> +#include <sound/pcm.h>
>>> +#include <sound/pcm_params.h>
>>> +#include <linux/io.h>
>>> +#include <linux/dmi.h>
>>> +#include <linux/acpi.h>
>>> +
>>> +#include "rpl_acp6x.h"
>>> +
>>> +#define DRV_NAME "acp_rpl_mach"
>>> +
>>> +SND_SOC_DAILINK_DEF(acp6x_pdm,
>>> + DAILINK_COMP_ARRAY(COMP_CPU("acp_rpl_pdm_dma.0")));
>>> +
>>> +SND_SOC_DAILINK_DEF(dmic_codec,
>>> + DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
>>> + "dmic-hifi")));
>>> +
>>> +SND_SOC_DAILINK_DEF(pdm_platform,
>>> + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_rpl_pdm_dma.0")));
>>> +
>>> +static struct snd_soc_dai_link acp6x_dai_pdm[] = {
>>> + {
>>> + .name = "rpl-acp6x-dmic-capture",
>>> + .stream_name = "DMIC capture",
>>> + .capture_only = 1,
>>> + SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
>>> + },
>>> +};
>>> +
>>> +static struct snd_soc_card acp6x_card = {
>>> + .name = "acp6x",
>>> + .owner = THIS_MODULE,
>>> + .dai_link = acp6x_dai_pdm,
>>> + .num_links = 1,
>>> +};
>>> +
>>> +static const struct dmi_system_id rpl_acp_quirk_table[] = {
>>> + {
>>> + .driver_data = &acp6x_card,
>>> + .matches = {
>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
>>> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
>>> + }
>>> + },
>>> + {}
>>> +};
>>> +
>>> +static int acp6x_probe(struct platform_device *pdev)
>>> +{
>>> + const struct dmi_system_id *dmi_id;
>>> + struct acp6x_pdm *machine = NULL;
>>> + struct snd_soc_card *card;
>>> + struct acpi_device *adev;
>>> + acpi_handle handle;
>>> + acpi_integer dmic_status;
>>> + int ret;
>>> + bool is_dmic_enable, wov_en;
>>> +
>>> + /* IF WOV entry not found, enable dmic based on AcpDmicConnected entry*/
>>> + is_dmic_enable = false;
>>> + wov_en = true;
>>> + /* check the parent device's firmware node has _DSD or not */
>>> + adev = ACPI_COMPANION(pdev->dev.parent);
>>> + if (adev) {
>>> + const union acpi_object *obj;
>>> +
>>> + if (!acpi_dev_get_property(adev, "AcpDmicConnected",
>>> ACPI_TYPE_INTEGER, &obj) &&
>>> + obj->integer.value == 1)
>>> + is_dmic_enable = true;
>>> + }
>>> +
>>> + handle = ACPI_HANDLE(pdev->dev.parent);
>>> + ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
>>> + if (!ACPI_FAILURE(ret)) {
>>> + wov_en = dmic_status;
>>> + if (!wov_en)
>>> + return -ENODEV;
>>> + } else {
>>> + /* Incase of ACPI method read failure then jump to check_dmi_entry */
>>> + goto check_dmi_entry;
>>> + }
>>> +
>>> + if (is_dmic_enable)
>>> + platform_set_drvdata(pdev, &acp6x_card);
>>> +
>>> +check_dmi_entry:
>>> + /* check for any DMI overrides */
>>> + dmi_id = dmi_first_match(rpl_acp_quirk_table);
>>> + if (dmi_id)
>>> + platform_set_drvdata(pdev, dmi_id->driver_data);
>>> +
>>> + card = platform_get_drvdata(pdev);
>>> + if (!card)
>>> + return -ENODEV;
>>> + dev_info(&pdev->dev, "Enabling ACP DMIC support via %s", dmi_id ? "DMI"
>>> : "ACPI");
>>> + acp6x_card.dev = &pdev->dev;
>>> +
>>> + snd_soc_card_set_drvdata(card, machine);
>>> + ret = devm_snd_soc_register_card(&pdev->dev, card);
>>> + if (ret) {
>>> + return dev_err_probe(&pdev->dev, ret,
>>> + "snd_soc_register_card(%s) failed\n",
>>> + card->name);
>>> + }
>>> + return 0;
>>> +}
>>> +
>>> +static struct platform_driver rpl_acp6x_mach_driver = {
>>> + .driver = {
>>> + .name = "acp_rpl_mach",
>>> + .pm = &snd_soc_pm_ops,
>>> + },
>>> + .probe = acp6x_probe,
>>> +};
>>> +
>>> +module_platform_driver(rpl_acp6x_mach_driver);
>>> +
>>> +MODULE_DESCRIPTION("AMD RPL support for DMIC");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:" DRV_NAME);
>>> +
>>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> new file mode 100644
>>> index 000000000000..2ae6d388e488
>>> --- /dev/null
>>> +++ b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> @@ -0,0 +1,454 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * AMD ALSA SoC RPL PDM Driver
>>> + *
>>> + * Copyright 2021 Advanced Micro Devices, Inc.
>>> + */
>>> +
>>> +#include <linux/platform_device.h>
>>> +#include <linux/module.h>
>>> +#include <linux/bitfield.h>
>>> +#include <linux/err.h>
>>> +#include <linux/io.h>
>>> +#include <sound/pcm_params.h>
>>> +#include <sound/soc.h>
>>> +#include <sound/soc-dai.h>
>>> +#include <linux/pm_runtime.h>
>>> +
>>> +#include "rpl_acp6x.h"
>>> +
>>> +#define DRV_NAME "acp_rpl_pdm_dma"
>>> +
>>> +static int pdm_gain = 3;
>>> +module_param(pdm_gain, int, 0644);
>>> +MODULE_PARM_DESC(pdm_gain, "Gain control (0-3)");
>>> +
>>> +static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
>>> + .info = SNDRV_PCM_INFO_INTERLEAVED |
>>> + SNDRV_PCM_INFO_BLOCK_TRANSFER |
>>> + SNDRV_PCM_INFO_MMAP |
>>> + SNDRV_PCM_INFO_MMAP_VALID |
>>> + SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
>>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>>> + .channels_min = 2,
>>> + .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> + .rate_min = 48000,
>>> + .rate_max = 48000,
>>> + .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
>>> + .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
>>> + .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
>>> + .periods_min = CAPTURE_MIN_NUM_PERIODS,
>>> + .periods_max = CAPTURE_MAX_NUM_PERIODS,
>>> +};
>>> +
>>> +static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
>>> + u32 watermark_size, void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
>>> + rpl_acp_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
>>> + rpl_acp_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
>>> + rpl_acp_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
>>> +}
>>> +
>>> +static void acp6x_enable_pdm_clock(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_clk_enable, pdm_ctrl;
>>> +
>>> + pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
>>> + pdm_ctrl = 0x00;
>>> +
>>> + rpl_acp_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
>>> + pdm_ctrl = rpl_acp_readl(acp_base + ACP_WOV_MISC_CTRL);
>>> + pdm_ctrl &= ~ACP_WOV_GAIN_CONTROL;
>>> + pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, clamp(pdm_gain, 0, 3));
>>> + rpl_acp_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
>>> +}
>>> +
>>> +static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
>>> +{
>>> + u32 ext_int_ctrl;
>>> +
>>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + ext_int_ctrl |= PDM_DMA_INTR_MASK;
>>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> +}
>>> +
>>> +static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
>>> +{
>>> + u32 ext_int_ctrl;
>>> +
>>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
>>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> +}
>>> +
>>> +static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
>>> +{
>>> + bool pdm_dma_status;
>>> + u32 pdm_enable, pdm_dma_enable;
>>> +
>>> + pdm_dma_status = false;
>>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable &
>>> ACP_PDM_DMA_EN_STATUS))
>>> + pdm_dma_status = true;
>>> +
>>> + return pdm_dma_status;
>>> +}
>>> +
>>> +static int acp6x_start_pdm_dma(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_enable;
>>> + u32 pdm_dma_enable;
>>> + int timeout;
>>> +
>>> + pdm_enable = 0x01;
>>> + pdm_dma_enable = 0x01;
>>> +
>>> + acp6x_enable_pdm_clock(acp_base);
>>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + timeout = 0;
>>> + while (++timeout < ACP_COUNTER) {
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
>>> + return 0;
>>> + udelay(DELAY_US);
>>> + }
>>> + return -ETIMEDOUT;
>>> +}
>>> +
>>> +static int acp6x_stop_pdm_dma(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_enable, pdm_dma_enable;
>>> + int timeout;
>>> +
>>> + pdm_enable = 0x00;
>>> + pdm_dma_enable = 0x00;
>>> +
>>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if (pdm_dma_enable & 0x01) {
>>> + pdm_dma_enable = 0x02;
>>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + timeout = 0;
>>> + while (++timeout < ACP_COUNTER) {
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_dma_enable & 0x02) == 0x00)
>>> + break;
>>> + udelay(DELAY_US);
>>> + }
>>> + if (timeout == ACP_COUNTER)
>>> + return -ETIMEDOUT;
>>> + }
>>> + if (pdm_enable == ACP_PDM_ENABLE) {
>>> + pdm_enable = ACP_PDM_DISABLE;
>>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>>> + }
>>> + rpl_acp_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
>>> + return 0;
>>> +}
>>> +
>>> +static void acp6x_config_dma(struct rpl_pdm_stream_instance *rtd, int
>>> direction)
>>> +{
>>> + u16 page_idx;
>>> + u32 low, high, val;
>>> + dma_addr_t addr;
>>> +
>>> + addr = rtd->dma_addr;
>>> + val = PDM_PTE_OFFSET;
>>> +
>>> + /* Group Enable */
>>> + rpl_acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
>>> + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
>>> + rpl_acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
>>> + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
>>> + for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
>>> + /* Load the low address of page int ACP SRAM through SRBM */
>>> + low = lower_32_bits(addr);
>>> + high = upper_32_bits(addr);
>>> +
>>> + rpl_acp_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
>>> + high |= BIT(31);
>>> + rpl_acp_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
>>> + val += 8;
>>> + addr += PAGE_SIZE;
>>> + }
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_open(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream)
>>> +{
>>> + struct snd_pcm_runtime *runtime;
>>> + struct rpl_pdm_dev_data *adata;
>>> + struct rpl_pdm_stream_instance *pdm_data;
>>> + int ret;
>>> +
>>> + runtime = substream->runtime;
>>> + adata = dev_get_drvdata(component->dev);
>>> + pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
>>> + if (!pdm_data)
>>> + return -EINVAL;
>>> +
>>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>>> + runtime->hw = acp6x_pdm_hardware_capture;
>>> +
>>> + ret = snd_pcm_hw_constraint_integer(runtime,
>>> + SNDRV_PCM_HW_PARAM_PERIODS);
>>> + if (ret < 0) {
>>> + dev_err(component->dev, "set integer constraint failed\n");
>>> + kfree(pdm_data);
>>> + return ret;
>>> + }
>>> +
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> +
>>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>>> + adata->capture_stream = substream;
>>> +
>>> + pdm_data->acp6x_base = adata->acp6x_base;
>>> + runtime->private_data = pdm_data;
>>> + return ret;
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream,
>>> + struct snd_pcm_hw_params *params)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + size_t size, period_bytes;
>>> +
>>> + rtd = substream->runtime->private_data;
>>> + if (!rtd)
>>> + return -EINVAL;
>>> + size = params_buffer_bytes(params);
>>> + period_bytes = params_period_bytes(params);
>>> + rtd->dma_addr = substream->runtime->dma_addr;
>>> + rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
>>> + acp6x_config_dma(rtd, substream->stream);
>>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
>>> + period_bytes, rtd->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static u64 acp6x_pdm_get_byte_count(struct rpl_pdm_stream_instance *rtd,
>>> + int direction)
>>> +{
>>> + union rpl_acp_pdm_dma_count byte_count;
>>> +
>>> + byte_count.bcount.high =
>>> + rpl_acp_readl(rtd->acp6x_base +
>>> ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
>>> + byte_count.bcount.low =
>>> + rpl_acp_readl(rtd->acp6x_base +
>>> ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
>>> + return byte_count.bytescount;
>>> +}
>>> +
>>> +static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
>>> + struct snd_pcm_substream *stream)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + u32 pos, buffersize;
>>> + u64 bytescount;
>>> +
>>> + rtd = stream->runtime->private_data;
>>> + buffersize = frames_to_bytes(stream->runtime,
>>> + stream->runtime->buffer_size);
>>> + bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
>>> + if (bytescount > rtd->bytescount)
>>> + bytescount -= rtd->bytescount;
>>> + pos = do_div(bytescount, buffersize);
>>> + return bytes_to_frames(stream->runtime, pos);
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_new(struct snd_soc_component *component,
>>> + struct snd_soc_pcm_runtime *rtd)
>>> +{
>>> + struct device *parent = component->dev->parent;
>>> +
>>> + snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
>>> + parent, MIN_BUFFER, MAX_BUFFER);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_close(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream)
>>> +{
>>> + struct rpl_pdm_dev_data *adata = dev_get_drvdata(component->dev);
>>> +
>>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>>> + adata->capture_stream = NULL;
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
>>> + int cmd, struct snd_soc_dai *dai)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + int ret;
>>> + bool pdm_status;
>>> + unsigned int ch_mask;
>>> +
>>> + rtd = substream->runtime->private_data;
>>> + ret = 0;
>>> + switch (substream->runtime->channels) {
>>> + case TWO_CH:
>>> + ch_mask = 0x00;
>>> + break;
>>> + default:
>>> + return -EINVAL;
>>> + }
>>> + switch (cmd) {
>>> + case SNDRV_PCM_TRIGGER_START:
>>> + case SNDRV_PCM_TRIGGER_RESUME:
>>> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>>> + rpl_acp_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
>>> + rpl_acp_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
>>> + ACP_WOV_PDM_DECIMATION_FACTOR);
>>> + rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
>>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>>> + if (!pdm_status)
>>> + ret = acp6x_start_pdm_dma(rtd->acp6x_base);
>>> + break;
>>> + case SNDRV_PCM_TRIGGER_STOP:
>>> + case SNDRV_PCM_TRIGGER_SUSPEND:
>>> + case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>>> + if (pdm_status)
>>> + ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
>>> + break;
>>> + default:
>>> + ret = -EINVAL;
>>> + break;
>>> + }
>>> + return ret;
>>> +}
>>> +
>>> +static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
>>> + .trigger = acp6x_pdm_dai_trigger,
>>> +};
>>> +
>>> +static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
>>> + .capture = {
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>>> + .channels_min = 2,
>>> + .channels_max = 2,
>>> + .rate_min = 48000,
>>> + .rate_max = 48000,
>>> + },
>>> + .ops = &acp6x_pdm_dai_ops,
>>> +};
>>> +
>>> +static const struct snd_soc_component_driver acp6x_pdm_component = {
>>> + .name = DRV_NAME,
>>> + .open = acp6x_pdm_dma_open,
>>> + .close = acp6x_pdm_dma_close,
>>> + .hw_params = acp6x_pdm_dma_hw_params,
>>> + .pointer = acp6x_pdm_dma_pointer,
>>> + .pcm_construct = acp6x_pdm_dma_new,
>>> + .legacy_dai_naming = 1,
>>> +};
>>> +
>>> +static int acp6x_pdm_audio_probe(struct platform_device *pdev)
>>> +{
>>> + struct resource *res;
>>> + struct rpl_pdm_dev_data *adata;
>>> + int status;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + if (!res) {
>>> + dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
>>> + return -ENODEV;
>>> + }
>>> +
>>> + adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
>>> + if (!adata)
>>> + return -ENOMEM;
>>> +
>>> + adata->acp6x_base = devm_ioremap(&pdev->dev, res->start,
>>> resource_size(res));
>>> + if (!adata->acp6x_base)
>>> + return -ENOMEM;
>>> +
>>> + adata->capture_stream = NULL;
>>> +
>>> + dev_set_drvdata(&pdev->dev, adata);
>>> + status = devm_snd_soc_register_component(&pdev->dev,
>>> + &acp6x_pdm_component,
>>> + &acp6x_pdm_dai_driver, 1);
>>> + if (status) {
>>> + dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
>>> +
>>> + return -ENODEV;
>>> + }
>>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
>>> + pm_runtime_use_autosuspend(&pdev->dev);
>>> + pm_runtime_mark_last_busy(&pdev->dev);
>>> + pm_runtime_set_active(&pdev->dev);
>>> + pm_runtime_enable(&pdev->dev);
>>> + return 0;
>>> +}
>>> +
>>> +static void acp6x_pdm_audio_remove(struct platform_device *pdev)
>>> +{
>>> + pm_runtime_disable(&pdev->dev);
>>> +}
>>> +
>>> +static int acp6x_pdm_resume(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> + struct snd_pcm_runtime *runtime;
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + u32 period_bytes, buffer_len;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + if (adata->capture_stream && adata->capture_stream->runtime) {
>>> + runtime = adata->capture_stream->runtime;
>>> + rtd = runtime->private_data;
>>> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
>>> + buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
>>> + acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
>>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
>>> + period_bytes, adata->acp6x_base);
>>> + }
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_suspend(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_runtime_resume(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static const struct dev_pm_ops acp6x_pdm_pm_ops = {
>>> + RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
>>> + SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
>>> +};
>>> +
>>> +static struct platform_driver acp6x_pdm_dma_driver = {
>>> + .probe = acp6x_pdm_audio_probe,
>>> + .remove = acp6x_pdm_audio_remove,
>>> + .driver = {
>>> + .name = "acp_rpl_pdm_dma",
>>> + .pm = pm_ptr(&acp6x_pdm_pm_ops),
>>> + },
>>> +};
>>> +
>>> +module_platform_driver(acp6x_pdm_dma_driver);
>>> +
>>> +MODULE_DESCRIPTION("AMD ACP6x RPL PDM Driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:" DRV_NAME);
>>> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> index e3afe9172bdf..9a0d9920ad8e 100644
>>> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> +++ b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> @@ -10,12 +10,16 @@
>>> #include <linux/io.h>
>>> #include <linux/delay.h>
>>> #include <linux/platform_device.h>
>>> +#include <sound/pcm.h>
>>> #include <linux/pm_runtime.h>
>>> #include "rpl_acp6x.h"
>>> struct rpl_dev_data {
>>> void __iomem *acp6x_base;
>>> + struct resource *res;
>>> + bool acp6x_audio_mode;
>>> + struct platform_device *pdev[ACP6x_DEVS];
>>> };
>>> static int rpl_power_on(void __iomem *acp_base)
>>> @@ -64,6 +68,19 @@ static int rpl_reset(void __iomem *acp_base)
>>> return -ETIMEDOUT;
>>> }
>>> +static void rpl_enable_interrupts(void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
>>> +}
>>> +
>>> +static void rpl_disable_interrupts(void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
>>> + ACP_EXTERNAL_INTR_STAT);
>>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
>>> +}
>>> +
>>> static int rpl_init(void __iomem *acp_base)
>>> {
>>> int ret;
>>> @@ -82,6 +99,7 @@ static int rpl_init(void __iomem *acp_base)
>>> return ret;
>>> }
>>> rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
>>> + rpl_enable_interrupts(acp_base);
>>> return 0;
>>> }
>>> @@ -89,6 +107,7 @@ static int rpl_deinit(void __iomem *acp_base)
>>> {
>>> int ret;
>>> + rpl_disable_interrupts(acp_base);
>>> /* Reset */
>>> ret = rpl_reset(acp_base);
>>> if (ret) {
>>> @@ -100,13 +119,45 @@ static int rpl_deinit(void __iomem *acp_base)
>>> return 0;
>>> }
>>> +static irqreturn_t rpl_irq_handler(int irq, void *dev_id)
>>> +{
>>> + struct rpl_dev_data *adata;
>>> + struct rpl_pdm_dev_data *rpl_pdm_data;
>>> + u32 val;
>>> +
>>> + adata = dev_id;
>>> + if (!adata)
>>> + return IRQ_NONE;
>>> +
>>> + val = rpl_acp_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>>> + if (val & BIT(PDM_DMA_STAT)) {
>>> + rpl_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
>>> + rpl_acp_writel(BIT(PDM_DMA_STAT), adata->acp6x_base +
>>> ACP_EXTERNAL_INTR_STAT);
>>> + if (rpl_pdm_data->capture_stream)
>>> + snd_pcm_period_elapsed(rpl_pdm_data->capture_stream);
>>> + return IRQ_HANDLED;
>>> + }
>>> + return IRQ_NONE;
>>> +}
>>> +
>>> static int snd_rpl_probe(struct pci_dev *pci,
>>> const struct pci_device_id *pci_id)
>>> {
>>> struct rpl_dev_data *adata;
>>> + struct platform_device_info pdevinfo[ACP6x_DEVS];
>>> + int index = 0;
>>> + int val = 0x00;
>>> + unsigned int irqflags, flag;
>>> u32 addr;
>>> int ret;
>>> + irqflags = IRQF_SHARED;
>>> +
>>> + /* Return if acp config flag is defined */
>>> + flag = snd_amd_acp_find_config(pci);
>>> + if (flag)
>>> + return -ENODEV;
>>> +
>>> /* RPL device check */
>>> switch (pci->revision) {
>>> case 0x62:
>>> @@ -145,12 +196,78 @@ static int snd_rpl_probe(struct pci_dev *pci,
>>> ret = rpl_init(adata->acp6x_base);
>>> if (ret)
>>> goto release_regions;
>>> +
>>> + val = rpl_acp_readl(adata->acp6x_base + ACP_PIN_CONFIG);
>>> + switch (val) {
>>> + case ACP_CONFIG_0:
>>> + case ACP_CONFIG_1:
>>> + case ACP_CONFIG_2:
>>> + case ACP_CONFIG_3:
>>> + case ACP_CONFIG_9:
>>> + case ACP_CONFIG_15:
>>> + dev_info(&pci->dev, "Audio Mode %d\n", val);
>>> + break;
>>> + default:
>>> + adata->res = devm_kzalloc(&pci->dev,
>>> + sizeof(struct resource),
>>> + GFP_KERNEL);
>>> + if (!adata->res) {
>>> + ret = -ENOMEM;
>>> + goto de_init;
>>> + }
>>> +
>>> + adata->res->name = "acp_iomem";
>>> + adata->res->flags = IORESOURCE_MEM;
>>> + adata->res->start = addr;
>>> + adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
>>> +
>>> + adata->acp6x_audio_mode = ACP6x_PDM_MODE;
>>> +
>>> + memset(&pdevinfo, 0, sizeof(pdevinfo));
>>> + pdevinfo[0].name = "acp_rpl_pdm_dma";
>>> + pdevinfo[0].id = 0;
>>> + pdevinfo[0].parent = &pci->dev;
>>> + pdevinfo[0].num_res = 1;
>>> + pdevinfo[0].res = adata->res;
>>> +
>>> + pdevinfo[1].name = "dmic-codec";
>>> + pdevinfo[1].id = 0;
>>> + pdevinfo[1].parent = &pci->dev;
>>> +
>>> + pdevinfo[2].name = "acp_rpl_mach";
>>> + pdevinfo[2].id = 0;
>>> + pdevinfo[2].parent = &pci->dev;
>>> +
>>> + for (index = 0; index < ACP6x_DEVS; index++) {
>>> + adata->pdev[index] =
>>> + platform_device_register_full(&pdevinfo[index]);
>>> + if (IS_ERR(adata->pdev[index])) {
>>> + dev_err(&pci->dev, "cannot register %s device\n",
>>> + pdevinfo[index].name);
>>> + ret = PTR_ERR(adata->pdev[index]);
>>> + goto unregister_devs;
>>> + }
>>> + }
>>> + break;
>>> + }
>>> + ret = devm_request_irq(&pci->dev, pci->irq, rpl_irq_handler,
>>> + irqflags, "ACP_PCI_IRQ", adata);
>>> + if (ret) {
>>> + dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
>>> + goto unregister_devs;
>>> + }
>>> pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
>>> pm_runtime_use_autosuspend(&pci->dev);
>>> pm_runtime_put_noidle(&pci->dev);
>>> pm_runtime_allow(&pci->dev);
>>> return 0;
>>> +unregister_devs:
>>> + for (--index; index >= 0; index--)
>>> + platform_device_unregister(adata->pdev[index]);
>>> +de_init:
>>> + if (rpl_deinit(adata->acp6x_base))
>>> + dev_err(&pci->dev, "ACP de-init failed\n");
>>> release_regions:
>>> pci_release_regions(pci);
>>> disable_pci:
>>> @@ -191,9 +308,13 @@ static const struct dev_pm_ops rpl_pm = {
>>> static void snd_rpl_remove(struct pci_dev *pci)
>>> {
>>> struct rpl_dev_data *adata;
>>> - int ret;
>>> + int ret, index;
>>> adata = pci_get_drvdata(pci);
>>> + if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
>>> + for (index = 0; index < ACP6x_DEVS; index++)
>>> + platform_device_unregister(adata->pdev[index]);
>>> + }
>>> ret = rpl_deinit(adata->acp6x_base);
>>> if (ret)
>>> dev_err(&pci->dev, "ACP de-init failed\n");
>>> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
>>> index f5816a33632e..d470927c1e35 100644
>>> --- a/sound/soc/amd/rpl/rpl_acp6x.h
>>> +++ b/sound/soc/amd/rpl/rpl_acp6x.h
>>> @@ -9,15 +9,46 @@
>>> #define ACP_DEVICE_ID 0x15E2
>>> #define ACP6x_PHY_BASE_ADDRESS 0x1240000
>>> +#define ACP6x_REG_START 0x1240000
>>> +#define ACP6x_REG_END 0x1250200
>>> +#define ACP6x_DEVS 3
>>> +#define ACP6x_PDM_MODE 1
>>> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>>> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>>> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>>> -#define ACP_PGFSM_STATUS_MASK 3
>>> -#define ACP_POWERED_ON 0
>>> -#define ACP_POWER_ON_IN_PROGRESS 1
>>> -#define ACP_POWERED_OFF 2
>>> -#define ACP_POWER_OFF_IN_PROGRESS 3
>>> +#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>>> +#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>>> +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>>> +#define ACP_PGFSM_STATUS_MASK 3
>>> +#define ACP_POWERED_ON 0
>>> +#define ACP_POWER_ON_IN_PROGRESS 1
>>> +#define ACP_POWERED_OFF 2
>>> +#define ACP_POWER_OFF_IN_PROGRESS 3
>>> +
>>> +#define ACP_ERROR_MASK 0x20000000
>>> +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
>>> +#define PDM_DMA_STAT 0x10
>>> +
>>> +#define PDM_DMA_INTR_MASK 0x10000
>>> +#define ACP_ERROR_STAT 29
>>> +#define PDM_DECIMATION_FACTOR 2
>>> +#define ACP_PDM_CLK_FREQ_MASK 7
>>> +#define ACP_WOV_GAIN_CONTROL GENMASK(4, 3)
>>> +#define ACP_PDM_ENABLE 1
>>> +#define ACP_PDM_DISABLE 0
>>> +#define ACP_PDM_DMA_EN_STATUS 2
>>> +#define TWO_CH 2
>>> +
>>> +#define ACP_SRAM_PTE_OFFSET 0x03800000
>>> +#define PAGE_SIZE_4K_ENABLE 2
>>> +#define PDM_PTE_OFFSET 0
>>> +#define PDM_MEM_WINDOW_START 0x4000000
>>> +
>>> +#define CAPTURE_MIN_NUM_PERIODS 4
>>> +#define CAPTURE_MAX_NUM_PERIODS 4
>>> +#define CAPTURE_MAX_PERIOD_SIZE 8192
>>> +#define CAPTURE_MIN_PERIOD_SIZE 4096
>>> +
>>> +#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
>>> +#define MIN_BUFFER MAX_BUFFER
>>> #define DELAY_US 5
>>> #define ACP_COUNTER 20000
>>> @@ -25,6 +56,47 @@
>>> /* time in ms for runtime suspend delay */
>>> #define ACP_SUSPEND_DELAY_MS 2000
>>> +enum rpl_acp_config {
>>> + ACP_CONFIG_0 = 0,
>>> + ACP_CONFIG_1,
>>> + ACP_CONFIG_2,
>>> + ACP_CONFIG_3,
>>> + ACP_CONFIG_4,
>>> + ACP_CONFIG_5,
>>> + ACP_CONFIG_6,
>>> + ACP_CONFIG_7,
>>> + ACP_CONFIG_8,
>>> + ACP_CONFIG_9,
>>> + ACP_CONFIG_10,
>>> + ACP_CONFIG_11,
>>> + ACP_CONFIG_12,
>>> + ACP_CONFIG_13,
>>> + ACP_CONFIG_14,
>>> + ACP_CONFIG_15,
>>> +};
>>> +
>>> +struct rpl_pdm_dev_data {
>>> + u32 pdm_irq;
>>> + void __iomem *acp6x_base;
>>> + struct snd_pcm_substream *capture_stream;
>>> +};
>>> +
>>> +struct rpl_pdm_stream_instance {
>>> + u16 num_pages;
>>> + u16 channels;
>>> + dma_addr_t dma_addr;
>>> + u64 bytescount;
>>> + void __iomem *acp6x_base;
>>> +};
>>> +
>>> +union rpl_acp_pdm_dma_count {
>>> + struct {
>>> + u32 low;
>>> + u32 high;
>>> + } bcount;
>>> + u64 bytescount;
>>> +};
>>> +
>>> static inline u32 rpl_acp_readl(void __iomem *base_addr)
>>> {
>>> return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
>>> @@ -34,3 +106,5 @@ static inline void rpl_acp_writel(u32 val, void __iomem
>>> *base_addr)
>>> {
>>> writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
>>> }
>>> +
>>> +int snd_amd_acp_find_config(struct pci_dev *pci);
>>> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> index 456498f5396d..44994a925149 100644
>>> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> +++ b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> @@ -8,14 +8,114 @@
>>> #ifndef _rpl_acp6x_OFFSET_HEADER
>>> #define _rpl_acp6x_OFFSET_HEADER
>>> +/* Registers from ACP_DMA block */
>>> +#define ACP_DMA_CNTL_0 0x1240000
>>> +#define ACP_DMA_CNTL_1 0x1240004
>>> +#define ACP_DMA_CNTL_2 0x1240008
>>> +#define ACP_DMA_CNTL_3 0x124000C
>>> +#define ACP_DMA_CNTL_4 0x1240010
>>> +#define ACP_DMA_CNTL_5 0x1240014
>>> +#define ACP_DMA_CNTL_6 0x1240018
>>> +#define ACP_DMA_CNTL_7 0x124001C
>>> +#define ACP_DMA_DSCR_STRT_IDX_0 0x1240020
>>> +#define ACP_DMA_DSCR_STRT_IDX_1 0x1240024
>>> +#define ACP_DMA_DSCR_STRT_IDX_2 0x1240028
>>> +#define ACP_DMA_DSCR_STRT_IDX_3 0x124002C
>>> +#define ACP_DMA_DSCR_STRT_IDX_4 0x1240030
>>> +#define ACP_DMA_DSCR_STRT_IDX_5 0x1240034
>>> +#define ACP_DMA_DSCR_STRT_IDX_6 0x1240038
>>> +#define ACP_DMA_DSCR_STRT_IDX_7 0x124003C
>>> +#define ACP_DMA_DSCR_CNT_0 0x1240040
>>> +#define ACP_DMA_DSCR_CNT_1 0x1240044
>>> +#define ACP_DMA_DSCR_CNT_2 0x1240048
>>> +#define ACP_DMA_DSCR_CNT_3 0x124004C
>>> +#define ACP_DMA_DSCR_CNT_4 0x1240050
>>> +#define ACP_DMA_DSCR_CNT_5 0x1240054
>>> +#define ACP_DMA_DSCR_CNT_6 0x1240058
>>> +#define ACP_DMA_DSCR_CNT_7 0x124005C
>>> +#define ACP_DMA_PRIO_0 0x1240060
>>> +#define ACP_DMA_PRIO_1 0x1240064
>>> +#define ACP_DMA_PRIO_2 0x1240068
>>> +#define ACP_DMA_PRIO_3 0x124006C
>>> +#define ACP_DMA_PRIO_4 0x1240070
>>> +#define ACP_DMA_PRIO_5 0x1240074
>>> +#define ACP_DMA_PRIO_6 0x1240078
>>> +#define ACP_DMA_PRIO_7 0x124007C
>>> +#define ACP_DMA_CUR_DSCR_0 0x1240080
>>> +#define ACP_DMA_CUR_DSCR_1 0x1240084
>>> +#define ACP_DMA_CUR_DSCR_2 0x1240088
>>> +#define ACP_DMA_CUR_DSCR_3 0x124008C
>>> +#define ACP_DMA_CUR_DSCR_4 0x1240090
>>> +#define ACP_DMA_CUR_DSCR_5 0x1240094
>>> +#define ACP_DMA_CUR_DSCR_6 0x1240098
>>> +#define ACP_DMA_CUR_DSCR_7 0x124009C
>>> +#define ACP_DMA_CUR_TRANS_CNT_0 0x12400A0
>>> +#define ACP_DMA_CUR_TRANS_CNT_1 0x12400A4
>>> +#define ACP_DMA_CUR_TRANS_CNT_2 0x12400A8
>>> +#define ACP_DMA_CUR_TRANS_CNT_3 0x12400AC
>>> +#define ACP_DMA_CUR_TRANS_CNT_4 0x12400B0
>>> +#define ACP_DMA_CUR_TRANS_CNT_5 0x12400B4
>>> +#define ACP_DMA_CUR_TRANS_CNT_6 0x12400B8
>>> +#define ACP_DMA_CUR_TRANS_CNT_7 0x12400BC
>>> +#define ACP_DMA_ERR_STS_0 0x12400C0
>>> +#define ACP_DMA_ERR_STS_1 0x12400C4
>>> +#define ACP_DMA_ERR_STS_2 0x12400C8
>>> +#define ACP_DMA_ERR_STS_3 0x12400CC
>>> +#define ACP_DMA_ERR_STS_4 0x12400D0
>>> +#define ACP_DMA_ERR_STS_5 0x12400D4
>>> +#define ACP_DMA_ERR_STS_6 0x12400D8
>>> +#define ACP_DMA_ERR_STS_7 0x12400DC
>>> +#define ACP_DMA_DESC_BASE_ADDR 0x12400E0
>>> +#define ACP_DMA_DESC_MAX_NUM_DSCR 0x12400E4
>>> +#define ACP_DMA_CH_STS 0x12400E8
>>> +#define ACP_DMA_CH_GROUP 0x12400EC
>>> +#define ACP_DMA_CH_RST_STS 0x12400F0
>>> +
>>> +/* Registers from ACP_AXI2AXIATU block */
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1 0x1240C00
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1 0x1240C04
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2 0x1240C08
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2 0x1240C0C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3 0x1240C10
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3 0x1240C14
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4 0x1240C18
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4 0x1240C1C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5 0x1240C20
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5 0x1240C24
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6 0x1240C28
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6 0x1240C2C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7 0x1240C30
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7 0x1240C34
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8 0x1240C38
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8 0x1240C3C
>>> +#define ACPAXI2AXI_ATU_CTRL 0x1240C40
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9 0x1240C44
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9 0x1240C48
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10 0x1240C4C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10 0x1240C50
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11 0x1240C54
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11 0x1240C58
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12 0x1240C5C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12 0x1240C60
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13 0x1240C64
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13 0x1240C68
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14 0x1240C6C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14 0x1240C70
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15 0x1240C74
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15 0x1240C78
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16 0x1240C7C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16 0x1240C80
>>> +
>>> /* Registers from ACP_CLKRST block */
>>> #define ACP_SOFT_RESET 0x1241000
>>> #define ACP_CONTROL 0x1241004
>>> #define ACP_STATUS 0x1241008
>>> #define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
>>> -#define ACP_PGFSM_CONTROL 0x124101C
>>> -#define ACP_PGFSM_STATUS 0x1241020
>>> -#define ACP_CLKMUX_SEL 0x1241024
>>> +#define ACP_ZSC_DSP_CTRL 0x1241014
>>> +#define ACP_ZSC_STS 0x1241018
>>> +#define ACP_PGFSM_CONTROL 0x1241024
>>> +#define ACP_PGFSM_STATUS 0x1241028
>>> +#define ACP_CLKMUX_SEL 0x124102C
>>> /* Registers from ACP_AON block */
>>> #define ACP_PME_EN 0x1241400
>>> @@ -26,5 +126,319 @@
>>> #define ACP_PAD_PULLDOWN_CTRL 0x1241448
>>> #define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
>>> #define ACP_PAD_SCHMEN_CTRL 0x1241450
>>> +#define ACP_SW_PAD_KEEPER_EN 0x1241454
>>> +#define ACP_SW_WAKE_EN 0x1241458
>>> +#define ACP_I2S_WAKE_EN 0x124145C
>>> +#define ACP_SW1_WAKE_EN 0x1241460
>>> +
>>> +/* Registers from ACP_P1_MISC block */
>>> +#define ACP_EXTERNAL_INTR_ENB 0x1241A00
>>> +#define ACP_EXTERNAL_INTR_CNTL 0x1241A04
>>> +#define ACP_EXTERNAL_INTR_CNTL1 0x1241A08
>>> +#define ACP_EXTERNAL_INTR_STAT 0x1241A0C
>>> +#define ACP_EXTERNAL_INTR_STAT1 0x1241A10
>>> +#define ACP_ERROR_STATUS 0x1241A4C
>>> +#define ACP_P1_SW_I2S_ERROR_REASON 0x1241A50
>>> +#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL 0x1241A6C
>>> +#define ACP_P1_SW_I2S_TX_DMA_POS 0x1241A70
>>> +#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL 0x1241A74
>>> +#define ACP_P1_SW_I2S_RX_DMA_POS 0x1241A78
>>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL 0x1241A7C
>>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS 0x1241A80
>>> +#define ACP_SCRATCH_REG_BASE_ADDR 0x1241A84
>>> +#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL 0x1241A88
>>> +#define ACP_P1_SW_BT_TX_DMA_POS 0x1241A8C
>>> +#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL 0x1241A90
>>> +#define ACP_P1_SW_HS_TX_DMA_POS 0x1241A94
>>> +#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL 0x1241A98
>>> +#define ACP_P1_SW_BT_RX_DMA_POS 0x1241A9C
>>> +#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL 0x1241AA0
>>> +#define ACP_P1_SW_HS_RX_DMA_POS 0x1241AA4
>>> +
>>> +/* Registers from ACP_AUDIO_BUFFERS block */
>>> +#define ACP_I2S_RX_RINGBUFADDR 0x1242000
>>> +#define ACP_I2S_RX_RINGBUFSIZE 0x1242004
>>> +#define ACP_I2S_RX_LINKPOSITIONCNTR 0x1242008
>>> +#define ACP_I2S_RX_FIFOADDR 0x124200C
>>> +#define ACP_I2S_RX_FIFOSIZE 0x1242010
>>> +#define ACP_I2S_RX_DMA_SIZE 0x1242014
>>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1242018
>>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW 0x124201C
>>> +#define ACP_I2S_RX_INTR_WATERMARK_SIZE 0x1242020
>>> +#define ACP_I2S_TX_RINGBUFADDR 0x1242024
>>> +#define ACP_I2S_TX_RINGBUFSIZE 0x1242028
>>> +#define ACP_I2S_TX_LINKPOSITIONCNTR 0x124202C
>>> +#define ACP_I2S_TX_FIFOADDR 0x1242030
>>> +#define ACP_I2S_TX_FIFOSIZE 0x1242034
>>> +#define ACP_I2S_TX_DMA_SIZE 0x1242038
>>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x124203C
>>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1242040
>>> +#define ACP_I2S_TX_INTR_WATERMARK_SIZE 0x1242044
>>> +#define ACP_BT_RX_RINGBUFADDR 0x1242048
>>> +#define ACP_BT_RX_RINGBUFSIZE 0x124204C
>>> +#define ACP_BT_RX_LINKPOSITIONCNTR 0x1242050
>>> +#define ACP_BT_RX_FIFOADDR 0x1242054
>>> +#define ACP_BT_RX_FIFOSIZE 0x1242058
>>> +#define ACP_BT_RX_DMA_SIZE 0x124205C
>>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1242060
>>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW 0x1242064
>>> +#define ACP_BT_RX_INTR_WATERMARK_SIZE 0x1242068
>>> +#define ACP_BT_TX_RINGBUFADDR 0x124206C
>>> +#define ACP_BT_TX_RINGBUFSIZE 0x1242070
>>> +#define ACP_BT_TX_LINKPOSITIONCNTR 0x1242074
>>> +#define ACP_BT_TX_FIFOADDR 0x1242078
>>> +#define ACP_BT_TX_FIFOSIZE 0x124207C
>>> +#define ACP_BT_TX_DMA_SIZE 0x1242080
>>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1242084
>>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW 0x1242088
>>> +#define ACP_BT_TX_INTR_WATERMARK_SIZE 0x124208C
>>> +#define ACP_HS_RX_RINGBUFADDR 0x1242090
>>> +#define ACP_HS_RX_RINGBUFSIZE 0x1242094
>>> +#define ACP_HS_RX_LINKPOSITIONCNTR 0x1242098
>>> +#define ACP_HS_RX_FIFOADDR 0x124209C
>>> +#define ACP_HS_RX_FIFOSIZE 0x12420A0
>>> +#define ACP_HS_RX_DMA_SIZE 0x12420A4
>>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH 0x12420A8
>>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW 0x12420AC
>>> +#define ACP_HS_RX_INTR_WATERMARK_SIZE 0x12420B0
>>> +#define ACP_HS_TX_RINGBUFADDR 0x12420B4
>>> +#define ACP_HS_TX_RINGBUFSIZE 0x12420B8
>>> +#define ACP_HS_TX_LINKPOSITIONCNTR 0x12420BC
>>> +#define ACP_HS_TX_FIFOADDR 0x12420C0
>>> +#define ACP_HS_TX_FIFOSIZE 0x12420C4
>>> +#define ACP_HS_TX_DMA_SIZE 0x12420C8
>>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH 0x12420CC
>>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW 0x12420D0
>>> +#define ACP_HS_TX_INTR_WATERMARK_SIZE 0x12420D4
>>> +
>>> +/* Registers from ACP_I2S_TDM block */
>>> +#define ACP_I2STDM_IER 0x1242400
>>> +#define ACP_I2STDM_IRER 0x1242404
>>> +#define ACP_I2STDM_RXFRMT 0x1242408
>>> +#define ACP_I2STDM_ITER 0x124240C
>>> +#define ACP_I2STDM_TXFRMT 0x1242410
>>> +#define ACP_I2STDM0_MSTRCLKGEN 0x1242414
>>> +#define ACP_I2STDM1_MSTRCLKGEN 0x1242418
>>> +#define ACP_I2STDM2_MSTRCLKGEN 0x124241C
>>> +#define ACP_I2STDM_REFCLKGEN 0x1242420
>>> +
>>> +/* Registers from ACP_BT_TDM block */
>>> +#define ACP_BTTDM_IER 0x1242800
>>> +#define ACP_BTTDM_IRER 0x1242804
>>> +#define ACP_BTTDM_RXFRMT 0x1242808
>>> +#define ACP_BTTDM_ITER 0x124280C
>>> +#define ACP_BTTDM_TXFRMT 0x1242810
>>> +#define ACP_HSTDM_IER 0x1242814
>>> +#define ACP_HSTDM_IRER 0x1242818
>>> +#define ACP_HSTDM_RXFRMT 0x124281C
>>> +#define ACP_HSTDM_ITER 0x1242820
>>> +#define ACP_HSTDM_TXFRMT 0x1242824
>>> +
>>> +/* Registers from ACP_WOV block */
>>> +#define ACP_WOV_PDM_ENABLE 0x1242C04
>>> +#define ACP_WOV_PDM_DMA_ENABLE 0x1242C08
>>> +#define ACP_WOV_RX_RINGBUFADDR 0x1242C0C
>>> +#define ACP_WOV_RX_RINGBUFSIZE 0x1242C10
>>> +#define ACP_WOV_RX_LINKPOSITIONCNTR 0x1242C14
>>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH 0x1242C18
>>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW 0x1242C1C
>>> +#define ACP_WOV_RX_INTR_WATERMARK_SIZE 0x1242C20
>>> +#define ACP_WOV_PDM_FIFO_FLUSH 0x1242C24
>>> +#define ACP_WOV_PDM_NO_OF_CHANNELS 0x1242C28
>>> +#define ACP_WOV_PDM_DECIMATION_FACTOR 0x1242C2C
>>> +#define ACP_WOV_PDM_VAD_CTRL 0x1242C30
>>> +#define ACP_WOV_WAKE 0x1242C54
>>> +#define ACP_WOV_BUFFER_STATUS 0x1242C58
>>> +#define ACP_WOV_MISC_CTRL 0x1242C5C
>>> +#define ACP_WOV_CLK_CTRL 0x1242C60
>>> +#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN 0x1242C64
>>> +#define ACP_WOV_ERROR_STATUS_REGISTER 0x1242C68
>>> +#define ACP_PDM_CLKDIV 0x1242C6C
>>> +
>>> +/* Registers from ACP_P1_AUDIO_BUFFERS block */
>>> +#define ACP_P1_I2S_RX_RINGBUFADDR 0x1243A00
>>> +#define ACP_P1_I2S_RX_RINGBUFSIZE 0x1243A04
>>> +#define ACP_P1_I2S_RX_LINKPOSITIONCNTR 0x1243A08
>>> +#define ACP_P1_I2S_RX_FIFOADDR 0x1243A0C
>>> +#define ACP_P1_I2S_RX_FIFOSIZE 0x1243A10
>>> +#define ACP_P1_I2S_RX_DMA_SIZE 0x1243A14
>>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1243A18
>>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW 0x1243A1C
>>> +#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE 0x1243A20
>>> +#define ACP_P1_I2S_TX_RINGBUFADDR 0x1243A24
>>> +#define ACP_P1_I2S_TX_RINGBUFSIZE 0x1243A28
>>> +#define ACP_P1_I2S_TX_LINKPOSITIONCNTR 0x1243A2C
>>> +#define ACP_P1_I2S_TX_FIFOADDR 0x1243A30
>>> +#define ACP_P1_I2S_TX_FIFOSIZE 0x1243A34
>>> +#define ACP_P1_I2S_TX_DMA_SIZE 0x1243A38
>>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x1243A3C
>>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1243A40
>>> +#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE 0x1243A44
>>> +#define ACP_P1_BT_RX_RINGBUFADDR 0x1243A48
>>> +#define ACP_P1_BT_RX_RINGBUFSIZE 0x1243A4C
>>> +#define ACP_P1_BT_RX_LINKPOSITIONCNTR 0x1243A50
>>> +#define ACP_P1_BT_RX_FIFOADDR 0x1243A54
>>> +#define ACP_P1_BT_RX_FIFOSIZE 0x1243A58
>>> +#define ACP_P1_BT_RX_DMA_SIZE 0x1243A5C
>>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1243A60
>>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW 0x1243A64
>>> +#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE 0x1243A68
>>> +#define ACP_P1_BT_TX_RINGBUFADDR 0x1243A6C
>>> +#define ACP_P1_BT_TX_RINGBUFSIZE 0x1243A70
>>> +#define ACP_P1_BT_TX_LINKPOSITIONCNTR 0x1243A74
>>> +#define ACP_P1_BT_TX_FIFOADDR 0x1243A78
>>> +#define ACP_P1_BT_TX_FIFOSIZE 0x1243A7C
>>> +#define ACP_P1_BT_TX_DMA_SIZE 0x1243A80
>>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1243A84
>>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW 0x1243A88
>>> +#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE 0x1243A8C
>>> +#define ACP_P1_HS_RX_RINGBUFADDR 0x1243A90
>>> +#define ACP_P1_HS_RX_RINGBUFSIZE 0x1243A94
>>> +#define ACP_P1_HS_RX_LINKPOSITIONCNTR 0x1243A98
>>> +#define ACP_P1_HS_RX_FIFOADDR 0x1243A9C
>>> +#define ACP_P1_HS_RX_FIFOSIZE 0x1243AA0
>>> +#define ACP_P1_HS_RX_DMA_SIZE 0x1243AA4
>>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH 0x1243AA8
>>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW 0x1243AAC
>>> +#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE 0x1243AB0
>>> +#define ACP_P1_HS_TX_RINGBUFADDR 0x1243AB4
>>> +#define ACP_P1_HS_TX_RINGBUFSIZE 0x1243AB8
>>> +#define ACP_P1_HS_TX_LINKPOSITIONCNTR 0x1243ABC
>>> +#define ACP_P1_HS_TX_FIFOADDR 0x1243AC0
>>> +#define ACP_P1_HS_TX_FIFOSIZE 0x1243AC4
>>> +#define ACP_P1_HS_TX_DMA_SIZE 0x1243AC8
>>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH 0x1243ACC
>>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW 0x1243AD0
>>> +#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE 0x1243AD4
>>> +/* Registers from ACP_SCRATCH block */
>>> +#define ACP_SCRATCH_REG_0 0x1250000
>>> +#define ACP_SCRATCH_REG_1 0x1250004
>>> +#define ACP_SCRATCH_REG_2 0x1250008
>>> +#define ACP_SCRATCH_REG_3 0x125000C
>>> +#define ACP_SCRATCH_REG_4 0x1250010
>>> +#define ACP_SCRATCH_REG_5 0x1250014
>>> +#define ACP_SCRATCH_REG_6 0x1250018
>>> +#define ACP_SCRATCH_REG_7 0x125001C
>>> +#define ACP_SCRATCH_REG_8 0x1250020
>>> +#define ACP_SCRATCH_REG_9 0x1250024
>>> +#define ACP_SCRATCH_REG_10 0x1250028
>>> +#define ACP_SCRATCH_REG_11 0x125002C
>>> +#define ACP_SCRATCH_REG_12 0x1250030
>>> +#define ACP_SCRATCH_REG_13 0x1250034
>>> +#define ACP_SCRATCH_REG_14 0x1250038
>>> +#define ACP_SCRATCH_REG_15 0x125003C
>>> +#define ACP_SCRATCH_REG_16 0x1250040
>>> +#define ACP_SCRATCH_REG_17 0x1250044
>>> +#define ACP_SCRATCH_REG_18 0x1250048
>>> +#define ACP_SCRATCH_REG_19 0x125004C
>>> +#define ACP_SCRATCH_REG_20 0x1250050
>>> +#define ACP_SCRATCH_REG_21 0x1250054
>>> +#define ACP_SCRATCH_REG_22 0x1250058
>>> +#define ACP_SCRATCH_REG_23 0x125005C
>>> +#define ACP_SCRATCH_REG_24 0x1250060
>>> +#define ACP_SCRATCH_REG_25 0x1250064
>>> +#define ACP_SCRATCH_REG_26 0x1250068
>>> +#define ACP_SCRATCH_REG_27 0x125006C
>>> +#define ACP_SCRATCH_REG_28 0x1250070
>>> +#define ACP_SCRATCH_REG_29 0x1250074
>>> +#define ACP_SCRATCH_REG_30 0x1250078
>>> +#define ACP_SCRATCH_REG_31 0x125007C
>>> +#define ACP_SCRATCH_REG_32 0x1250080
>>> +#define ACP_SCRATCH_REG_33 0x1250084
>>> +#define ACP_SCRATCH_REG_34 0x1250088
>>> +#define ACP_SCRATCH_REG_35 0x125008C
>>> +#define ACP_SCRATCH_REG_36 0x1250090
>>> +#define ACP_SCRATCH_REG_37 0x1250094
>>> +#define ACP_SCRATCH_REG_38 0x1250098
>>> +#define ACP_SCRATCH_REG_39 0x125009C
>>> +#define ACP_SCRATCH_REG_40 0x12500A0
>>> +#define ACP_SCRATCH_REG_41 0x12500A4
>>> +#define ACP_SCRATCH_REG_42 0x12500A8
>>> +#define ACP_SCRATCH_REG_43 0x12500AC
>>> +#define ACP_SCRATCH_REG_44 0x12500B0
>>> +#define ACP_SCRATCH_REG_45 0x12500B4
>>> +#define ACP_SCRATCH_REG_46 0x12500B8
>>> +#define ACP_SCRATCH_REG_47 0x12500BC
>>> +#define ACP_SCRATCH_REG_48 0x12500C0
>>> +#define ACP_SCRATCH_REG_49 0x12500C4
>>> +#define ACP_SCRATCH_REG_50 0x12500C8
>>> +#define ACP_SCRATCH_REG_51 0x12500CC
>>> +#define ACP_SCRATCH_REG_52 0x12500D0
>>> +#define ACP_SCRATCH_REG_53 0x12500D4
>>> +#define ACP_SCRATCH_REG_54 0x12500D8
>>> +#define ACP_SCRATCH_REG_55 0x12500DC
>>> +#define ACP_SCRATCH_REG_56 0x12500E0
>>> +#define ACP_SCRATCH_REG_57 0x12500E4
>>> +#define ACP_SCRATCH_REG_58 0x12500E8
>>> +#define ACP_SCRATCH_REG_59 0x12500EC
>>> +#define ACP_SCRATCH_REG_60 0x12500F0
>>> +#define ACP_SCRATCH_REG_61 0x12500F4
>>> +#define ACP_SCRATCH_REG_62 0x12500F8
>>> +#define ACP_SCRATCH_REG_63 0x12500FC
>>> +#define ACP_SCRATCH_REG_64 0x1250100
>>> +#define ACP_SCRATCH_REG_65 0x1250104
>>> +#define ACP_SCRATCH_REG_66 0x1250108
>>> +#define ACP_SCRATCH_REG_67 0x125010C
>>> +#define ACP_SCRATCH_REG_68 0x1250110
>>> +#define ACP_SCRATCH_REG_69 0x1250114
>>> +#define ACP_SCRATCH_REG_70 0x1250118
>>> +#define ACP_SCRATCH_REG_71 0x125011C
>>> +#define ACP_SCRATCH_REG_72 0x1250120
>>> +#define ACP_SCRATCH_REG_73 0x1250124
>>> +#define ACP_SCRATCH_REG_74 0x1250128
>>> +#define ACP_SCRATCH_REG_75 0x125012C
>>> +#define ACP_SCRATCH_REG_76 0x1250130
>>> +#define ACP_SCRATCH_REG_77 0x1250134
>>> +#define ACP_SCRATCH_REG_78 0x1250138
>>> +#define ACP_SCRATCH_REG_79 0x125013C
>>> +#define ACP_SCRATCH_REG_80 0x1250140
>>> +#define ACP_SCRATCH_REG_81 0x1250144
>>> +#define ACP_SCRATCH_REG_82 0x1250148
>>> +#define ACP_SCRATCH_REG_83 0x125014C
>>> +#define ACP_SCRATCH_REG_84 0x1250150
>>> +#define ACP_SCRATCH_REG_85 0x1250154
>>> +#define ACP_SCRATCH_REG_86 0x1250158
>>> +#define ACP_SCRATCH_REG_87 0x125015C
>>> +#define ACP_SCRATCH_REG_88 0x1250160
>>> +#define ACP_SCRATCH_REG_89 0x1250164
>>> +#define ACP_SCRATCH_REG_90 0x1250168
>>> +#define ACP_SCRATCH_REG_91 0x125016C
>>> +#define ACP_SCRATCH_REG_92 0x1250170
>>> +#define ACP_SCRATCH_REG_93 0x1250174
>>> +#define ACP_SCRATCH_REG_94 0x1250178
>>> +#define ACP_SCRATCH_REG_95 0x125017C
>>> +#define ACP_SCRATCH_REG_96 0x1250180
>>> +#define ACP_SCRATCH_REG_97 0x1250184
>>> +#define ACP_SCRATCH_REG_98 0x1250188
>>> +#define ACP_SCRATCH_REG_99 0x125018C
>>> +#define ACP_SCRATCH_REG_100 0x1250190
>>> +#define ACP_SCRATCH_REG_101 0x1250194
>>> +#define ACP_SCRATCH_REG_102 0x1250198
>>> +#define ACP_SCRATCH_REG_103 0x125019C
>>> +#define ACP_SCRATCH_REG_104 0x12501A0
>>> +#define ACP_SCRATCH_REG_105 0x12501A4
>>> +#define ACP_SCRATCH_REG_106 0x12501A8
>>> +#define ACP_SCRATCH_REG_107 0x12501AC
>>> +#define ACP_SCRATCH_REG_108 0x12501B0
>>> +#define ACP_SCRATCH_REG_109 0x12501B4
>>> +#define ACP_SCRATCH_REG_110 0x12501B8
>>> +#define ACP_SCRATCH_REG_111 0x12501BC
>>> +#define ACP_SCRATCH_REG_112 0x12501C0
>>> +#define ACP_SCRATCH_REG_113 0x12501C4
>>> +#define ACP_SCRATCH_REG_114 0x12501C8
>>> +#define ACP_SCRATCH_REG_115 0x12501CC
>>> +#define ACP_SCRATCH_REG_116 0x12501D0
>>> +#define ACP_SCRATCH_REG_117 0x12501D4
>>> +#define ACP_SCRATCH_REG_118 0x12501D8
>>> +#define ACP_SCRATCH_REG_119 0x12501DC
>>> +#define ACP_SCRATCH_REG_120 0x12501E0
>>> +#define ACP_SCRATCH_REG_121 0x12501E4
>>> +#define ACP_SCRATCH_REG_122 0x12501E8
>>> +#define ACP_SCRATCH_REG_123 0x12501EC
>>> +#define ACP_SCRATCH_REG_124 0x12501F0
>>> +#define ACP_SCRATCH_REG_125 0x12501F4
>>> +#define ACP_SCRATCH_REG_126 0x12501F8
>>> +#define ACP_SCRATCH_REG_127 0x12501FC
>>> +#define ACP_SCRATCH_REG_128 0x1250200
>>> #endif
>>> --
>>> 2.51.2
>>>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-07 1:44 ` qby140326
2026-02-07 5:50 ` Mukunda,Vijendar
@ 2026-02-07 12:45 ` Mark Brown
2026-02-11 9:22 ` Mukunda,Vijendar
2 siblings, 0 replies; 19+ messages in thread
From: Mark Brown @ 2026-02-07 12:45 UTC (permalink / raw)
To: qby140326
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Vijendar Mukunda, Mario Limonciello,
Venkata Prasad Potturu
[-- Attachment #1: Type: text/plain, Size: 502 bytes --]
On Sat, Feb 07, 2026 at 09:44:28AM +0800, qby140326 wrote:
> Since I don't work for AMD, I'm not in a position to decide who should be
> officially responsible for this.
That comment was addressed at the AMD people I was copying in more than
you.
Please don't top post, reply in line with needed context. This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-07 1:44 ` qby140326
2026-02-07 5:50 ` Mukunda,Vijendar
2026-02-07 12:45 ` Mark Brown
@ 2026-02-11 9:22 ` Mukunda,Vijendar
2026-02-11 10:46 ` qby140326
2 siblings, 1 reply; 19+ messages in thread
From: Mukunda,Vijendar @ 2026-02-11 9:22 UTC (permalink / raw)
To: qby140326, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Mario Limonciello, Venkata Prasad Potturu,
Dommati, Sunil-kumar
On 07/02/26 07:14, qby140326 wrote:
> Hi Mark,
>
> Since I don't work for AMD, I'm not in a position to decide who should be
> officially responsible for this.
>
> I have checked the git history via `git shortlog -sne --since="1 year ago"
> sound/soc/amd/`, I've seen Vijendar and Venkata are the most
> active contributors to the sound/soc/amd/ folder. I have CC-ed them in this
> email. I'll leave it to the AMD team to coordinate and submit a proper
> MAINTAINERS entry.
>
> Best regards, Mingyou Chen
>
> On 2/7/26 01:51, Mark Brown wrote:
>> On Thu, Feb 05, 2026 at 10:07:03AM +0800, Mingyou Chen wrote:
>>> Add DMIC support for the AMD RPL platform. The drivers are derived on
>>> the YC platform driver.
>> Copying in some of the AMD people - there's no MAINTAINERS entry for the
>> AMD ASoC drivers, it'd probably be good to add one so people are more
>> likely to CC you on changes.
There is minor delta between RPL and YC platforms for ACP PDM IO enablement.
No need to duplicate the code. You can include support for RPL platform in
yc folder itself. Most of the YC code can be reused.
We can completely remove the RPL folder itself.
Add extra checks for ACP PCI revision ID.
>>
>>> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
>>> ---
>>> sound/soc/amd/Kconfig | 11 +
>>> sound/soc/amd/rpl/Makefile | 4 +
>>> sound/soc/amd/rpl/rpl-acp6x-mach.c | 131 +++++
>>> sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c | 454 ++++++++++++++++++
>>> sound/soc/amd/rpl/rpl-pci-acp6x.c | 123 ++++-
>>> sound/soc/amd/rpl/rpl_acp6x.h | 90 +++-
>>> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 420 +++++++++++++++-
>>> 7 files changed, 1221 insertions(+), 12 deletions(-)
>>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> create mode 100644 sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>>
>>> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
>>> index fd35a03aadcb..da2940e94a7e 100644
>>> --- a/sound/soc/amd/Kconfig
>>> +++ b/sound/soc/amd/Kconfig
>>> @@ -134,6 +134,17 @@ config SND_SOC_AMD_RPL_ACP6x
>>> Say m if you have such a device.
>>> If unsure select "N".
>>> +config SND_SOC_AMD_RPL_MACH
>>> + tristate "AMD RPL support for DMIC"
>>> + select SND_SOC_DMIC
>>> + depends on SND_SOC_AMD_ACP6x && ACPI
>>> + help
>>> + This option enables machine driver for AMD RPL platform
>>> + using dmic. ACP IP has PDM Decoder block with DMA controller.
>>> + DMIC can be connected directly to ACP IP.
>>> + Say m if you have such a device.
>>> + If unsure select "N".
>>> +
>>> config SND_SOC_AMD_ACP63_TOPLEVEL
>>> tristate "support for AMD platforms with ACP version >= 6.3"
>>> default SND_AMD_ACP_CONFIG
>>> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
>>> index a3825c5be4e7..b1190fcdf1f6 100644
>>> --- a/sound/soc/amd/rpl/Makefile
>>> +++ b/sound/soc/amd/rpl/Makefile
>>> @@ -1,5 +1,9 @@
>>> # SPDX-License-Identifier: GPL-2.0+
>>> # RPL platform Support
>>> snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
>>> +snd-rpl-acp6x-pdm-dma-y := rpl-acp6x-pdm-dma.o
>>> +snd-soc-rpl-acp6x-mach-y := rpl-acp6x-mach.o
>>> obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
>>> +obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-acp6x-pdm-dma.o
>>> +obj-$(CONFIG_SND_SOC_AMD_RPL_MACH) += snd-soc-rpl-acp6x-mach.o
>>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> new file mode 100644
>>> index 000000000000..71a384b9a36c
>>> --- /dev/null
>>> +++ b/sound/soc/amd/rpl/rpl-acp6x-mach.c
>>> @@ -0,0 +1,131 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Machine driver for AMD RPL platform using DMIC
>>> + *
>>> + * Copyright 2025 Advanced Micro Devices, Inc.
>>> + */
>>> +
>>> +#include <sound/soc.h>
>>> +#include <sound/soc-dapm.h>
>>> +#include <linux/module.h>
>>> +#include <sound/pcm.h>
>>> +#include <sound/pcm_params.h>
>>> +#include <linux/io.h>
>>> +#include <linux/dmi.h>
>>> +#include <linux/acpi.h>
>>> +
>>> +#include "rpl_acp6x.h"
>>> +
>>> +#define DRV_NAME "acp_rpl_mach"
>>> +
>>> +SND_SOC_DAILINK_DEF(acp6x_pdm,
>>> + DAILINK_COMP_ARRAY(COMP_CPU("acp_rpl_pdm_dma.0")));
>>> +
>>> +SND_SOC_DAILINK_DEF(dmic_codec,
>>> + DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
>>> + "dmic-hifi")));
>>> +
>>> +SND_SOC_DAILINK_DEF(pdm_platform,
>>> + DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_rpl_pdm_dma.0")));
>>> +
>>> +static struct snd_soc_dai_link acp6x_dai_pdm[] = {
>>> + {
>>> + .name = "rpl-acp6x-dmic-capture",
>>> + .stream_name = "DMIC capture",
>>> + .capture_only = 1,
>>> + SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
>>> + },
>>> +};
>>> +
>>> +static struct snd_soc_card acp6x_card = {
>>> + .name = "acp6x",
>>> + .owner = THIS_MODULE,
>>> + .dai_link = acp6x_dai_pdm,
>>> + .num_links = 1,
>>> +};
>>> +
>>> +static const struct dmi_system_id rpl_acp_quirk_table[] = {
>>> + {
>>> + .driver_data = &acp6x_card,
>>> + .matches = {
>>> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
>>> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
>>> + }
>>> + },
>>> + {}
>>> +};
>>> +
>>> +static int acp6x_probe(struct platform_device *pdev)
>>> +{
>>> + const struct dmi_system_id *dmi_id;
>>> + struct acp6x_pdm *machine = NULL;
>>> + struct snd_soc_card *card;
>>> + struct acpi_device *adev;
>>> + acpi_handle handle;
>>> + acpi_integer dmic_status;
>>> + int ret;
>>> + bool is_dmic_enable, wov_en;
>>> +
>>> + /* IF WOV entry not found, enable dmic based on AcpDmicConnected entry*/
>>> + is_dmic_enable = false;
>>> + wov_en = true;
>>> + /* check the parent device's firmware node has _DSD or not */
>>> + adev = ACPI_COMPANION(pdev->dev.parent);
>>> + if (adev) {
>>> + const union acpi_object *obj;
>>> +
>>> + if (!acpi_dev_get_property(adev, "AcpDmicConnected",
>>> ACPI_TYPE_INTEGER, &obj) &&
>>> + obj->integer.value == 1)
>>> + is_dmic_enable = true;
>>> + }
>>> +
>>> + handle = ACPI_HANDLE(pdev->dev.parent);
>>> + ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
>>> + if (!ACPI_FAILURE(ret)) {
>>> + wov_en = dmic_status;
>>> + if (!wov_en)
>>> + return -ENODEV;
>>> + } else {
>>> + /* Incase of ACPI method read failure then jump to check_dmi_entry */
>>> + goto check_dmi_entry;
>>> + }
>>> +
>>> + if (is_dmic_enable)
>>> + platform_set_drvdata(pdev, &acp6x_card);
>>> +
>>> +check_dmi_entry:
>>> + /* check for any DMI overrides */
>>> + dmi_id = dmi_first_match(rpl_acp_quirk_table);
>>> + if (dmi_id)
>>> + platform_set_drvdata(pdev, dmi_id->driver_data);
>>> +
>>> + card = platform_get_drvdata(pdev);
>>> + if (!card)
>>> + return -ENODEV;
>>> + dev_info(&pdev->dev, "Enabling ACP DMIC support via %s", dmi_id ? "DMI"
>>> : "ACPI");
>>> + acp6x_card.dev = &pdev->dev;
>>> +
>>> + snd_soc_card_set_drvdata(card, machine);
>>> + ret = devm_snd_soc_register_card(&pdev->dev, card);
>>> + if (ret) {
>>> + return dev_err_probe(&pdev->dev, ret,
>>> + "snd_soc_register_card(%s) failed\n",
>>> + card->name);
>>> + }
>>> + return 0;
>>> +}
>>> +
>>> +static struct platform_driver rpl_acp6x_mach_driver = {
>>> + .driver = {
>>> + .name = "acp_rpl_mach",
>>> + .pm = &snd_soc_pm_ops,
>>> + },
>>> + .probe = acp6x_probe,
>>> +};
>>> +
>>> +module_platform_driver(rpl_acp6x_mach_driver);
>>> +
>>> +MODULE_DESCRIPTION("AMD RPL support for DMIC");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:" DRV_NAME);
>>> +
>>> diff --git a/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> new file mode 100644
>>> index 000000000000..2ae6d388e488
>>> --- /dev/null
>>> +++ b/sound/soc/amd/rpl/rpl-acp6x-pdm-dma.c
>>> @@ -0,0 +1,454 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * AMD ALSA SoC RPL PDM Driver
>>> + *
>>> + * Copyright 2021 Advanced Micro Devices, Inc.
>>> + */
>>> +
>>> +#include <linux/platform_device.h>
>>> +#include <linux/module.h>
>>> +#include <linux/bitfield.h>
>>> +#include <linux/err.h>
>>> +#include <linux/io.h>
>>> +#include <sound/pcm_params.h>
>>> +#include <sound/soc.h>
>>> +#include <sound/soc-dai.h>
>>> +#include <linux/pm_runtime.h>
>>> +
>>> +#include "rpl_acp6x.h"
>>> +
>>> +#define DRV_NAME "acp_rpl_pdm_dma"
>>> +
>>> +static int pdm_gain = 3;
>>> +module_param(pdm_gain, int, 0644);
>>> +MODULE_PARM_DESC(pdm_gain, "Gain control (0-3)");
>>> +
>>> +static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
>>> + .info = SNDRV_PCM_INFO_INTERLEAVED |
>>> + SNDRV_PCM_INFO_BLOCK_TRANSFER |
>>> + SNDRV_PCM_INFO_MMAP |
>>> + SNDRV_PCM_INFO_MMAP_VALID |
>>> + SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
>>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>>> + .channels_min = 2,
>>> + .channels_max = 2,
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> + .rate_min = 48000,
>>> + .rate_max = 48000,
>>> + .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
>>> + .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
>>> + .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
>>> + .periods_min = CAPTURE_MIN_NUM_PERIODS,
>>> + .periods_max = CAPTURE_MAX_NUM_PERIODS,
>>> +};
>>> +
>>> +static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
>>> + u32 watermark_size, void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
>>> + rpl_acp_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
>>> + rpl_acp_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
>>> + rpl_acp_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
>>> +}
>>> +
>>> +static void acp6x_enable_pdm_clock(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_clk_enable, pdm_ctrl;
>>> +
>>> + pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
>>> + pdm_ctrl = 0x00;
>>> +
>>> + rpl_acp_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
>>> + pdm_ctrl = rpl_acp_readl(acp_base + ACP_WOV_MISC_CTRL);
>>> + pdm_ctrl &= ~ACP_WOV_GAIN_CONTROL;
>>> + pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, clamp(pdm_gain, 0, 3));
>>> + rpl_acp_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
>>> +}
>>> +
>>> +static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
>>> +{
>>> + u32 ext_int_ctrl;
>>> +
>>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + ext_int_ctrl |= PDM_DMA_INTR_MASK;
>>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> +}
>>> +
>>> +static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
>>> +{
>>> + u32 ext_int_ctrl;
>>> +
>>> + ext_int_ctrl = rpl_acp_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
>>> + rpl_acp_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> +}
>>> +
>>> +static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
>>> +{
>>> + bool pdm_dma_status;
>>> + u32 pdm_enable, pdm_dma_enable;
>>> +
>>> + pdm_dma_status = false;
>>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable &
>>> ACP_PDM_DMA_EN_STATUS))
>>> + pdm_dma_status = true;
>>> +
>>> + return pdm_dma_status;
>>> +}
>>> +
>>> +static int acp6x_start_pdm_dma(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_enable;
>>> + u32 pdm_dma_enable;
>>> + int timeout;
>>> +
>>> + pdm_enable = 0x01;
>>> + pdm_dma_enable = 0x01;
>>> +
>>> + acp6x_enable_pdm_clock(acp_base);
>>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + timeout = 0;
>>> + while (++timeout < ACP_COUNTER) {
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
>>> + return 0;
>>> + udelay(DELAY_US);
>>> + }
>>> + return -ETIMEDOUT;
>>> +}
>>> +
>>> +static int acp6x_stop_pdm_dma(void __iomem *acp_base)
>>> +{
>>> + u32 pdm_enable, pdm_dma_enable;
>>> + int timeout;
>>> +
>>> + pdm_enable = 0x00;
>>> + pdm_dma_enable = 0x00;
>>> +
>>> + pdm_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_ENABLE);
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if (pdm_dma_enable & 0x01) {
>>> + pdm_dma_enable = 0x02;
>>> + rpl_acp_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + timeout = 0;
>>> + while (++timeout < ACP_COUNTER) {
>>> + pdm_dma_enable = rpl_acp_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
>>> + if ((pdm_dma_enable & 0x02) == 0x00)
>>> + break;
>>> + udelay(DELAY_US);
>>> + }
>>> + if (timeout == ACP_COUNTER)
>>> + return -ETIMEDOUT;
>>> + }
>>> + if (pdm_enable == ACP_PDM_ENABLE) {
>>> + pdm_enable = ACP_PDM_DISABLE;
>>> + rpl_acp_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
>>> + }
>>> + rpl_acp_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
>>> + return 0;
>>> +}
>>> +
>>> +static void acp6x_config_dma(struct rpl_pdm_stream_instance *rtd, int
>>> direction)
>>> +{
>>> + u16 page_idx;
>>> + u32 low, high, val;
>>> + dma_addr_t addr;
>>> +
>>> + addr = rtd->dma_addr;
>>> + val = PDM_PTE_OFFSET;
>>> +
>>> + /* Group Enable */
>>> + rpl_acp_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
>>> + ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
>>> + rpl_acp_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
>>> + ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
>>> + for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
>>> + /* Load the low address of page int ACP SRAM through SRBM */
>>> + low = lower_32_bits(addr);
>>> + high = upper_32_bits(addr);
>>> +
>>> + rpl_acp_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
>>> + high |= BIT(31);
>>> + rpl_acp_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
>>> + val += 8;
>>> + addr += PAGE_SIZE;
>>> + }
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_open(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream)
>>> +{
>>> + struct snd_pcm_runtime *runtime;
>>> + struct rpl_pdm_dev_data *adata;
>>> + struct rpl_pdm_stream_instance *pdm_data;
>>> + int ret;
>>> +
>>> + runtime = substream->runtime;
>>> + adata = dev_get_drvdata(component->dev);
>>> + pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
>>> + if (!pdm_data)
>>> + return -EINVAL;
>>> +
>>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>>> + runtime->hw = acp6x_pdm_hardware_capture;
>>> +
>>> + ret = snd_pcm_hw_constraint_integer(runtime,
>>> + SNDRV_PCM_HW_PARAM_PERIODS);
>>> + if (ret < 0) {
>>> + dev_err(component->dev, "set integer constraint failed\n");
>>> + kfree(pdm_data);
>>> + return ret;
>>> + }
>>> +
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> +
>>> + if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
>>> + adata->capture_stream = substream;
>>> +
>>> + pdm_data->acp6x_base = adata->acp6x_base;
>>> + runtime->private_data = pdm_data;
>>> + return ret;
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream,
>>> + struct snd_pcm_hw_params *params)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + size_t size, period_bytes;
>>> +
>>> + rtd = substream->runtime->private_data;
>>> + if (!rtd)
>>> + return -EINVAL;
>>> + size = params_buffer_bytes(params);
>>> + period_bytes = params_period_bytes(params);
>>> + rtd->dma_addr = substream->runtime->dma_addr;
>>> + rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
>>> + acp6x_config_dma(rtd, substream->stream);
>>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
>>> + period_bytes, rtd->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static u64 acp6x_pdm_get_byte_count(struct rpl_pdm_stream_instance *rtd,
>>> + int direction)
>>> +{
>>> + union rpl_acp_pdm_dma_count byte_count;
>>> +
>>> + byte_count.bcount.high =
>>> + rpl_acp_readl(rtd->acp6x_base +
>>> ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
>>> + byte_count.bcount.low =
>>> + rpl_acp_readl(rtd->acp6x_base +
>>> ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
>>> + return byte_count.bytescount;
>>> +}
>>> +
>>> +static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
>>> + struct snd_pcm_substream *stream)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + u32 pos, buffersize;
>>> + u64 bytescount;
>>> +
>>> + rtd = stream->runtime->private_data;
>>> + buffersize = frames_to_bytes(stream->runtime,
>>> + stream->runtime->buffer_size);
>>> + bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
>>> + if (bytescount > rtd->bytescount)
>>> + bytescount -= rtd->bytescount;
>>> + pos = do_div(bytescount, buffersize);
>>> + return bytes_to_frames(stream->runtime, pos);
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_new(struct snd_soc_component *component,
>>> + struct snd_soc_pcm_runtime *rtd)
>>> +{
>>> + struct device *parent = component->dev->parent;
>>> +
>>> + snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
>>> + parent, MIN_BUFFER, MAX_BUFFER);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_dma_close(struct snd_soc_component *component,
>>> + struct snd_pcm_substream *substream)
>>> +{
>>> + struct rpl_pdm_dev_data *adata = dev_get_drvdata(component->dev);
>>> +
>>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>>> + adata->capture_stream = NULL;
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
>>> + int cmd, struct snd_soc_dai *dai)
>>> +{
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + int ret;
>>> + bool pdm_status;
>>> + unsigned int ch_mask;
>>> +
>>> + rtd = substream->runtime->private_data;
>>> + ret = 0;
>>> + switch (substream->runtime->channels) {
>>> + case TWO_CH:
>>> + ch_mask = 0x00;
>>> + break;
>>> + default:
>>> + return -EINVAL;
>>> + }
>>> + switch (cmd) {
>>> + case SNDRV_PCM_TRIGGER_START:
>>> + case SNDRV_PCM_TRIGGER_RESUME:
>>> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>>> + rpl_acp_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
>>> + rpl_acp_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
>>> + ACP_WOV_PDM_DECIMATION_FACTOR);
>>> + rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
>>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>>> + if (!pdm_status)
>>> + ret = acp6x_start_pdm_dma(rtd->acp6x_base);
>>> + break;
>>> + case SNDRV_PCM_TRIGGER_STOP:
>>> + case SNDRV_PCM_TRIGGER_SUSPEND:
>>> + case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
>>> + pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
>>> + if (pdm_status)
>>> + ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
>>> + break;
>>> + default:
>>> + ret = -EINVAL;
>>> + break;
>>> + }
>>> + return ret;
>>> +}
>>> +
>>> +static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
>>> + .trigger = acp6x_pdm_dai_trigger,
>>> +};
>>> +
>>> +static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
>>> + .capture = {
>>> + .rates = SNDRV_PCM_RATE_48000,
>>> + .formats = SNDRV_PCM_FMTBIT_S32_LE,
>>> + .channels_min = 2,
>>> + .channels_max = 2,
>>> + .rate_min = 48000,
>>> + .rate_max = 48000,
>>> + },
>>> + .ops = &acp6x_pdm_dai_ops,
>>> +};
>>> +
>>> +static const struct snd_soc_component_driver acp6x_pdm_component = {
>>> + .name = DRV_NAME,
>>> + .open = acp6x_pdm_dma_open,
>>> + .close = acp6x_pdm_dma_close,
>>> + .hw_params = acp6x_pdm_dma_hw_params,
>>> + .pointer = acp6x_pdm_dma_pointer,
>>> + .pcm_construct = acp6x_pdm_dma_new,
>>> + .legacy_dai_naming = 1,
>>> +};
>>> +
>>> +static int acp6x_pdm_audio_probe(struct platform_device *pdev)
>>> +{
>>> + struct resource *res;
>>> + struct rpl_pdm_dev_data *adata;
>>> + int status;
>>> +
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + if (!res) {
>>> + dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
>>> + return -ENODEV;
>>> + }
>>> +
>>> + adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
>>> + if (!adata)
>>> + return -ENOMEM;
>>> +
>>> + adata->acp6x_base = devm_ioremap(&pdev->dev, res->start,
>>> resource_size(res));
>>> + if (!adata->acp6x_base)
>>> + return -ENOMEM;
>>> +
>>> + adata->capture_stream = NULL;
>>> +
>>> + dev_set_drvdata(&pdev->dev, adata);
>>> + status = devm_snd_soc_register_component(&pdev->dev,
>>> + &acp6x_pdm_component,
>>> + &acp6x_pdm_dai_driver, 1);
>>> + if (status) {
>>> + dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
>>> +
>>> + return -ENODEV;
>>> + }
>>> + pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
>>> + pm_runtime_use_autosuspend(&pdev->dev);
>>> + pm_runtime_mark_last_busy(&pdev->dev);
>>> + pm_runtime_set_active(&pdev->dev);
>>> + pm_runtime_enable(&pdev->dev);
>>> + return 0;
>>> +}
>>> +
>>> +static void acp6x_pdm_audio_remove(struct platform_device *pdev)
>>> +{
>>> + pm_runtime_disable(&pdev->dev);
>>> +}
>>> +
>>> +static int acp6x_pdm_resume(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> + struct snd_pcm_runtime *runtime;
>>> + struct rpl_pdm_stream_instance *rtd;
>>> + u32 period_bytes, buffer_len;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + if (adata->capture_stream && adata->capture_stream->runtime) {
>>> + runtime = adata->capture_stream->runtime;
>>> + rtd = runtime->private_data;
>>> + period_bytes = frames_to_bytes(runtime, runtime->period_size);
>>> + buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
>>> + acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
>>> + acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
>>> + period_bytes, adata->acp6x_base);
>>> + }
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_suspend(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + acp6x_disable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static int acp6x_pdm_runtime_resume(struct device *dev)
>>> +{
>>> + struct rpl_pdm_dev_data *adata;
>>> +
>>> + adata = dev_get_drvdata(dev);
>>> + acp6x_enable_pdm_interrupts(adata->acp6x_base);
>>> + return 0;
>>> +}
>>> +
>>> +static const struct dev_pm_ops acp6x_pdm_pm_ops = {
>>> + RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
>>> + SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
>>> +};
>>> +
>>> +static struct platform_driver acp6x_pdm_dma_driver = {
>>> + .probe = acp6x_pdm_audio_probe,
>>> + .remove = acp6x_pdm_audio_remove,
>>> + .driver = {
>>> + .name = "acp_rpl_pdm_dma",
>>> + .pm = pm_ptr(&acp6x_pdm_pm_ops),
>>> + },
>>> +};
>>> +
>>> +module_platform_driver(acp6x_pdm_dma_driver);
>>> +
>>> +MODULE_DESCRIPTION("AMD ACP6x RPL PDM Driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_ALIAS("platform:" DRV_NAME);
>>> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> index e3afe9172bdf..9a0d9920ad8e 100644
>>> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> +++ b/sound/soc/amd/rpl/rpl-pci-acp6x.c
>>> @@ -10,12 +10,16 @@
>>> #include <linux/io.h>
>>> #include <linux/delay.h>
>>> #include <linux/platform_device.h>
>>> +#include <sound/pcm.h>
>>> #include <linux/pm_runtime.h>
>>> #include "rpl_acp6x.h"
>>> struct rpl_dev_data {
>>> void __iomem *acp6x_base;
>>> + struct resource *res;
>>> + bool acp6x_audio_mode;
>>> + struct platform_device *pdev[ACP6x_DEVS];
>>> };
>>> static int rpl_power_on(void __iomem *acp_base)
>>> @@ -64,6 +68,19 @@ static int rpl_reset(void __iomem *acp_base)
>>> return -ETIMEDOUT;
>>> }
>>> +static void rpl_enable_interrupts(void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
>>> +}
>>> +
>>> +static void rpl_disable_interrupts(void __iomem *acp_base)
>>> +{
>>> + rpl_acp_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
>>> + ACP_EXTERNAL_INTR_STAT);
>>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
>>> + rpl_acp_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
>>> +}
>>> +
>>> static int rpl_init(void __iomem *acp_base)
>>> {
>>> int ret;
>>> @@ -82,6 +99,7 @@ static int rpl_init(void __iomem *acp_base)
>>> return ret;
>>> }
>>> rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
>>> + rpl_enable_interrupts(acp_base);
>>> return 0;
>>> }
>>> @@ -89,6 +107,7 @@ static int rpl_deinit(void __iomem *acp_base)
>>> {
>>> int ret;
>>> + rpl_disable_interrupts(acp_base);
>>> /* Reset */
>>> ret = rpl_reset(acp_base);
>>> if (ret) {
>>> @@ -100,13 +119,45 @@ static int rpl_deinit(void __iomem *acp_base)
>>> return 0;
>>> }
>>> +static irqreturn_t rpl_irq_handler(int irq, void *dev_id)
>>> +{
>>> + struct rpl_dev_data *adata;
>>> + struct rpl_pdm_dev_data *rpl_pdm_data;
>>> + u32 val;
>>> +
>>> + adata = dev_id;
>>> + if (!adata)
>>> + return IRQ_NONE;
>>> +
>>> + val = rpl_acp_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
>>> + if (val & BIT(PDM_DMA_STAT)) {
>>> + rpl_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
>>> + rpl_acp_writel(BIT(PDM_DMA_STAT), adata->acp6x_base +
>>> ACP_EXTERNAL_INTR_STAT);
>>> + if (rpl_pdm_data->capture_stream)
>>> + snd_pcm_period_elapsed(rpl_pdm_data->capture_stream);
>>> + return IRQ_HANDLED;
>>> + }
>>> + return IRQ_NONE;
>>> +}
>>> +
>>> static int snd_rpl_probe(struct pci_dev *pci,
>>> const struct pci_device_id *pci_id)
>>> {
>>> struct rpl_dev_data *adata;
>>> + struct platform_device_info pdevinfo[ACP6x_DEVS];
>>> + int index = 0;
>>> + int val = 0x00;
>>> + unsigned int irqflags, flag;
>>> u32 addr;
>>> int ret;
>>> + irqflags = IRQF_SHARED;
>>> +
>>> + /* Return if acp config flag is defined */
>>> + flag = snd_amd_acp_find_config(pci);
>>> + if (flag)
>>> + return -ENODEV;
>>> +
>>> /* RPL device check */
>>> switch (pci->revision) {
>>> case 0x62:
>>> @@ -145,12 +196,78 @@ static int snd_rpl_probe(struct pci_dev *pci,
>>> ret = rpl_init(adata->acp6x_base);
>>> if (ret)
>>> goto release_regions;
>>> +
>>> + val = rpl_acp_readl(adata->acp6x_base + ACP_PIN_CONFIG);
>>> + switch (val) {
>>> + case ACP_CONFIG_0:
>>> + case ACP_CONFIG_1:
>>> + case ACP_CONFIG_2:
>>> + case ACP_CONFIG_3:
>>> + case ACP_CONFIG_9:
>>> + case ACP_CONFIG_15:
For RPL platform, ACP PIN Config from 9 to 15 are reserved.
Include switch cases for rest of the ACP PIN config values i.e.
10,11,12,13,14.
>>> + dev_info(&pci->dev, "Audio Mode %d\n", val);
>>> + break;
>>> + default:
>>> + adata->res = devm_kzalloc(&pci->dev,
>>> + sizeof(struct resource),
>>> + GFP_KERNEL);
>>> + if (!adata->res) {
>>> + ret = -ENOMEM;
>>> + goto de_init;
>>> + }
>>> +
>>> + adata->res->name = "acp_iomem";
>>> + adata->res->flags = IORESOURCE_MEM;
>>> + adata->res->start = addr;
>>> + adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
>>> +
>>> + adata->acp6x_audio_mode = ACP6x_PDM_MODE;
>>> +
>>> + memset(&pdevinfo, 0, sizeof(pdevinfo));
>>> + pdevinfo[0].name = "acp_rpl_pdm_dma";
>>> + pdevinfo[0].id = 0;
>>> + pdevinfo[0].parent = &pci->dev;
>>> + pdevinfo[0].num_res = 1;
>>> + pdevinfo[0].res = adata->res;
>>> +
>>> + pdevinfo[1].name = "dmic-codec";
>>> + pdevinfo[1].id = 0;
>>> + pdevinfo[1].parent = &pci->dev;
>>> +
>>> + pdevinfo[2].name = "acp_rpl_mach";
>>> + pdevinfo[2].id = 0;
>>> + pdevinfo[2].parent = &pci->dev;
>>> +
>>> + for (index = 0; index < ACP6x_DEVS; index++) {
>>> + adata->pdev[index] =
>>> + platform_device_register_full(&pdevinfo[index]);
>>> + if (IS_ERR(adata->pdev[index])) {
>>> + dev_err(&pci->dev, "cannot register %s device\n",
>>> + pdevinfo[index].name);
>>> + ret = PTR_ERR(adata->pdev[index]);
>>> + goto unregister_devs;
>>> + }
>>> + }
>>> + break;
>>> + }
>>> + ret = devm_request_irq(&pci->dev, pci->irq, rpl_irq_handler,
>>> + irqflags, "ACP_PCI_IRQ", adata);
>>> + if (ret) {
>>> + dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
>>> + goto unregister_devs;
>>> + }
>>> pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
>>> pm_runtime_use_autosuspend(&pci->dev);
>>> pm_runtime_put_noidle(&pci->dev);
>>> pm_runtime_allow(&pci->dev);
>>> return 0;
>>> +unregister_devs:
>>> + for (--index; index >= 0; index--)
>>> + platform_device_unregister(adata->pdev[index]);
>>> +de_init:
>>> + if (rpl_deinit(adata->acp6x_base))
>>> + dev_err(&pci->dev, "ACP de-init failed\n");
>>> release_regions:
>>> pci_release_regions(pci);
>>> disable_pci:
>>> @@ -191,9 +308,13 @@ static const struct dev_pm_ops rpl_pm = {
>>> static void snd_rpl_remove(struct pci_dev *pci)
>>> {
>>> struct rpl_dev_data *adata;
>>> - int ret;
>>> + int ret, index;
>>> adata = pci_get_drvdata(pci);
>>> + if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
>>> + for (index = 0; index < ACP6x_DEVS; index++)
>>> + platform_device_unregister(adata->pdev[index]);
>>> + }
>>> ret = rpl_deinit(adata->acp6x_base);
>>> if (ret)
>>> dev_err(&pci->dev, "ACP de-init failed\n");
>>> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
>>> index f5816a33632e..d470927c1e35 100644
>>> --- a/sound/soc/amd/rpl/rpl_acp6x.h
>>> +++ b/sound/soc/amd/rpl/rpl_acp6x.h
>>> @@ -9,15 +9,46 @@
>>> #define ACP_DEVICE_ID 0x15E2
>>> #define ACP6x_PHY_BASE_ADDRESS 0x1240000
>>> +#define ACP6x_REG_START 0x1240000
>>> +#define ACP6x_REG_END 0x1250200
>>> +#define ACP6x_DEVS 3
>>> +#define ACP6x_PDM_MODE 1
>>> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>>> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>>> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>>> -#define ACP_PGFSM_STATUS_MASK 3
>>> -#define ACP_POWERED_ON 0
>>> -#define ACP_POWER_ON_IN_PROGRESS 1
>>> -#define ACP_POWERED_OFF 2
>>> -#define ACP_POWER_OFF_IN_PROGRESS 3
>>> +#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
>>> +#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
>>> +#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
>>> +#define ACP_PGFSM_STATUS_MASK 3
>>> +#define ACP_POWERED_ON 0
>>> +#define ACP_POWER_ON_IN_PROGRESS 1
>>> +#define ACP_POWERED_OFF 2
>>> +#define ACP_POWER_OFF_IN_PROGRESS 3
>>> +
>>> +#define ACP_ERROR_MASK 0x20000000
>>> +#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
>>> +#define PDM_DMA_STAT 0x10
>>> +
>>> +#define PDM_DMA_INTR_MASK 0x10000
>>> +#define ACP_ERROR_STAT 29
>>> +#define PDM_DECIMATION_FACTOR 2
>>> +#define ACP_PDM_CLK_FREQ_MASK 7
>>> +#define ACP_WOV_GAIN_CONTROL GENMASK(4, 3)
>>> +#define ACP_PDM_ENABLE 1
>>> +#define ACP_PDM_DISABLE 0
>>> +#define ACP_PDM_DMA_EN_STATUS 2
>>> +#define TWO_CH 2
>>> +
>>> +#define ACP_SRAM_PTE_OFFSET 0x03800000
>>> +#define PAGE_SIZE_4K_ENABLE 2
>>> +#define PDM_PTE_OFFSET 0
>>> +#define PDM_MEM_WINDOW_START 0x4000000
>>> +
>>> +#define CAPTURE_MIN_NUM_PERIODS 4
>>> +#define CAPTURE_MAX_NUM_PERIODS 4
>>> +#define CAPTURE_MAX_PERIOD_SIZE 8192
>>> +#define CAPTURE_MIN_PERIOD_SIZE 4096
>>> +
>>> +#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
>>> +#define MIN_BUFFER MAX_BUFFER
>>> #define DELAY_US 5
>>> #define ACP_COUNTER 20000
>>> @@ -25,6 +56,47 @@
>>> /* time in ms for runtime suspend delay */
>>> #define ACP_SUSPEND_DELAY_MS 2000
>>> +enum rpl_acp_config {
>>> + ACP_CONFIG_0 = 0,
>>> + ACP_CONFIG_1,
>>> + ACP_CONFIG_2,
>>> + ACP_CONFIG_3,
>>> + ACP_CONFIG_4,
>>> + ACP_CONFIG_5,
>>> + ACP_CONFIG_6,
>>> + ACP_CONFIG_7,
>>> + ACP_CONFIG_8,
>>> + ACP_CONFIG_9,
>>> + ACP_CONFIG_10,
>>> + ACP_CONFIG_11,
>>> + ACP_CONFIG_12,
>>> + ACP_CONFIG_13,
>>> + ACP_CONFIG_14,
>>> + ACP_CONFIG_15,
>>> +};
>>> +
>>> +struct rpl_pdm_dev_data {
>>> + u32 pdm_irq;
>>> + void __iomem *acp6x_base;
>>> + struct snd_pcm_substream *capture_stream;
>>> +};
>>> +
>>> +struct rpl_pdm_stream_instance {
>>> + u16 num_pages;
>>> + u16 channels;
>>> + dma_addr_t dma_addr;
>>> + u64 bytescount;
>>> + void __iomem *acp6x_base;
>>> +};
>>> +
>>> +union rpl_acp_pdm_dma_count {
>>> + struct {
>>> + u32 low;
>>> + u32 high;
>>> + } bcount;
>>> + u64 bytescount;
>>> +};
>>> +
>>> static inline u32 rpl_acp_readl(void __iomem *base_addr)
>>> {
>>> return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
>>> @@ -34,3 +106,5 @@ static inline void rpl_acp_writel(u32 val, void __iomem
>>> *base_addr)
>>> {
>>> writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
>>> }
>>> +
>>> +int snd_amd_acp_find_config(struct pci_dev *pci);
>>> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> index 456498f5396d..44994a925149 100644
>>> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> +++ b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>>> @@ -8,14 +8,114 @@
>>> #ifndef _rpl_acp6x_OFFSET_HEADER
>>> #define _rpl_acp6x_OFFSET_HEADER
>>> +/* Registers from ACP_DMA block */
>>> +#define ACP_DMA_CNTL_0 0x1240000
>>> +#define ACP_DMA_CNTL_1 0x1240004
>>> +#define ACP_DMA_CNTL_2 0x1240008
>>> +#define ACP_DMA_CNTL_3 0x124000C
>>> +#define ACP_DMA_CNTL_4 0x1240010
>>> +#define ACP_DMA_CNTL_5 0x1240014
>>> +#define ACP_DMA_CNTL_6 0x1240018
>>> +#define ACP_DMA_CNTL_7 0x124001C
>>> +#define ACP_DMA_DSCR_STRT_IDX_0 0x1240020
>>> +#define ACP_DMA_DSCR_STRT_IDX_1 0x1240024
>>> +#define ACP_DMA_DSCR_STRT_IDX_2 0x1240028
>>> +#define ACP_DMA_DSCR_STRT_IDX_3 0x124002C
>>> +#define ACP_DMA_DSCR_STRT_IDX_4 0x1240030
>>> +#define ACP_DMA_DSCR_STRT_IDX_5 0x1240034
>>> +#define ACP_DMA_DSCR_STRT_IDX_6 0x1240038
>>> +#define ACP_DMA_DSCR_STRT_IDX_7 0x124003C
>>> +#define ACP_DMA_DSCR_CNT_0 0x1240040
>>> +#define ACP_DMA_DSCR_CNT_1 0x1240044
>>> +#define ACP_DMA_DSCR_CNT_2 0x1240048
>>> +#define ACP_DMA_DSCR_CNT_3 0x124004C
>>> +#define ACP_DMA_DSCR_CNT_4 0x1240050
>>> +#define ACP_DMA_DSCR_CNT_5 0x1240054
>>> +#define ACP_DMA_DSCR_CNT_6 0x1240058
>>> +#define ACP_DMA_DSCR_CNT_7 0x124005C
>>> +#define ACP_DMA_PRIO_0 0x1240060
>>> +#define ACP_DMA_PRIO_1 0x1240064
>>> +#define ACP_DMA_PRIO_2 0x1240068
>>> +#define ACP_DMA_PRIO_3 0x124006C
>>> +#define ACP_DMA_PRIO_4 0x1240070
>>> +#define ACP_DMA_PRIO_5 0x1240074
>>> +#define ACP_DMA_PRIO_6 0x1240078
>>> +#define ACP_DMA_PRIO_7 0x124007C
>>> +#define ACP_DMA_CUR_DSCR_0 0x1240080
>>> +#define ACP_DMA_CUR_DSCR_1 0x1240084
>>> +#define ACP_DMA_CUR_DSCR_2 0x1240088
>>> +#define ACP_DMA_CUR_DSCR_3 0x124008C
>>> +#define ACP_DMA_CUR_DSCR_4 0x1240090
>>> +#define ACP_DMA_CUR_DSCR_5 0x1240094
>>> +#define ACP_DMA_CUR_DSCR_6 0x1240098
>>> +#define ACP_DMA_CUR_DSCR_7 0x124009C
>>> +#define ACP_DMA_CUR_TRANS_CNT_0 0x12400A0
>>> +#define ACP_DMA_CUR_TRANS_CNT_1 0x12400A4
>>> +#define ACP_DMA_CUR_TRANS_CNT_2 0x12400A8
>>> +#define ACP_DMA_CUR_TRANS_CNT_3 0x12400AC
>>> +#define ACP_DMA_CUR_TRANS_CNT_4 0x12400B0
>>> +#define ACP_DMA_CUR_TRANS_CNT_5 0x12400B4
>>> +#define ACP_DMA_CUR_TRANS_CNT_6 0x12400B8
>>> +#define ACP_DMA_CUR_TRANS_CNT_7 0x12400BC
>>> +#define ACP_DMA_ERR_STS_0 0x12400C0
>>> +#define ACP_DMA_ERR_STS_1 0x12400C4
>>> +#define ACP_DMA_ERR_STS_2 0x12400C8
>>> +#define ACP_DMA_ERR_STS_3 0x12400CC
>>> +#define ACP_DMA_ERR_STS_4 0x12400D0
>>> +#define ACP_DMA_ERR_STS_5 0x12400D4
>>> +#define ACP_DMA_ERR_STS_6 0x12400D8
>>> +#define ACP_DMA_ERR_STS_7 0x12400DC
>>> +#define ACP_DMA_DESC_BASE_ADDR 0x12400E0
>>> +#define ACP_DMA_DESC_MAX_NUM_DSCR 0x12400E4
>>> +#define ACP_DMA_CH_STS 0x12400E8
>>> +#define ACP_DMA_CH_GROUP 0x12400EC
>>> +#define ACP_DMA_CH_RST_STS 0x12400F0
>>> +
>>> +/* Registers from ACP_AXI2AXIATU block */
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1 0x1240C00
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1 0x1240C04
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2 0x1240C08
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2 0x1240C0C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3 0x1240C10
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3 0x1240C14
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4 0x1240C18
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4 0x1240C1C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5 0x1240C20
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5 0x1240C24
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6 0x1240C28
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6 0x1240C2C
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7 0x1240C30
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7 0x1240C34
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8 0x1240C38
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8 0x1240C3C
>>> +#define ACPAXI2AXI_ATU_CTRL 0x1240C40
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9 0x1240C44
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9 0x1240C48
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10 0x1240C4C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10 0x1240C50
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11 0x1240C54
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11 0x1240C58
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12 0x1240C5C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12 0x1240C60
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13 0x1240C64
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13 0x1240C68
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14 0x1240C6C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14 0x1240C70
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15 0x1240C74
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15 0x1240C78
>>> +#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16 0x1240C7C
>>> +#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16 0x1240C80
>>> +
>>> /* Registers from ACP_CLKRST block */
>>> #define ACP_SOFT_RESET 0x1241000
>>> #define ACP_CONTROL 0x1241004
>>> #define ACP_STATUS 0x1241008
>>> #define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
>>> -#define ACP_PGFSM_CONTROL 0x124101C
>>> -#define ACP_PGFSM_STATUS 0x1241020
>>> -#define ACP_CLKMUX_SEL 0x1241024
>>> +#define ACP_ZSC_DSP_CTRL 0x1241014
>>> +#define ACP_ZSC_STS 0x1241018
>>> +#define ACP_PGFSM_CONTROL 0x1241024
>>> +#define ACP_PGFSM_STATUS 0x1241028
>>> +#define ACP_CLKMUX_SEL 0x124102C
>>> /* Registers from ACP_AON block */
>>> #define ACP_PME_EN 0x1241400
>>> @@ -26,5 +126,319 @@
>>> #define ACP_PAD_PULLDOWN_CTRL 0x1241448
>>> #define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
>>> #define ACP_PAD_SCHMEN_CTRL 0x1241450
>>> +#define ACP_SW_PAD_KEEPER_EN 0x1241454
>>> +#define ACP_SW_WAKE_EN 0x1241458
>>> +#define ACP_I2S_WAKE_EN 0x124145C
>>> +#define ACP_SW1_WAKE_EN 0x1241460
>>> +
>>> +/* Registers from ACP_P1_MISC block */
>>> +#define ACP_EXTERNAL_INTR_ENB 0x1241A00
>>> +#define ACP_EXTERNAL_INTR_CNTL 0x1241A04
>>> +#define ACP_EXTERNAL_INTR_CNTL1 0x1241A08
>>> +#define ACP_EXTERNAL_INTR_STAT 0x1241A0C
>>> +#define ACP_EXTERNAL_INTR_STAT1 0x1241A10
>>> +#define ACP_ERROR_STATUS 0x1241A4C
>>> +#define ACP_P1_SW_I2S_ERROR_REASON 0x1241A50
>>> +#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL 0x1241A6C
>>> +#define ACP_P1_SW_I2S_TX_DMA_POS 0x1241A70
>>> +#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL 0x1241A74
>>> +#define ACP_P1_SW_I2S_RX_DMA_POS 0x1241A78
>>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL 0x1241A7C
>>> +#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS 0x1241A80
>>> +#define ACP_SCRATCH_REG_BASE_ADDR 0x1241A84
>>> +#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL 0x1241A88
>>> +#define ACP_P1_SW_BT_TX_DMA_POS 0x1241A8C
>>> +#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL 0x1241A90
>>> +#define ACP_P1_SW_HS_TX_DMA_POS 0x1241A94
>>> +#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL 0x1241A98
>>> +#define ACP_P1_SW_BT_RX_DMA_POS 0x1241A9C
>>> +#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL 0x1241AA0
>>> +#define ACP_P1_SW_HS_RX_DMA_POS 0x1241AA4
>>> +
>>> +/* Registers from ACP_AUDIO_BUFFERS block */
>>> +#define ACP_I2S_RX_RINGBUFADDR 0x1242000
>>> +#define ACP_I2S_RX_RINGBUFSIZE 0x1242004
>>> +#define ACP_I2S_RX_LINKPOSITIONCNTR 0x1242008
>>> +#define ACP_I2S_RX_FIFOADDR 0x124200C
>>> +#define ACP_I2S_RX_FIFOSIZE 0x1242010
>>> +#define ACP_I2S_RX_DMA_SIZE 0x1242014
>>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1242018
>>> +#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW 0x124201C
>>> +#define ACP_I2S_RX_INTR_WATERMARK_SIZE 0x1242020
>>> +#define ACP_I2S_TX_RINGBUFADDR 0x1242024
>>> +#define ACP_I2S_TX_RINGBUFSIZE 0x1242028
>>> +#define ACP_I2S_TX_LINKPOSITIONCNTR 0x124202C
>>> +#define ACP_I2S_TX_FIFOADDR 0x1242030
>>> +#define ACP_I2S_TX_FIFOSIZE 0x1242034
>>> +#define ACP_I2S_TX_DMA_SIZE 0x1242038
>>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x124203C
>>> +#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1242040
>>> +#define ACP_I2S_TX_INTR_WATERMARK_SIZE 0x1242044
>>> +#define ACP_BT_RX_RINGBUFADDR 0x1242048
>>> +#define ACP_BT_RX_RINGBUFSIZE 0x124204C
>>> +#define ACP_BT_RX_LINKPOSITIONCNTR 0x1242050
>>> +#define ACP_BT_RX_FIFOADDR 0x1242054
>>> +#define ACP_BT_RX_FIFOSIZE 0x1242058
>>> +#define ACP_BT_RX_DMA_SIZE 0x124205C
>>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1242060
>>> +#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW 0x1242064
>>> +#define ACP_BT_RX_INTR_WATERMARK_SIZE 0x1242068
>>> +#define ACP_BT_TX_RINGBUFADDR 0x124206C
>>> +#define ACP_BT_TX_RINGBUFSIZE 0x1242070
>>> +#define ACP_BT_TX_LINKPOSITIONCNTR 0x1242074
>>> +#define ACP_BT_TX_FIFOADDR 0x1242078
>>> +#define ACP_BT_TX_FIFOSIZE 0x124207C
>>> +#define ACP_BT_TX_DMA_SIZE 0x1242080
>>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1242084
>>> +#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW 0x1242088
>>> +#define ACP_BT_TX_INTR_WATERMARK_SIZE 0x124208C
>>> +#define ACP_HS_RX_RINGBUFADDR 0x1242090
>>> +#define ACP_HS_RX_RINGBUFSIZE 0x1242094
>>> +#define ACP_HS_RX_LINKPOSITIONCNTR 0x1242098
>>> +#define ACP_HS_RX_FIFOADDR 0x124209C
>>> +#define ACP_HS_RX_FIFOSIZE 0x12420A0
>>> +#define ACP_HS_RX_DMA_SIZE 0x12420A4
>>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH 0x12420A8
>>> +#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW 0x12420AC
>>> +#define ACP_HS_RX_INTR_WATERMARK_SIZE 0x12420B0
>>> +#define ACP_HS_TX_RINGBUFADDR 0x12420B4
>>> +#define ACP_HS_TX_RINGBUFSIZE 0x12420B8
>>> +#define ACP_HS_TX_LINKPOSITIONCNTR 0x12420BC
>>> +#define ACP_HS_TX_FIFOADDR 0x12420C0
>>> +#define ACP_HS_TX_FIFOSIZE 0x12420C4
>>> +#define ACP_HS_TX_DMA_SIZE 0x12420C8
>>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH 0x12420CC
>>> +#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW 0x12420D0
>>> +#define ACP_HS_TX_INTR_WATERMARK_SIZE 0x12420D4
>>> +
>>> +/* Registers from ACP_I2S_TDM block */
>>> +#define ACP_I2STDM_IER 0x1242400
>>> +#define ACP_I2STDM_IRER 0x1242404
>>> +#define ACP_I2STDM_RXFRMT 0x1242408
>>> +#define ACP_I2STDM_ITER 0x124240C
>>> +#define ACP_I2STDM_TXFRMT 0x1242410
>>> +#define ACP_I2STDM0_MSTRCLKGEN 0x1242414
>>> +#define ACP_I2STDM1_MSTRCLKGEN 0x1242418
>>> +#define ACP_I2STDM2_MSTRCLKGEN 0x124241C
>>> +#define ACP_I2STDM_REFCLKGEN 0x1242420
>>> +
>>> +/* Registers from ACP_BT_TDM block */
>>> +#define ACP_BTTDM_IER 0x1242800
>>> +#define ACP_BTTDM_IRER 0x1242804
>>> +#define ACP_BTTDM_RXFRMT 0x1242808
>>> +#define ACP_BTTDM_ITER 0x124280C
>>> +#define ACP_BTTDM_TXFRMT 0x1242810
>>> +#define ACP_HSTDM_IER 0x1242814
>>> +#define ACP_HSTDM_IRER 0x1242818
>>> +#define ACP_HSTDM_RXFRMT 0x124281C
>>> +#define ACP_HSTDM_ITER 0x1242820
>>> +#define ACP_HSTDM_TXFRMT 0x1242824
>>> +
>>> +/* Registers from ACP_WOV block */
>>> +#define ACP_WOV_PDM_ENABLE 0x1242C04
>>> +#define ACP_WOV_PDM_DMA_ENABLE 0x1242C08
>>> +#define ACP_WOV_RX_RINGBUFADDR 0x1242C0C
>>> +#define ACP_WOV_RX_RINGBUFSIZE 0x1242C10
>>> +#define ACP_WOV_RX_LINKPOSITIONCNTR 0x1242C14
>>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH 0x1242C18
>>> +#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW 0x1242C1C
>>> +#define ACP_WOV_RX_INTR_WATERMARK_SIZE 0x1242C20
>>> +#define ACP_WOV_PDM_FIFO_FLUSH 0x1242C24
>>> +#define ACP_WOV_PDM_NO_OF_CHANNELS 0x1242C28
>>> +#define ACP_WOV_PDM_DECIMATION_FACTOR 0x1242C2C
>>> +#define ACP_WOV_PDM_VAD_CTRL 0x1242C30
>>> +#define ACP_WOV_WAKE 0x1242C54
>>> +#define ACP_WOV_BUFFER_STATUS 0x1242C58
>>> +#define ACP_WOV_MISC_CTRL 0x1242C5C
>>> +#define ACP_WOV_CLK_CTRL 0x1242C60
>>> +#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN 0x1242C64
>>> +#define ACP_WOV_ERROR_STATUS_REGISTER 0x1242C68
>>> +#define ACP_PDM_CLKDIV 0x1242C6C
>>> +
>>> +/* Registers from ACP_P1_AUDIO_BUFFERS block */
>>> +#define ACP_P1_I2S_RX_RINGBUFADDR 0x1243A00
>>> +#define ACP_P1_I2S_RX_RINGBUFSIZE 0x1243A04
>>> +#define ACP_P1_I2S_RX_LINKPOSITIONCNTR 0x1243A08
>>> +#define ACP_P1_I2S_RX_FIFOADDR 0x1243A0C
>>> +#define ACP_P1_I2S_RX_FIFOSIZE 0x1243A10
>>> +#define ACP_P1_I2S_RX_DMA_SIZE 0x1243A14
>>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH 0x1243A18
>>> +#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW 0x1243A1C
>>> +#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE 0x1243A20
>>> +#define ACP_P1_I2S_TX_RINGBUFADDR 0x1243A24
>>> +#define ACP_P1_I2S_TX_RINGBUFSIZE 0x1243A28
>>> +#define ACP_P1_I2S_TX_LINKPOSITIONCNTR 0x1243A2C
>>> +#define ACP_P1_I2S_TX_FIFOADDR 0x1243A30
>>> +#define ACP_P1_I2S_TX_FIFOSIZE 0x1243A34
>>> +#define ACP_P1_I2S_TX_DMA_SIZE 0x1243A38
>>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH 0x1243A3C
>>> +#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW 0x1243A40
>>> +#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE 0x1243A44
>>> +#define ACP_P1_BT_RX_RINGBUFADDR 0x1243A48
>>> +#define ACP_P1_BT_RX_RINGBUFSIZE 0x1243A4C
>>> +#define ACP_P1_BT_RX_LINKPOSITIONCNTR 0x1243A50
>>> +#define ACP_P1_BT_RX_FIFOADDR 0x1243A54
>>> +#define ACP_P1_BT_RX_FIFOSIZE 0x1243A58
>>> +#define ACP_P1_BT_RX_DMA_SIZE 0x1243A5C
>>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH 0x1243A60
>>> +#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW 0x1243A64
>>> +#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE 0x1243A68
>>> +#define ACP_P1_BT_TX_RINGBUFADDR 0x1243A6C
>>> +#define ACP_P1_BT_TX_RINGBUFSIZE 0x1243A70
>>> +#define ACP_P1_BT_TX_LINKPOSITIONCNTR 0x1243A74
>>> +#define ACP_P1_BT_TX_FIFOADDR 0x1243A78
>>> +#define ACP_P1_BT_TX_FIFOSIZE 0x1243A7C
>>> +#define ACP_P1_BT_TX_DMA_SIZE 0x1243A80
>>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH 0x1243A84
>>> +#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW 0x1243A88
>>> +#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE 0x1243A8C
>>> +#define ACP_P1_HS_RX_RINGBUFADDR 0x1243A90
>>> +#define ACP_P1_HS_RX_RINGBUFSIZE 0x1243A94
>>> +#define ACP_P1_HS_RX_LINKPOSITIONCNTR 0x1243A98
>>> +#define ACP_P1_HS_RX_FIFOADDR 0x1243A9C
>>> +#define ACP_P1_HS_RX_FIFOSIZE 0x1243AA0
>>> +#define ACP_P1_HS_RX_DMA_SIZE 0x1243AA4
>>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH 0x1243AA8
>>> +#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW 0x1243AAC
>>> +#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE 0x1243AB0
>>> +#define ACP_P1_HS_TX_RINGBUFADDR 0x1243AB4
>>> +#define ACP_P1_HS_TX_RINGBUFSIZE 0x1243AB8
>>> +#define ACP_P1_HS_TX_LINKPOSITIONCNTR 0x1243ABC
>>> +#define ACP_P1_HS_TX_FIFOADDR 0x1243AC0
>>> +#define ACP_P1_HS_TX_FIFOSIZE 0x1243AC4
>>> +#define ACP_P1_HS_TX_DMA_SIZE 0x1243AC8
>>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH 0x1243ACC
>>> +#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW 0x1243AD0
>>> +#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE 0x1243AD4
>>> +/* Registers from ACP_SCRATCH block */
>>> +#define ACP_SCRATCH_REG_0 0x1250000
>>> +#define ACP_SCRATCH_REG_1 0x1250004
>>> +#define ACP_SCRATCH_REG_2 0x1250008
>>> +#define ACP_SCRATCH_REG_3 0x125000C
>>> +#define ACP_SCRATCH_REG_4 0x1250010
>>> +#define ACP_SCRATCH_REG_5 0x1250014
>>> +#define ACP_SCRATCH_REG_6 0x1250018
>>> +#define ACP_SCRATCH_REG_7 0x125001C
>>> +#define ACP_SCRATCH_REG_8 0x1250020
>>> +#define ACP_SCRATCH_REG_9 0x1250024
>>> +#define ACP_SCRATCH_REG_10 0x1250028
>>> +#define ACP_SCRATCH_REG_11 0x125002C
>>> +#define ACP_SCRATCH_REG_12 0x1250030
>>> +#define ACP_SCRATCH_REG_13 0x1250034
>>> +#define ACP_SCRATCH_REG_14 0x1250038
>>> +#define ACP_SCRATCH_REG_15 0x125003C
>>> +#define ACP_SCRATCH_REG_16 0x1250040
>>> +#define ACP_SCRATCH_REG_17 0x1250044
>>> +#define ACP_SCRATCH_REG_18 0x1250048
>>> +#define ACP_SCRATCH_REG_19 0x125004C
>>> +#define ACP_SCRATCH_REG_20 0x1250050
>>> +#define ACP_SCRATCH_REG_21 0x1250054
>>> +#define ACP_SCRATCH_REG_22 0x1250058
>>> +#define ACP_SCRATCH_REG_23 0x125005C
>>> +#define ACP_SCRATCH_REG_24 0x1250060
>>> +#define ACP_SCRATCH_REG_25 0x1250064
>>> +#define ACP_SCRATCH_REG_26 0x1250068
>>> +#define ACP_SCRATCH_REG_27 0x125006C
>>> +#define ACP_SCRATCH_REG_28 0x1250070
>>> +#define ACP_SCRATCH_REG_29 0x1250074
>>> +#define ACP_SCRATCH_REG_30 0x1250078
>>> +#define ACP_SCRATCH_REG_31 0x125007C
>>> +#define ACP_SCRATCH_REG_32 0x1250080
>>> +#define ACP_SCRATCH_REG_33 0x1250084
>>> +#define ACP_SCRATCH_REG_34 0x1250088
>>> +#define ACP_SCRATCH_REG_35 0x125008C
>>> +#define ACP_SCRATCH_REG_36 0x1250090
>>> +#define ACP_SCRATCH_REG_37 0x1250094
>>> +#define ACP_SCRATCH_REG_38 0x1250098
>>> +#define ACP_SCRATCH_REG_39 0x125009C
>>> +#define ACP_SCRATCH_REG_40 0x12500A0
>>> +#define ACP_SCRATCH_REG_41 0x12500A4
>>> +#define ACP_SCRATCH_REG_42 0x12500A8
>>> +#define ACP_SCRATCH_REG_43 0x12500AC
>>> +#define ACP_SCRATCH_REG_44 0x12500B0
>>> +#define ACP_SCRATCH_REG_45 0x12500B4
>>> +#define ACP_SCRATCH_REG_46 0x12500B8
>>> +#define ACP_SCRATCH_REG_47 0x12500BC
>>> +#define ACP_SCRATCH_REG_48 0x12500C0
>>> +#define ACP_SCRATCH_REG_49 0x12500C4
>>> +#define ACP_SCRATCH_REG_50 0x12500C8
>>> +#define ACP_SCRATCH_REG_51 0x12500CC
>>> +#define ACP_SCRATCH_REG_52 0x12500D0
>>> +#define ACP_SCRATCH_REG_53 0x12500D4
>>> +#define ACP_SCRATCH_REG_54 0x12500D8
>>> +#define ACP_SCRATCH_REG_55 0x12500DC
>>> +#define ACP_SCRATCH_REG_56 0x12500E0
>>> +#define ACP_SCRATCH_REG_57 0x12500E4
>>> +#define ACP_SCRATCH_REG_58 0x12500E8
>>> +#define ACP_SCRATCH_REG_59 0x12500EC
>>> +#define ACP_SCRATCH_REG_60 0x12500F0
>>> +#define ACP_SCRATCH_REG_61 0x12500F4
>>> +#define ACP_SCRATCH_REG_62 0x12500F8
>>> +#define ACP_SCRATCH_REG_63 0x12500FC
>>> +#define ACP_SCRATCH_REG_64 0x1250100
>>> +#define ACP_SCRATCH_REG_65 0x1250104
>>> +#define ACP_SCRATCH_REG_66 0x1250108
>>> +#define ACP_SCRATCH_REG_67 0x125010C
>>> +#define ACP_SCRATCH_REG_68 0x1250110
>>> +#define ACP_SCRATCH_REG_69 0x1250114
>>> +#define ACP_SCRATCH_REG_70 0x1250118
>>> +#define ACP_SCRATCH_REG_71 0x125011C
>>> +#define ACP_SCRATCH_REG_72 0x1250120
>>> +#define ACP_SCRATCH_REG_73 0x1250124
>>> +#define ACP_SCRATCH_REG_74 0x1250128
>>> +#define ACP_SCRATCH_REG_75 0x125012C
>>> +#define ACP_SCRATCH_REG_76 0x1250130
>>> +#define ACP_SCRATCH_REG_77 0x1250134
>>> +#define ACP_SCRATCH_REG_78 0x1250138
>>> +#define ACP_SCRATCH_REG_79 0x125013C
>>> +#define ACP_SCRATCH_REG_80 0x1250140
>>> +#define ACP_SCRATCH_REG_81 0x1250144
>>> +#define ACP_SCRATCH_REG_82 0x1250148
>>> +#define ACP_SCRATCH_REG_83 0x125014C
>>> +#define ACP_SCRATCH_REG_84 0x1250150
>>> +#define ACP_SCRATCH_REG_85 0x1250154
>>> +#define ACP_SCRATCH_REG_86 0x1250158
>>> +#define ACP_SCRATCH_REG_87 0x125015C
>>> +#define ACP_SCRATCH_REG_88 0x1250160
>>> +#define ACP_SCRATCH_REG_89 0x1250164
>>> +#define ACP_SCRATCH_REG_90 0x1250168
>>> +#define ACP_SCRATCH_REG_91 0x125016C
>>> +#define ACP_SCRATCH_REG_92 0x1250170
>>> +#define ACP_SCRATCH_REG_93 0x1250174
>>> +#define ACP_SCRATCH_REG_94 0x1250178
>>> +#define ACP_SCRATCH_REG_95 0x125017C
>>> +#define ACP_SCRATCH_REG_96 0x1250180
>>> +#define ACP_SCRATCH_REG_97 0x1250184
>>> +#define ACP_SCRATCH_REG_98 0x1250188
>>> +#define ACP_SCRATCH_REG_99 0x125018C
>>> +#define ACP_SCRATCH_REG_100 0x1250190
>>> +#define ACP_SCRATCH_REG_101 0x1250194
>>> +#define ACP_SCRATCH_REG_102 0x1250198
>>> +#define ACP_SCRATCH_REG_103 0x125019C
>>> +#define ACP_SCRATCH_REG_104 0x12501A0
>>> +#define ACP_SCRATCH_REG_105 0x12501A4
>>> +#define ACP_SCRATCH_REG_106 0x12501A8
>>> +#define ACP_SCRATCH_REG_107 0x12501AC
>>> +#define ACP_SCRATCH_REG_108 0x12501B0
>>> +#define ACP_SCRATCH_REG_109 0x12501B4
>>> +#define ACP_SCRATCH_REG_110 0x12501B8
>>> +#define ACP_SCRATCH_REG_111 0x12501BC
>>> +#define ACP_SCRATCH_REG_112 0x12501C0
>>> +#define ACP_SCRATCH_REG_113 0x12501C4
>>> +#define ACP_SCRATCH_REG_114 0x12501C8
>>> +#define ACP_SCRATCH_REG_115 0x12501CC
>>> +#define ACP_SCRATCH_REG_116 0x12501D0
>>> +#define ACP_SCRATCH_REG_117 0x12501D4
>>> +#define ACP_SCRATCH_REG_118 0x12501D8
>>> +#define ACP_SCRATCH_REG_119 0x12501DC
>>> +#define ACP_SCRATCH_REG_120 0x12501E0
>>> +#define ACP_SCRATCH_REG_121 0x12501E4
>>> +#define ACP_SCRATCH_REG_122 0x12501E8
>>> +#define ACP_SCRATCH_REG_123 0x12501EC
>>> +#define ACP_SCRATCH_REG_124 0x12501F0
>>> +#define ACP_SCRATCH_REG_125 0x12501F4
>>> +#define ACP_SCRATCH_REG_126 0x12501F8
>>> +#define ACP_SCRATCH_REG_127 0x12501FC
>>> +#define ACP_SCRATCH_REG_128 0x1250200
>>> #endif
>>> --
>>> 2.51.2
>>>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-11 9:22 ` Mukunda,Vijendar
@ 2026-02-11 10:46 ` qby140326
2026-02-11 11:16 ` qby140326
2026-02-11 11:19 ` Mukunda,Vijendar
0 siblings, 2 replies; 19+ messages in thread
From: qby140326 @ 2026-02-11 10:46 UTC (permalink / raw)
To: Mukunda,Vijendar, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Mario Limonciello, Venkata Prasad Potturu,
Dommati, Sunil-kumar
On 2/11/26 17:22, Mukunda,Vijendar wrote:
> There is minor delta between RPL and YC platforms for ACP PDM IO enablement.
> No need to duplicate the code. You can include support for RPL platform in
> yc folder itself. Most of the YC code can be reused.
> We can completely remove the RPL folder itself.
> Add extra checks for ACP PCI revision ID.
Hi Mukunda,
Thanks for the feedback. Could you please elaborate on what the 'minor
delta' specifically entails for the RPL platform compared to YC?
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-11 10:46 ` qby140326
@ 2026-02-11 11:16 ` qby140326
2026-02-11 11:19 ` Mukunda,Vijendar
1 sibling, 0 replies; 19+ messages in thread
From: qby140326 @ 2026-02-11 11:16 UTC (permalink / raw)
To: Mukunda,Vijendar, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Mario Limonciello, Venkata Prasad Potturu,
Dommati, Sunil-kumar
On 2/11/26 18:46, qby140326 wrote:
> On 2/11/26 17:22, Mukunda,Vijendar wrote:
>> There is minor delta between RPL and YC platforms for ACP PDM IO
>> enablement.
>> No need to duplicate the code. You can include support for RPL
>> platform in
>> yc folder itself. Most of the YC code can be reused.
>> We can completely remove the RPL folder itself.
>> Add extra checks for ACP PCI revision ID.
>
> Hi Mukunda,
>
> Thanks for the feedback. Could you please elaborate on what the 'minor
> delta' specifically entails for the RPL platform compared to YC?
Additionally, I'd like to provide some context regarding the current
behavior.
While the driver works correctly on my hardware, other users have
reported encountering I/O errors (for reference, see this report:
https://forum.archlinuxcn.org/t/topic/14050/8
<https://forum.archlinuxcn.org/t/topic/14050/8>).
These are the information the user provided:
Hardware info:
05:00.5 Multimedia controller: Advanced Micro Devices, Inc. [AMD]
ACP/ACP3X/ACP6x Audio Coprocessor (rev 62)
Subsystem: AIstone Global Limited Device 1301
Kernel driver in use: snd_rpl_pci_acp6x
Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x,
snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x, snd_pci_ps,
snd_sof_amd_renoir, snd_sof_amd_rembrandt, snd_sof_amd_vangogh,
snd_sof_amd_acp63, snd_sof_amd_acp70
dmesg:
[ 706.019901] snd_rpl_pci_acp6x: loading out-of-tree module taints kernel.
[ 723.527213] acp_rpl_mach acp_rpl_mach.0: Enabling ACP DMIC support via DMI
arecord log:
# arecord -D hw:3,0 -f S32_LE -r 48000 -c 2 -d 10 /tmp/test.wav
Recording WAVE '/tmp/test.wav' : Signed 32 bit Little Endian, Rate 48000
Hz, Stereo
arecord: pcm_read:2272: read error: Input/output error
And this is my device (Working)'s hardware info:
07:00.5 Multimedia controller: Advanced Micro Devices, Inc. [AMD] Audio
Coprocessor (rev 62)
Subsystem: Lenovo Device 383d
Kernel driver in use: snd_rpl_pci_acp6x
Kernel modules: snd_pci_acp3x, snd_rn_pci_acp3x, snd_pci_acp5x,
snd_pci_acp6x, snd_acp_pci, snd_rpl_pci_acp6x, snd_pci_ps,
snd_sof_amd_renoir, snd_sof_amd_rembrandt, snd_sof_amd_vangogh,
snd_sof_amd_acp63, snd_sof_amd_acp70
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH] ASoC: amd: add DMIC support for RPL platform
2026-02-11 10:46 ` qby140326
2026-02-11 11:16 ` qby140326
@ 2026-02-11 11:19 ` Mukunda,Vijendar
2026-02-11 11:50 ` [PATCH v2] " Mingyou Chen
1 sibling, 1 reply; 19+ messages in thread
From: Mukunda,Vijendar @ 2026-02-11 11:19 UTC (permalink / raw)
To: qby140326, Mark Brown
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, linux-kernel,
linux-sound, Mario Limonciello, Venkata Prasad Potturu,
Dommati, Sunil-kumar
On 11/02/26 16:16, qby140326 wrote:
> On 2/11/26 17:22, Mukunda,Vijendar wrote:
>> There is minor delta between RPL and YC platforms for ACP PDM IO enablement.
>> No need to duplicate the code. You can include support for RPL platform in
>> yc folder itself. Most of the YC code can be reused.
>> We can completely remove the RPL folder itself.
>> Add extra checks for ACP PCI revision ID.
>
> Hi Mukunda,
>
> Thanks for the feedback. Could you please elaborate on what the 'minor delta'
> specifically entails for the RPL platform compared to YC?
>
Except ACP PIN CONFIG values, for PDM IO validation, same YC stack should work.
All you need to do is add ACP PCI revision id for RPL in YC folder and check my
review comment for ACP PIN CONFIG values for RPL platform.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2] ASoC: amd: add DMIC support for RPL platform
2026-02-11 11:19 ` Mukunda,Vijendar
@ 2026-02-11 11:50 ` Mingyou Chen
2026-02-11 15:21 ` Mario Limonciello
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Mingyou Chen @ 2026-02-11 11:50 UTC (permalink / raw)
To: vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, mario.limonciello,
venkataprasad.potturu, Sunil-kumar.Dommati, linux-sound,
linux-kernel, Mingyou Chen
Add DMIC support for the AMD RPL platform. The drivers are derived on
the YC platform driver.
Signed-off-by: Mingyou Chen <qby140326@gmail.com>
---
v2:
- Reverse ACP CONFIG PIN from 10 to 14 for rpl
- Remove the rpl folder
sound/soc/amd/rpl/Makefile | 5 -
sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
.../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
sound/soc/amd/yc/acp6x-mach.c | 7 +
sound/soc/amd/yc/pci-acp6x.c | 6 +
6 files changed, 13 insertions(+), 298 deletions(-)
delete mode 100644 sound/soc/amd/rpl/Makefile
delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
deleted file mode 100644
index a3825c5be4e7..000000000000
--- a/sound/soc/amd/rpl/Makefile
+++ /dev/null
@@ -1,5 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-# RPL platform Support
-snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
-
-obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
deleted file mode 100644
index e3afe9172bdf..000000000000
--- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
+++ /dev/null
@@ -1,227 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * AMD RPL ACP PCI Driver
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#include <linux/pci.h>
-#include <linux/module.h>
-#include <linux/io.h>
-#include <linux/delay.h>
-#include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
-
-#include "rpl_acp6x.h"
-
-struct rpl_dev_data {
- void __iomem *acp6x_base;
-};
-
-static int rpl_power_on(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
-
- if (!val)
- return val;
-
- if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
- rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
- if (!val)
- return 0;
- udelay(1);
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_reset(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
- break;
- cpu_relax();
- }
- rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (!val)
- return 0;
- cpu_relax();
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_init(void __iomem *acp_base)
-{
- int ret;
-
- /* power on */
- ret = rpl_power_on(acp_base);
- if (ret) {
- pr_err("ACP power on failed\n");
- return ret;
- }
- rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
- return 0;
-}
-
-static int rpl_deinit(void __iomem *acp_base)
-{
- int ret;
-
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
- rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
- return 0;
-}
-
-static int snd_rpl_probe(struct pci_dev *pci,
- const struct pci_device_id *pci_id)
-{
- struct rpl_dev_data *adata;
- u32 addr;
- int ret;
-
- /* RPL device check */
- switch (pci->revision) {
- case 0x62:
- break;
- default:
- dev_dbg(&pci->dev, "acp6x pci device not found\n");
- return -ENODEV;
- }
- if (pci_enable_device(pci)) {
- dev_err(&pci->dev, "pci_enable_device failed\n");
- return -ENODEV;
- }
-
- ret = pci_request_regions(pci, "AMD ACP6x audio");
- if (ret < 0) {
- dev_err(&pci->dev, "pci_request_regions failed\n");
- goto disable_pci;
- }
-
- adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
- GFP_KERNEL);
- if (!adata) {
- ret = -ENOMEM;
- goto release_regions;
- }
-
- addr = pci_resource_start(pci, 0);
- adata->acp6x_base = devm_ioremap(&pci->dev, addr,
- pci_resource_len(pci, 0));
- if (!adata->acp6x_base) {
- ret = -ENOMEM;
- goto release_regions;
- }
- pci_set_master(pci);
- pci_set_drvdata(pci, adata);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- goto release_regions;
- pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
- pm_runtime_use_autosuspend(&pci->dev);
- pm_runtime_put_noidle(&pci->dev);
- pm_runtime_allow(&pci->dev);
-
- return 0;
-release_regions:
- pci_release_regions(pci);
-disable_pci:
- pci_disable_device(pci);
-
- return ret;
-}
-
-static int snd_rpl_suspend(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP de-init failed\n");
- return ret;
-}
-
-static int snd_rpl_resume(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP init failed\n");
- return ret;
-}
-
-static const struct dev_pm_ops rpl_pm = {
- RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
- SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
-};
-
-static void snd_rpl_remove(struct pci_dev *pci)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = pci_get_drvdata(pci);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(&pci->dev, "ACP de-init failed\n");
- pm_runtime_forbid(&pci->dev);
- pm_runtime_get_noresume(&pci->dev);
- pci_release_regions(pci);
- pci_disable_device(pci);
-}
-
-static const struct pci_device_id snd_rpl_ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
- .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
- .class_mask = 0xffffff },
- { 0, },
-};
-MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
-
-static struct pci_driver rpl_acp6x_driver = {
- .name = KBUILD_MODNAME,
- .id_table = snd_rpl_ids,
- .probe = snd_rpl_probe,
- .remove = snd_rpl_remove,
- .driver = {
- .pm = pm_ptr(&rpl_pm),
- }
-};
-
-module_pci_driver(rpl_acp6x_driver);
-
-MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
-MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
deleted file mode 100644
index f5816a33632e..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP Driver
- *
- * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
- */
-
-#include "rpl_acp6x_chip_offset_byte.h"
-
-#define ACP_DEVICE_ID 0x15E2
-#define ACP6x_PHY_BASE_ADDRESS 0x1240000
-
-#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
-#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
-#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
-#define ACP_PGFSM_STATUS_MASK 3
-#define ACP_POWERED_ON 0
-#define ACP_POWER_ON_IN_PROGRESS 1
-#define ACP_POWERED_OFF 2
-#define ACP_POWER_OFF_IN_PROGRESS 3
-
-#define DELAY_US 5
-#define ACP_COUNTER 20000
-
-/* time in ms for runtime suspend delay */
-#define ACP_SUSPEND_DELAY_MS 2000
-
-static inline u32 rpl_acp_readl(void __iomem *base_addr)
-{
- return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
-
-static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
-{
- writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
deleted file mode 100644
index 456498f5396d..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP 6.2 Register Documentation
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#ifndef _rpl_acp6x_OFFSET_HEADER
-#define _rpl_acp6x_OFFSET_HEADER
-
-/* Registers from ACP_CLKRST block */
-#define ACP_SOFT_RESET 0x1241000
-#define ACP_CONTROL 0x1241004
-#define ACP_STATUS 0x1241008
-#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
-#define ACP_PGFSM_CONTROL 0x124101C
-#define ACP_PGFSM_STATUS 0x1241020
-#define ACP_CLKMUX_SEL 0x1241024
-
-/* Registers from ACP_AON block */
-#define ACP_PME_EN 0x1241400
-#define ACP_DEVICE_STATE 0x1241404
-#define AZ_DEVICE_STATE 0x1241408
-#define ACP_PIN_CONFIG 0x1241440
-#define ACP_PAD_PULLUP_CTRL 0x1241444
-#define ACP_PAD_PULLDOWN_CTRL 0x1241448
-#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
-#define ACP_PAD_SCHMEN_CTRL 0x1241450
-
-#endif
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0294177acc66..de49c812124a 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
};
static const struct dmi_system_id yc_acp_quirk_table[] = {
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 1140ed1cbb3d..296b74252a8a 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -163,6 +163,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
switch (pci->revision) {
case 0x60:
case 0x6f:
+ case 0x62: /* RPL */
break;
default:
dev_dbg(&pci->dev, "acp6x pci device not found\n");
@@ -205,6 +206,11 @@ static int snd_acp6x_probe(struct pci_dev *pci,
case ACP_CONFIG_2:
case ACP_CONFIG_3:
case ACP_CONFIG_9:
+ case ACP_CONFIG_10: /* Reserved for RPL */
+ case ACP_CONFIG_11: /* Reserved for RPL */
+ case ACP_CONFIG_12: /* Reserved for RPL */
+ case ACP_CONFIG_13: /* Reserved for RPL */
+ case ACP_CONFIG_14: /* Reserved for RPL */
case ACP_CONFIG_15:
dev_info(&pci->dev, "Audio Mode %d\n", val);
break;
base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377
--
2.51.2
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
2026-02-11 11:50 ` [PATCH v2] " Mingyou Chen
@ 2026-02-11 15:21 ` Mario Limonciello
2026-02-12 1:42 ` qby140326
2026-02-11 17:13 ` [PATCH v2] " kernel test robot
2026-02-11 22:35 ` kernel test robot
2 siblings, 1 reply; 19+ messages in thread
From: Mario Limonciello @ 2026-02-11 15:21 UTC (permalink / raw)
To: Mingyou Chen, vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, venkataprasad.potturu,
Sunil-kumar.Dommati, linux-sound, linux-kernel
On 2/11/26 5:50 AM, Mingyou Chen wrote:
> Add DMIC support for the AMD RPL platform. The drivers are derived on
> the YC platform driver.
>
> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
> ---
> v2:
> - Reverse ACP CONFIG PIN from 10 to 14 for rpl
> - Remove the rpl folder
>
> sound/soc/amd/rpl/Makefile | 5 -
> sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
> sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +
> sound/soc/amd/yc/pci-acp6x.c | 6 +
> 6 files changed, 13 insertions(+), 298 deletions(-)
> delete mode 100644 sound/soc/amd/rpl/Makefile
> delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
Your diff should be relative to sound.git, not relative to your last patch.
That means you shouldn't be "deleting the rpl directory" because it
isn't there in upstream.
On your local tree you can probably just rebase to drop it or revert it.
>
> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
> deleted file mode 100644
> index a3825c5be4e7..000000000000
> --- a/sound/soc/amd/rpl/Makefile
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0+
> -# RPL platform Support
> -snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
> -
> -obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
> deleted file mode 100644
> index e3afe9172bdf..000000000000
> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
> +++ /dev/null
> @@ -1,227 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> - * AMD RPL ACP PCI Driver
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#include <linux/pci.h>
> -#include <linux/module.h>
> -#include <linux/io.h>
> -#include <linux/delay.h>
> -#include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
> -
> -#include "rpl_acp6x.h"
> -
> -struct rpl_dev_data {
> - void __iomem *acp6x_base;
> -};
> -
> -static int rpl_power_on(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> -
> - if (!val)
> - return val;
> -
> - if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
> - rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> - if (!val)
> - return 0;
> - udelay(1);
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_reset(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
> - break;
> - cpu_relax();
> - }
> - rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (!val)
> - return 0;
> - cpu_relax();
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_init(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* power on */
> - ret = rpl_power_on(acp_base);
> - if (ret) {
> - pr_err("ACP power on failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
> - return 0;
> -}
> -
> -static int rpl_deinit(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
> - rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
> - return 0;
> -}
> -
> -static int snd_rpl_probe(struct pci_dev *pci,
> - const struct pci_device_id *pci_id)
> -{
> - struct rpl_dev_data *adata;
> - u32 addr;
> - int ret;
> -
> - /* RPL device check */
> - switch (pci->revision) {
> - case 0x62:
> - break;
> - default:
> - dev_dbg(&pci->dev, "acp6x pci device not found\n");
> - return -ENODEV;
> - }
> - if (pci_enable_device(pci)) {
> - dev_err(&pci->dev, "pci_enable_device failed\n");
> - return -ENODEV;
> - }
> -
> - ret = pci_request_regions(pci, "AMD ACP6x audio");
> - if (ret < 0) {
> - dev_err(&pci->dev, "pci_request_regions failed\n");
> - goto disable_pci;
> - }
> -
> - adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
> - GFP_KERNEL);
> - if (!adata) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> -
> - addr = pci_resource_start(pci, 0);
> - adata->acp6x_base = devm_ioremap(&pci->dev, addr,
> - pci_resource_len(pci, 0));
> - if (!adata->acp6x_base) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> - pci_set_master(pci);
> - pci_set_drvdata(pci, adata);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - goto release_regions;
> - pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
> - pm_runtime_use_autosuspend(&pci->dev);
> - pm_runtime_put_noidle(&pci->dev);
> - pm_runtime_allow(&pci->dev);
> -
> - return 0;
> -release_regions:
> - pci_release_regions(pci);
> -disable_pci:
> - pci_disable_device(pci);
> -
> - return ret;
> -}
> -
> -static int snd_rpl_suspend(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP de-init failed\n");
> - return ret;
> -}
> -
> -static int snd_rpl_resume(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP init failed\n");
> - return ret;
> -}
> -
> -static const struct dev_pm_ops rpl_pm = {
> - RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
> - SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
> -};
> -
> -static void snd_rpl_remove(struct pci_dev *pci)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = pci_get_drvdata(pci);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(&pci->dev, "ACP de-init failed\n");
> - pm_runtime_forbid(&pci->dev);
> - pm_runtime_get_noresume(&pci->dev);
> - pci_release_regions(pci);
> - pci_disable_device(pci);
> -}
> -
> -static const struct pci_device_id snd_rpl_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
> - .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
> - .class_mask = 0xffffff },
> - { 0, },
> -};
> -MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
> -
> -static struct pci_driver rpl_acp6x_driver = {
> - .name = KBUILD_MODNAME,
> - .id_table = snd_rpl_ids,
> - .probe = snd_rpl_probe,
> - .remove = snd_rpl_remove,
> - .driver = {
> - .pm = pm_ptr(&rpl_pm),
> - }
> -};
> -
> -module_pci_driver(rpl_acp6x_driver);
> -
> -MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
> deleted file mode 100644
> index f5816a33632e..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x.h
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP Driver
> - *
> - * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
> - */
> -
> -#include "rpl_acp6x_chip_offset_byte.h"
> -
> -#define ACP_DEVICE_ID 0x15E2
> -#define ACP6x_PHY_BASE_ADDRESS 0x1240000
> -
> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
> -#define ACP_PGFSM_STATUS_MASK 3
> -#define ACP_POWERED_ON 0
> -#define ACP_POWER_ON_IN_PROGRESS 1
> -#define ACP_POWERED_OFF 2
> -#define ACP_POWER_OFF_IN_PROGRESS 3
> -
> -#define DELAY_US 5
> -#define ACP_COUNTER 20000
> -
> -/* time in ms for runtime suspend delay */
> -#define ACP_SUSPEND_DELAY_MS 2000
> -
> -static inline u32 rpl_acp_readl(void __iomem *base_addr)
> -{
> - return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> -
> -static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
> -{
> - writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> deleted file mode 100644
> index 456498f5396d..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP 6.2 Register Documentation
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#ifndef _rpl_acp6x_OFFSET_HEADER
> -#define _rpl_acp6x_OFFSET_HEADER
> -
> -/* Registers from ACP_CLKRST block */
> -#define ACP_SOFT_RESET 0x1241000
> -#define ACP_CONTROL 0x1241004
> -#define ACP_STATUS 0x1241008
> -#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
> -#define ACP_PGFSM_CONTROL 0x124101C
> -#define ACP_PGFSM_STATUS 0x1241020
> -#define ACP_CLKMUX_SEL 0x1241024
> -
> -/* Registers from ACP_AON block */
> -#define ACP_PME_EN 0x1241400
> -#define ACP_DEVICE_STATE 0x1241404
> -#define AZ_DEVICE_STATE 0x1241408
> -#define ACP_PIN_CONFIG 0x1241440
> -#define ACP_PAD_PULLUP_CTRL 0x1241444
> -#define ACP_PAD_PULLDOWN_CTRL 0x1241448
> -#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
> -#define ACP_PAD_SCHMEN_CTRL 0x1241450
> -
> -#endif
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0294177acc66..de49c812124a 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
> };
>
> static const struct dmi_system_id yc_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 1140ed1cbb3d..296b74252a8a 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -163,6 +163,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> switch (pci->revision) {
> case 0x60:
> case 0x6f:
> + case 0x62: /* RPL */
> break;
> default:
> dev_dbg(&pci->dev, "acp6x pci device not found\n");
> @@ -205,6 +206,11 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> case ACP_CONFIG_2:
> case ACP_CONFIG_3:
> case ACP_CONFIG_9:
> + case ACP_CONFIG_10: /* Reserved for RPL */
> + case ACP_CONFIG_11: /* Reserved for RPL */
> + case ACP_CONFIG_12: /* Reserved for RPL */
> + case ACP_CONFIG_13: /* Reserved for RPL */
> + case ACP_CONFIG_14: /* Reserved for RPL */
> case ACP_CONFIG_15:
> dev_info(&pci->dev, "Audio Mode %d\n", val);
> break;
>
> base-commit: 63804fed149a6750ffd28610c5c1c98cce6bd377
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
2026-02-11 11:50 ` [PATCH v2] " Mingyou Chen
2026-02-11 15:21 ` Mario Limonciello
@ 2026-02-11 17:13 ` kernel test robot
2026-02-11 22:35 ` kernel test robot
2 siblings, 0 replies; 19+ messages in thread
From: kernel test robot @ 2026-02-11 17:13 UTC (permalink / raw)
To: Mingyou Chen, vijendar.mukunda
Cc: oe-kbuild-all, broonie, lgirdwood, perex, tiwai,
mario.limonciello, venkataprasad.potturu, Sunil-kumar.Dommati,
linux-sound, linux-kernel, Mingyou Chen
Hi Mingyou,
kernel test robot noticed the following build errors:
[auto build test ERROR on 63804fed149a6750ffd28610c5c1c98cce6bd377]
url: https://github.com/intel-lab-lkp/linux/commits/Mingyou-Chen/ASoC-amd-add-DMIC-support-for-RPL-platform/20260211-195242
base: 63804fed149a6750ffd28610c5c1c98cce6bd377
patch link: https://lore.kernel.org/r/20260211115008.100239-1-qby140326%40gmail.com
patch subject: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
config: sh-allnoconfig (https://download.01.org/0day-ci/archive/20260212/202602120150.0yxjhYKZ-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260212/202602120150.0yxjhYKZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602120150.0yxjhYKZ-lkp@intel.com/
All errors (new ones prefixed by >>):
>> scripts/Makefile.clean:12: sound/soc/amd/rpl/Makefile: No such file or directory
>> make[7]: *** No rule to make target 'sound/soc/amd/rpl/Makefile'.
scripts/Makefile.clean:12: Failed to remake makefile 'sound/soc/amd/rpl/Makefile'.
make[6]: *** [scripts/Makefile.clean:61: sound/soc/amd/rpl] Error 2
make[6]: Target '__clean' not remade because of errors.
make[5]: *** [scripts/Makefile.clean:61: sound/soc/amd] Error 2
make[5]: Target '__clean' not remade because of errors.
make[4]: *** [scripts/Makefile.clean:61: sound/soc] Error 2
make[4]: Target '__clean' not remade because of errors.
make[3]: *** [scripts/Makefile.clean:61: sound] Error 2
make[3]: Target '__clean' not remade because of errors.
make[2]: *** [Makefile:2059: _clean_.] Error 2
make[2]: Target 'distclean' not remade because of errors.
make[1]: *** [Makefile:248: __sub-make] Error 2
make[1]: Target 'distclean' not remade because of errors.
make: *** [Makefile:248: __sub-make] Error 2
make: Target 'distclean' not remade because of errors.
vim +12 scripts/Makefile.clean
^1da177e4c3f41 Linus Torvalds 2005-04-16 7
4f1933620f5714 Paul Smith 2006-03-05 8 PHONY := __clean
^1da177e4c3f41 Linus Torvalds 2005-04-16 9 __clean:
^1da177e4c3f41 Linus Torvalds 2005-04-16 10
3204a7fb98a3bc Masahiro Yamada 2021-02-28 11 include $(srctree)/scripts/Kbuild.include
a2430b25c31840 Masahiro Yamada 2022-11-19 @12 include $(kbuild-file)
^1da177e4c3f41 Linus Torvalds 2005-04-16 13
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
2026-02-11 11:50 ` [PATCH v2] " Mingyou Chen
2026-02-11 15:21 ` Mario Limonciello
2026-02-11 17:13 ` [PATCH v2] " kernel test robot
@ 2026-02-11 22:35 ` kernel test robot
2 siblings, 0 replies; 19+ messages in thread
From: kernel test robot @ 2026-02-11 22:35 UTC (permalink / raw)
To: Mingyou Chen, vijendar.mukunda
Cc: oe-kbuild-all, broonie, lgirdwood, perex, tiwai,
mario.limonciello, venkataprasad.potturu, Sunil-kumar.Dommati,
linux-sound, linux-kernel, Mingyou Chen
Hi Mingyou,
kernel test robot noticed the following build errors:
[auto build test ERROR on 63804fed149a6750ffd28610c5c1c98cce6bd377]
url: https://github.com/intel-lab-lkp/linux/commits/Mingyou-Chen/ASoC-amd-add-DMIC-support-for-RPL-platform/20260211-195242
base: 63804fed149a6750ffd28610c5c1c98cce6bd377
patch link: https://lore.kernel.org/r/20260211115008.100239-1-qby140326%40gmail.com
patch subject: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
config: x86_64-buildonly-randconfig-002-20260211 (https://download.01.org/0day-ci/archive/20260212/202602120639.za1Vo64M-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260212/202602120639.za1Vo64M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602120639.za1Vo64M-lkp@intel.com/
All errors (new ones prefixed by >>):
>> scripts/Makefile.build:37: sound/soc/amd/rpl/Makefile: No such file or directory
make[7]: *** No rule to make target 'sound/soc/amd/rpl/Makefile'.
scripts/Makefile.build:37: Failed to remake makefile 'sound/soc/amd/rpl/Makefile'.
vim +37 scripts/Makefile.build
^1da177e4c3f41 Linus Torvalds 2005-04-16 34
3204a7fb98a3bc Masahiro Yamada 2021-02-28 35 include $(srctree)/scripts/Kbuild.include
57fd251c789647 Masahiro Yamada 2021-02-28 36 include $(srctree)/scripts/Makefile.compiler
a2430b25c31840 Masahiro Yamada 2022-11-19 @37 include $(kbuild-file)
3204a7fb98a3bc Masahiro Yamada 2021-02-28 38 include $(srctree)/scripts/Makefile.lib
^1da177e4c3f41 Linus Torvalds 2005-04-16 39
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2] ASoC: amd: add DMIC support for RPL platform
2026-02-11 15:21 ` Mario Limonciello
@ 2026-02-12 1:42 ` qby140326
2026-02-12 1:46 ` [PATCH v3] " Mingyou Chen
0 siblings, 1 reply; 19+ messages in thread
From: qby140326 @ 2026-02-12 1:42 UTC (permalink / raw)
To: Mario Limonciello, vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, venkataprasad.potturu,
Sunil-kumar.Dommati, linux-sound, linux-kernel
On 2/11/26 23:21, Mario Limonciello wrote:
> Your diff should be relative to sound.git, not relative to your last
> patch.
>
> That means you shouldn't be "deleting the rpl directory" because it
> isn't there in upstream.
>
> On your local tree you can probably just rebase to drop it or revert it.
Hi Mario,
Regarding the sound/soc/amd/rpl directory, I believe it actually exists
in the current upstream sound.git (and mainline). You can find it here:
sound/soc/amd/rpl/
The goal of this patch is to follow the suggestion from Vijendar Mukunda
to consolidate the RPL support into the yc driver, as they share very
similar logic. By doing this, we can completely remove the redundant rpl
folder to simplify the codebase.
PS: I noticed the Makefile and Kconfig problem, I'll create the v3 patch
shortly to ensure everything builds correctly.
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v3] ASoC: amd: add DMIC support for RPL platform
2026-02-12 1:42 ` qby140326
@ 2026-02-12 1:46 ` Mingyou Chen
2026-02-12 5:13 ` Mukunda,Vijendar
0 siblings, 1 reply; 19+ messages in thread
From: Mingyou Chen @ 2026-02-12 1:46 UTC (permalink / raw)
To: vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, mario.limonciello,
venkataprasad.potturu, Sunil-kumar.Dommati, linux-sound,
linux-kernel, Mingyou Chen
Add DMIC support for the AMD RPL platform. The drivers are derived on
the YC platform driver.
Signed-off-by: Mingyou Chen <qby140326@gmail.com>
---
v2:
- Reverse ACP CONFIG PIN from 10 to 14 for rpl
- Remove the rpl folder
v3:
- Remove rpl configuration from Kconfig and Makefile
sound/soc/amd/Kconfig | 10 -
sound/soc/amd/Makefile | 1 -
sound/soc/amd/rpl/Makefile | 5 -
sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
.../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
sound/soc/amd/yc/acp6x-mach.c | 7 +
sound/soc/amd/yc/pci-acp6x.c | 6 +
8 files changed, 13 insertions(+), 309 deletions(-)
delete mode 100644 sound/soc/amd/rpl/Makefile
delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index fd35a03aadcb..a6eecbe12e84 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -124,16 +124,6 @@ config SND_AMD_ACP_CONFIG
source "sound/soc/amd/acp/Kconfig"
-config SND_SOC_AMD_RPL_ACP6x
- tristate "AMD Audio Coprocessor-v6.2 RPL support"
- depends on X86 && PCI
- help
- This option enables Audio Coprocessor i.e. ACP v6.2 support on
- AMD RPL platform. By enabling this flag build will be
- triggered for ACP PCI driver.
- Say m if you have such a device.
- If unsure select "N".
-
config SND_SOC_AMD_ACP63_TOPLEVEL
tristate "support for AMD platforms with ACP version >= 6.3"
default SND_AMD_ACP_CONFIG
diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
index 4f89d962cce2..23b25ff0d800 100644
--- a/sound/soc/amd/Makefile
+++ b/sound/soc/amd/Makefile
@@ -17,5 +17,4 @@ obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
obj-$(CONFIG_SND_AMD_ACP_CONFIG) += acp/
obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
-obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
obj-$(CONFIG_SND_SOC_AMD_PS) += ps/
diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
deleted file mode 100644
index a3825c5be4e7..000000000000
--- a/sound/soc/amd/rpl/Makefile
+++ /dev/null
@@ -1,5 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-# RPL platform Support
-snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
-
-obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
deleted file mode 100644
index e3afe9172bdf..000000000000
--- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
+++ /dev/null
@@ -1,227 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * AMD RPL ACP PCI Driver
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#include <linux/pci.h>
-#include <linux/module.h>
-#include <linux/io.h>
-#include <linux/delay.h>
-#include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
-
-#include "rpl_acp6x.h"
-
-struct rpl_dev_data {
- void __iomem *acp6x_base;
-};
-
-static int rpl_power_on(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
-
- if (!val)
- return val;
-
- if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
- rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
- if (!val)
- return 0;
- udelay(1);
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_reset(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
- break;
- cpu_relax();
- }
- rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (!val)
- return 0;
- cpu_relax();
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_init(void __iomem *acp_base)
-{
- int ret;
-
- /* power on */
- ret = rpl_power_on(acp_base);
- if (ret) {
- pr_err("ACP power on failed\n");
- return ret;
- }
- rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
- return 0;
-}
-
-static int rpl_deinit(void __iomem *acp_base)
-{
- int ret;
-
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
- rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
- return 0;
-}
-
-static int snd_rpl_probe(struct pci_dev *pci,
- const struct pci_device_id *pci_id)
-{
- struct rpl_dev_data *adata;
- u32 addr;
- int ret;
-
- /* RPL device check */
- switch (pci->revision) {
- case 0x62:
- break;
- default:
- dev_dbg(&pci->dev, "acp6x pci device not found\n");
- return -ENODEV;
- }
- if (pci_enable_device(pci)) {
- dev_err(&pci->dev, "pci_enable_device failed\n");
- return -ENODEV;
- }
-
- ret = pci_request_regions(pci, "AMD ACP6x audio");
- if (ret < 0) {
- dev_err(&pci->dev, "pci_request_regions failed\n");
- goto disable_pci;
- }
-
- adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
- GFP_KERNEL);
- if (!adata) {
- ret = -ENOMEM;
- goto release_regions;
- }
-
- addr = pci_resource_start(pci, 0);
- adata->acp6x_base = devm_ioremap(&pci->dev, addr,
- pci_resource_len(pci, 0));
- if (!adata->acp6x_base) {
- ret = -ENOMEM;
- goto release_regions;
- }
- pci_set_master(pci);
- pci_set_drvdata(pci, adata);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- goto release_regions;
- pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
- pm_runtime_use_autosuspend(&pci->dev);
- pm_runtime_put_noidle(&pci->dev);
- pm_runtime_allow(&pci->dev);
-
- return 0;
-release_regions:
- pci_release_regions(pci);
-disable_pci:
- pci_disable_device(pci);
-
- return ret;
-}
-
-static int snd_rpl_suspend(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP de-init failed\n");
- return ret;
-}
-
-static int snd_rpl_resume(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP init failed\n");
- return ret;
-}
-
-static const struct dev_pm_ops rpl_pm = {
- RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
- SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
-};
-
-static void snd_rpl_remove(struct pci_dev *pci)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = pci_get_drvdata(pci);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(&pci->dev, "ACP de-init failed\n");
- pm_runtime_forbid(&pci->dev);
- pm_runtime_get_noresume(&pci->dev);
- pci_release_regions(pci);
- pci_disable_device(pci);
-}
-
-static const struct pci_device_id snd_rpl_ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
- .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
- .class_mask = 0xffffff },
- { 0, },
-};
-MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
-
-static struct pci_driver rpl_acp6x_driver = {
- .name = KBUILD_MODNAME,
- .id_table = snd_rpl_ids,
- .probe = snd_rpl_probe,
- .remove = snd_rpl_remove,
- .driver = {
- .pm = pm_ptr(&rpl_pm),
- }
-};
-
-module_pci_driver(rpl_acp6x_driver);
-
-MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
-MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
deleted file mode 100644
index f5816a33632e..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP Driver
- *
- * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
- */
-
-#include "rpl_acp6x_chip_offset_byte.h"
-
-#define ACP_DEVICE_ID 0x15E2
-#define ACP6x_PHY_BASE_ADDRESS 0x1240000
-
-#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
-#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
-#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
-#define ACP_PGFSM_STATUS_MASK 3
-#define ACP_POWERED_ON 0
-#define ACP_POWER_ON_IN_PROGRESS 1
-#define ACP_POWERED_OFF 2
-#define ACP_POWER_OFF_IN_PROGRESS 3
-
-#define DELAY_US 5
-#define ACP_COUNTER 20000
-
-/* time in ms for runtime suspend delay */
-#define ACP_SUSPEND_DELAY_MS 2000
-
-static inline u32 rpl_acp_readl(void __iomem *base_addr)
-{
- return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
-
-static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
-{
- writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
deleted file mode 100644
index 456498f5396d..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP 6.2 Register Documentation
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#ifndef _rpl_acp6x_OFFSET_HEADER
-#define _rpl_acp6x_OFFSET_HEADER
-
-/* Registers from ACP_CLKRST block */
-#define ACP_SOFT_RESET 0x1241000
-#define ACP_CONTROL 0x1241004
-#define ACP_STATUS 0x1241008
-#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
-#define ACP_PGFSM_CONTROL 0x124101C
-#define ACP_PGFSM_STATUS 0x1241020
-#define ACP_CLKMUX_SEL 0x1241024
-
-/* Registers from ACP_AON block */
-#define ACP_PME_EN 0x1241400
-#define ACP_DEVICE_STATE 0x1241404
-#define AZ_DEVICE_STATE 0x1241408
-#define ACP_PIN_CONFIG 0x1241440
-#define ACP_PAD_PULLUP_CTRL 0x1241444
-#define ACP_PAD_PULLDOWN_CTRL 0x1241448
-#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
-#define ACP_PAD_SCHMEN_CTRL 0x1241450
-
-#endif
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0294177acc66..de49c812124a 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
};
static const struct dmi_system_id yc_acp_quirk_table[] = {
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 1140ed1cbb3d..296b74252a8a 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -163,6 +163,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
switch (pci->revision) {
case 0x60:
case 0x6f:
+ case 0x62: /* RPL */
break;
default:
dev_dbg(&pci->dev, "acp6x pci device not found\n");
@@ -205,6 +206,11 @@ static int snd_acp6x_probe(struct pci_dev *pci,
case ACP_CONFIG_2:
case ACP_CONFIG_3:
case ACP_CONFIG_9:
+ case ACP_CONFIG_10: /* Reserved for RPL */
+ case ACP_CONFIG_11: /* Reserved for RPL */
+ case ACP_CONFIG_12: /* Reserved for RPL */
+ case ACP_CONFIG_13: /* Reserved for RPL */
+ case ACP_CONFIG_14: /* Reserved for RPL */
case ACP_CONFIG_15:
dev_info(&pci->dev, "Audio Mode %d\n", val);
break;
--
2.51.2
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v3] ASoC: amd: add DMIC support for RPL platform
2026-02-12 1:46 ` [PATCH v3] " Mingyou Chen
@ 2026-02-12 5:13 ` Mukunda,Vijendar
2026-02-12 11:15 ` [PATCH v4] " Mingyou Chen
0 siblings, 1 reply; 19+ messages in thread
From: Mukunda,Vijendar @ 2026-02-12 5:13 UTC (permalink / raw)
To: Mingyou Chen
Cc: broonie, lgirdwood, perex, tiwai, mario.limonciello,
venkataprasad.potturu, Sunil-kumar.Dommati, linux-sound,
linux-kernel
On 12/02/26 07:16, Mingyou Chen wrote:
> Add DMIC support for the AMD RPL platform. The drivers are derived on
> the YC platform driver.
>
> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
> ---
> v2:
> - Reverse ACP CONFIG PIN from 10 to 14 for rpl
> - Remove the rpl folder
> v3:
> - Remove rpl configuration from Kconfig and Makefile
>
> sound/soc/amd/Kconfig | 10 -
> sound/soc/amd/Makefile | 1 -
> sound/soc/amd/rpl/Makefile | 5 -
> sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
> sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +
> sound/soc/amd/yc/pci-acp6x.c | 6 +
> 8 files changed, 13 insertions(+), 309 deletions(-)
> delete mode 100644 sound/soc/amd/rpl/Makefile
> delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index fd35a03aadcb..a6eecbe12e84 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -124,16 +124,6 @@ config SND_AMD_ACP_CONFIG
>
> source "sound/soc/amd/acp/Kconfig"
>
> -config SND_SOC_AMD_RPL_ACP6x
> - tristate "AMD Audio Coprocessor-v6.2 RPL support"
> - depends on X86 && PCI
> - help
> - This option enables Audio Coprocessor i.e. ACP v6.2 support on
> - AMD RPL platform. By enabling this flag build will be
> - triggered for ACP PCI driver.
> - Say m if you have such a device.
> - If unsure select "N".
> -
> config SND_SOC_AMD_ACP63_TOPLEVEL
> tristate "support for AMD platforms with ACP version >= 6.3"
> default SND_AMD_ACP_CONFIG
> diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
> index 4f89d962cce2..23b25ff0d800 100644
> --- a/sound/soc/amd/Makefile
> +++ b/sound/soc/amd/Makefile
> @@ -17,5 +17,4 @@ obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
> obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
> obj-$(CONFIG_SND_AMD_ACP_CONFIG) += acp/
> obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
> -obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
> obj-$(CONFIG_SND_SOC_AMD_PS) += ps/
> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
> deleted file mode 100644
> index a3825c5be4e7..000000000000
> --- a/sound/soc/amd/rpl/Makefile
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0+
> -# RPL platform Support
> -snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
> -
> -obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
> deleted file mode 100644
> index e3afe9172bdf..000000000000
> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
> +++ /dev/null
> @@ -1,227 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> - * AMD RPL ACP PCI Driver
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#include <linux/pci.h>
> -#include <linux/module.h>
> -#include <linux/io.h>
> -#include <linux/delay.h>
> -#include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
> -
> -#include "rpl_acp6x.h"
> -
> -struct rpl_dev_data {
> - void __iomem *acp6x_base;
> -};
> -
> -static int rpl_power_on(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> -
> - if (!val)
> - return val;
> -
> - if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
> - rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> - if (!val)
> - return 0;
> - udelay(1);
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_reset(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
> - break;
> - cpu_relax();
> - }
> - rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (!val)
> - return 0;
> - cpu_relax();
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_init(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* power on */
> - ret = rpl_power_on(acp_base);
> - if (ret) {
> - pr_err("ACP power on failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
> - return 0;
> -}
> -
> -static int rpl_deinit(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
> - rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
> - return 0;
> -}
> -
> -static int snd_rpl_probe(struct pci_dev *pci,
> - const struct pci_device_id *pci_id)
> -{
> - struct rpl_dev_data *adata;
> - u32 addr;
> - int ret;
> -
> - /* RPL device check */
> - switch (pci->revision) {
> - case 0x62:
> - break;
> - default:
> - dev_dbg(&pci->dev, "acp6x pci device not found\n");
> - return -ENODEV;
> - }
> - if (pci_enable_device(pci)) {
> - dev_err(&pci->dev, "pci_enable_device failed\n");
> - return -ENODEV;
> - }
> -
> - ret = pci_request_regions(pci, "AMD ACP6x audio");
> - if (ret < 0) {
> - dev_err(&pci->dev, "pci_request_regions failed\n");
> - goto disable_pci;
> - }
> -
> - adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
> - GFP_KERNEL);
> - if (!adata) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> -
> - addr = pci_resource_start(pci, 0);
> - adata->acp6x_base = devm_ioremap(&pci->dev, addr,
> - pci_resource_len(pci, 0));
> - if (!adata->acp6x_base) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> - pci_set_master(pci);
> - pci_set_drvdata(pci, adata);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - goto release_regions;
> - pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
> - pm_runtime_use_autosuspend(&pci->dev);
> - pm_runtime_put_noidle(&pci->dev);
> - pm_runtime_allow(&pci->dev);
> -
> - return 0;
> -release_regions:
> - pci_release_regions(pci);
> -disable_pci:
> - pci_disable_device(pci);
> -
> - return ret;
> -}
> -
> -static int snd_rpl_suspend(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP de-init failed\n");
> - return ret;
> -}
> -
> -static int snd_rpl_resume(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP init failed\n");
> - return ret;
> -}
> -
> -static const struct dev_pm_ops rpl_pm = {
> - RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
> - SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
> -};
> -
> -static void snd_rpl_remove(struct pci_dev *pci)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = pci_get_drvdata(pci);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(&pci->dev, "ACP de-init failed\n");
> - pm_runtime_forbid(&pci->dev);
> - pm_runtime_get_noresume(&pci->dev);
> - pci_release_regions(pci);
> - pci_disable_device(pci);
> -}
> -
> -static const struct pci_device_id snd_rpl_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
> - .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
> - .class_mask = 0xffffff },
> - { 0, },
> -};
> -MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
> -
> -static struct pci_driver rpl_acp6x_driver = {
> - .name = KBUILD_MODNAME,
> - .id_table = snd_rpl_ids,
> - .probe = snd_rpl_probe,
> - .remove = snd_rpl_remove,
> - .driver = {
> - .pm = pm_ptr(&rpl_pm),
> - }
> -};
> -
> -module_pci_driver(rpl_acp6x_driver);
> -
> -MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
> deleted file mode 100644
> index f5816a33632e..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x.h
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP Driver
> - *
> - * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
> - */
> -
> -#include "rpl_acp6x_chip_offset_byte.h"
> -
> -#define ACP_DEVICE_ID 0x15E2
> -#define ACP6x_PHY_BASE_ADDRESS 0x1240000
> -
> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
> -#define ACP_PGFSM_STATUS_MASK 3
> -#define ACP_POWERED_ON 0
> -#define ACP_POWER_ON_IN_PROGRESS 1
> -#define ACP_POWERED_OFF 2
> -#define ACP_POWER_OFF_IN_PROGRESS 3
> -
> -#define DELAY_US 5
> -#define ACP_COUNTER 20000
> -
> -/* time in ms for runtime suspend delay */
> -#define ACP_SUSPEND_DELAY_MS 2000
> -
> -static inline u32 rpl_acp_readl(void __iomem *base_addr)
> -{
> - return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> -
> -static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
> -{
> - writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> deleted file mode 100644
> index 456498f5396d..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP 6.2 Register Documentation
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#ifndef _rpl_acp6x_OFFSET_HEADER
> -#define _rpl_acp6x_OFFSET_HEADER
> -
> -/* Registers from ACP_CLKRST block */
> -#define ACP_SOFT_RESET 0x1241000
> -#define ACP_CONTROL 0x1241004
> -#define ACP_STATUS 0x1241008
> -#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
> -#define ACP_PGFSM_CONTROL 0x124101C
> -#define ACP_PGFSM_STATUS 0x1241020
> -#define ACP_CLKMUX_SEL 0x1241024
> -
> -/* Registers from ACP_AON block */
> -#define ACP_PME_EN 0x1241400
> -#define ACP_DEVICE_STATE 0x1241404
> -#define AZ_DEVICE_STATE 0x1241408
> -#define ACP_PIN_CONFIG 0x1241440
> -#define ACP_PAD_PULLUP_CTRL 0x1241444
> -#define ACP_PAD_PULLDOWN_CTRL 0x1241448
> -#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
> -#define ACP_PAD_SCHMEN_CTRL 0x1241450
> -
> -#endif
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0294177acc66..de49c812124a 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
> };
>
> static const struct dmi_system_id yc_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 1140ed1cbb3d..296b74252a8a 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -163,6 +163,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> switch (pci->revision) {
> case 0x60:
> case 0x6f:
> + case 0x62: /* RPL */
> break;
> default:
> dev_dbg(&pci->dev, "acp6x pci device not found\n");
> @@ -205,6 +206,11 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> case ACP_CONFIG_2:
> case ACP_CONFIG_3:
> case ACP_CONFIG_9:
> + case ACP_CONFIG_10: /* Reserved for RPL */
> + case ACP_CONFIG_11: /* Reserved for RPL */
> + case ACP_CONFIG_12: /* Reserved for RPL */
> + case ACP_CONFIG_13: /* Reserved for RPL */
> + case ACP_CONFIG_14: /* Reserved for RPL */
Need to handle separate switch case for RPL. Above changes breaks
the functionality for YC.
> case ACP_CONFIG_15:
> dev_info(&pci->dev, "Audio Mode %d\n", val);
> break;
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v4] ASoC: amd: add DMIC support for RPL platform
2026-02-12 5:13 ` Mukunda,Vijendar
@ 2026-02-12 11:15 ` Mingyou Chen
2026-02-12 13:26 ` Mark Brown
2026-02-12 13:45 ` Mario Limonciello
0 siblings, 2 replies; 19+ messages in thread
From: Mingyou Chen @ 2026-02-12 11:15 UTC (permalink / raw)
To: vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, mario.limonciello,
venkataprasad.potturu, Sunil-kumar.Dommati, linux-sound,
linux-kernel, Mingyou Chen
Add DMIC support for the AMD RPL platform. The drivers are derived on
the YC platform driver.
Signed-off-by: Mingyou Chen <qby140326@gmail.com>
---
v2:
- Reverse ACP CONFIG PIN from 10 to 14 for rpl
- Remove the rpl folder
v3:
- Remove rpl configuration from Kconfig and Makefile
v4:
- Handle separate switch case for RPL platform (ACP Pin config)
sound/soc/amd/Kconfig | 10 -
sound/soc/amd/Makefile | 1 -
sound/soc/amd/rpl/Makefile | 5 -
sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
.../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
sound/soc/amd/yc/acp6x-mach.c | 7 +
sound/soc/amd/yc/pci-acp6x.c | 13 +
8 files changed, 20 insertions(+), 309 deletions(-)
delete mode 100644 sound/soc/amd/rpl/Makefile
delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index fd35a03aadcb..a6eecbe12e84 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -124,16 +124,6 @@ config SND_AMD_ACP_CONFIG
source "sound/soc/amd/acp/Kconfig"
-config SND_SOC_AMD_RPL_ACP6x
- tristate "AMD Audio Coprocessor-v6.2 RPL support"
- depends on X86 && PCI
- help
- This option enables Audio Coprocessor i.e. ACP v6.2 support on
- AMD RPL platform. By enabling this flag build will be
- triggered for ACP PCI driver.
- Say m if you have such a device.
- If unsure select "N".
-
config SND_SOC_AMD_ACP63_TOPLEVEL
tristate "support for AMD platforms with ACP version >= 6.3"
default SND_AMD_ACP_CONFIG
diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
index 4f89d962cce2..23b25ff0d800 100644
--- a/sound/soc/amd/Makefile
+++ b/sound/soc/amd/Makefile
@@ -17,5 +17,4 @@ obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
obj-$(CONFIG_SND_AMD_ACP_CONFIG) += acp/
obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
-obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
obj-$(CONFIG_SND_SOC_AMD_PS) += ps/
diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
deleted file mode 100644
index a3825c5be4e7..000000000000
--- a/sound/soc/amd/rpl/Makefile
+++ /dev/null
@@ -1,5 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0+
-# RPL platform Support
-snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
-
-obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
deleted file mode 100644
index e3afe9172bdf..000000000000
--- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
+++ /dev/null
@@ -1,227 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0+
-/*
- * AMD RPL ACP PCI Driver
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#include <linux/pci.h>
-#include <linux/module.h>
-#include <linux/io.h>
-#include <linux/delay.h>
-#include <linux/platform_device.h>
-#include <linux/pm_runtime.h>
-
-#include "rpl_acp6x.h"
-
-struct rpl_dev_data {
- void __iomem *acp6x_base;
-};
-
-static int rpl_power_on(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
-
- if (!val)
- return val;
-
- if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
- rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
- if (!val)
- return 0;
- udelay(1);
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_reset(void __iomem *acp_base)
-{
- u32 val;
- int timeout;
-
- rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
- break;
- cpu_relax();
- }
- rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
- timeout = 0;
- while (++timeout < 500) {
- val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
- if (!val)
- return 0;
- cpu_relax();
- }
- return -ETIMEDOUT;
-}
-
-static int rpl_init(void __iomem *acp_base)
-{
- int ret;
-
- /* power on */
- ret = rpl_power_on(acp_base);
- if (ret) {
- pr_err("ACP power on failed\n");
- return ret;
- }
- rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
- return 0;
-}
-
-static int rpl_deinit(void __iomem *acp_base)
-{
- int ret;
-
- /* Reset */
- ret = rpl_reset(acp_base);
- if (ret) {
- pr_err("ACP reset failed\n");
- return ret;
- }
- rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
- rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
- return 0;
-}
-
-static int snd_rpl_probe(struct pci_dev *pci,
- const struct pci_device_id *pci_id)
-{
- struct rpl_dev_data *adata;
- u32 addr;
- int ret;
-
- /* RPL device check */
- switch (pci->revision) {
- case 0x62:
- break;
- default:
- dev_dbg(&pci->dev, "acp6x pci device not found\n");
- return -ENODEV;
- }
- if (pci_enable_device(pci)) {
- dev_err(&pci->dev, "pci_enable_device failed\n");
- return -ENODEV;
- }
-
- ret = pci_request_regions(pci, "AMD ACP6x audio");
- if (ret < 0) {
- dev_err(&pci->dev, "pci_request_regions failed\n");
- goto disable_pci;
- }
-
- adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
- GFP_KERNEL);
- if (!adata) {
- ret = -ENOMEM;
- goto release_regions;
- }
-
- addr = pci_resource_start(pci, 0);
- adata->acp6x_base = devm_ioremap(&pci->dev, addr,
- pci_resource_len(pci, 0));
- if (!adata->acp6x_base) {
- ret = -ENOMEM;
- goto release_regions;
- }
- pci_set_master(pci);
- pci_set_drvdata(pci, adata);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- goto release_regions;
- pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
- pm_runtime_use_autosuspend(&pci->dev);
- pm_runtime_put_noidle(&pci->dev);
- pm_runtime_allow(&pci->dev);
-
- return 0;
-release_regions:
- pci_release_regions(pci);
-disable_pci:
- pci_disable_device(pci);
-
- return ret;
-}
-
-static int snd_rpl_suspend(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP de-init failed\n");
- return ret;
-}
-
-static int snd_rpl_resume(struct device *dev)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = dev_get_drvdata(dev);
- ret = rpl_init(adata->acp6x_base);
- if (ret)
- dev_err(dev, "ACP init failed\n");
- return ret;
-}
-
-static const struct dev_pm_ops rpl_pm = {
- RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
- SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
-};
-
-static void snd_rpl_remove(struct pci_dev *pci)
-{
- struct rpl_dev_data *adata;
- int ret;
-
- adata = pci_get_drvdata(pci);
- ret = rpl_deinit(adata->acp6x_base);
- if (ret)
- dev_err(&pci->dev, "ACP de-init failed\n");
- pm_runtime_forbid(&pci->dev);
- pm_runtime_get_noresume(&pci->dev);
- pci_release_regions(pci);
- pci_disable_device(pci);
-}
-
-static const struct pci_device_id snd_rpl_ids[] = {
- { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
- .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
- .class_mask = 0xffffff },
- { 0, },
-};
-MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
-
-static struct pci_driver rpl_acp6x_driver = {
- .name = KBUILD_MODNAME,
- .id_table = snd_rpl_ids,
- .probe = snd_rpl_probe,
- .remove = snd_rpl_remove,
- .driver = {
- .pm = pm_ptr(&rpl_pm),
- }
-};
-
-module_pci_driver(rpl_acp6x_driver);
-
-MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
-MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
deleted file mode 100644
index f5816a33632e..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x.h
+++ /dev/null
@@ -1,36 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP Driver
- *
- * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
- */
-
-#include "rpl_acp6x_chip_offset_byte.h"
-
-#define ACP_DEVICE_ID 0x15E2
-#define ACP6x_PHY_BASE_ADDRESS 0x1240000
-
-#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
-#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
-#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
-#define ACP_PGFSM_STATUS_MASK 3
-#define ACP_POWERED_ON 0
-#define ACP_POWER_ON_IN_PROGRESS 1
-#define ACP_POWERED_OFF 2
-#define ACP_POWER_OFF_IN_PROGRESS 3
-
-#define DELAY_US 5
-#define ACP_COUNTER 20000
-
-/* time in ms for runtime suspend delay */
-#define ACP_SUSPEND_DELAY_MS 2000
-
-static inline u32 rpl_acp_readl(void __iomem *base_addr)
-{
- return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
-
-static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
-{
- writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
-}
diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
deleted file mode 100644
index 456498f5396d..000000000000
--- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0+ */
-/*
- * AMD ACP 6.2 Register Documentation
- *
- * Copyright 2022 Advanced Micro Devices, Inc.
- */
-
-#ifndef _rpl_acp6x_OFFSET_HEADER
-#define _rpl_acp6x_OFFSET_HEADER
-
-/* Registers from ACP_CLKRST block */
-#define ACP_SOFT_RESET 0x1241000
-#define ACP_CONTROL 0x1241004
-#define ACP_STATUS 0x1241008
-#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
-#define ACP_PGFSM_CONTROL 0x124101C
-#define ACP_PGFSM_STATUS 0x1241020
-#define ACP_CLKMUX_SEL 0x1241024
-
-/* Registers from ACP_AON block */
-#define ACP_PME_EN 0x1241400
-#define ACP_DEVICE_STATE 0x1241404
-#define AZ_DEVICE_STATE 0x1241408
-#define ACP_PIN_CONFIG 0x1241440
-#define ACP_PAD_PULLUP_CTRL 0x1241444
-#define ACP_PAD_PULLDOWN_CTRL 0x1241448
-#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
-#define ACP_PAD_SCHMEN_CTRL 0x1241450
-
-#endif
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0294177acc66..de49c812124a 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
};
static const struct dmi_system_id yc_acp_quirk_table[] = {
+ {
+ .driver_data = &acp6x_card,
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
+ }
+ },
{
.driver_data = &acp6x_card,
.matches = {
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 1140ed1cbb3d..5883c1836f02 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -5,6 +5,7 @@
* Copyright 2021 Advanced Micro Devices, Inc.
*/
+#include "linux/compiler_attributes.h"
#include <linux/pci.h>
#include <linux/module.h>
#include <linux/io.h>
@@ -163,6 +164,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
switch (pci->revision) {
case 0x60:
case 0x6f:
+ case 0x62: /* RPL */
break;
default:
dev_dbg(&pci->dev, "acp6x pci device not found\n");
@@ -208,6 +210,17 @@ static int snd_acp6x_probe(struct pci_dev *pci,
case ACP_CONFIG_15:
dev_info(&pci->dev, "Audio Mode %d\n", val);
break;
+ /* PIN 10 to 14 is reversed for RPL */
+ case ACP_CONFIG_10:
+ case ACP_CONFIG_11:
+ case ACP_CONFIG_12:
+ case ACP_CONFIG_13:
+ case ACP_CONFIG_14:
+ if (pci->revision == 0x62) {
+ dev_info(&pci->dev, "RPL Audio Mode %d\n", val);
+ break;
+ }
+ fallthrough;
default:
adata->res = devm_kzalloc(&pci->dev,
sizeof(struct resource),
--
2.51.2
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v4] ASoC: amd: add DMIC support for RPL platform
2026-02-12 11:15 ` [PATCH v4] " Mingyou Chen
@ 2026-02-12 13:26 ` Mark Brown
2026-02-12 13:45 ` Mario Limonciello
1 sibling, 0 replies; 19+ messages in thread
From: Mark Brown @ 2026-02-12 13:26 UTC (permalink / raw)
To: Mingyou Chen
Cc: vijendar.mukunda, lgirdwood, perex, tiwai, mario.limonciello,
venkataprasad.potturu, Sunil-kumar.Dommati, linux-sound,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 448 bytes --]
On Thu, Feb 12, 2026 at 07:15:18PM +0800, Mingyou Chen wrote:
> Add DMIC support for the AMD RPL platform. The drivers are derived on
> the YC platform driver.
Please don't send new patches in reply to old patches or serieses, this
makes it harder for both people and tools to understand what is going
on - it can bury things in mailboxes and make it difficult to keep track
of what current patches are, both for the new patches and the old ones.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v4] ASoC: amd: add DMIC support for RPL platform
2026-02-12 11:15 ` [PATCH v4] " Mingyou Chen
2026-02-12 13:26 ` Mark Brown
@ 2026-02-12 13:45 ` Mario Limonciello
1 sibling, 0 replies; 19+ messages in thread
From: Mario Limonciello @ 2026-02-12 13:45 UTC (permalink / raw)
To: Mingyou Chen, vijendar.mukunda
Cc: broonie, lgirdwood, perex, tiwai, venkataprasad.potturu,
Sunil-kumar.Dommati, linux-sound, linux-kernel
On 2/12/26 5:15 AM, Mingyou Chen wrote:
> Add DMIC support for the AMD RPL platform. The drivers are derived on
> the YC platform driver.
>
> Signed-off-by: Mingyou Chen <qby140326@gmail.com>
> ---
> v2:
> - Reverse ACP CONFIG PIN from 10 to 14 for rpl
> - Remove the rpl folder
> v3:
> - Remove rpl configuration from Kconfig and Makefile
> v4:
> - Handle separate switch case for RPL platform (ACP Pin config)
I didn't realize there was a RPL driver upstream at this point, sorry
about my mistake on the earlier patch. But I do still have a concern
with the approach you're doing considering that. You have way too much
stuff going on in one patch.
I feel that this should be a series with multiple patches.
1) Add support for correct pin config in YC
2) Drop RPL driver
3) Add the quirk for your system
Think it through like this - when I look over your diff for each patch
your changelog should mention exactly what it is going in that
individual patch. If it's covering more than one thing it needs to be
an atomic action and justifiable to happen at once. Otherwise split
each thing to it's own patch.
This is important for a variety of reasons.
1) It makes the work of a reviewer a lot easier.
2) It makes bisection possible to figure out the smallest change that
caused an issue.
>
> sound/soc/amd/Kconfig | 10 -
> sound/soc/amd/Makefile | 1 -
> sound/soc/amd/rpl/Makefile | 5 -
> sound/soc/amd/rpl/rpl-pci-acp6x.c | 227 ------------------
> sound/soc/amd/rpl/rpl_acp6x.h | 36 ---
> .../soc/amd/rpl/rpl_acp6x_chip_offset_byte.h | 30 ---
> sound/soc/amd/yc/acp6x-mach.c | 7 +
> sound/soc/amd/yc/pci-acp6x.c | 13 +
> 8 files changed, 20 insertions(+), 309 deletions(-)
> delete mode 100644 sound/soc/amd/rpl/Makefile
> delete mode 100644 sound/soc/amd/rpl/rpl-pci-acp6x.c
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x.h
> delete mode 100644 sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index fd35a03aadcb..a6eecbe12e84 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -124,16 +124,6 @@ config SND_AMD_ACP_CONFIG
>
> source "sound/soc/amd/acp/Kconfig"
>
> -config SND_SOC_AMD_RPL_ACP6x
> - tristate "AMD Audio Coprocessor-v6.2 RPL support"
> - depends on X86 && PCI
> - help
> - This option enables Audio Coprocessor i.e. ACP v6.2 support on
> - AMD RPL platform. By enabling this flag build will be
> - triggered for ACP PCI driver.
> - Say m if you have such a device.
> - If unsure select "N".
> -
> config SND_SOC_AMD_ACP63_TOPLEVEL
> tristate "support for AMD platforms with ACP version >= 6.3"
> default SND_AMD_ACP_CONFIG
> diff --git a/sound/soc/amd/Makefile b/sound/soc/amd/Makefile
> index 4f89d962cce2..23b25ff0d800 100644
> --- a/sound/soc/amd/Makefile
> +++ b/sound/soc/amd/Makefile
> @@ -17,5 +17,4 @@ obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
> obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
> obj-$(CONFIG_SND_AMD_ACP_CONFIG) += acp/
> obj-$(CONFIG_SND_AMD_ACP_CONFIG) += snd-acp-config.o
> -obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += rpl/
> obj-$(CONFIG_SND_SOC_AMD_PS) += ps/
> diff --git a/sound/soc/amd/rpl/Makefile b/sound/soc/amd/rpl/Makefile
> deleted file mode 100644
> index a3825c5be4e7..000000000000
> --- a/sound/soc/amd/rpl/Makefile
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0+
> -# RPL platform Support
> -snd-rpl-pci-acp6x-y := rpl-pci-acp6x.o
> -
> -obj-$(CONFIG_SND_SOC_AMD_RPL_ACP6x) += snd-rpl-pci-acp6x.o
> diff --git a/sound/soc/amd/rpl/rpl-pci-acp6x.c b/sound/soc/amd/rpl/rpl-pci-acp6x.c
> deleted file mode 100644
> index e3afe9172bdf..000000000000
> --- a/sound/soc/amd/rpl/rpl-pci-acp6x.c
> +++ /dev/null
> @@ -1,227 +0,0 @@
> -// SPDX-License-Identifier: GPL-2.0+
> -/*
> - * AMD RPL ACP PCI Driver
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#include <linux/pci.h>
> -#include <linux/module.h>
> -#include <linux/io.h>
> -#include <linux/delay.h>
> -#include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
> -
> -#include "rpl_acp6x.h"
> -
> -struct rpl_dev_data {
> - void __iomem *acp6x_base;
> -};
> -
> -static int rpl_power_on(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> -
> - if (!val)
> - return val;
> -
> - if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
> - rpl_acp_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_PGFSM_STATUS);
> - if (!val)
> - return 0;
> - udelay(1);
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_reset(void __iomem *acp_base)
> -{
> - u32 val;
> - int timeout;
> -
> - rpl_acp_writel(1, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
> - break;
> - cpu_relax();
> - }
> - rpl_acp_writel(0, acp_base + ACP_SOFT_RESET);
> - timeout = 0;
> - while (++timeout < 500) {
> - val = rpl_acp_readl(acp_base + ACP_SOFT_RESET);
> - if (!val)
> - return 0;
> - cpu_relax();
> - }
> - return -ETIMEDOUT;
> -}
> -
> -static int rpl_init(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* power on */
> - ret = rpl_power_on(acp_base);
> - if (ret) {
> - pr_err("ACP power on failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x01, acp_base + ACP_CONTROL);
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x03, acp_base + ACP_CLKMUX_SEL);
> - return 0;
> -}
> -
> -static int rpl_deinit(void __iomem *acp_base)
> -{
> - int ret;
> -
> - /* Reset */
> - ret = rpl_reset(acp_base);
> - if (ret) {
> - pr_err("ACP reset failed\n");
> - return ret;
> - }
> - rpl_acp_writel(0x00, acp_base + ACP_CLKMUX_SEL);
> - rpl_acp_writel(0x00, acp_base + ACP_CONTROL);
> - return 0;
> -}
> -
> -static int snd_rpl_probe(struct pci_dev *pci,
> - const struct pci_device_id *pci_id)
> -{
> - struct rpl_dev_data *adata;
> - u32 addr;
> - int ret;
> -
> - /* RPL device check */
> - switch (pci->revision) {
> - case 0x62:
> - break;
> - default:
> - dev_dbg(&pci->dev, "acp6x pci device not found\n");
> - return -ENODEV;
> - }
> - if (pci_enable_device(pci)) {
> - dev_err(&pci->dev, "pci_enable_device failed\n");
> - return -ENODEV;
> - }
> -
> - ret = pci_request_regions(pci, "AMD ACP6x audio");
> - if (ret < 0) {
> - dev_err(&pci->dev, "pci_request_regions failed\n");
> - goto disable_pci;
> - }
> -
> - adata = devm_kzalloc(&pci->dev, sizeof(struct rpl_dev_data),
> - GFP_KERNEL);
> - if (!adata) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> -
> - addr = pci_resource_start(pci, 0);
> - adata->acp6x_base = devm_ioremap(&pci->dev, addr,
> - pci_resource_len(pci, 0));
> - if (!adata->acp6x_base) {
> - ret = -ENOMEM;
> - goto release_regions;
> - }
> - pci_set_master(pci);
> - pci_set_drvdata(pci, adata);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - goto release_regions;
> - pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
> - pm_runtime_use_autosuspend(&pci->dev);
> - pm_runtime_put_noidle(&pci->dev);
> - pm_runtime_allow(&pci->dev);
> -
> - return 0;
> -release_regions:
> - pci_release_regions(pci);
> -disable_pci:
> - pci_disable_device(pci);
> -
> - return ret;
> -}
> -
> -static int snd_rpl_suspend(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP de-init failed\n");
> - return ret;
> -}
> -
> -static int snd_rpl_resume(struct device *dev)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = dev_get_drvdata(dev);
> - ret = rpl_init(adata->acp6x_base);
> - if (ret)
> - dev_err(dev, "ACP init failed\n");
> - return ret;
> -}
> -
> -static const struct dev_pm_ops rpl_pm = {
> - RUNTIME_PM_OPS(snd_rpl_suspend, snd_rpl_resume, NULL)
> - SYSTEM_SLEEP_PM_OPS(snd_rpl_suspend, snd_rpl_resume)
> -};
> -
> -static void snd_rpl_remove(struct pci_dev *pci)
> -{
> - struct rpl_dev_data *adata;
> - int ret;
> -
> - adata = pci_get_drvdata(pci);
> - ret = rpl_deinit(adata->acp6x_base);
> - if (ret)
> - dev_err(&pci->dev, "ACP de-init failed\n");
> - pm_runtime_forbid(&pci->dev);
> - pm_runtime_get_noresume(&pci->dev);
> - pci_release_regions(pci);
> - pci_disable_device(pci);
> -}
> -
> -static const struct pci_device_id snd_rpl_ids[] = {
> - { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
> - .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
> - .class_mask = 0xffffff },
> - { 0, },
> -};
> -MODULE_DEVICE_TABLE(pci, snd_rpl_ids);
> -
> -static struct pci_driver rpl_acp6x_driver = {
> - .name = KBUILD_MODNAME,
> - .id_table = snd_rpl_ids,
> - .probe = snd_rpl_probe,
> - .remove = snd_rpl_remove,
> - .driver = {
> - .pm = pm_ptr(&rpl_pm),
> - }
> -};
> -
> -module_pci_driver(rpl_acp6x_driver);
> -
> -MODULE_DESCRIPTION("AMD ACP RPL PCI driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/sound/soc/amd/rpl/rpl_acp6x.h b/sound/soc/amd/rpl/rpl_acp6x.h
> deleted file mode 100644
> index f5816a33632e..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x.h
> +++ /dev/null
> @@ -1,36 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP Driver
> - *
> - * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
> - */
> -
> -#include "rpl_acp6x_chip_offset_byte.h"
> -
> -#define ACP_DEVICE_ID 0x15E2
> -#define ACP6x_PHY_BASE_ADDRESS 0x1240000
> -
> -#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK 0x00010001
> -#define ACP_PGFSM_CNTL_POWER_ON_MASK 1
> -#define ACP_PGFSM_CNTL_POWER_OFF_MASK 0
> -#define ACP_PGFSM_STATUS_MASK 3
> -#define ACP_POWERED_ON 0
> -#define ACP_POWER_ON_IN_PROGRESS 1
> -#define ACP_POWERED_OFF 2
> -#define ACP_POWER_OFF_IN_PROGRESS 3
> -
> -#define DELAY_US 5
> -#define ACP_COUNTER 20000
> -
> -/* time in ms for runtime suspend delay */
> -#define ACP_SUSPEND_DELAY_MS 2000
> -
> -static inline u32 rpl_acp_readl(void __iomem *base_addr)
> -{
> - return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> -
> -static inline void rpl_acp_writel(u32 val, void __iomem *base_addr)
> -{
> - writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
> -}
> diff --git a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h b/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> deleted file mode 100644
> index 456498f5396d..000000000000
> --- a/sound/soc/amd/rpl/rpl_acp6x_chip_offset_byte.h
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0+ */
> -/*
> - * AMD ACP 6.2 Register Documentation
> - *
> - * Copyright 2022 Advanced Micro Devices, Inc.
> - */
> -
> -#ifndef _rpl_acp6x_OFFSET_HEADER
> -#define _rpl_acp6x_OFFSET_HEADER
> -
> -/* Registers from ACP_CLKRST block */
> -#define ACP_SOFT_RESET 0x1241000
> -#define ACP_CONTROL 0x1241004
> -#define ACP_STATUS 0x1241008
> -#define ACP_DYNAMIC_CG_MASTER_CONTROL 0x1241010
> -#define ACP_PGFSM_CONTROL 0x124101C
> -#define ACP_PGFSM_STATUS 0x1241020
> -#define ACP_CLKMUX_SEL 0x1241024
> -
> -/* Registers from ACP_AON block */
> -#define ACP_PME_EN 0x1241400
> -#define ACP_DEVICE_STATE 0x1241404
> -#define AZ_DEVICE_STATE 0x1241408
> -#define ACP_PIN_CONFIG 0x1241440
> -#define ACP_PAD_PULLUP_CTRL 0x1241444
> -#define ACP_PAD_PULLDOWN_CTRL 0x1241448
> -#define ACP_PAD_DRIVE_STRENGTH_CTRL 0x124144C
> -#define ACP_PAD_SCHMEN_CTRL 0x1241450
> -
> -#endif
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
> index 0294177acc66..de49c812124a 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -45,6 +45,13 @@ static struct snd_soc_card acp6x_card = {
> };
>
> static const struct dmi_system_id yc_acp_quirk_table[] = {
> + {
> + .driver_data = &acp6x_card,
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Lecoo"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Bellator N176"),
> + }
> + },
> {
> .driver_data = &acp6x_card,
> .matches = {
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 1140ed1cbb3d..5883c1836f02 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -5,6 +5,7 @@
> * Copyright 2021 Advanced Micro Devices, Inc.
> */
>
> +#include "linux/compiler_attributes.h"
This is really weird - did you mean to include this?
> #include <linux/pci.h>
> #include <linux/module.h>
> #include <linux/io.h>
> @@ -163,6 +164,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> switch (pci->revision) {
> case 0x60:
> case 0x6f:
> + case 0x62: /* RPL */
> break;
> default:
> dev_dbg(&pci->dev, "acp6x pci device not found\n");
> @@ -208,6 +210,17 @@ static int snd_acp6x_probe(struct pci_dev *pci,
> case ACP_CONFIG_15:
> dev_info(&pci->dev, "Audio Mode %d\n", val);
> break;
> + /* PIN 10 to 14 is reversed for RPL */
> + case ACP_CONFIG_10:
> + case ACP_CONFIG_11:
> + case ACP_CONFIG_12:
> + case ACP_CONFIG_13:
> + case ACP_CONFIG_14:
> + if (pci->revision == 0x62) {
> + dev_info(&pci->dev, "RPL Audio Mode %d\n", val);
> + break;
> + }
> + fallthrough;
> default:
> adata->res = devm_kzalloc(&pci->dev,
> sizeof(struct resource),
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2026-02-12 13:45 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-05 2:07 [PATCH] ASoC: amd: add DMIC support for RPL platform Mingyou Chen
2026-02-06 17:51 ` Mark Brown
2026-02-07 1:44 ` qby140326
2026-02-07 5:50 ` Mukunda,Vijendar
2026-02-07 12:45 ` Mark Brown
2026-02-11 9:22 ` Mukunda,Vijendar
2026-02-11 10:46 ` qby140326
2026-02-11 11:16 ` qby140326
2026-02-11 11:19 ` Mukunda,Vijendar
2026-02-11 11:50 ` [PATCH v2] " Mingyou Chen
2026-02-11 15:21 ` Mario Limonciello
2026-02-12 1:42 ` qby140326
2026-02-12 1:46 ` [PATCH v3] " Mingyou Chen
2026-02-12 5:13 ` Mukunda,Vijendar
2026-02-12 11:15 ` [PATCH v4] " Mingyou Chen
2026-02-12 13:26 ` Mark Brown
2026-02-12 13:45 ` Mario Limonciello
2026-02-11 17:13 ` [PATCH v2] " kernel test robot
2026-02-11 22:35 ` kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox