From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03B6F21C173; Mon, 16 Mar 2026 12:49:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.20 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773665352; cv=none; b=W/XiiTFrWAxy7cG1hmvjxrFxS6Yfc/SOf9CgMUeOoW1O9pAiwAU5tPuut0GGNL7Mg+lCZoYUPvdN3RPI1iT6qPCUGUFKqAP7067ToYO0eOQHmOV/hPCZdMFmvBpQSkYrT8Upu2RgXsmNlBpqnyI4Cc35sROM/0QVj5fC5R2QdYc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773665352; c=relaxed/simple; bh=+fKnMOAy4txozyuTQa186zP47LQj68e8yWqSt0ZdZiE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hwd1+x9/Rop5zdzrMSruPLiQ2Jr2JuQpPOMehIfEUrqV4du+emChLkmjG1b4kbJlZ6gFgN9mDVO5uGm/uGybOdbZziOrDAkXGy6JV6TlSLRAP4xIh4yRXktrQNhqPR8jtPPdPcSwLD7GB8sCHsXFnADZLiUrTT0/cgeGUDUDO7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nHq1ZzZ3; arc=none smtp.client-ip=198.175.65.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nHq1ZzZ3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773665351; x=1805201351; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=+fKnMOAy4txozyuTQa186zP47LQj68e8yWqSt0ZdZiE=; b=nHq1ZzZ3urO+lek5hQrppKmsOE84kJvwKvxKB/Pt2ZpBxXqZRLBHYGM1 jBElZzIYRIbnEKXKlTbU5AHDbPF+R+gnGaN7n5V8Nofd+Uni/ul4Q4z3Y ofQ0fb0UYAZ8beJi+opR5/a31eJGEHql+rLB6J/xI1RnZON231NAjUld0 I5SOH80gcsFfzTULSRc0p+VYcMzD+bnoYNUBB6WVJM9HTYcCXkFmhHbSi bTI29nbQhclDN4oIDNPWRXjpnLNv48T3i55lLrOfGtbUd9DOUC805myeF 3SuelA8KndQXEs1fSjtMRoJKR/tXrYnY0aBNL7FTCk05T7aXrDgDj2IgN g==; X-CSE-ConnectionGUID: nYA0v7IuSaqbL0waDjmCaA== X-CSE-MsgGUID: Cqa5yglgRe+qETmwApbP4g== X-IronPort-AV: E=McAfee;i="6800,10657,11731"; a="74382108" X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="74382108" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 05:49:10 -0700 X-CSE-ConnectionGUID: EjlCi3DxRQatj9fKZHTReg== X-CSE-MsgGUID: K9Hc76poRwCC4Cy9XMcoEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,124,1770624000"; d="scan'208";a="221146562" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO pujfalus-desk.intel.com) ([10.245.244.184]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 05:49:08 -0700 From: Peter Ujfalusi To: lgirdwood@gmail.com, broonie@kernel.org, ckeepax@opensource.cirrus.com, david.rhodes@cirrus.com, rf@opensource.cirrus.com Cc: linux-sound@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] ASoC: cs42l43-jack: Remove manual pm_runtime get/put from tip_sense_work Date: Mon, 16 Mar 2026 14:49:24 +0200 Message-ID: <20260316124924.31047-1-peter.ujfalusi@linux.intel.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When a jack is inserted the forced pm_runtime_get() will keep the codec, soundwire bus and it's parent active as long as the jack is connected. This makes for example the DSP and firmware booted up on Intel platforms. If the module is removed while the jack is connected we will also have unbalanced runtime PM state. Without the manual get/put, the button detection still works correctly and the system can reach lower power state while the jack is connected like in the case when there is no jack connected. Fixes: fc918cbe874e ("ASoC: cs42l43: Add support for the cs42l43") Cc: stable@vger.kernel.org Signed-off-by: Peter Ujfalusi --- sound/soc/codecs/cs42l43-jack.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/cs42l43-jack.c b/sound/soc/codecs/cs42l43-jack.c index 3e04e6897b14..d90a13a55845 100644 --- a/sound/soc/codecs/cs42l43-jack.c +++ b/sound/soc/codecs/cs42l43-jack.c @@ -756,10 +756,8 @@ void cs42l43_tip_sense_work(struct work_struct *work) ring = (sts >> CS42L43_RINGSENSE_PLUG_DB_STS_SHIFT) & CS42L43_JACK_PRESENT; if (tip == CS42L43_JACK_PRESENT) { - if (cs42l43->sdw && !priv->jack_present) { + if (cs42l43->sdw && !priv->jack_present) priv->jack_present = true; - pm_runtime_get(priv->dev); - } if (priv->use_ring_sense && ring == CS42L43_JACK_ABSENT) { report = CS42L43_JACK_OPTICAL; @@ -779,10 +777,8 @@ void cs42l43_tip_sense_work(struct work_struct *work) snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF); - if (cs42l43->sdw && priv->jack_present) { - pm_runtime_put(priv->dev); + if (cs42l43->sdw && priv->jack_present) priv->jack_present = false; - } } error: -- 2.53.0