[PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

[PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

[Simon Trimmer]

Ensure that subsystem_device is printed with leading zeros when combined
with subsystem_vendor to form the SSID. Without this, devices with upper
bits unset may appear to have an incorrect SSID in the debug output.

Fixes: aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem Vendor and Device IDs")
Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
---
 sound/soc/amd/ps/pci-ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 3a20cc10d61f5..fafadc36e4830 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -339,7 +339,7 @@ static struct snd_soc_acpi_mach *acp63_sdw_machine_select(struct device *dev)
 			mach->mach_params.subsystem_device = acp_data->subsystem_device;
 			mach->mach_params.subsystem_id_set = true;
 
-			dev_dbg(dev, "SSID %x%x\n", mach->mach_params.subsystem_vendor,
+			dev_dbg(dev, "SSID %x%0x\n", mach->mach_params.subsystem_vendor,
 				mach->mach_params.subsystem_device);
 			return mach;
 		}
-- 
2.43.0

Re: [PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 605 bytes --]

On Tue, Mar 31, 2026 at 10:41:16AM +0000, Simon Trimmer wrote:
> Ensure that subsystem_device is printed with leading zeros when combined
> with subsystem_vendor to form the SSID. Without this, devices with upper
> bits unset may appear to have an incorrect SSID in the debug output.

> Fixes: aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem Vendor and Device IDs")

Fixes?

> -			dev_dbg(dev, "SSID %x%x\n", mach->mach_params.subsystem_vendor,
> +			dev_dbg(dev, "SSID %x%0x\n", mach->mach_params.subsystem_vendor,

This doesn't specify a width so how would printk know how much to zero
pad?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [PATCH] ASoC: amd: ps: Fix missing leading zeros in subsystem_device SSID log

[Simon Trimmer]

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Tuesday, March 31, 2026 12:27 PM
> To: Simon Trimmer <simont@opensource.cirrus.com>
> Cc: linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org;
> patches@opensource.cirrus.com; Vijendar.Mukunda@amd.com
> Subject: Re: [PATCH] ASoC: amd: ps: Fix missing leading zeros in
> subsystem_device SSID log
> 
> On Tue, Mar 31, 2026 at 10:41:16AM +0000, Simon Trimmer wrote:
> > Ensure that subsystem_device is printed with leading zeros when combined
> > with subsystem_vendor to form the SSID. Without this, devices with upper
> > bits unset may appear to have an incorrect SSID in the debug output.
> 
> > Fixes: aab1301cfde344 ("ASoC: amd: ps: Propagate the PCI subsystem
> Vendor and Device IDs")
> 
> Fixes?
> 
> > -			dev_dbg(dev, "SSID %x%x\n", mach-
> >mach_params.subsystem_vendor,
> > +			dev_dbg(dev, "SSID %x%0x\n", mach-
> >mach_params.subsystem_vendor,
> 
> This doesn't specify a width so how would printk know how much to zero
> pad?

Hmm, that's a good point - I'll correct it

Looking at sound/ there's a handful of other log messages making this same
mistake