From: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
To: Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
"Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Subject: [PATCH 1/2] ALSA: compress: Use EOPNOTSUPP for missing pointer callbacks
Date: Tue, 14 Apr 2026 13:47:53 -0300 [thread overview]
Message-ID: <20260414-alsa-compress-pointer-avail-errors-v1-1-f5a1a8b1dfba@gmail.com> (raw)
In-Reply-To: <20260414-alsa-compress-pointer-avail-errors-v1-0-f5a1a8b1dfba@gmail.com>
snd_compr_update_tstamp() returns a sentinel error when a
compress driver does not implement the pointer() callback.
Use -EOPNOTSUPP for that case instead of -ENOTSUPP. This
keeps the behavior the same while switching to the standard
unsupported-operation errno and avoids the checkpatch warning
about ENOTSUPP not being a SUSv4 error code.
Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
---
sound/core/compress_offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index fd63d219bf86..e3239c739d34 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -186,7 +186,7 @@ static int snd_compr_update_tstamp(struct snd_compr_stream *stream,
int ret;
if (!stream->ops->pointer)
- return -ENOTSUPP;
+ return -EOPNOTSUPP;
switch (stream->runtime->state) {
case SNDRV_PCM_STATE_OPEN:
--
2.53.0
next prev parent reply other threads:[~2026-04-14 16:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 16:47 [PATCH 0/2] ALSA: compress: clean up pointer errno handling and fix avail errors Cássio Gabriel
2026-04-14 16:47 ` Cássio Gabriel [this message]
2026-04-14 16:47 ` [PATCH 2/2] ALSA: compress: Propagate real pointer errors in avail paths Cássio Gabriel
2026-04-14 16:53 ` Mark Brown
2026-04-14 17:45 ` Cássio Gabriel Monteiro Pires
2026-04-15 14:20 ` Takashi Iwai
2026-04-15 19:29 ` Cássio Gabriel Monteiro Pires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414-alsa-compress-pointer-avail-errors-v1-1-f5a1a8b1dfba@gmail.com \
--to=cassiogabrielcontato@gmail.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox