From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 40037369970 for ; Sun, 10 May 2026 08:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778402649; cv=none; b=k3ORwQF5k06a0bB2MpHxw9eYQzGPcRvMwng2JBlv7eqgj5iUi0v2Fe3yn15gkUkvuqnCnvLIfoc4zQQEXXRtyx743LHkdJn3I17N+2STl135mwZKEVRaqUvn0LdMvOTWmYUWfe6CLUPq4ZJxlJamb0oE1rPSW9xATBz9rlalM88= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778402649; c=relaxed/simple; bh=vBVltSf+zvidy2s5NGA4z20jtANfqFt6bS7cHx7O2tc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t39mEX0VFZUajdSjyKfJ1iIRan6v9QQhuAqY0RBmG2EF1+6ARBDjkP6Fr8oqjUcF7vHi35yEV6wn2WZHldbxmPnMReP/sdO2CNBQcHVOcmfkoavu1fN38yIG5lhwkQ7UAdYf2oyK3acGk/n7DJ0G3BTNFQ5PZZ7c02CtWFj44Os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Me4OFeWS; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Me4OFeWS" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b4583f0a1aso20915045ad.3 for ; Sun, 10 May 2026 01:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778402647; x=1779007447; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6p0JHZRpvp5tAeW23q1iGWhiV14ay6JXEiHGZU5IDsQ=; b=Me4OFeWSV/C3CCoE//GHGJmx26/Ep0R9AMfzfFaZUkNesxM7wIt54d4xMxDKhkOu+d ytbnp6ZuW2do1vdsiyuSEMfdQipvr5jYctGzWHt108EurnXYWrQyLuhvWovHDSHKaTRy abTEGIcwgBxGaQS+VZiJRVYCeh0VZmysUzFgbujW6K+EXNb0HY0z2dCyMqvy1/S4SF/F W0aL/endzhxn74kolUQwMb9sO2o8hVqyb/ALoFwZqwiyxigiWxVDxEGMkcjm42n/Jvut 7wslN8+gjdfgqmlHELWXyLUXFgcz01BeGe2e8GQxKPrHYHcMQr0XQJcm6p/W70f3Z1G5 oeJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778402647; x=1779007447; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6p0JHZRpvp5tAeW23q1iGWhiV14ay6JXEiHGZU5IDsQ=; b=leBC2fI4CYV37eTM8xGi3ti76JmiPPKQI0TdpJNbyYhklBZ7oIqiuijFyi8GOjSnJk Zgr0rNOHzXMLoc4t48am9IFVsKW96qe8fi2WneGyMzUhSUPyPZhqUT8dfPboUH157+jf BRJfXrklcmnNrOtqvm/5J/6lSt0Cbt7hHqH6U8W5L7B6XyTyraY0EWrziZ+wg8ERDjUo G2rEh9RMmNcqOqiOXtPTzRr1SvVDwHu6VvYReZatNMYo1NNpfCcmLvM4mXdmlzMBZepP XLtms72ide3kdiBal9dlEA142H/Vu7RjOGuGJRm5oUfnlxjMa0R4oKEsNTgAWyOHo+gX muPA== X-Forwarded-Encrypted: i=1; AFNElJ8zkHn/Q+IA91xsJc1S63FvuYRlof1CDfqfLZC6wsQ01iRLM1zJmFtHWdi0KUtgjXxGyKHleps+/Yq8og==@vger.kernel.org X-Gm-Message-State: AOJu0Yw3F7dp9+T4FvtiFHYvFhMltrBsRwbRxxVWLGqCf3rrEB6SU8j5 FPrRgEJjIk9OKuiTnVO8mZqwDX6G6VEvUnCcQ03FxMzNHCJg7LArp6Uu X-Gm-Gg: Acq92OHLdxUo5He2kGTWKpBvQv/5FxHm2N1vYRtkVt+bHIzQAY5ttXHAGhKZE6KagfL 4mTNCQ6nsLdKXpdoyZd0z0dEqQfPzaySxB2xCHbpFFn41jH8KWI1Ha91b+xiUveqbOc0cB29lky MeykV7TIMVe5gG8v3pDz/AEW28eiQMXLPQsDd8jLIL1RI4JzL77t35VqqqRFKeSOLNoGUbcuaug d3kBudQipnE+fFDE6ue2Tk49TCv4Y06rQLmzgyKLk0xLGd+8TFuho1w0qQ004ZkODaP1lvOQryC oIA7JC4PxB3glYeMYEOPirb8vXx7hVIN5qzMSYx6ZU554Z5WutvQJQdGOhMDvWOy7NrY5o253+U BsuNAKn9sYfZe6G8tnnpxMFFS9YeIL7Z+QYL+ppknMq6deauvdmtQe05312MZ5LGCCGSjMHc7MR H+bh1faSwr1ahfPkyr4cmy46GxDvGQH6pkuTTTFiD2FVMJClGflGlOk1GXkg== X-Received: by 2002:a17:903:1984:b0:2b9:59ea:7eba with SMTP id d9443c01a7336-2bc7a9b74fcmr51289285ad.13.1778402647580; Sun, 10 May 2026 01:44:07 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d3ffa0sm70471005ad.25.2026.05.10.01.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 01:44:07 -0700 (PDT) From: phucduc.bui@gmail.com To: kuninori.morimoto.gx@renesas.com Cc: broonie@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, geert+renesas@glider.be, krzk+dt@kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sound@vger.kernel.org, magnus.damm@gmail.com, perex@perex.cz, robh@kernel.org, tiwai@suse.com, bui duc phuc Subject: [PATCH v3 05/10] ASoC: renesas: fsi: Move fsi_clk_init() Date: Sun, 10 May 2026 15:42:58 +0700 Message-ID: <20260510084303.122426-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260510084303.122426-1-phucduc.bui@gmail.com> References: <20260510084303.122426-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Move fsi_clk_init() after set_rate() functions to prepare for subsequent refactoring. Suggested-by: Kuninori Morimoto Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 128 ++++++++++++++++++++-------------------- 1 file changed, 64 insertions(+), 64 deletions(-) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index fc8428cb1ba7..06ec5709216b 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -718,70 +718,6 @@ static void fsi_spdif_clk_ctrl(struct fsi_priv *fsi, int enable) /* * clock function */ -static int fsi_clk_init(struct device *dev, - struct fsi_priv *fsi, - int xck, - int ick, - int div, - int (*set_rate)(struct device *dev, - struct fsi_priv *fsi)) -{ - struct fsi_clk *clock = &fsi->clock; - int is_porta = fsi_is_port_a(fsi); - - clock->xck = NULL; - clock->ick = NULL; - clock->div = NULL; - clock->rate = 0; - clock->count = 0; - clock->set_rate = set_rate; - - clock->own = devm_clk_get(dev, NULL); - if (IS_ERR(clock->own)) - return -EINVAL; - - /* external clock */ - if (xck) { - clock->xck = devm_clk_get(dev, is_porta ? "xcka" : "xckb"); - if (IS_ERR(clock->xck)) { - dev_err(dev, "can't get xck clock\n"); - return -EINVAL; - } - if (clock->xck == clock->own) { - dev_err(dev, "cpu doesn't support xck clock\n"); - return -EINVAL; - } - } - - /* FSIACLK/FSIBCLK */ - if (ick) { - clock->ick = devm_clk_get(dev, is_porta ? "icka" : "ickb"); - if (IS_ERR(clock->ick)) { - dev_err(dev, "can't get ick clock\n"); - return -EINVAL; - } - if (clock->ick == clock->own) { - dev_err(dev, "cpu doesn't support ick clock\n"); - return -EINVAL; - } - } - - /* FSI-DIV */ - if (div) { - clock->div = devm_clk_get(dev, is_porta ? "diva" : "divb"); - if (IS_ERR(clock->div)) { - dev_err(dev, "can't get div clock\n"); - return -EINVAL; - } - if (clock->div == clock->own) { - dev_err(dev, "cpu doesn't support div clock\n"); - return -EINVAL; - } - } - - return 0; -} - #define fsi_clk_invalid(fsi) fsi_clk_valid(fsi, 0) static void fsi_clk_valid(struct fsi_priv *fsi, unsigned long rate) { @@ -1035,6 +971,70 @@ static int fsi_clk_set_rate_cpg(struct device *dev, return ret; } +static int fsi_clk_init(struct device *dev, + struct fsi_priv *fsi, + int xck, + int ick, + int div, + int (*set_rate)(struct device *dev, + struct fsi_priv *fsi)) +{ + struct fsi_clk *clock = &fsi->clock; + int is_porta = fsi_is_port_a(fsi); + + clock->xck = NULL; + clock->ick = NULL; + clock->div = NULL; + clock->rate = 0; + clock->count = 0; + clock->set_rate = set_rate; + + clock->own = devm_clk_get(dev, NULL); + if (IS_ERR(clock->own)) + return -EINVAL; + + /* external clock */ + if (xck) { + clock->xck = devm_clk_get(dev, is_porta ? "xcka" : "xckb"); + if (IS_ERR(clock->xck)) { + dev_err(dev, "can't get xck clock\n"); + return -EINVAL; + } + if (clock->xck == clock->own) { + dev_err(dev, "cpu doesn't support xck clock\n"); + return -EINVAL; + } + } + + /* FSIACLK/FSIBCLK */ + if (ick) { + clock->ick = devm_clk_get(dev, is_porta ? "icka" : "ickb"); + if (IS_ERR(clock->ick)) { + dev_err(dev, "can't get ick clock\n"); + return -EINVAL; + } + if (clock->ick == clock->own) { + dev_err(dev, "cpu doesn't support ick clock\n"); + return -EINVAL; + } + } + + /* FSI-DIV */ + if (div) { + clock->div = devm_clk_get(dev, is_porta ? "diva" : "divb"); + if (IS_ERR(clock->div)) { + dev_err(dev, "can't get div clock\n"); + return -EINVAL; + } + if (clock->div == clock->own) { + dev_err(dev, "cpu doesn't support div clock\n"); + return -EINVAL; + } + } + + return 0; +} + static void fsi_pointer_update(struct fsi_stream *io, int size) { io->buff_sample_pos += size; -- 2.43.0