From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 1/2] ASoC: sti: uniperif_reader: Use guard() for spin locks
Date: Wed, 27 May 2026 17:02:05 +0700 [thread overview]
Message-ID: <20260527100206.26788-2-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260527100206.26788-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for spin locks.
Merely code refactoring, and no behavior change.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
Compile-tested only.
sound/soc/sti/uniperif_reader.c | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
diff --git a/sound/soc/sti/uniperif_reader.c b/sound/soc/sti/uniperif_reader.c
index 05ea2b794eb9..45d7613f595c 100644
--- a/sound/soc/sti/uniperif_reader.c
+++ b/sound/soc/sti/uniperif_reader.c
@@ -46,15 +46,16 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id)
struct uniperif *reader = dev_id;
unsigned int status;
- spin_lock(&reader->irq_lock);
+ guard(spinlock)(&reader->irq_lock);
if (!reader->substream)
- goto irq_spin_unlock;
+ return ret;
snd_pcm_stream_lock(reader->substream);
if (reader->state == UNIPERIF_STATE_STOPPED) {
/* Unexpected IRQ: do nothing */
dev_warn(reader->dev, "unexpected IRQ\n");
- goto stream_unlock;
+ snd_pcm_stream_unlock(reader->substream);
+ return ret;
}
/* Get interrupt status & clear them immediately */
@@ -70,10 +71,7 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id)
ret = IRQ_HANDLED;
}
-stream_unlock:
snd_pcm_stream_unlock(reader->substream);
-irq_spin_unlock:
- spin_unlock(&reader->irq_lock);
return ret;
}
@@ -355,12 +353,10 @@ static int uni_reader_startup(struct snd_pcm_substream *substream,
{
struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai);
struct uniperif *reader = priv->dai_data.uni;
- unsigned long flags;
int ret;
- spin_lock_irqsave(&reader->irq_lock, flags);
- reader->substream = substream;
- spin_unlock_irqrestore(&reader->irq_lock, flags);
+ scoped_guard(spinlock_irqsave, &reader->irq_lock)
+ reader->substream = substream;
if (!UNIPERIF_TYPE_IS_TDM(reader))
return 0;
@@ -386,15 +382,13 @@ static void uni_reader_shutdown(struct snd_pcm_substream *substream,
{
struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai);
struct uniperif *reader = priv->dai_data.uni;
- unsigned long flags;
- spin_lock_irqsave(&reader->irq_lock, flags);
+ guard(spinlock_irqsave)(&reader->irq_lock);
if (reader->state != UNIPERIF_STATE_STOPPED) {
/* Stop the reader */
uni_reader_stop(reader);
}
reader->substream = NULL;
- spin_unlock_irqrestore(&reader->irq_lock, flags);
}
static const struct snd_soc_dai_ops uni_reader_dai_ops = {
--
2.43.0
next prev parent reply other threads:[~2026-05-27 10:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 10:02 [PATCH 0/2] ASoC: sti: Use guard() for mutex & spin locks phucduc.bui
2026-05-27 10:02 ` phucduc.bui [this message]
2026-05-27 10:02 ` [PATCH 2/2] ASoC: sti: uniperif_player: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260527100206.26788-2-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=arnaud.pouliquen@foss.st.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox