From: Herve Codina <herve.codina@bootlin.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "Baojun Xu" <baojun.xu@ti.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Jaroslav Kysela" <perex@perex.cz>, "Kevin Lu" <kevin-lu@ti.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
linux-sound@vger.kernel.org, "Mark Brown" <broonie@kernel.org>,
"Sen Wang" <sen@ti.com>, "Shenghao Ding" <shenghao-ding@ti.com>,
"Support Opensource" <support.opensource@diasemi.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>
Subject: Re: [PATCH v2 4/9] ASoC: codecs: peb2466: don't use array if single pattarn
Date: Mon, 8 Jun 2026 15:34:35 +0200 [thread overview]
Message-ID: <20260608153435.1734706b@bootlin.com> (raw)
In-Reply-To: <87qzmhetlx.wl-kuninori.morimoto.gx@renesas.com>
Hi Kuninori,
On Mon, 8 Jun 2026 00:58:02 +0000
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote:
Still the typo in commit title
s/pattarn/pattern/
Best regards,
Hervé
> Because it is confusable during debugging ASoC FW update, tidyup
> auto format style not to use array if single pattern case.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/codecs/peb2466.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/peb2466.c b/sound/soc/codecs/peb2466.c
> index 2d5163c15d0d1..2d71d204d8fa2 100644
> --- a/sound/soc/codecs/peb2466.c
> +++ b/sound/soc/codecs/peb2466.c
> @@ -817,18 +817,17 @@ static int peb2466_dai_startup(struct snd_pcm_substream *substream,
> &peb2466_sample_bits_constr);
> }
>
> -static const u64 peb2466_dai_formats[] = {
> +static const u64 peb2466_dai_formats =
> SND_SOC_POSSIBLE_DAIFMT_DSP_A |
> - SND_SOC_POSSIBLE_DAIFMT_DSP_B,
> -};
> + SND_SOC_POSSIBLE_DAIFMT_DSP_B;
>
> static const struct snd_soc_dai_ops peb2466_dai_ops = {
> .startup = peb2466_dai_startup,
> .hw_params = peb2466_dai_hw_params,
> .set_tdm_slot = peb2466_dai_set_tdm_slot,
> .set_fmt = peb2466_dai_set_fmt,
> - .auto_selectable_formats = peb2466_dai_formats,
> - .num_auto_selectable_formats = ARRAY_SIZE(peb2466_dai_formats),
> + .auto_selectable_formats = &peb2466_dai_formats,
> + .num_auto_selectable_formats = 1,
> };
>
> static struct snd_soc_dai_driver peb2466_dai_driver = {
next prev parent reply other threads:[~2026-06-08 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 0:57 [PATCH v2 0/9] ASoC: don't use array if single pattarn Kuninori Morimoto
2026-06-08 0:57 ` [PATCH v2 1/9] ASoC: remove SND_SOC_POSSIBLE_xBx_xFx Kuninori Morimoto
2026-06-08 0:57 ` [PATCH v2 2/9] ASoC: codecs: framer-codec: don't use array if single pattarn Kuninori Morimoto
2026-06-08 13:33 ` Herve Codina
2026-06-08 23:12 ` Kuninori Morimoto
2026-06-08 0:57 ` [PATCH v2 3/9] ASoC: codecs: idt821034: " Kuninori Morimoto
2026-06-08 13:33 ` Herve Codina
2026-06-08 0:58 ` [PATCH v2 4/9] ASoC: codecs: peb2466: " Kuninori Morimoto
2026-06-08 13:34 ` Herve Codina [this message]
2026-06-08 0:58 ` [PATCH v2 5/9] ASoC: codecs: ak4619: update auto select format Kuninori Morimoto
2026-06-08 0:58 ` [PATCH v2 6/9] ASoC: codecs: pcm3168a: " Kuninori Morimoto
2026-06-08 0:58 ` [PATCH v2 7/9] ASoC: renesas: rcar: " Kuninori Morimoto
2026-06-08 0:58 ` [PATCH v2 8/9] ASoC: update auto format selection method Kuninori Morimoto
2026-06-08 0:58 ` [PATCH v2 9/9] ASoC: audio-graph-card2: recommend to use auto select DAI format Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608153435.1734706b@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox