From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Nick Li <nick.li@foursemi.com>,
Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Srinivas Kandagatla <srini@kernel.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
Oder Chiou <oder_chiou@realtek.com>,
Linus Walleij <linusw@kernel.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
Marco Crivellari <marco.crivellari@suse.com>,
Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Qianfeng Rong <rongqianfeng@vivo.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 08/27] ASoC: codecs: hdmi-codec: Use guard() for mutex locks
Date: Tue, 30 Jun 2026 13:34:30 +0700 [thread overview]
Message-ID: <20260630063449.503996-9-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260630063449.503996-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/codecs/hdmi-codec.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
index 13ae9e83bc21..bc2c22436ba6 100644
--- a/sound/soc/codecs/hdmi-codec.c
+++ b/sound/soc/codecs/hdmi-codec.c
@@ -4,6 +4,7 @@
* Copyright (C) 2015 Texas Instruments Incorporated - https://www.ti.com/
* Author: Jyri Sarha <jsarha@ti.com>
*/
+#include <linux/cleanup.h>
#include <linux/module.h>
#include <linux/string.h>
#include <sound/core.h>
@@ -452,31 +453,30 @@ static int hdmi_codec_startup(struct snd_pcm_substream *substream,
if (!((has_playback && tx) || (has_capture && !tx)))
return 0;
- mutex_lock(&hcp->lock);
+ guard(mutex)(&hcp->lock);
if (hcp->busy) {
dev_err(dai->dev, "Only one simultaneous stream supported!\n");
- mutex_unlock(&hcp->lock);
return -EINVAL;
}
if (hcp->hcd.ops->audio_startup) {
ret = hcp->hcd.ops->audio_startup(dai->dev->parent, hcp->hcd.data);
if (ret)
- goto err;
+ return ret;
}
if (tx && hcp->hcd.ops->get_eld) {
ret = hcp->hcd.ops->get_eld(dai->dev->parent, hcp->hcd.data,
hcp->eld, sizeof(hcp->eld));
if (ret)
- goto err;
+ return ret;
snd_parse_eld(dai->dev, &hcp->eld_parsed,
hcp->eld, sizeof(hcp->eld));
ret = snd_pcm_hw_constraint_eld(substream->runtime, hcp->eld);
if (ret)
- goto err;
+ return ret;
/* Select chmap supported */
hdmi_codec_eld_chmap(hcp);
@@ -484,8 +484,6 @@ static int hdmi_codec_startup(struct snd_pcm_substream *substream,
hcp->busy = true;
-err:
- mutex_unlock(&hcp->lock);
return ret;
}
@@ -503,9 +501,8 @@ static void hdmi_codec_shutdown(struct snd_pcm_substream *substream,
hcp->chmap_idx = HDMI_CODEC_CHMAP_IDX_UNKNOWN;
hcp->hcd.ops->audio_shutdown(dai->dev->parent, hcp->hcd.data);
- mutex_lock(&hcp->lock);
+ guard(mutex)(&hcp->lock);
hcp->busy = false;
- mutex_unlock(&hcp->lock);
}
static int hdmi_codec_fill_codec_params(struct snd_soc_dai *dai,
--
2.43.0
next prev parent reply other threads:[~2026-06-30 6:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-30 6:34 [PATCH 00/27] ASoC: codecs: Use guard() for mutex & spin locks phucduc.bui
2026-06-30 6:34 ` [PATCH 01/27] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-06-30 6:34 ` [PATCH 02/27] ASoC: codecs: da7219: " phucduc.bui
2026-06-30 6:34 ` [PATCH 03/27] ASoC: codecs: es8316: " phucduc.bui
2026-06-30 6:34 ` [PATCH 04/27] ASoC: codecs: es8326: " phucduc.bui
2026-06-30 6:34 ` [PATCH 05/27] ASoC: codecs: es9356: " phucduc.bui
2026-06-30 6:34 ` [PATCH 06/27] ASoC: codecs: fs210x: " phucduc.bui
2026-06-30 6:34 ` [PATCH 07/27] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-06-30 6:34 ` phucduc.bui [this message]
2026-06-30 6:34 ` [PATCH 09/27] ASoC: codecs: idt821034: " phucduc.bui
2026-06-30 7:28 ` Herve Codina
2026-06-30 9:14 ` Bui Duc Phuc
2026-06-30 13:28 ` Mark Brown
2026-06-30 13:50 ` Bui Duc Phuc
2026-06-30 6:34 ` [PATCH 10/27] ASoC: codecs: lpass-macro: " phucduc.bui
2026-06-30 6:34 ` [PATCH 11/27] ASoC: codecs: madera: " phucduc.bui
2026-06-30 6:34 ` [PATCH 12/27] ASoC: codecs: max98095: " phucduc.bui
2026-06-30 6:34 ` [PATCH 13/27] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-06-30 6:34 ` [PATCH 14/27] ASoC: codecs: pcm512x: " phucduc.bui
2026-06-30 6:34 ` [PATCH 15/27] ASoC: codecs: pcm6240: " phucduc.bui
2026-06-30 6:34 ` [PATCH 16/27] ASoC: codecs: peb2466: " phucduc.bui
2026-06-30 6:54 ` Herve Codina
2026-06-30 6:34 ` [PATCH 17/27] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-06-30 6:34 ` [PATCH 18/27] ASoC: codecs: rt5645: " phucduc.bui
2026-06-30 6:34 ` [PATCH 19/27] ASoC: codecs: rt5665: " phucduc.bui
2026-06-30 6:34 ` [PATCH 20/27] ASoC: codecs: rt5668: " phucduc.bui
2026-06-30 6:34 ` [PATCH 21/27] ASoC: codecs: rt5677: " phucduc.bui
2026-06-30 6:34 ` [PATCH 22/27] ASoC: codecs: rt5682: " phucduc.bui
2026-06-30 6:34 ` [PATCH 23/27] ASoC: codecs: rt700: " phucduc.bui
2026-06-30 6:34 ` [PATCH 24/27] ASoC: codecs: rt711: " phucduc.bui
2026-06-30 6:34 ` [PATCH 25/27] ASoC: codecs: rt712: " phucduc.bui
2026-06-30 6:34 ` [PATCH 26/27] ASoC: codecs: rt721: " phucduc.bui
2026-06-30 6:34 ` [PATCH 27/27] ASoC: codecs: rt722: " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630063449.503996-9-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=herve.codina@bootlin.com \
--cc=kees@kernel.org \
--cc=kevin-lu@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=matthias.bgg@gmail.com \
--cc=nick.li@foursemi.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=rongqianfeng@vivo.com \
--cc=sammiee5311@gmail.com \
--cc=sen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=srini@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=zhangyi@everest-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox