Linux Sound subsystem development
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: cassiogabrielcontato@gmail.com,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Kees Cook <kees@kernel.org>, Ziqing Chen <chenziqing@xiaomi.com>,
	HariKrishna Sagala <hariconscious@gmail.com>,
	Dan Carpenter <error27@gmail.com>,
	Cen Zhang <zzzccc427@gmail.com>, Len Bao <len.bao@gmx.us>,
	HanQuan <eilaimemedsnaimel@gmail.com>,
	Kyle Zeng <kylebot@openai.com>,
	Dewei Meng <mengdewei@cqsoftware.com.cn>,
	Maoyi Xie <maoyixie.tju@gmail.com>,
	Mehul Rao <mehulrao@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Nathan Chancellor <nathan@kernel.org>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 0/7] ALSA: Remove redundant open helper return checks
Date: Thu,  2 Jul 2026 15:44:37 +0700	[thread overview]
Message-ID: <20260702084445.519669-1-phucduc.bui@gmail.com> (raw)

From: bui duc phuc <phucduc.bui@gmail.com>

Hi all,

This series removes redundant error checks after calls to
nonseekable_open() and stream_open() in the ALSA core.

nonseekable_open() always returns 0, so checking its return value is
unnecessary.

Several users were later converted from nonseekable_open() to
stream_open(), but the original error checks were retained.
Since stream_open() also always returns 0, those checks are likewise
unnecessary.

As a result, all patches simply remove dead error handling paths with no
functional change.

Change in v2 : 
 - Drop the unnecessary assignment of the return value from
   nonseekable_open()/stream_open(), as suggested by Takashi.
 - Merge the individual patches into a single patch series.

Best regards,
Phuc

bui duc phuc (7):
  ALSA: control: Drop redundant stream_open() return check
  ALSA: mixer: oss: Drop redundant nonseekable_open() return check
  ALSA: pcm: oss: Drop redundant nonseekable_open() return check
  ALSA: pcm: Drop redundant nonseekable_open() return check
  ALSA: rawmidi: Drop redundant stream_open() return check
  ALSA: seq: Drop redundant stream_open() return check
  ALSA: timer: Drop redundant stream_open() return check

 sound/core/control.c           |  4 +---
 sound/core/oss/mixer_oss.c     |  4 +---
 sound/core/oss/pcm_oss.c       |  4 +---
 sound/core/pcm_native.c        | 14 ++++++++------
 sound/core/rawmidi.c           |  4 +---
 sound/core/seq/seq_clientmgr.c |  5 +----
 sound/core/timer.c             |  5 +----
 7 files changed, 14 insertions(+), 26 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-07-02  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  8:44 phucduc.bui [this message]
2026-07-02  8:44 ` [PATCH v2 1/7] ALSA: control: Drop redundant stream_open() return check phucduc.bui
2026-07-02  8:44 ` [PATCH v2 2/7] ALSA: mixer: oss: Drop redundant nonseekable_open() " phucduc.bui
2026-07-02  8:44 ` [PATCH v2 3/7] ALSA: pcm: " phucduc.bui
2026-07-02  8:44 ` [PATCH v2 4/7] ALSA: pcm: " phucduc.bui
2026-07-02  8:44 ` [PATCH v2 5/7] ALSA: rawmidi: Drop redundant stream_open() " phucduc.bui
2026-07-02  8:44 ` [PATCH v2 6/7] ALSA: seq: " phucduc.bui
2026-07-02  8:44 ` [PATCH v2 7/7] ALSA: timer: " phucduc.bui
2026-07-02  9:31 ` [PATCH v2 0/7] ALSA: Remove redundant open helper return checks Cezary Rojewski
2026-07-03 11:06 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260702084445.519669-1-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=cassiogabrielcontato@gmail.com \
    --cc=cezary.rojewski@intel.com \
    --cc=chenziqing@xiaomi.com \
    --cc=eilaimemedsnaimel@gmail.com \
    --cc=error27@gmail.com \
    --cc=hariconscious@gmail.com \
    --cc=kees@kernel.org \
    --cc=kylebot@openai.com \
    --cc=len.bao@gmx.us \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=maoyixie.tju@gmail.com \
    --cc=mehulrao@gmail.com \
    --cc=mengdewei@cqsoftware.com.cn \
    --cc=nathan@kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=zzzccc427@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox