From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D15E13A7F5F for ; Sat, 4 Jul 2026 10:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783162675; cv=none; b=YgbePJyWm8nn40UvG3yWIRtbEgtUtnTSu1DtHIG3sS3Hxkvx132SNAUKQu+81H4fUOfPRy964U9TDlBxqjOhM81RpeAg3Y4s1FpCJrcPyV5W4rXb6CI4C0xLO9Fx+E/X+0T5UQbP7iXVYAGAKvc+WdQWDgbEvJtco1nAdw7eClg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783162675; c=relaxed/simple; bh=LpNMONAFHratRfzTozrtWCPtx2mIhGjyICB1cGXRlQM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bT90HjnUhUP2eSvce5pnbGVN5O+TXOZ8imhhvyGUVCAyrkmaA3GDEWf6NfpwP/Q0GooHpn4KkEBBf0GRAVgwXtTTzdY4UwTbpfcw6qClRamRuHv+mOpMZxy3/i9032ZxFRdugKOfqJOdI34YRezZobAhUNW+BclOfsUTB+TTKos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fxSfLdah; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fxSfLdah" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c96bfabc8d4so672528a12.3 for ; Sat, 04 Jul 2026 03:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783162673; x=1783767473; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6fJsXDYm01gP/6NPsGPNca/1nthqrVfe5CcgN03ZolE=; b=fxSfLdahgyUDsb0hQUOYnjCQ0G3Zka6kWDxRkfUC1HLTLN7R3072W8t+OPoBLvV6iU 8VPdTBkF9MxsHVknhsowwJQpvHGzAk1Pw1mQU0wxuMlz+m8kp0DLdKmJ1CAMBcJfjG29 cpxtF3mhOwpuKUyGFBjVxb5FtM4eNWpl2XAa+ZhvkUdCISBRL959io2uUrUhGCNyKXuZ a7ac382nFKodEM/NFZoOM4kDkqteUa/LmGYeITqQYJkW6cUzEGCiFdH4StMyslx1tNjm 29L8g0RjFkUVAjsNli7W8RcI+lvTayQmZ+vWSOtq8RkIFYTR//i6G8TssEsbsCwOLxDy 59Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783162673; x=1783767473; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6fJsXDYm01gP/6NPsGPNca/1nthqrVfe5CcgN03ZolE=; b=aETWSuRgcOXKXlUiUiUn9WidGfzrmOJxpCZcR1zM1qwP56J+uD6gVDnuUrjyoj+cUI TFgdGDS4aNX2RPChEBGux/U48aB+iRU/culSwEo9/QpjoDK25XMxMo8AUJe4YT4mShzj gYqiFnfztpIndb0Wzx3OYa9aBJIthgTyiVK1zye0rGexog04nSF0j1yPLdn0Yt9bKLmT H5FY2i5/tvH71A86MtBXVwQAsBhwEOTJ0FZWaymj6Cna4LTE2mF6Wu6nD9xp+Exi37Gm XEnod+8RwDt+XQPTs5vyEeE87FEanqS7lLKDvmTGA8rnTEcBP7aOf4xVt4OYoKsMz1tn 3mug== X-Forwarded-Encrypted: i=1; AFNElJ/5P5JAjstXDOw5GAVbugd5NHzKsL/wg/bSHTvTfYw6nIO/mBLPzm8YrPSLIQn0kBCVVQ0fpJYGAWFATA==@vger.kernel.org X-Gm-Message-State: AOJu0YzdXDAMvHnLm6/DupjyAYX/mHGgSsXjwmJAuMvAP/E1EQTs6P5C iOZT6vYXd1h7Nwayz9/M9tBiesAtjUteKRljvkB2FqxyLSdaU9N7+YfR X-Gm-Gg: AfdE7cmzDp4YkKpIIWV2hFZrW27AoXmBisgnhf8AA70CFCAnh2ES6rp1TcrDNjstuxB x4pyp8PmGmVfuRhkuo7YU4d8myatQoktf6Od4qspEf0gmUhI5gJSXpUqRmkhNzpOQY0VMrgWT2Z SE9+5SCeITch/cBeNrcW12y8zw6H1542DyD33jC04fmKTniegBtzLRNvk77k9rrkK1vFvg/Q2Xs GkRBIv0+o8ATZ2TYanwcfU+6vvrS0pd91TV3gXoDDxIjlud1iDFGVDnkUJzIeEODSC51HxxbKPu nlSBgymrDav1wP2/BBxzMIcfpebYcCtsmb+iHwWUQfFF8HUNC0f/srDVr+E+ui1cMC7K/AGmaW5 XcbFi9y3FGe+cALa9KilNtryRTte38W0aXuhuVDMbOTxzSs2S0yW/S4a7Z0f+lQsAwGjsqArmXB JHfETgoEoRFMK5mXb5kxCe5lpgrEOySj20fFCayRd/7mUdvSi7I1P4S7tCfQ== X-Received: by 2002:a05:6a20:6f93:b0:3bf:82c5:ed0f with SMTP id adf61e73a8af0-3c03e512963mr3099508637.44.1783162673047; Sat, 04 Jul 2026 03:57:53 -0700 (PDT) Received: from fedora.mrout-thinkpadp16vgen1.punetw6.csb ([103.133.229.222]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30f290b6bc2sm17179812eec.27.2026.07.04.03.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Jul 2026 03:57:52 -0700 (PDT) From: Malaya Kumar Rout To: linux-kernel@vger.kernel.org Cc: mrout@redhat.com, skhan@linuxfoundation.org, me@brighamcampbell.com, Malaya Kumar Rout , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shuah Khan , linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH] selftests/alsa: Fix memory leak in find_controls error path Date: Sat, 4 Jul 2026 16:27:36 +0530 Message-ID: <20260704105736.94874-1-malayarout91@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In find_controls(), card_data is allocated with malloc() but when snd_ctl_open_lconf() fails, the code jumps to next_card without freeing the allocated memory. This results in a memory leak for each card where snd_ctl_open_lconf() fails. Add free(card_data) before goto next_card to ensure proper cleanup of the allocated memory in the error path. Fixes: 5aaf9efffc57 ("kselftest: alsa: Add simplistic test for ALSA mixer controls kselftest") Signed-off-by: Malaya Kumar Rout --- tools/testing/selftests/alsa/mixer-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/alsa/mixer-test.c b/tools/testing/selftests/alsa/mixer-test.c index d4f845c32804..c5ae2a026ce9 100644 --- a/tools/testing/selftests/alsa/mixer-test.c +++ b/tools/testing/selftests/alsa/mixer-test.c @@ -84,6 +84,7 @@ static void find_controls(void) if (err < 0) { ksft_print_msg("Failed to get hctl for card %d: %s\n", card, snd_strerror(err)); + free(card_data); goto next_card; } -- 2.54.0