Linux Sound subsystem development
 help / color / mirror / Atom feed
From: James Calligeros <jcalligeros99@gmail.com>
To: "Martin Povišer" <povik+lin@cutebit.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>
Cc: asahi@lists.linux.dev, linux-sound@vger.kernel.org,
	 linux-kernel@vger.kernel.org, Hector Martin <marcan@marcan.st>,
	 James Calligeros <jcalligeros99@gmail.com>
Subject: [PATCH v3 7/7] ASoC: apple: mca: Add delay after configuring clock
Date: Sun, 05 Jul 2026 13:37:56 +1000	[thread overview]
Message-ID: <20260705-apple-audio-redux-v3-7-ff7a7afe2b6b@gmail.com> (raw)
In-Reply-To: <20260705-apple-audio-redux-v3-0-ff7a7afe2b6b@gmail.com>

From: Hector Martin <marcan@marcan.st>

Right after the early FE setup, ADMAC gets told to start the DMA. This
can end up in a weird "slip" state with the channels transposed. Waiting
a bit fixes this; presumably this allows the clock to stabilize.

Signed-off-by: Hector Martin <marcan@marcan.st>
Signed-off-by: James Calligeros <jcalligeros99@gmail.com>
---
 sound/soc/apple/mca.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/sound/soc/apple/mca.c b/sound/soc/apple/mca.c
index 322dd8771111..afb3754a8883 100644
--- a/sound/soc/apple/mca.c
+++ b/sound/soc/apple/mca.c
@@ -225,6 +225,12 @@ static void mca_fe_early_trigger(struct snd_pcm_substream *substream, int cmd,
 			   FIELD_PREP(SERDES_CONF_SYNC_SEL, 0));
 		mca_modify(cl, serdes_conf, SERDES_CONF_SYNC_SEL,
 			   FIELD_PREP(SERDES_CONF_SYNC_SEL, cl->no + 1));
+		/*
+		 * ADMAC gets started right after this. This delay seems
+		 * to be needed for that to be reliable, e.g. ensure the
+		 * clock is stable?
+		 */
+		udelay(100);
 		break;
 	default:
 		break;

-- 
2.55.0


  parent reply	other threads:[~2026-07-05  3:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-05  3:37 [PATCH v3 0/7] ASoC: apple: mca: support simultaneous I2S capture on the frontend James Calligeros
2026-07-05  3:37 ` [PATCH v3 1/7] ASoC: apple: mca: increase SERDES reset delay James Calligeros
2026-07-05  3:37 ` [PATCH v3 2/7] ASoC: apple: mca: Separate data & clock port setup James Calligeros
2026-07-10 20:41   ` Mark Brown
2026-07-05  3:37 ` [PATCH v3 3/7] ASoC: apple: mca: Factor out mca_be_get_fe James Calligeros
2026-07-05  3:37 ` [PATCH v3 4/7] ASoC: apple: mca: Support FEs being clock consumers James Calligeros
2026-07-05  3:37 ` [PATCH v3 5/7] ASoC: apple: mca: Support capture on multiples BEs James Calligeros
2026-07-05  3:37 ` [PATCH v3 6/7] ASoC: apple: mca: Do not mark clocks in use for non-providers James Calligeros
2026-07-05  3:37 ` James Calligeros [this message]
2026-07-10 18:04 ` [PATCH v3 0/7] ASoC: apple: mca: support simultaneous I2S capture on the frontend Mark Brown
2026-07-10 22:24   ` Mark Brown
2026-07-11  1:09     ` James Calligeros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260705-apple-audio-redux-v3-7-ff7a7afe2b6b@gmail.com \
    --to=jcalligeros99@gmail.com \
    --cc=asahi@lists.linux.dev \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox