From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84FCF36C588 for ; Wed, 8 Jul 2026 12:51:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515097; cv=none; b=rwLwwvoMS57pTNgMuyfNuV29bMqFe9SwSd0wo7RI8h3OWovkk0LdjtoBRrMByi/8UtjluoIGJc6dRdCaG04MVDOP3rUsKE4nf3uqv/y7w+xa+NzUdOGBxmUAmZnqKm3EPUMjyKExse/LxULRSMBsl8TSFg99j7r29TmNICTimcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783515097; c=relaxed/simple; bh=FZJHEq+m+NwJ2REYxhVqqiGn9Us8YuJAuO/EjhxISdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j1U/fTkLY0d/95dNjzg/YVe+u1tOe7Kd+pX52q06iWNunmtHbb2IcWD5Rt68Gl5eR/TPjiitKUlLVi5enMlH2V2Io39S69W6Mx+pCUVXuI6Qbnj+yHzEUS08F3yQi8a/yK68wCbKkQ5vuossAWVzj4zAKD7do/65un/BpEWpG1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qGHyZ1Ez; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qGHyZ1Ez" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-381891a9525so789662a91.3 for ; Wed, 08 Jul 2026 05:51:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783515095; x=1784119895; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5A9Wsb8hutS/8m09pj/ujWNwrZYrSgIajODypS2rlzs=; b=qGHyZ1EzOAjEk7TPCc7ys0GJkeLJpAAIL8XAV5k7zGTnTQlOvuflNPmtxSfky95+/h Hy85E5WBjahw1Zf8xP/RTvfp+zNVXKfN1r4/zdhGW6lIHsSml3sz0vRwg6Dz2wZMCb6X up16e513al5tuTNJopOTNDf0ASWDp9H+jX3kcbKyfvB1q6U+3+RFpMDXdojKJa5t6wV4 IOWBiIhR/GsCHlQULkF9qUi83FNE02y/LfldnYu4F4uAi1GVm8L49N5efPGo6P7LbGCq 8RxlZDu1I44eT9v0ZF8rXAu9Zv86o+gfc3KvMwdTP10jtDcEyxn06qesTwW0SrEvqx1C /m6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783515095; x=1784119895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=5A9Wsb8hutS/8m09pj/ujWNwrZYrSgIajODypS2rlzs=; b=aSHE2mcssCbvj/mQCQeDvtTLb3JYArj3y7DYROxwP6tnsHbIEXrTJtJdE4U2MFPlU7 njk+l8zv/w10Crl5nwSK8bqO4j3u/8BAL4QEBMV8rTZrGIyUzxKgyM6+dN5PGkIutdhh 7kcVxwamZP9bmQ5dP2eLzUczYtMLVMOaUxtdyYyEHXvBqS9VKHGLsR7AUW4crm6ntxW8 gl8+lRIqOdYZcdVnwumZQA4m1YnRiKgT2QgbUBHqW8GL0pfqsiJLoQs6PseQOap/I5GE E1afJHmIoWaDgo3VU2uuummHvZakokOSHSRD1bfVDctOMb2NCBA5clkNzuwzCKPnSob/ 5fOg== X-Forwarded-Encrypted: i=1; AHgh+RpIBNReVFCSWDffGm503K1/7reZy4CFlbPP+I84IFyKqWXplqvPoyTzu1L7Bo1p87mvaBDuyA7hI/KRBA==@vger.kernel.org X-Gm-Message-State: AOJu0Yyv2hG6EGp1FEg/ln8xqpni0d383piElxZIAXra6ZUJHeFcbljk xFgjEGleNhEe2o+iGeYGOmJzhsSBFxQYHY/dM1WtoTBnBFF6lgcxUQcX X-Gm-Gg: AfdE7cm8pBBHM1inwQpT2txDGEwL1jmRHU3Qzwm9dSI8myGKqmTD6S0HhJ7M08f33I4 C1sLQTbomq+wSfPYC1HWd0dOMINO54lOS2AaDSaqyd873c8gUNcmTMdm+nhOm7svLjzOrKLlYwI 5jvF+Y3hk6/1FJ7QqX+6Qg3j1ggUIcZVsn+JLLga26CE7U4fIDVlYQDhSu4gTtQoKCFFQtAmhy3 CaLaeLFDM6L8HzfBhmaXQr30tETiO5UbvstfJYDA2DAJN+Et4c+BGQt0qBJ6hH0P2BexQnDw7/8 X9JLQswv7RPKZWIcWkI/YAFvybFv1y2P+waqJZn0qhyxpdO+tT7tJpfUn7J0P0Se97oJ3EGMXgA ZFyWo4J3GdR2SjZonDzS6muHMXeUSs7qGVefaoteL23hkIwuvsfGF7SZlCDZQYPSx9a1dTRg7Nr oMCX32+8yw8WXbknF1LELrWGtjo1s0U6IZ+H62XkHuvDA740g= X-Received: by 2002:a17:90b:384f:b0:37e:1c8f:3dff with SMTP id 98e67ed59e1d1-3893fb746dfmr2587279a91.11.1783515094892; Wed, 08 Jul 2026 05:51:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-387d20a2f2fsm2784349a91.13.2026.07.08.05.51.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 05:51:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Tzung-Bi Shih , David Rhodes , Charles Keepax Cc: Liam Girdwood , Jaroslav Kysela , Cheng-Yi Chiang , Guenter Roeck , Benson Leung , Richard Fitzgerald , povik+lin@cutebit.org, u.kleine-koenig@baylibre.com, kuninori.morimoto.gx@renesas.com, christian.ehrhardt@codasip.com, Linus Walleij , Arnd Bergmann , Sakari Ailus , Thorsten Blum , Chris Morgan , Dan Carpenter , Marco Crivellari , Rosen Penev , Weidong Wang , Teguh Sobirin , Val Packett , Luca Weiss , wangdicheng , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, chrome-platform@lists.linux.dev, asahi@lists.linux.dev, Cezary Rojewski , bui duc phuc Subject: [PATCH v4 08/24] ASoC: codecs: aw88261: Use guard() for mutex locks Date: Wed, 8 Jul 2026 19:49:45 +0700 Message-ID: <20260708125002.202515-9-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260708125002.202515-1-phucduc.bui@gmail.com> References: <20260708125002.202515-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Reviewed-by: Cezary Rojewski Signed-off-by: bui duc phuc --- sound/soc/codecs/aw88261.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 549783d3e75e..b931b8602566 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -8,6 +8,7 @@ // Author: Weidong Wang // +#include #include #include #include @@ -960,11 +961,10 @@ static int aw88261_profile_set(struct snd_kcontrol *kcontrol, int ret; /* pa stop or stopping just set profile */ - mutex_lock(&aw88261->lock); + guard(mutex)(&aw88261->lock); ret = aw88261_dev_set_profile_index(aw88261->aw_pa, ucontrol->value.integer.value[0]); if (ret) { dev_dbg(codec->dev, "profile index does not change"); - mutex_unlock(&aw88261->lock); return 0; } @@ -973,8 +973,6 @@ static int aw88261_profile_set(struct snd_kcontrol *kcontrol, aw88261_start(aw88261); } - mutex_unlock(&aw88261->lock); - return 1; } @@ -1038,7 +1036,7 @@ static int aw88261_playback_event(struct snd_soc_dapm_widget *w, struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm); struct aw88261 *aw88261 = snd_soc_component_get_drvdata(component); - mutex_lock(&aw88261->lock); + guard(mutex)(&aw88261->lock); switch (event) { case SND_SOC_DAPM_PRE_PMU: aw88261_start(aw88261); @@ -1049,7 +1047,6 @@ static int aw88261_playback_event(struct snd_soc_dapm_widget *w, default: break; } - mutex_unlock(&aw88261->lock); return 0; } @@ -1188,12 +1185,12 @@ static int aw88261_request_firmware_file(struct aw88261 *aw88261) return ret; } - mutex_lock(&aw88261->lock); - /* aw device init */ - ret = aw88261_dev_init(aw88261, aw88261->aw_cfg); - if (ret) - dev_err(aw88261->aw_pa->dev, "dev init failed"); - mutex_unlock(&aw88261->lock); + scoped_guard(mutex, &aw88261->lock) { + /* aw device init */ + ret = aw88261_dev_init(aw88261, aw88261->aw_cfg); + if (ret) + dev_err(aw88261->aw_pa->dev, "dev init failed"); + } return ret; } -- 2.43.0