Linux Sound subsystem development
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	linux-omap@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH 08/10] ASoC: ti: omap-twl4030: Return the original error code
Date: Tue, 14 Jul 2026 19:00:40 +0700	[thread overview]
Message-ID: <20260714120042.491712-9-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260714120042.491712-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Return the error from snd_soc_of_parse_card_name() directly and drop
the redundant error message since the helper already logs the failure.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/ti/omap-twl4030.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/soc/ti/omap-twl4030.c b/sound/soc/ti/omap-twl4030.c
index 4d80f8a7a947..2a80e44035d7 100644
--- a/sound/soc/ti/omap-twl4030.c
+++ b/sound/soc/ti/omap-twl4030.c
@@ -253,10 +253,9 @@ static int omap_twl4030_probe(struct platform_device *pdev)
 		struct device_node *dai_node;
 		struct property *prop;
 
-		if (snd_soc_of_parse_card_name(card, "ti,model")) {
-			dev_err(&pdev->dev, "Card name is not provided\n");
-			return -ENODEV;
-		}
+		ret = snd_soc_of_parse_card_name(card, "ti,model");
+		if (ret)
+			return ret;
 
 		dai_node = of_parse_phandle(node, "ti,mcbsp", 0);
 		if (!dai_node) {
-- 
2.43.0


  parent reply	other threads:[~2026-07-14 12:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 12:00 [PATCH 00/10] ASoC: ti: Improve probe error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 01/10] ASoC: ti: ams-delta: Use dev_err_probe() for " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 12:00 ` [PATCH 02/10] ASoC: ti: davinci-evm: " phucduc.bui
2026-07-14 12:27   ` Christophe JAILLET
2026-07-14 12:29   ` Christophe JAILLET
2026-07-14 12:00 ` [PATCH 03/10] ASoC: ti: j721e-evm: Return the original error from card name parsing phucduc.bui
2026-07-14 12:00 ` [PATCH 04/10] ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log phucduc.bui
2026-07-14 12:00 ` [PATCH 05/10] ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling phucduc.bui
2026-07-14 12:00 ` [PATCH 06/10] ASoC: ti: omap-dmic: " phucduc.bui
2026-07-14 12:00 ` [PATCH 07/10] ASoC: ti: omap-hdmi: " phucduc.bui
2026-07-14 12:00 ` phucduc.bui [this message]
2026-07-14 12:00 ` [PATCH 09/10] ASoC: ti: omap-twl4030: " phucduc.bui
2026-07-14 12:00 ` [PATCH 10/10] ASoC: ti: rx51: " phucduc.bui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260714120042.491712-9-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox