From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B73B93B2FC0 for ; Wed, 15 Jul 2026 05:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784092319; cv=none; b=bKNDQrR8ZcinKVliCmwfptIuL7ZyskyW+usYJQl8T2cUqInLR2PC8ak3nguDP4nLKVHnhvEnDMyPjgJxFTNGPEmG2KCsv9G28z6jxpKL9as7BBl05f+kvlQOrxYEW7QWbDpQFqdIEav6A0AzsT7NNGCVyLMIwhTYrTRcDd8OAZU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784092319; c=relaxed/simple; bh=qLfioYwLvE9VutCAAUZImR+gmjyd33EDpV+qIhvHhvQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NIs+GDsf727pKv+bndttCNlTy1iFd9RHZpTS384MkIM140Fj+QJdmwjwMeIbC00sxwT2FMzWrnWHyxiFThtR6C4aCo4kf8pFiG0srYAZyhRLbHoKrnLch83KTjiWb0tHP6ik/oyqLBIY86rv14pyKxM94XllmbQjeK8nMt8+oL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WMHdvV0C; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WMHdvV0C" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-84862b0d5f8so1557914b3a.3 for ; Tue, 14 Jul 2026 22:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784092317; x=1784697117; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6Up1ItAxd03r+T8RjvfRHCmeD/3+6lpPQg/1O4r65ak=; b=WMHdvV0CNHACGH8Yv2jKEFp14PVR6QtZNPN+XtL/gE9P4O6xwiip6IAzdqFzaryyGG 8/OR19Juj6W96A5HmIs/lOiAZy2k9adiJOtUEThUGxp+knjvLodcNIknq/eqV19lXAmw upvisJvhwTefFuAvrqa/BQ1Z98NicP+IWIMWOIw+GOmopYHHld1tQhF2EWIgtaAGrAu1 PI8co0Y7l9kFKX4tlSwoGJ/JJ6Fshk6pfUlwz4LjUjqnYmWIlCN6ZlqDwWw1dY9DPOJ0 WIdqIxaj7tDgo29Icct79phYxPpWN6fFx0iLVTxsjU2NLjN4emI7Te9W7qs3sBUZ4Sgq RZmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784092317; x=1784697117; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6Up1ItAxd03r+T8RjvfRHCmeD/3+6lpPQg/1O4r65ak=; b=ZgKzf7LlZYgX3wKDjaD2jfxM+3SD9koIOrz82N1JQPvxR4WfauEPXR7iOvolN5abo1 rIONFQh2BfrbzrOxa7+wcKEg/jRcCKElqae1bVB+4XaewBR0ImbDd/bvKwTkpecdIGAf W5IuEoRsqwCf/zbOfXVpApuexsn09oWgowNnyDd7h19KJQSTQp5EcXpG001idrcGwvzU klKMUkz1igk8QIF3Kp6WZd5UHUwyqRkYt84jZ28/JYWZiAa1zFN4fqOiCIhrH01OoxxX mcirK7JImg4FL+QijAlFCbYEIKO2dQFj2TAtoXChMD7ieb2s5XQEAl3+pIN7kVdYBG+k oKNQ== X-Forwarded-Encrypted: i=1; AHgh+RpcXEQqTM/TA6865D8VnL9KKBh/djs6+ILDkXuAv6ME6GgI+hnB857ifaa4vv3etEeFMDXeK4nADaNmlQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy61DfEDvKmNXi5vinSNsrS0ACjjPI9m+5mGUY6WspKEmWMUyQC LnEhdu276WkPtCU9JCegtzZ2qjtKxI1fpigq8FiFtBbUdSHsNG8B8wQ3 X-Gm-Gg: AfdE7cmqpDWp/Jg2WdPJG9M8OyMMgscEZUQgPKPpPWju+stwiXH5mrJ8no1LEzR7WdB 6shsm+M8zkMtqqHgROak/pGr+pUZ7NBxThO6uod7+rRvUi6D5CZyOOxZhm1ro3gR2AFdjNpTyY0 bL2jK0OUWdyUJ4tlq4bWQePN+BjZTha++oItrZ1X7mzNOOF5chSUYK+w6H3tEG8BiYKdyK5dN92 P0q3UXkxN+llj3dYJcvBJY/myt634wfHBsWyyXfv51iRUs1WTVIgDSoEx16bdgj8brrk0fOh6Va LIBwI3FXuJIkfhwg8FwCVJfOkTMYhW3DBAG0fyBC3BEA/yPjeJDQUDzrKuh74V0WCRN44tUNzNO MiBpZ1qEKu13g0oW7To3+/NgofjBuOjSiQI2CBOf2bAIv+W6Zscaq5vhYF458r6qqCBPbSjYnQF Rqqgkr/0hg6SaTwCIhQCEuCvof4bNDUMegycd7qmph9QZoB2A= X-Received: by 2002:a05:6a00:b47:b0:847:9c99:ea52 with SMTP id d2e1a72fcca58-848896084ebmr15599104b3a.24.1784092317042; Tue, 14 Jul 2026 22:11:57 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84a4f271ddbsm2594093b3a.18.2026.07.14.22.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 22:11:56 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Thierry Reding , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Jonathan Hunter Cc: Krzysztof Kozlowski , Sheetal , u.kleine-koenig@baylibre.com, Kuninori Morimoto , Rosen Penev , Piyush Patle , Takashi Sakamoto , Bjorn Helgaas , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, bui duc phuc Subject: [PATCH 3/4] ASoC: tegra: tegra210_amx: Return the original error directly Date: Wed, 15 Jul 2026 12:11:14 +0700 Message-ID: <20260715051115.17385-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715051115.17385-1-phucduc.bui@gmail.com> References: <20260715051115.17385-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_soc_add_component_controls() already reports failures internally. Return its error code directly instead of logging the error again in the component probe callback. Also remove the now unnecessary local error variable. Signed-off-by: bui duc phuc --- sound/soc/tegra/tegra210_amx.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/sound/soc/tegra/tegra210_amx.c b/sound/soc/tegra/tegra210_amx.c index cc1f9c158191..6a67ce6128b4 100644 --- a/sound/soc/tegra/tegra210_amx.c +++ b/sound/soc/tegra/tegra210_amx.c @@ -504,16 +504,12 @@ static struct snd_kcontrol_new tegra264_amx_controls[] = { static int tegra210_amx_component_probe(struct snd_soc_component *component) { struct tegra210_amx *amx = snd_soc_component_get_drvdata(component); - int err = 0; - if (amx->soc_data->num_controls) { - err = snd_soc_add_component_controls(component, amx->soc_data->controls, - amx->soc_data->num_controls); - if (err) - dev_err(component->dev, "can't add AMX controls, err: %d\n", err); - } + if (amx->soc_data->num_controls) + return snd_soc_add_component_controls(component, amx->soc_data->controls, + amx->soc_data->num_controls); - return err; + return 0; } static const struct snd_soc_component_driver tegra210_amx_cmpnt = { -- 2.43.0