Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Ian Bridges <icb@fastmail.org>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hardening@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/generic: Replace strlcat() with strscpy()
Date: Wed, 15 Jul 2026 09:45:16 -0700	[thread overview]
Message-ID: <202607150944.0EDBF2874@keescook> (raw)
In-Reply-To: <ale0bq8DSefjWC3P@dev>

On Wed, Jul 15, 2026 at 11:25:18AM -0500, Ian Bridges wrote:
> A seq_buf conversion would also be possible.

I think this is the right approach. The string/length is passed around
as arguments already, so switching that to seq_buf would mean all the
users of those arg wouldn't have to do their own bounds checking, etc.

-- 
Kees Cook

      reply	other threads:[~2026-07-15 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 19:36 [PATCH] ALSA: hda/generic: Replace strlcat() with strscpy() Ian Bridges
2026-07-15  7:54 ` Takashi Iwai
2026-07-15 16:25   ` Ian Bridges
2026-07-15 16:45     ` Kees Cook [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202607150944.0EDBF2874@keescook \
    --to=kees@kernel.org \
    --cc=icb@fastmail.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox