Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Julian Braha <julianbraha@gmail.com>
To: srini@kernel.org, andersson@kernel.org, konradybcio@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, arnd@arndb.de,
	Julian Braha <julianbraha@gmail.com>
Subject: [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG
Date: Sun, 19 Jul 2026 03:22:41 +0100	[thread overview]
Message-ID: <20260719022242.139472-1-julianbraha@gmail.com> (raw)

QCOM_PDR_MSG is defined in an 'if QCOM_SOC..endif', so its selectors
QCOM_PDR_HELPERS and SLIM_QCOM_NGD_CTRL also need to ensure QCOM_SOC is
enabled. Otherwise, QCOM_PDR_MSG has an unmet dependency, such as:

WARNING: unmet direct dependencies detected for QCOM_PDR_MSG
  Depends on [n]: QCOM_SOC [=n]
  Selected by [y]:
  - QCOM_PDR_HELPERS [=y] && ARCH_QCOM [=y] && NET [=y]

This unmet dependency was found by kconfirm, a static analysis tool for
Kconfig.

Fixes: f2866e6a27f7 ("soc: qcom: Hide all drivers behind selectable menu")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
 drivers/slimbus/Kconfig  | 2 +-
 drivers/soc/qcom/Kconfig | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 60b0dcbc0ebb..5dded61191e0 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -17,7 +17,7 @@ config SLIM_QCOM_NGD_CTRL
 	tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
 	depends on HAS_IOMEM && DMA_ENGINE && NET
 	depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
-	depends on ARCH_QCOM || COMPILE_TEST
+	depends on QCOM_SOC && (ARCH_QCOM || COMPILE_TEST)
 	select QCOM_QMI_HELPERS
 	select QCOM_PDR_HELPERS
 	help
diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index fd4d4ecd2df0..ef844947593c 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -292,7 +292,7 @@ config QCOM_PBS
 	  This module provides the APIs to the client drivers that wants to send the
 	  PBS trigger event to the PBS RAM.
 
-endif
+endif # QCOM_SOC
 
 # Options selected by other drivers from different subsystems must be outside
 # of the menuconfig if-block:
@@ -314,6 +314,7 @@ config QCOM_PDR_HELPERS
 	select QCOM_QMI_HELPERS
 	select QCOM_PDR_MSG
 	depends on NET
+	depends on QCOM_SOC
 
 config QCOM_QMI_HELPERS
 	tristate
-- 
2.54.0


             reply	other threads:[~2026-07-19  2:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-19  2:22 Julian Braha [this message]
2026-07-22 13:47 ` [PATCH] soc: qcom: fix unmet dependency for QCOM_PDR_MSG Dmitry Baryshkov
2026-07-22 13:54   ` Arnd Bergmann
2026-07-22 20:29     ` Julian Braha
2026-07-22 20:34   ` Julian Braha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260719022242.139472-1-julianbraha@gmail.com \
    --to=julianbraha@gmail.com \
    --cc=andersson@kernel.org \
    --cc=arnd@arndb.de \
    --cc=konradybcio@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=srini@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox