Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org, vkoul@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com
Subject: [PATCH 0/4] ASoC: cs35l56: Switch to using the IRQ from the SoundWire core
Date: Mon, 10 Aug 2026 11:40:41 +0100	[thread overview]
Message-ID: <20260810104045.60701-1-rf@opensource.cirrus.com> (raw)

At the time the cs35l56 driver was written the only way to get interrupts
from the SoundWire core was to implement a custom handler inside the
interrupt_callback() function.

The SoundWire core now provides a virtual IRQ for notifying ImpDef
interrupts, and switching to this simplifies the code and also makes it
more similar to the normal interrupt handling of I2C/SPI (though some
SoundWire specials are still needed).

Patches #1 and #2 do some preparatory code shuffling so that there is
less clutter in patch #4.

Patch #3 changes the SoundWire core code to create the virtual ImpDef IRQ
before calling the codec drive probe() so that the IRQ can be requested in
probe().

Richard Fitzgerald (4):
  ASoC: cs35l56: Request IRQ in cs35l56_common_probe()
  ASoC: cs35l56: Move cs35l56_irq_request() after cs35l56_irq()
  soundwire: bus_type: Create IRQ mapping before calling driver probe()
  ASoC: cs35l56: Use IRQ provided by the SoundWire core

 drivers/soundwire/bus_type.c      |  6 +--
 include/sound/cs35l56.h           |  1 -
 sound/soc/codecs/Kconfig          |  1 +
 sound/soc/codecs/cs35l56-i2c.c    | 10 +----
 sound/soc/codecs/cs35l56-sdw.c    | 69 ++++++-------------------------
 sound/soc/codecs/cs35l56-shared.c | 41 +++++++++---------
 sound/soc/codecs/cs35l56-spi.c    | 10 +----
 sound/soc/codecs/cs35l56.c        | 57 +++++++++++++------------
 sound/soc/codecs/cs35l56.h        | 11 ++---
 9 files changed, 73 insertions(+), 133 deletions(-)

-- 
2.47.3


             reply	other threads:[~2026-08-10 10:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-10 10:40 Richard Fitzgerald [this message]
2026-08-10 10:40 ` [PATCH 1/4] ASoC: cs35l56: Request IRQ in cs35l56_common_probe() Richard Fitzgerald
2026-08-10 10:40 ` [PATCH 2/4] ASoC: cs35l56: Move cs35l56_irq_request() after cs35l56_irq() Richard Fitzgerald
2026-08-10 10:40 ` [PATCH 3/4] soundwire: bus_type: Create IRQ mapping before calling driver probe() Richard Fitzgerald
2026-08-11  5:16   ` Vinod Koul
2026-08-11  8:37     ` Richard Fitzgerald
2026-08-10 10:40 ` [PATCH 4/4] ASoC: cs35l56: Use IRQ provided by the SoundWire core Richard Fitzgerald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810104045.60701-1-rf@opensource.cirrus.com \
    --to=rf@opensource.cirrus.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox