Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Nikita Koval <me@nikitakoval.com>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-sound@vger.kernel.org, Nikita Koval <me@nikitakoval.com>
Subject: [PATCH] ASoC: amd: fix DMIC detection on Lenovo ThinkPad P14s Gen 6 AMD
Date: Fri, 11 Sep 2026 18:20:50 +0600	[thread overview]
Message-ID: <20260911122050.42453-1-me@nikitakoval.com> (raw)

The Lenovo ThinkPad P14s Gen 6 AMD with BIOS R2XET41W (1.21)
reports acp-audio-config-flag as FLAG_AMD_LEGACY_ONLY_DMIC.

This causes the legacy ACP driver path to be selected and results in:

  No matching ASoC machine driver found

The firmware otherwise exposes a valid PDM microphone device through
ACPI, with _ADR 0x02 and acp-audio-device-type 0x02.

After selecting the snd_pci_ps path, the firmware _WOV method returns
0. The driver currently treats this as disabling the PDM/DMIC path,
which prevents the internal microphone from being registered.

Add DMI quirks for the ThinkPad P14s Gen 6 AMD to ignore the firmware
ACP config flag and the _WOV value.

With these quirks applied, the internal microphone is registered as:

  acp63: DMIC capture dmic-hifi-0

and capture works correctly.

DMI:
  System Vendor: LENOVO
  Product Name: 21RV000NUS
  Product Version: ThinkPad P14s Gen 6 AMD

Tested with BIOS R2XET41W (1.21) and Linux 7.2.4.

Signed-off-by: Nikita Koval <me@nikitakoval.com>
---
 sound/soc/amd/acp-config.c |  7 +++++++
 sound/soc/amd/ps/pci-ps.c  | 14 +++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/sound/soc/amd/acp-config.c b/sound/soc/amd/acp-config.c
index 2d50be819..0372906f9 100644
--- a/sound/soc/amd/acp-config.c
+++ b/sound/soc/amd/acp-config.c
@@ -77,6 +77,13 @@ static const struct dmi_system_id acp70_acpi_flag_override_table[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "8EA2"),
 		},
 	},
+	{
+		/* Lenovo ThinkPad P14s Gen 6 AMD */
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad P14s Gen 6 AMD")
+		},
+	},
 	{}
 };
 
diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
index 729f9aaba..afb8c78d3 100644
--- a/sound/soc/amd/ps/pci-ps.c
+++ b/sound/soc/amd/ps/pci-ps.c
@@ -10,6 +10,7 @@
 #include <linux/module.h>
 #include <linux/io.h>
 #include <linux/delay.h>
+#include <linux/dmi.h>
 #include <linux/platform_device.h>
 #include <linux/acpi.h>
 #include <linux/interrupt.h>
@@ -401,6 +402,17 @@ static int acp63_machine_register(struct device *dev)
 	return 0;
 }
 
+static const struct dmi_system_id acp_ignore_wov_table[] = {
+	{
+		/* Lenovo ThinkPad P14s Gen 6 AMD */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad P14s Gen 6 AMD"),
+		},
+	},
+	{}
+};
+
 static int get_acp63_device_config(struct pci_dev *pci, struct acp63_dev_data *acp_data)
 {
 	struct acpi_device *pdm_dev;
@@ -430,7 +442,7 @@ static int get_acp63_device_config(struct pci_dev *pci, struct acp63_dev_data *a
 
 		handle = ACPI_HANDLE(&pci->dev);
 		ret = acpi_evaluate_integer(handle, "_WOV", NULL, &dmic_status);
-		if (!ACPI_FAILURE(ret))
+		if (!ACPI_FAILURE(ret) && !dmi_check_system(acp_ignore_wov_table))
 			wov_en = dmic_status;
 	}
 
-- 
2.55.0


             reply	other threads:[~2026-09-11 12:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11 12:20 Nikita Koval [this message]
2026-09-12  9:48 ` [PATCH] ASoC: amd: fix DMIC detection on Lenovo ThinkPad P14s Gen 6 AMD Nikita Koval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911122050.42453-1-me@nikitakoval.com \
    --to=me@nikitakoval.com \
    --cc=Vijendar.Mukunda@amd.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-sound@vger.kernel.org \
    --cc=venkataprasad.potturu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox