From: Cezary Rojewski <cezary.rojewski@intel.com>
To: broonie@kernel.org
Cc: tiwai@suse.com, perex@perex.cz, amade@asmblr.net,
linux-sound@vger.kernel.org,
Cezary Rojewski <cezary.rojewski@intel.com>
Subject: [PATCH 1/2] ASoC: Intel: avs: Use list_count_nodes() to simplify the code
Date: Mon, 14 Sep 2026 12:19:16 +0200 [thread overview]
Message-ID: <20260914101917.2969665-1-cezary.rojewski@intel.com> (raw)
By enlisting list_count_nodes(), a recent addition to the list.h, the
code responsible for manual counting of the HDAudio PCMs can be dropped.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/avs/boards/hdaudio.c | 8 +++-----
sound/soc/intel/avs/pcm.c | 7 +++----
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/sound/soc/intel/avs/boards/hdaudio.c b/sound/soc/intel/avs/boards/hdaudio.c
index 2e15a293298d..c1d2d0082b14 100644
--- a/sound/soc/intel/avs/boards/hdaudio.c
+++ b/sound/soc/intel/avs/boards/hdaudio.c
@@ -147,17 +147,15 @@ static int avs_probing_link_init(struct snd_soc_pcm_runtime *rtm)
struct snd_soc_dai_link *links = NULL;
struct snd_soc_card *card = rtm->card;
struct hda_codec *codec;
- struct hda_pcm *pcm;
- int ret, pcm_count = 0;
+ int ret, pcm_count;
mach = dev_get_platdata(card->dev);
pdata = mach->pdata;
codec = pdata->codec;
+ pcm_count = list_count_nodes(&codec->pcm_list_head);
- if (list_empty(&codec->pcm_list_head))
+ if (!pcm_count)
return -EINVAL;
- list_for_each_entry(pcm, &codec->pcm_list_head, list)
- pcm_count++;
ret = avs_create_dai_links(card->dev, codec, pcm_count, &links);
if (ret < 0) {
diff --git a/sound/soc/intel/avs/pcm.c b/sound/soc/intel/avs/pcm.c
index ad25bd355769..8174d2ebfa99 100644
--- a/sound/soc/intel/avs/pcm.c
+++ b/sound/soc/intel/avs/pcm.c
@@ -1614,7 +1614,7 @@ static int avs_component_hda_probe(struct snd_soc_component *component)
struct hda_codec *codec;
struct hda_pcm *pcm;
const char *cname;
- int pcm_count = 0, ret, i;
+ int pcm_count, ret, i;
mach = dev_get_platdata(component->card->dev);
if (!mach)
@@ -1622,10 +1622,9 @@ static int avs_component_hda_probe(struct snd_soc_component *component)
pdata = mach->pdata;
codec = pdata->codec;
- if (list_empty(&codec->pcm_list_head))
+ pcm_count = list_count_nodes(&codec->pcm_list_head);
+ if (!pcm_count)
return -EINVAL;
- list_for_each_entry(pcm, &codec->pcm_list_head, list)
- pcm_count++;
dais = devm_kcalloc(component->dev, pcm_count, sizeof(*dais),
GFP_KERNEL);
--
2.34.1
next reply other threads:[~2026-09-14 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 10:19 Cezary Rojewski [this message]
2026-09-14 10:19 ` [PATCH 2/2] ASoC: codecs: hda: Use list_count_nodes() to simplify the code Cezary Rojewski
2026-09-14 14:23 ` [PATCH 1/2] ASoC: Intel: avs: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260914101917.2969665-1-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=amade@asmblr.net \
--cc=broonie@kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox