From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0086A4A2046 for ; Tue, 15 Sep 2026 08:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.199 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460866; cv=none; b=jHoxxIaUwYG2EZscVILXLwOtm4ruqpTrOMGGF5KsTFhw3Oi3gWuzCOsMrsN8qEhPL+ALB97a2/y4rq6qOIe3W7ulHS1H6fKiqU44qfcS7gMdJgFTIh6e/teTcZS3AomMQQyW5O+DslOdjWhMzSRyIFVYYGJZ7bExXgmy4FVrRT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789460866; c=relaxed/simple; bh=Te8HD9YkwxCOhstie9EUJ32KLA4oNHtDIGXeNIM9YkI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=twRznh95hy9d7L3scuzNXSHraSWvtF3hF8jEuFEaoEHlAxRq9AvxOIxlc8YwcSX51k1ZJQ9l/yt78oSwipsQLa31EL07foCU7TvTqtzrRxX3Qf6MLpWBC8aBnv3rFjFz47mH+k3bstG4IfAQat7ery81lCUhlgBvQ1e0Y4H56Oo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=joDP/JyA; arc=none smtp.client-ip=209.85.167.199 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--morbo.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="joDP/JyA" Received: by mail-oi1-f199.google.com with SMTP id 5614622812f47-4b2fb8f0df0so5044145b6e.0 for ; Tue, 15 Sep 2026 01:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789460864; x=1790065664; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=aUeRHnlHuLyd8Os/OfUYHyanuI/6gSGpcAdXKzgjG1A=; b=joDP/JyAmVvBkePjQkvBdrQrkLLbr98hfxC5QzEgEI1/4QJ6dnibUytNO9+oWuZf+k ab0gTArHOlXoTg12/RjQXsvm8ltvc7VxpcIuUSSULXaIQQj6KnJV+Kog3htnnCWOIk1v Qh+GJ4syLN/82vHIBHSdKLpYLqFfpEFpk+cFe9FAYpFq5irN3vS+2YuIZ9oYSy7jv6A1 LNHG2hYstYchxjdkXeRMKegIVxPXvOgoggQGReDGn2Aan8c8WuzOtri3cwkGkOo0oIeD x0MR6bASazgP9+IE6rzxmyhNxCLZccO6ZWmIQ5/CULvdLksRR0LJk2IvHFaBvKqa/+JG D0cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789460864; x=1790065664; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aUeRHnlHuLyd8Os/OfUYHyanuI/6gSGpcAdXKzgjG1A=; b=w8n9DgrXhMelHvPPh5M3Z0D98DaTz8wNRAcs7xrl0uY16R4Ds/jB42FqiVgia/Zy7Q L93dSjq0zvII/3qyIYd/1iu05nNU07Ehh97DGHsJQXLCXbTpp9BS8IQu7lybRpTrmrU4 Kq6gq50Hj2ON6gZf/7A3eJwouNUKHQjppNe19OZ8fG+IrSp64AxcXY1zr5ttHiTERh1g l2pZpZcgsey8DadyPxccQNCiX7QP9AD5KbpX4FAiw+UyRFkS1De81EJwfl4bCvPvMlXn CpBzRVlWu0erHBpQ8SdPojmCe2WtsD9gAsIJUbnLinCtyMAZvWwIOksHyyooqQGdGkcN jHiQ== X-Forwarded-Encrypted: i=1; AKwUvBx3vSc5d8rcTNa5KSCllHCEFM+HrTpbOzo3+dOTLMAp8lkba6rrGwBWMGVW0D5GqiIXd1wnBEAI+Jm2sg==@vger.kernel.org X-Gm-Message-State: AFuF++kJxxl7Xk95z6/2Cw5az5zadRhzo8M8mZgkT4WQC+pzbSo8z2+E q/EklHeiScbO6zBpmdOU6NWYyroab6ye/iUfm8O+hxp1ANpHz/E9al+75wJaeXfgn6yp+8LN1qi e X-Received: from plbmz16.prod.google.com ([2002:a17:903:3510:b0:2dd:2adc:aa80]) (user=morbo job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:a8b:b0:2d9:26b3:547 with SMTP id d9443c01a7336-2dd83882243mr420135ad.20.1789460414438; Tue, 15 Sep 2026 01:20:14 -0700 (PDT) Date: Tue, 15 Sep 2026 08:18:40 +0000 In-Reply-To: <20260915081910.4142719-1-morbo@google.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260915081910.4142719-1-morbo@google.com> X-Mailer: git-send-email 2.55.0.1032.g73a4cd73de-goog Message-ID: <20260915081910.4142719-24-morbo@google.com> Subject: [PATCH 23/28] Input: synaptics_usb - use seq_buf and snprintf() for name and phys From: Bill Wendling To: linux-kernel@vger.kernel.org Cc: Bill Wendling , codemender-patching+linux@google.com, Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Tony Luck , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , "=?UTF-8?q?Thomas=20Hellstr=C3=B6m?=" , Rodrigo Vivi , Dmitry Torokhov , Matthias Schwarzott , Mauro Carvalho Chehab , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Sylwester Nawrocki , Peter Griffin , Alim Akhtar , Linus Walleij , Anil Gurumurthy , Sudarsana Kalluru , "Martin K. Petersen" , Trond Myklebust , Anna Schumaker , Mike Marshall , Martin Brandenburg , Kees Cook , Jiri Pirko , Simon Horman , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jaroslav Kysela , Takashi Iwai , Andrew Morton , "Mike Rapoport (Microsoft)" , Kanglong Wang , Tiezhu Yang , Qiang Ma , Randy Dunlap , Pengpeng Hou , Ard Biesheuvel , Breno Leitao , Thorsten Blum , Harshit Mogalapalli , Greg Kroah-Hartman , Lyude Paul , Ashutosh Desai , Imre Deak , Dmitry Baryshkov , Johan Hovold , Johannes Berg , Miri Korenblit , Alexander Stein , Cryolitia PukNgae , Jiaming Zhang , Will Porter , Cen Zhang , "=?UTF-8?q?C=C3=A1ssio=20Gabriel?=" , Rong Zhang , Arun Raghavan , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-edac@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable synusb_probe() constructs the device name and physical path using a mix of strscpy(), strlcat(), and snprintf(). In preparation for removing the deprecated strlcat() API[1], use struct seq_buf to incrementally build synusb->name, and format synusb->phys with snprintf() after generating the USB path. Link: https://github.com/KSPP/linux/issues/370 [1] Cc: codemender-patching+linux@google.com Assisted-by: Gemini:1.5-Pro-002 [editor_update_file, make_kernel_build_sing= le_file, test_runner_run_kunit_test] Signed-off-by: Bill Wendling --- Cc: Russell King Cc: Huacai Chen Cc: WANG Xuerui Cc: Thomas Bogendoerfer Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Tony Luck Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Matthew Brost Cc: "Thomas Hellstr=C3=B6m" Cc: Rodrigo Vivi Cc: Dmitry Torokhov Cc: Matthias Schwarzott Cc: Mauro Carvalho Chehab Cc: Tony Nguyen Cc: Przemek Kitszel Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Arend van Spriel Cc: Rob Herring Cc: Saravana Kannan Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Peter Griffin Cc: Alim Akhtar Cc: Linus Walleij Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "Martin K. Petersen" Cc: Trond Myklebust Cc: Anna Schumaker Cc: Mike Marshall Cc: Martin Brandenburg Cc: Kees Cook Cc: Jiri Pirko Cc: Simon Horman Cc: Chuck Lever Cc: Jeff Layton Cc: NeilBrown Cc: Olga Kornievskaia Cc: Dai Ngo Cc: Tom Talpey Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Bill Wendling Cc: Andrew Morton Cc: "Mike Rapoport (Microsoft)" Cc: Kanglong Wang Cc: Tiezhu Yang Cc: Qiang Ma Cc: Randy Dunlap Cc: Pengpeng Hou Cc: Ard Biesheuvel Cc: Breno Leitao Cc: Thorsten Blum Cc: Harshit Mogalapalli Cc: Greg Kroah-Hartman Cc: Lyude Paul Cc: Ashutosh Desai Cc: Imre Deak Cc: Dmitry Baryshkov Cc: Johan Hovold Cc: Johannes Berg Cc: Miri Korenblit Cc: Alexander Stein Cc: Cryolitia PukNgae Cc: Jiaming Zhang Cc: Will Porter Cc: Cen Zhang Cc: "C=C3=A1ssio Gabriel" Cc: Rong Zhang Cc: Arun Raghavan Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-edac@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: brcm80211@lists.linux.dev Cc: brcm80211-dev-list.pdl@broadcom.com Cc: devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-nfs@vger.kernel.org Cc: devel@lists.orangefs.org Cc: linux-hardening@vger.kernel.org Cc: linux-sound@vger.kernel.org --- drivers/input/mouse/synaptics_usb.c | 29 +++++++++++++++++------------ 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/input/mouse/synaptics_usb.c b/drivers/input/mouse/syna= ptics_usb.c index 880a0c79148c..d13d2d6202ee 100644 --- a/drivers/input/mouse/synaptics_usb.c +++ b/drivers/input/mouse/synaptics_usb.c @@ -41,6 +41,7 @@ #include #include #include +#include =20 #define USB_VENDOR_ID_SYNAPTICS 0x06cb #define USB_DEVICE_ID_SYNAPTICS_TP 0x0001 /* Synaptics USB TouchPad */ @@ -278,6 +279,8 @@ static int synusb_probe(struct usb_interface *intf, struct input_dev *input_dev; unsigned int intf_num =3D intf->cur_altsetting->desc.bInterfaceNumber; unsigned int altsetting =3D min(intf->num_altsetting, 1U); + struct seq_buf s; + char path[64]; int error; =20 error =3D usb_set_interface(udev, intf_num, altsetting); @@ -334,27 +337,29 @@ static int synusb_probe(struct usb_interface *intf, ep->bInterval); synusb->urb->transfer_flags |=3D URB_NO_TRANSFER_DMA_MAP; =20 + seq_buf_init(&s, synusb->name, sizeof(synusb->name)); + if (udev->manufacturer) - strscpy(synusb->name, udev->manufacturer, - sizeof(synusb->name)); + seq_buf_puts(&s, udev->manufacturer); =20 if (udev->product) { if (udev->manufacturer) - strlcat(synusb->name, " ", sizeof(synusb->name)); - strlcat(synusb->name, udev->product, sizeof(synusb->name)); + seq_buf_puts(&s, " "); + seq_buf_puts(&s, udev->product); } =20 - if (!strlen(synusb->name)) - snprintf(synusb->name, sizeof(synusb->name), - "USB Synaptics Device %04x:%04x", - le16_to_cpu(udev->descriptor.idVendor), - le16_to_cpu(udev->descriptor.idProduct)); + if (!seq_buf_used(&s)) + seq_buf_printf(&s, "USB Synaptics Device %04x:%04x", + le16_to_cpu(udev->descriptor.idVendor), + le16_to_cpu(udev->descriptor.idProduct)); =20 if (synusb->flags & SYNUSB_STICK) - strlcat(synusb->name, " (Stick)", sizeof(synusb->name)); + seq_buf_puts(&s, " (Stick)"); =20 - usb_make_path(udev, synusb->phys, sizeof(synusb->phys)); - strlcat(synusb->phys, "/input0", sizeof(synusb->phys)); + seq_buf_str(&s); + + usb_make_path(udev, path, sizeof(path)); + snprintf(synusb->phys, sizeof(synusb->phys), "%s/input0", path); =20 input_dev->name =3D synusb->name; input_dev->phys =3D synusb->phys; --=20 2.55.0.1032.g73a4cd73de-goog