From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7DE4A480DF0 for ; Wed, 7 Oct 2026 11:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791371413; cv=none; b=u811oBBQdcW+2uTjAsWxGRa8G63sHK4TYeeovrPf4yvJWQkqifFPzvxTmPcP09mK/1UT8lE1lIUmwKFkA353ud/aYxUtYA0Mmj2ZqcOpXcipgF0X5WF+e/1Uc533vrYF8yqR0f1kqTKyzpYD83pr4zqb9whfk/1Ox/+bt79bCJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791371413; c=relaxed/simple; bh=IPLilhdcPz0Rw1KffNK3T7TwDRffmKz0tzBAuXq8ebA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qvpnjjfRqhKu4L/xoQk/lJ6lDbhiPtxoxokoEY9rkeag7saXXnW7x4Hv6GNqhIaDtm+jhDaDYUkNnDfczJz5q4xyhVUYdUh7fFlBk4Gm9xULUTnKVWHzWezycA2zHCYKSPlt8LXhEosEWxYfZd2WWfBNbtQ3AIfURETAykdvBiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ed1gVfFx; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ed1gVfFx" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3a4a7eb86a4so1311472a91.3 for ; Wed, 07 Oct 2026 04:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791371395; x=1791976195; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0f/MTd/p24/UUitH2lVkrRpF3QAUdU24FyYEOQgmlyU=; b=ed1gVfFx/iZDQohOt8vmgpE0QeSJy4AZmEQB66iOmSMI/Aj7XMq8yCtdMkLqPx3BhN kX4s+IflMwXUiY/+TC+ovvyzQlvp3Bgf5WtW4Q16+qPTQcl152go18AnTvV0ujpIhITj FvQIsAkjoa592m6db7sU9NY4YeA+Xa/SGtAvHBXvc/QbLJJMYxNYK8A03VIatmWgHOOh OJV9BpB2UyQZ1ywy5EN5T5ngBr1R4TwJMMIzFp7dyw3QMy4edUUApS4sNoLeE1InlcTX PnB1CsQk0f5ERqUDfN0hKAmst0ek1dhK4unjW6JyP84qPsw1mLpW6pcrfqP5fctfcZKf L0kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791371395; x=1791976195; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0f/MTd/p24/UUitH2lVkrRpF3QAUdU24FyYEOQgmlyU=; b=Thp+xBxpGFjwj7FoCh/YCWa5NILVtNq0E3/4wUnUlzZjoEfYYTqNeLJxs4T2aMQzV+ yMcyrhrZaH1wFhpVmG1fwOaK456O+vG4lhmzVr9RfrTxWK/lEL4Hkw/yqrw91Q3+VGBG dZquC9J0K+GThjmn9g9OzzPF1/cRmrSsYeaKPcYys0oEkIN2GOwgqeA6LkBCJkPBrk72 A22q5g01CP40EczKU78omawV7ovg8JBfTQ8mZswQdR8PDYGi01ZeZXUu5Uw/SlCRj03E YbCrqTTmOtkQTIER+Nn98ywx1VTAneqP4Z5N5oryQe6iXUimYv+qcB7AHcLk/FVQOsMP +KGQ== X-Forwarded-Encrypted: i=1; AKwUvByMLImo5BE83Uc5RwtpuNEDOmLaFI/w1B7hk7agBPvhxq0cgxHob1Og/1UKoMMAIGNQFpCBw6IBKJA9Cw==@vger.kernel.org X-Gm-Message-State: AFq9FYLA0RFW5kZp0MG2t/H+V6FeklIxhX6KygeG/6GHB4WLIHQQROv9 Bnj9QYahGHdqRcdHwACAWM4/HkLe6Wo1K68S/bf5IBqxfNQaFU7hJdLo X-Gm-Gg: AYBFou3sD/RSuMGIO45dAiWzy9Cq15FPtZgRm8O88s1o9DapQ+VBCJNL+4aZTVRWj4w kp22HtIDTE6+c+Svcft/TjDgUW4aFReY3Rt7yxOJd5RsWkw+eIXNHEche8vAA8x9Y+Q66ocRRu0 q1hvcdO0MGLYZKTI3gDPHATtk/DtEWvakZWNGp5iPt/tBnvNBKRYtgTHUip6n9mB25as2k4szrh RMm9HSQ4CXdNP+u5fJVRNNncKYc1uzYjqGXTyacX+UiGT/wBpbosqwpsu8M6Nri/zzo95EJX+h+ daEQHSuKpgnUcV0oNH/SO8DiLfCOpYUPPVgP+PBZ9ZL1g9CCAd8HSXNpMLLlQm9z7/I5DQYBte5 mRxGVphkYCWBAvvv9oNfKNVfDIjQxj/rxogB9iLfWSqv6qWI2GdqGhZ1/oKEDieosEV6cRC/erS j3piOTic8OvUh0WLShMzwX9xuzsF9vT44zRO0XmEnLuLP9IKYgLwU34tNeO85iqPKfQrPnP46gF sbvWSyxQmadL0UCaDnkhAVHUMgGm30v9qGkWNqKfgN+LgbfJugXWq8P7nP7YTpzT8uGFozrE4bI E3cvzDkn3IzmW8E= X-Received: by 2002:a17:90b:37d0:b0:3a8:5d57:a5eb with SMTP id 98e67ed59e1d1-3a8a19478d4mr1407044a91.15.1791371395353; Wed, 07 Oct 2026 04:09:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a8a5ec70dbsm1328745a91.2.2026.10.07.04.09.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 04:09:55 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , AngeloGioacchino Del Regno , Trevor Wu Cc: Liam Girdwood , Matthias Brugger , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , cassiogabrielcontato@gmail.com, Haotian Zhang , Christian Marangi , Cezary Rojewski , Cyril Chao , Tuo Li , Rosen Penev , Garlic Tseng , Alexandre Mergnat , Dan Carpenter , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 3/4] ASoC: mediatek: mt8189: Handle constraint return value in FE startup Date: Wed, 7 Oct 2026 18:08:57 +0700 Message-ID: <20261007110858.509341-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261007110858.509341-1-phucduc.bui@gmail.com> References: <20261007110858.509341-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from mt8189_fe_startup(). ASoC only treats 0 as success when marking the DAI as started, so .shutdown() can be skipped on rollback. Return 0 explicitly on success. Fixes: 7eb153585598 ("ASoC: mediatek: mt8189: add platform driver") Signed-off-by: bui duc phuc --- sound/soc/mediatek/mt8189/mt8189-afe-pcm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c index c0f340a6cc09..eefa96b701a5 100644 --- a/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c +++ b/sound/soc/mediatek/mt8189/mt8189-afe-pcm.c @@ -155,8 +155,10 @@ static int mt8189_fe_startup(struct snd_pcm_substream *substream, ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); - if (ret < 0) + if (ret < 0) { dev_warn(afe->dev, "snd_pcm_hw_constraint_integer failed\n"); + return ret; + } /* dynamic allocate irq to memif */ if (memif->irq_usage < 0) { @@ -168,11 +170,11 @@ static int mt8189_fe_startup(struct snd_pcm_substream *substream, } else { dev_err(afe->dev, "%s() error: no more asys irq\n", __func__); - ret = -EBUSY; + return -EBUSY; } } - return ret; + return 0; } static void mt8189_fe_shutdown(struct snd_pcm_substream *substream, -- 2.43.0