From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f181.google.com (mail-dy1-f181.google.com [74.125.82.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D33A497388 for ; Thu, 8 Oct 2026 10:43:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456188; cv=none; b=rdzkIQecQITXD8CnGeW1ybCUw3Q/MX47qJ2kgtpTkJeAmtbFkdNGm+xF2bH95OiAIyMwADmooS+biT4A7MoWMcLf3LRkENT9Iy3co1Z5T6QDgs+O155dCjCPsyN5kd1Nw4d5mwgtSkbcMuGXoVCiRgNxvzxo4X7yt8Q6NxZKYY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456188; c=relaxed/simple; bh=4NCY4WcF1QlkYiyC8+OHrV0PoUi/1+lM3FPBnwvgx8U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OAl3waJPKZ8GiDTIIrbCkm987q/S82tv/CNWGRt8b2FMjXG9gLFUvGqSz0QoIYW5yPV30smtjqGF+UonLLMBigfy1DfNDIKszTSRURkHaSxNKUGkD4KzuvE6Ce5j6/JUMtubHANccXUrI2bHD8Y3uyierURuYVYhWkgoSAWIFR4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=an3s2u8p; arc=none smtp.client-ip=74.125.82.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="an3s2u8p" Received: by mail-dy1-f181.google.com with SMTP id 5a478bee46e88-34ca2d54925so7790496eec.0 for ; Thu, 08 Oct 2026 03:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456186; x=1792060986; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=an3s2u8p5OY9ozjikxopfvD2s2dvThSZJkSZpYCmzt9KrB9ckSxWzVQXnzMNuYN/La L6mIFkmzBAgJVxCTDJbTh38yQ9RiW74I7L61/i4YBkTTBCRKXONBmuT02t+Ri4Q7NDqF wBuCcFqDKt6lgbUXckopGm6ZZUB90NOHhmoaS9Vi+U8iV8VO+2Q162Zn09HYgY55xEPR huAm/5UGfWVgGaWKSFENcAUsRiyFPjmx7S5wTgY3SIykwCbLhvl26yAKa/Tnu5rL9IUo 8T5Zi9MlphRLltVbh+MV3pj7VRTFbb1TBI3XkB8xcGmsdaA/VywOeeaEeupkjG8ensYf 7e7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456186; x=1792060986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=T/ErUb+BYhJoBzVefBGuzS4rmfVbIr3TqgsBxZ+R3Yg=; b=fwW8h5D3P/zhuuPwOTAIeWbPSwGa1HQZiMX4aHWDhdEnw8P9enq2iN1bjD2AFjWyxO ZZo/0NUG24r/DWhvQB98MJ5taG9wpfHs2TOKq/QHnrxBh2bCm1k1g7A+4YWu5ua2Shv7 HouICgZb05bqXWNzVUvd/5dDrBNhBUy4mTLT0zCYSvZbzQpZUAN2YwyG3s0pWoycCnz5 SW6JneuNA8gVZyVESoOoU9rIjoiOdpeUmjDsPmUo77WW0jqoa50KBmhVAVXgDnyP3WYw 2yOlpHdIgkiKtAP+lqAWN6JEgpTgP9BHjh9xJtfe3AazNoRXgpUaWCnbHKTCTOiVEVoc lo2g== X-Forwarded-Encrypted: i=1; AKwUvBxU/Lwm4BqKH0D31D/LdQLwSgDccURizn3lY2UDyMryLAEhLjNLTHIY37Po6AIzHsIvpY0z+GE1QQzENA==@vger.kernel.org X-Gm-Message-State: AFuF++nfC4MJEg0JtK4390erhVeJwsjEKznV6X669HAc60rYuFnp/Bib icInrb0Ln1gcZEpapdP9qVOjBXdpTIhwl281QLu58ynh3VigcJxXKbpQ X-Gm-Gg: AYBFou1zPPHoVqMLrnObdLWe9OtjYa6j/mwwYl3yrvsgBCtM8j/4TP0//I7ibJN9kwR j/zfvCJ/ViQW6n+pL6f1oLwQh4T0VKVgNgtXnVquhWDTCz5lkUjvCerrTegYT5OkQPqiiTWOW+D N8222RZwdBa+41y8Y3zxL1nvPnUquHwvaanpCx+J2gzQG+d4Ofo3HkGOjGB1kcrvOfXsdlRCAdg 2oU3aY5pYWyJvbRiitdMWpRmH13unSRQt8DsHX1g59c7J5eEgGcHy0YUufTwH6m6n6TPacz0Ar6 r8BlylQzVyMN0aa6nKHYQzap+5YvPTym6ooUEvYL6A3zR6T9BDvBpdYoT4QjoiGoE24uEgLmd48 d+kSg7Q0UhbwUiA7xClNtJ3d9/AWV9T0T+tePbWHt3lP1RQlyGt5MuvRxwFMKCMyMGjIq0GhgAJ pO7nt7KgpmwuSCkkI+RA6RPdKxSzkClfFTmtRjSYgsiqbj1X4RQLmXDYArbwhcS/3Gftbnop351 2MzWot7sklyVZMfEbCJcrD6/iqxAVbn206Ma/MtZKnmvnu6Q4kPuz6ISJVglD3BCaoAIdjNNpOG 568MDiuCpZW9YJhtwWYq4Vuj X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6108352eec.2.1791456186115; Thu, 08 Oct 2026 03:43:06 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:43:05 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 16/24] ASoC: codecs: wm8580: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:23 +0700 Message-ID: <20261008103831.542533-17-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from wm8580_playback_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as wm8580_dai_ops_playback has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/wm8580.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8580.c b/sound/soc/codecs/wm8580.c index 9bc5d1e795dc..5343d445c322 100644 --- a/sound/soc/codecs/wm8580.c +++ b/sound/soc/codecs/wm8580.c @@ -852,9 +852,15 @@ static int wm8580_playback_startup(struct snd_pcm_substream *substream, { struct snd_soc_component *component = dai->component; struct wm8580_priv *wm8580 = snd_soc_component_get_drvdata(component); + int ret; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_CHANNELS, 1, wm8580->drvdata->num_dacs * 2); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_CHANNELS, 1, + wm8580->drvdata->num_dacs * 2); + if (ret < 0) + return ret; + + return 0; } #define WM8580_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\ -- 2.43.0