From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D9B1497B87 for ; Thu, 8 Oct 2026 10:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456297; cv=none; b=OmizgZIP4NVFTFatSNCzUCPeVFkATtiJcfcKYpSIUwG7+qjYLQpULUhzvhoezAvgeT+EPsHVYz3gk+YW4YWoAQFsQFa4Nz8zdenidEbpddRI2KZxbej57ktR975wzP3QwFSboaTWn2N/kHuuk5yl2DFPB6n6XxSPLPJSi+ZWobE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456297; c=relaxed/simple; bh=f8CcWoO4sZy/Z9AND7TTLaeemfCybBHCm1tDpN4e8XU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cafTZ363D1c5TUKKys11YUwpIEkz9Gh3k2ZEOQvFFU1l3QHsilOfJFbehOxnqx+hjUUp+YLTcwxAe+whuxTfbrlvSo9ScvsOxqU71eXqvr/8v67pVx4x0+9pZbZ1WWVieOUV9mOxNMUU2YNKxg8i/LAAx3I3NuCvROTciYyOuUA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bkPLdyxP; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bkPLdyxP" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-3514b90bb89so4403779eec.1 for ; Thu, 08 Oct 2026 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456295; x=1792061095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=bkPLdyxPlKZJ6UoQZVrpzQ98CZ7sB44mduLnmgwU8jv+cleFB9rIAh2DKm7QewtvjT TbqkKNBCRcjq/SCWvLhZg5MD12rUwnSZjB7Nvv5UzrUoMZ975DekI2TnSR7dzRX6oEyp X47/rm5YYfBlfvBStHAUNcjwG+9d/OCBsvHMyLJ7PqGDTUcNVrSeXE4ZOD4Gen+wlkVd sZOBg4QgVwY0TaFBmN4Nh4Bf5p2WYa62hDdb9A5AOYCRvRVFu6096AJDDXLOcujFQL1o KFO78Ws14X8iDEajdEACNyKOFN23ipiGWY8LvLLw112NTzVb4xmFCIq9X7r6YMd5Q0HW uPKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456295; x=1792061095; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=vuCt8LfoeVxeGP9EXdKyFEToJzhlOF5O+NhVLwPyMgM=; b=pQnbM2ODpJGcsyrXdMyX447OmH3f6zgP50mlFNan5cGVKumDnPQ9L3lJon+SPAet4Y VjkzDHXGkkL7jUlb7zSLNv67vCXxOFW3aWEFpA7l94/3IGwlFw3R8Z8QKmUmTupFgOS7 gbJpCw5kKtVZdbrLQ7wDhNJm3f7FvV6koZD/EZ48d1JYXKfmZ1i/OJVgKxVRoMBzxfOb jIdrnXnfuaahMUh7YBBcmcXSDqIiV1xWAf2m3iQ0RLP0mEkWCuQmHwm+e9yKXJDYlNGd R38gaakIcSFJsh/Qzg3prvQEuBXkdgy0B12KgDbFMBoN/45l6MNx5EgbYen5Byig7Hzt f3Bg== X-Forwarded-Encrypted: i=1; AKwUvBwUQSebMAU2GJMOKAYjuKAT65rURSVw1DmJMmqjaprWMH1nm7JmssJN9KXZutbwqex+gz/oAv7ygW9zfw==@vger.kernel.org X-Gm-Message-State: AFuF++k/l/Rd2lhAMZazL9MdBGppUJvzWbvt5HfY65vE5xEiYAjjmHPV Vi9/yX9u4eIxSo+W9+PCPEtl2lp/8u1IzLlaiCbY9HTTpRQZApGt7QBu X-Gm-Gg: AYBFou17iX1REbhyiTlBH/Bq771170lM06nqdTStNNevWjMa/bplhTNqa2oRMw2kHlP Pa8k8Uxd+VE4ZAxezaM9dirvcYTsIyrIpkcGJkh+2s1/vcV8S7o6r1cWTRIelxh9rT4XqlN/1rg VlBf5EepfCeyhrPE/nETQ5t48E0rYFlfo9WdTjpZks7lURXvX5+R2WR0LgIFWq1ILqCy1ci8vfy xx7yfmudvXPoMwRmDY8zv5t+N6cId6OuAc0/2zm8lkS7lK221X5ECn43nPmuwG/PJ4Um4S1oQvj +wbVqAMEwyxmdejvNSrsmbK5+Ld4etvQt+DSrEl6E1tSZyysFgZ+z3eX2OiaRH9dER6DShkrlzQ 1uIp16Dofs1smZabg1t462IqAztbjq/kcYyW3kXzt1N+EKXiOMoXt8aN1GVvVcwirwMm/2zu10K DVjcB63qzQuhhErIkRbUMNWazTlzF6BrnP0vdRF8uVQ7ijXXvdgBkGFpQr65GQ8cqEtWo2m9QVj +rUCjfQRssnJ1c9kNxx0IxqgKNOWZLGFCt/B9/4n3lZM3Blx9dwKNluVIzOqpEbyOQeWOLyFLvy vENYcPGeqnsIsw== X-Received: by 2002:a05:693c:88c6:10b0:328:3944:ee53 with SMTP id 5a478bee46e88-3515da28859mr6112721eec.2.1791456295330; Thu, 08 Oct 2026 03:44:55 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.44.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:44:54 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 23/24] ASoC: rockchip: rk3399_gru_sound: Mark the link as started on success Date: Thu, 8 Oct 2026 17:38:30 +0700 Message-ID: <20261008103831.542533-24-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rockchip_sound_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rk3399_gru_sound.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 04e7bed8275d..0ec80a4b8c59 100644 --- a/sound/soc/rockchip/rk3399_gru_sound.c +++ b/sound/soc/rockchip/rk3399_gru_sound.c @@ -258,10 +258,15 @@ static int rockchip_sound_dmic_hw_params(struct snd_pcm_substream *substream, static int rockchip_sound_startup(struct snd_pcm_substream *substream) { struct snd_pcm_runtime *runtime = substream->runtime; + int ret; runtime->hw.formats = SNDRV_PCM_FMTBIT_S16_LE; - return snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, - 8000, 96000); + ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, + 8000, 96000); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_ops rockchip_sound_max98357a_ops = { -- 2.43.0