From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2A5542E41B for ; Thu, 8 Oct 2026 10:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456024; cv=none; b=eIu9lGicsdUQR0jf8XVJygQXoJaNPOKFVTXCBUB91OFUhI2pfKUDkiKf7/Qz5azwOSqACSX/xhkDDZVmNhsmf3uJAEsglns9O3Ue9rINjBmr3K/i1yeMPJCQyrVoqAtPRRqsok6Q/tq0j1zbTCf1C4+cOth2lwoocUAQM8uIToA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456024; c=relaxed/simple; bh=aAJwqH/KKsd5BFgyPNOpN1XC3DMyvJ2Ee51+WOeaFBI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RpfSltvLFTiurgropqXOVBif8Wqk2UeqU3YfasPx4JX6DSUAQNWRrg7WQOAUgPhEpnqFhCX+wFY3JOPQU4Kh57toDU+z/jZ4Fgc6d+8kiPZ7EG/EGan+TuytHzFCp1OkJMuof9Q9YeYlbSOGjTdYmJ/YNSOhljhTgJe7q2IX9Ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X4lD3ZPf; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X4lD3ZPf" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-35120d43ecaso7719406eec.1 for ; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456022; x=1792060822; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=X4lD3ZPfeQcGsMQTUiJaPNGSoWdlpV1BWgJM9a7+nPkyvzWrl2UdLSl9Y5jbRtWunz Eu211goiSVVa256kmngY1NjBmdGQUYnqCKazn21GwNggbAl/Q8wAwIbnTF6HG7P1DVEJ pFTxy0jjmaxDtT0aUc5dsAj4a1Cpc94B9ufORRq30fVr81uLb9LQXiGDb5oKE6Mc+ZH+ I1OggFmbkVaDwD+4AdZTadXMY2zL4sDysgdDpEhtjL4ubmNU7kb7qvxn+ZVGt/LvBCEp qxLGK8w81TCCKjf3RxCGRi3X8/QV6g6JYkjtAI5WNrlVwydhkQmIpnLpuskh9WTS3R4Z ynUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456022; x=1792060822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=h9Ry8JRaSeFrVq0Ud0+uxs62YoBNOy3ejKA8MS9Fs2w=; b=Zo284RTTaCM8QCmt1KZip/wZ7QP+o/2SkamOXUmzdooGt3EWS3xUzaJZGt5lzpu/1T uUdbV4XJYgDSzuvnWpZ8yc4b7g1ouMvCM77QsADdFrcPLWyRnw0Yx2jGRb4rTjLRixzV KrwuvUqWZpxzbuGF7hw/HylBvUCh3G0a5ECnAZvktgSXg80VuGsFSvRTdC8MWIEnk3nS YKpuNOSvhnP8EYLN2tcR4GNYqREyqhBmE15zc02RBC4TG5nUL3LGXZ6N2nhfSoFiCGbz /Y0mRPjSyBD4r2EhkZQKvceh2zAxKQcYI/U4e52pYlysq1T5kYOj5czSHOXTJD4XFYTD Ssww== X-Forwarded-Encrypted: i=1; AKwUvBxQX4JEWbmiN0PrY+c8HlEW/HYWK5ODFDDSELXpZzwCJfmFLZxo5C2Ua0KPeJmBHcO/IaDlBskQq9em7w==@vger.kernel.org X-Gm-Message-State: AFuF++nZSdAxhoXqxf0yOdHync8go6OyaBP0dupliIR3HPOviYJgHwq0 hFp+Ymz9Z0U1B9nfEEVbSRin3qIundE8tP6yTcUpQrbXHPvnFiaY634o X-Gm-Gg: AYBFou0KmGA3tTzNScyEfx+NYNnKxgRX3aDb9BuFCriINHMyOy2Zg2xQiECfWPL6tEq jbxZ9Mzc731ujp4T6h6lorPw/rK6KRXULDiChmmcguGQGg/NIL4r+Vf8rVS8JW4x9sILnyuPyUD L0lk5U+Dj88v5dToJPgO87i7zke+ecqTkaK5E0VUzBF1kTb9Jg4S8LfcBif2kpgavmuEpBzCHsr wAqOaRN6w5Sn05qhMFCMAczg9PW6vF2uG4A7AHIgSK9UfgrUAVSvPb4iZiCoCDdmoOonMJ0H3H9 2LXMjFwdlkZEVbkHKyzKGSi0HIjwaFq4lWhxMgClt5/WkOvIXTfuz2R2+hONsW6qF5YS8d4Dpvo xjhnGYq5ZrBNWTmXRrmiY5+YQfprKMpWdkYR2d1ecVFG+XZO6Z9HsB1ph8yorNBTvhne6uCtwjv aDDZtSHfqvGqDO3T7dCOHUnC2NXX4bR8YjCenlM2j2Q2VFlueN0Wox8aQR8VYVE7HLHlUlH31ay t0LjsThqsix7OU4YhI1sHonvhpg27wcwveJlEvBrTUznXVPRicInD7z4mWuV0YBN2DbDsbjhf74 K95ooZ6TpXzIUELllNmlcqJR X-Received: by 2002:a05:693c:414b:20b0:351:1e2e:da4d with SMTP id 5a478bee46e88-3515def434bmr6671263eec.23.1791456022013; Thu, 08 Oct 2026 03:40:22 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 05/24] ASoC: amd: renoir: Fix acp_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:12 +0700 Message-ID: <20261008103831.542533-6-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 4a767b1d039a ("ASoC: amd: add acp3x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 3f59b753243d..c0481a9ba858 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -233,7 +233,7 @@ static int acp_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp_base = adata->acp_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0