From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Trevor Wu <trevor.wu@mediatek.com>,
Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
cassiogabrielcontato@gmail.com,
Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Haotian Zhang <vulab@iscas.ac.cn>,
HariKrishna Sagala <hariconscious@gmail.com>,
linux-sound@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v3 08/16] ASoC: mediatek: mt8195: Check paired MEMIF clock enable in FE trigger
Date: Wed, 14 Oct 2026 18:27:43 +0700 [thread overview]
Message-ID: <20261014112752.683032-9-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20261014112752.683032-1-phucduc.bui@gmail.com>
From: bui duc phuc <phucduc.bui@gmail.com>
Check the return value of mt8195_afe_paired_memif_clk_enable() on
START/RESUME. On failure, stop the MEMIF and disable the channel
merge before returning the error.
Also skip enabling the paired clock if mtk_afe_fe_trigger() fails.
Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
sound/soc/mediatek/mt8195/mt8195-afe-pcm.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
index 02736949ae6a..4216c47a56c9 100644
--- a/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
+++ b/sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
@@ -466,7 +466,14 @@ static int mt8195_afe_fe_trigger(struct snd_pcm_substream *substream, int cmd,
switch (cmd) {
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_RESUME:
- mt8195_afe_paired_memif_clk_enable(substream, dai, 1);
+ if (ret)
+ break;
+
+ ret = mt8195_afe_paired_memif_clk_enable(substream, dai, 1);
+ if (ret) {
+ mtk_afe_fe_trigger(substream, SNDRV_PCM_TRIGGER_STOP, dai);
+ mt8195_afe_enable_cm(afe, cm, false);
+ }
break;
case SNDRV_PCM_TRIGGER_STOP:
case SNDRV_PCM_TRIGGER_SUSPEND:
--
2.43.0
next prev parent reply other threads:[~2026-10-14 11:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 11:27 [PATCH v3 00/16] ASoC: mediatek: mt8195: Fix clock error handling phucduc.bui
2026-10-14 11:27 ` [PATCH v3 01/16] ASoC: mediatek: mt8195: Fix tuner " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 02/16] ASoC: mediatek: mt8195: Use dev_err_probe() in mt8195_afe_init_clock() phucduc.bui
2026-10-14 11:27 ` [PATCH v3 03/16] ASoC: mediatek: mt8195: Fix register access clock error handling phucduc.bui
2026-10-14 11:27 ` [PATCH v3 04/16] ASoC: mediatek: mt8195: Fix timing system " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 05/16] ASoC: mediatek: mt8195: Fix main " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 06/16] ASoC: mediatek: mt8195: Fix paired memif " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 07/16] ASoC: mediatek: mt8195: Fix FE startup " phucduc.bui
2026-10-14 11:27 ` phucduc.bui [this message]
2026-10-14 11:27 ` [PATCH v3 09/16] ASoC: mediatek: mt8195: Fix runtime resume " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 10/16] ASoC: mediatek: mt8195: Remove redundant error message phucduc.bui
2026-10-14 11:27 ` [PATCH v3 11/16] ASoC: mediatek: mt8195: Propagate IRQ lookup errors phucduc.bui
2026-10-14 11:27 ` [PATCH v3 12/16] ASoC: mediatek: mt8195: Fix ETDM MCLK error handling phucduc.bui
2026-10-14 11:27 ` [PATCH v3 13/16] ASoC: mediatek: mt8195: Fix ETDM startup " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 14/16] ASoC: mediatek: mt8195: Fix HDMI TX " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 15/16] ASoC: mediatek: mt8195: Fix ETDM probe " phucduc.bui
2026-10-14 11:27 ` [PATCH v3 16/16] ASoC: mediatek: mt8195: Fix clock parent " phucduc.bui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261014112752.683032-9-phucduc.bui@gmail.com \
--to=phucduc.bui@gmail.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=cassiogabrielcontato@gmail.com \
--cc=hariconscious@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=trevor.wu@mediatek.com \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox