From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF6636A36B for ; Thu, 15 Oct 2026 01:46:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028791; cv=none; b=TL6L8qTKghN8sri07F+NQkuYOAur0z5x9WTMcJe3nmrho1ONobEM3297G9DS0RsC7uQ+NXCfRHyhLUpvVWvKWhu52G5UEy9ALM7v0R5LKTAapVTWLtfE92tPCOpoRoUjsal7MMvzi2ImxpNIbhQSebWxtukOk4n0e4hTnxhsT5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028791; c=relaxed/simple; bh=JyLcEpuVNYAJZZcS3MtfM//iTF4DoBGRH1sMBv09uo8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Br1C43U5DJgQ18u4qiSW5qedc46feh7GIrGAmMhVYJ9sVJyPEaITIvtSkj+lBIqE//oSz1FdZNb+XhAO7JDqpjUap8YMQi771GsOQDoBIEGTYe9UUX8oxYqUw8N8nFGdaYs5cRc3XOgGWOey9Z/T9Oc5bat1cRZvVw1eK7lpUmQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sui7pE9l; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sui7pE9l" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2e942864693so5059275ad.1 for ; Wed, 14 Oct 2026 18:46:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028788; x=1792633588; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FVoaE90uxAa4MGE2u5YmtFWHqpvVUok70EqIpA+eTKA=; b=sui7pE9l0ruWCQ45xTBS+mPN14NATdBzveKMgrwr+LLMCcx4+yXA3xDHoedWk6FvDM tXPMGe+ukdI9CzVCyl+SZbeIffszPdbcjv6nNQp8eoM12o3BrUwNZoM0G/IGQuH9bnQK 9YTtGtMrMRlL8XENCY5g74xHcb2tjI/UHeRVhpvbg8co4d8jFdOJuaK3ALfuvED5/fw1 K6ZFn3POWGR/KRLscqJwgxxxBqB73mEXQW+Vkb07d9i1xJSWKwPojzYy3Zy+cN5QUyzR n3E6BazfYjLmLsKFPC6kh6YTuMxK1tMub15QOlmUL+DmAD1XGhJfiNqTnpRsU7d1N6IY gWiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028788; x=1792633588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FVoaE90uxAa4MGE2u5YmtFWHqpvVUok70EqIpA+eTKA=; b=arjupuxhvbBOf2bqTMvjBImVXfjRvRCv/FPtu1vI683RUVE/i7CbakbPlmGt2QgWaf ViUVWqR1dRC4wBQ6IeqOebfj+CADvbVNHzm8G9m1tqizLGCcz+FgTk+pC++CK58Qa7hT Zwad0miLvbJIG1+Zy6qjxlponnXoy84FiCdwrRjCt+1+aBDrXvDk5Ou9ZbMUsMNh6dWt SWDpYEQE5CF0XJx1APGy2pbH5cunbj8SF9wu5QgXmoqUvYgq9x6LTjmx6yrlNPlZAD68 ulV97Beth+KDyXLyc6UM3frBdykaTblz411BJuWqvm7vGyjbGioxiNWhVPIciykPrlkT kcdQ== X-Forwarded-Encrypted: i=1; AKwUvBx95gqDXGv6uQo4n58+62H/epnBpcOpDstk94sQce5IGW4Pc5r8B1eCIfLSX80mzHPVPgJJaUtsawRJ3g==@vger.kernel.org X-Gm-Message-State: AFq9FYKlpx7luYqUHwbt4Ht/wYjO33dqK2tmy3J67y3xrWaOwUdvRuf7 GPvGSs6q/s1eMZr3wrhV0PNmNMNlIRX//CpfeG/H298EWsTnylcuTYGJ X-Gm-Gg: AYBFou3sjThxBcMWt0eSKkQNaVdg26Q341Be9RTkUauPrryYGetI3rC0eKUDSF1moax JcPSCFpFlC41HOL7hE8KAgbNTuu+wULmoH9VZ3Zdz0WmL2EzbiPVuhc9Z53Zcr2TDTBvs+cBZKl JVNcbfqwV8czLmiQVZAreUI76SUvfdeHZ7Rqno2BjMdqVe9KnnMd/L5c0wXIV/Z4tTASx55N5rw hjdEOntbgKG5edrNCBU6GvlbF12m+zq9/bfbpZRtkBj9hO3QqjEflm1lOnP3wviqF+bK8zppFSb pe4l/+O61SI6ThdCWxWWQT1mNPIdAI4nSUjLmgnRNExLsiiFGla+44cKTM4Lxcx/NC/Z1y1q6ib Y2cUJAOt25lk+xulyKBueucnSSi5yTNW2qJEyvvqc/tTFghbnh4pOqTawmLRkfQbHIlGKkgrggE NP13xH2Lp2bKMSp134Oejo4tJ9ENf4XgDFYvq0MYGDvctf1KW6AyzEU+xVEjnueKRVQmWjwDf2j gJHSKAugiF9xO5bDlna26zosKNwHNZtGQVigE1HNlyB9YxBYISi5241o+VwKayngb5FtCfkcgcb aDJy6m31N208uA== X-Received: by 2002:a17:903:38c8:b0:2e5:e3da:be04 with SMTP id d9443c01a7336-2e84304792emr134212015ad.59.1792028788486; Wed, 14 Oct 2026 18:46:28 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.46.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:46:27 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 09/25] ASoC: atmel: atmel-pcm-pdc: Fix atmel_pcm_close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:08 +0700 Message-ID: <20261015014324.5569-10-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from atmel_pcm_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 92dfa6198623 ("ASoC: atmel-pcm: split into two file") Signed-off-by: bui duc phuc --- sound/soc/atmel/atmel-pcm-pdc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sound/soc/atmel/atmel-pcm-pdc.c b/sound/soc/atmel/atmel-pcm-pdc.c index 374f93fa6e0b..4cedf2ad934d 100644 --- a/sound/soc/atmel/atmel-pcm-pdc.c +++ b/sound/soc/atmel/atmel-pcm-pdc.c @@ -295,6 +295,13 @@ static int atmel_pcm_open(struct snd_soc_component *component, } runtime->private_data = prtd; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; + out: return ret; } -- 2.43.0