From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D25C1279DC3 for ; Thu, 15 Oct 2026 01:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028874; cv=none; b=ssdmppDZQAneIK58Hdbzan2fIistYHfZoHD7kqnezoxsQjiqh57HLmV+6wodZ7bG6x2Qo1SajGtFDyJAA9rSDzuJa3MZ+ArIGhevOcDfmOQ2O9lQtsGG+8V0vOX0naKwChqSicOagGK3C5oEpXgVu3Mh/rh5KO+GvNbmVwYkz0M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028874; c=relaxed/simple; bh=lTLKa+91g0xBOu/fagB1HB+X80BcBi+hkbX2nHYkS5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gOyZZZuOvyQzIUHUi+Z8fhDq52FIkgGXDkCr53jBleOBQvj4vOr0lL+LiKxUk9DYTj1jQIQMPi4R4dL0o/sX6NRtCceaXgPADKKSfMhU4SgxTzYZy1Q9gSIEvVFB1sWJ8/k6f1cFZMQfnOubuyBYi8khyFypwC1qXE9X0osfhwE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyJQ50XL; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyJQ50XL" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2dd76b1361dso11009015ad.1 for ; Wed, 14 Oct 2026 18:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028871; x=1792633671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r52r7lHoOPMhC++VZB/BAS85K3dCRyowF6eP319pd4Y=; b=fyJQ50XLD0VGhFdTUS8F5Q02f8eZQ1wnfChyTmn/KstNhFh5QKhpibH9Q3TMB4pdCS RGZTitI0b5WwIBzVMIo3UbXwxF9JbxRpi3drFRO5GEAbRmtV2OBibX177V5JICYNZ8ie l+n6IlxUj5WUKNKm0LzdCZnT8antgVmQem4/e22H6pMfwHmFFUV4UX1FS8uY6wraz5iE qLTCi5YMkLdP9ab8HyM15Gjznt0J0ljH5cp9+qjFXIplpWZaJBfdHJ2AiDWxUArmwOZY Q++5igF6c/dus8/aUKLwWao/m73POPFl4L5DJtwSaZsCZ9wLmhEl5eXCDmVnFlEeTXSV injw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028871; x=1792633671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=r52r7lHoOPMhC++VZB/BAS85K3dCRyowF6eP319pd4Y=; b=JA8GPowE1Asye5nO5pVoLRWjnd1/mTW8ckJCBhhvbqHYq7xT6dvJztMYTzIB5eZy8P UXKFlE4oS5//wf+fD94HTcXHq934wcR1GgFZQbsKsw8wYPOsz2B2ReYmhMBi3hWe505O RnapMlV6N/mOX0r1Q8MgdJPapxcpTvbBlDOY5rzTNyO8aMxABMJV27wvWpG06ZCYzlwi fL/NjcNpY1Qj5dAuvRxBtIwVwqP87dbccnNuTsKI7y82TEvfHdjzQlVF/DZUanVAZFn/ 9Y65gEQRvaf5p31f3lkY95CgXPe9woujZlFjO8Iys6jMXVtoYmfROPo4vXumDlO9kcC8 KOpw== X-Forwarded-Encrypted: i=1; AKwUvBzLBGBQLrsMkWmKiYe7nOrctWX2p3aFK6WvAGueHObV7m+D7ZEt3IIWRVrcuZPhYLjoXa+6nm3Z7fNs6g==@vger.kernel.org X-Gm-Message-State: AFq9FYLfLOaBXxmGKDeVrPXTLvPEYntLmKUVNDGjdOfEgam3a24G7qIF O3ofYWgRt/5/cPyDiDGtajHT2lOYfV3gT6qywDVXedVR5f/mFvewg8At X-Gm-Gg: AYBFou1jwri8qIHr1mu2M7gLICSiJy/DVYKAHcKOcsDHwoLx0zvf7I+RfpWct4qzWh9 UJiA6GmbO0V9xSl7zUlyOIWEoLm1//FSCN//cuTTR6Huz6hcZtxUP4fjPnxIziq2RC0AI0AEzpJ ZpJQi87L+gniRa+GpRzPgPnYO44yeamq5XLPYNHwqZD8S+AwBmapGpLQhAI4+5fjd7tnwK2dH7J fH2NABV/mrml7BmZUx0FyDCiBuLWbSkDc7PwkxrwF2bsoSz1qy9voHQbgf8/BvJBoxEm1ALQePT TSOSLiMikOqm/WWYcPfzWKdFwukAr4OOJNXFak79k2hYWWsvYzSTZfsKnucCGIyWkfzWy8322yU h3We+fM9g19QD3qmG918TZZHp5oGNNrhVKtohSouJim8ImvmSg5zHEHKvN4odZ+VAeYXm3BDBVS jRsdsbaWuTvH8K5pKeSxBRQPmANsZ6T0oy//yBJstPwrV9YbmaxdZXdgKebRw1Z+T9ywJZXWyEs GONkss6+iYHLEEEPpeXKpaVh0Wrt5r8we7Xk/3e+LAbjv1bQjnhXQBhMVLSKHpjDa7Nf9lpVyRz kCXzM5AwlbX/wog= X-Received: by 2002:a17:902:d4c9:b0:2e2:dbf6:3744 with SMTP id d9443c01a7336-2e842ce7d6fmr143717775ad.42.1792028871192; Wed, 14 Oct 2026 18:47:51 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.47.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:47:50 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 14/25] ASoC: codecs: nau8824: Ensure the DAI is marked as started on success Date: Thu, 15 Oct 2026 08:43:13 +0700 Message-ID: <20261015014324.5569-15-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from nau8824_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as nau8824_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/nau8824.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/nau8824.c b/sound/soc/codecs/nau8824.c index 853eb9472af9..046cce9192b7 100644 --- a/sound/soc/codecs/nau8824.c +++ b/sound/soc/codecs/nau8824.c @@ -1061,14 +1061,24 @@ static int nau8824_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_component *component = dai->component; struct nau8824 *nau8824 = snd_soc_component_get_drvdata(component); const struct nau8824_osr_attr *osr; + int ret; osr = nau8824_get_osr(nau8824, substream->stream); if (!osr || !osr->osr) return -EINVAL; - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_RATE, - 0, CLK_DA_AD_MAX / osr->osr); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_RATE, + 0, CLK_DA_AD_MAX / osr->osr); + if (ret < 0) + return ret; + + /* + * ASoC only marks the DAI as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI is correctly marked as started. + */ + return 0; } static int nau8824_hw_params(struct snd_pcm_substream *substream, -- 2.43.0