From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 519E636EABE for ; Thu, 15 Oct 2026 01:49:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028945; cv=none; b=WCJ1XcXODg2XUAG7nUWYOVotsQBtSy620KvOsL4Ky8JlREz4BEIpid5Bl8GBsvNvUJHDVkXwO8+te3Ps8dfjjUcyAyBQ4z6jsujfQ7/fBXkHhJC7BBr/uR3wPEhkiwC+Hmh93aSnBxOcD6e/QI1t/mAVGUFAacZjHU5+/9H4bBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028945; c=relaxed/simple; bh=DUWEL6UBJjwb+FrcYegjJbSUhp1MVY9nmyM190lvMmA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jfn3fhjNw/tv1+0G52n9Zla5DAM7g3Mf2wE4t9lqwZGXIHnPXbFd3OH2Po5SfpvanFs1UIQmlHv4pBcNA8ScUVD1VTZqWwpneSzEIf8VKoUjhui2v6W/5rv5+WNv6QD6HXAdTKtk/ZA2c7BYuo/SJSb6pe0AFVfEGawb/B8g22k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p4/VKRqN; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p4/VKRqN" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2e5fb79ce82so26376525ad.0 for ; Wed, 14 Oct 2026 18:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028943; x=1792633743; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=M1jbxv0B573E/6JvVMqt4p2dOdYoex1i5fkYQYaL9us=; b=p4/VKRqNETmRDqK0sIz2WIta+zqF7QaUJyuzH3R7vJXo4H4uigi4/wNQRthvzJsGf4 3EbKdrQZL6b45Sp2sP8ABIzNlNPnVFtvaiAEvLVLIDlNFEEV8SMMS12o9BfeklyhUywu YCAxuvonCS6USuwprRa2o1A7dpZyTEoHqdDd2AkKttpW6/gRHpDpF1lG+514dLsMw4+u iHRmEJNdZfdg4msAyYcC0R/LGr91rhPcGup2/6xMsmYbO8b3sQ1GflAf6AZbY5imYVNL oqezBfWJZYP+g0eUNFcADZHteoUTUq7M4Ua3zOIrURJutFYLkdCrAgamAdvzETCseD0F PV1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028944; x=1792633744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=M1jbxv0B573E/6JvVMqt4p2dOdYoex1i5fkYQYaL9us=; b=wAweVF+VTbC3++fs+WGc9f33ehEldchy6+b8Yr6oFNnLB0YkQAZs34rs2quJJbFKab IDXdkDrZmmxUsnROV7Udg3qs81jvAPxaRbl3XrhQ31zvxtuXHkv9FCVR/+oLavAgOaPT RpMlu1jYpTluF2SMoN7LpFr135hhKYmGsT0vx4aXc8ekINOQalrMO5WH+jpxgHwXkD0u 0zbw9Neadmcq/M4ovO7ZQT9XYNiQELeOOPKOH3SKDaU5iTxc/bVP7THxpkL7ZPmIA7ly WB7zjRzXmNc2YnVJzv7LdgGfBzuzKMckznPRWcGrj8WxfwqKJCHMHzvgVYe3Ya44nAVJ cwPQ== X-Forwarded-Encrypted: i=1; AKwUvBxaS1DzbdSPUN3TexG6rLkFFNVcNKk6KPZzgKvOyDvNPNic/zLggiqotxW9vzPedvUDwPfc3i7QiaNHag==@vger.kernel.org X-Gm-Message-State: AFq9FYLXqDWAPQ6NHg4VTab/Df+CCqDjtKvtjJ1Pfr5AH3B0OtW1rSSA 2JmAJmf3vdUeV/Npish8bkrgod0VazfrBqkA3B9U7wLugKMELvFDZH2L X-Gm-Gg: AYBFou1EgDZn+RO0v4G94Eum2dsPE7souUnb993ad/v5E7zvfxs69VNg3MdweW5AZD6 ayKtzbcpP4Fk/F/gAnPSE+ZWrTYLau/SMlkNoRhOW6aAy1YVh3K0qZ4/NGgrRuPMwZwMwIuUpQo FCYbepAHNisbCfUXixApIQOo5tlBFIkwZsI9qZhTTnY6lZ9wvPIvdD091ql2SlH0obHE+vEPg5b lk3tQHluxQLLEZV7NrcGZIpDwmbPhofMNNHN2mE5X3ajhpr1BVy13Lri2f6wacCCX19Rcd19fUn m0uH11qJyyeDTY2JQzO8y0AVukiYOuz5Nbm0ZV6hCt9Yd3IJtnP6+Hu28pNooIjAyPZxAHy2so7 5CWPJM7jJ+BDVhQBYRewo5cpQAJCGUt03kx20LRtZ7KgLNJ9NYDDT8kZ8xbFmbR2xnzKWBuYoXp /CJXgPdqTBfmX93JxxGsPAhJQ+lYc6dzkxYAeubizXMjMW+4sCWMA7h5U6zB7EKqRIVvq8629VJ +obvwEdkoTLBB6QggofIxEoYzZHDiElFcEEjEnyXGXMQFRnTU7WMnOs3nuEkYwCWSAGRQGMWBHF ArzA2zWPmM7gV9HjO+TBpURS X-Received: by 2002:a17:903:41cf:b0:2dd:7a0d:e51d with SMTP id d9443c01a7336-2e842ab64f2mr171051285ad.16.1792028943557; Wed, 14 Oct 2026 18:49:03 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:49:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc , Chancel Liu Subject: [PATCH v2 18/25] ASoC: imx-pcm-rpmsg: Fix imx_rpmsg_pcm_close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:17 +0700 Message-ID: <20261015014324.5569-19-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from imx_rpmsg_pcm_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 3c00eceb2a53 ("ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg") Reviewed-by: Chancel Liu Signed-off-by: bui duc phuc --- sound/soc/fsl/imx-pcm-rpmsg.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sound/soc/fsl/imx-pcm-rpmsg.c b/sound/soc/fsl/imx-pcm-rpmsg.c index 7086fb7fc1eb..85b7c929a28a 100644 --- a/sound/soc/fsl/imx-pcm-rpmsg.c +++ b/sound/soc/fsl/imx-pcm-rpmsg.c @@ -269,7 +269,13 @@ static int imx_rpmsg_pcm_open(struct snd_soc_component *component, info->stream_timer[substream->stream].substream = substream; timer_setup(&info->stream_timer[substream->stream].timer, imx_rpmsg_timer_callback, 0); - return ret; + + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int imx_rpmsg_pcm_close(struct snd_soc_component *component, -- 2.43.0