From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8072334B1B0 for ; Thu, 15 Oct 2026 01:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028675; cv=none; b=mD6TXMcCxN7pxit7NbhhFkb3kVOZiDY+HsoY7P5dtAEPQBtTb865apfZMGW6V88SefPIZU11NiwAaUrqTKfIWvJxjRMVYKufMsguzJs0PIgGZ0ieh/cT6YTxFHY32FuFRHZuYvfl4+PS+vwfxTUxI+1SVxUaTshr6DnszekimDY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792028675; c=relaxed/simple; bh=PxltNMQY4Mwf0miBiwGdcHoJbpALYxNGOELj9h3ky6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mpgWQqjPzo9rROhalT7oC+cEU669GWITylzShyJg11DO6eZ6IMuFRjy7b5IWriVRSH29ptKY/G3E4imD9VKYh8vLDnELlrdH2qd8PbIMOzr6o1X8k4PxZV6IQR7DjaIfksBKr1HoMdMglh8bx2Z178SHAmAQiOQECy9SoizAuy8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NZcm/EgJ; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NZcm/EgJ" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2e946155442so9570795ad.3 for ; Wed, 14 Oct 2026 18:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792028672; x=1792633472; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=NZcm/EgJGTSoahrgTYvpfiadxJl+YHkpB+p8KiElUaDciTrf324yATI6v+OnJ8RtMw ASHiO3SANkEfAH1pgWknUhvZd6x2TMKKt5UUa1vRIK1+feWF+YlnpoXpqDPROMWQn2OK hmtZWyG5X0E+asU6QlFFZeWYdO6X1oIY1rxhap44qK6wUHhOvMI/DHIerJp/2MkCbJid 1O1x1cP4a4OdGmXdyePj72Re2I09bluAiKtMKaJZ9fwIEf0sKdKF5h4bWatmNWFmFMpo EtA10jlYaZgPxEc/3jONFAdp00pPPUlIUvbgaWFwLX04ZzKE1q1oEv0kHYKhAL92HecX kBlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792028672; x=1792633472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0f9CDxT7c2yfniMxJX6Z2S0DK8dovzfteRrAqStY2sw=; b=a9731Dm1wjTPVcuRiJ3qjTOTnn+erw90UN+iJEi0Gx5iJcM79GRei1y1lbswKadCKd aEoCWmM1Izh2usEoWBiIkW+HBeO8H8VD5X1LAHsvgKbTzQsMXpxGG41fBC44gbfnPGWK SHAZHjmuF1uqGQDLkarU2LHlaguVNBZDXjkZUDFk4rBgur2SusM7PU0ElPh1VXlh14bO ZTY+AsMQ4ZR+dESf3xEuod55UpWFE+QcIIdID5m9P9DUsvfkbtupneJAn7p3hADOxWEj zM5jcCLTBRCwM03NOgTzE+KGt2rI8cREjwt7Ea16FkmFufZuExrp0wZbFYotgkXfmc9e CECw== X-Forwarded-Encrypted: i=1; AKwUvBwLPZ12oSy1Cv/7br/0d453Dz45COSASm96dfcPrIlohN+kd/Dik0QFVxEJYqdUynGcVCvthdM19qckow==@vger.kernel.org X-Gm-Message-State: AFq9FYI7hzaoZonNb1kiuqrutGH1pooI2OFj9Dt5SPlxacA/nfstWu/H EJXJUnISjQvJ56RoibUOX+iAEsMlCdoHKkIw9bNV8FTxeyy+2Fra+6yw X-Gm-Gg: AYBFou3qz2HqgClLWKnpa2XGgcJhJ2PLy9bLY9J0SXOvHhsD2lFUcC46nwu0Z5uCj83 Pih7fzhm8CfavlmixDrknuHX/NMpB4K7LLyJceFudRsJYLLcpb0VOpD+v6s9O7Y8Pn2CjTJaahk TYdrgkFLq6XeD+O7ZlqkRRghKT81yvgV0/OSK7uE44H6IlDZsOgfw3O0VB1yuSPgI7SxZC/DYOG AfVIZf65kLCq2A374iqMFYqaqTK1ykCrHde20pW2rKgR+hrCOTm+EjxwANMox3/08pFSLG3AQef H6frseLn6D7pCio0XX4FJJ5prheDwC25phqg2MS8fe2by4guizjwN07S3luhW6vxYbk7TI0Mt+S zB8qfV5fy/t5Z4WqffbFmFLJ8EAk4nOpTSOvbJ/tR3/lvMzscx2yMpWHhyBNxHvK11rVWlQXlKI Uy4GbIVpHDBL+ehk6PdszJOAo/2qyvM9o2INn76eb6A31Aa24SdZPkF3ZDifXEW4NMi1Cd1RpiZ 08qIiXQQOGCKK3piuPggTGClpclWDsD4I/caxYfEZ1Pl1feBH9S6NlTSJHu/o+NXDARxJpoDlW+ PCmozyeaunFyVw== X-Received: by 2002:a17:902:f541:b0:2dd:ad73:c938 with SMTP id d9443c01a7336-2e842abebd7mr158700385ad.25.1792028671728; Wed, 14 Oct 2026 18:44:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e8422b8cc1sm73202995ad.54.2026.10.14.18.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Oct 2026 18:44:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 01/25] ASoC: amd: acp: Fix .close() being skipped on rollback Date: Thu, 15 Oct 2026 08:43:00 +0700 Message-ID: <20261015014324.5569-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: 623621a9f9e1 ("ASoC: amd: Add common framework to support I2S on ACP SOC") Reviewed-by: Vijendar Mukunda Signed-off-by: bui duc phuc --- sound/soc/amd/acp/acp-platform.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c index 6b1e18b31c1c..f2c8853775ad 100644 --- a/sound/soc/amd/acp/acp-platform.c +++ b/sound/soc/amd/acp/acp-platform.c @@ -248,7 +248,12 @@ static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_subs list_add_tail(&stream->list, &chip->stream_list); spin_unlock_irq(&chip->acp_lock); - return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ + return 0; } static int acp_dma_hw_params(struct snd_soc_component *component, -- 2.43.0