From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 369831A6808 for ; Fri, 16 Oct 2026 04:01:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123277; cv=none; b=RhoBe4ls7JVh6p5eMPDaVbvGYH30xNl4JKTemz0M14lq6rcpBC5HVturUeleJJ1kRZoVFz0iKX3TeDGWi8uDy8IsQnkcFWMzvX7/kS1ypSIaUQGm7Ck1W09ay6bbKuS/CeewpsQVhjc1XdMq3Odnpe09mS1soTaWDKmOcSLRvMw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123277; c=relaxed/simple; bh=kz6hWgoXjwzN/plzsOuupJpm8SEQMOhxfOMvvFLoLo4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F2rHRQDqG4xcCgfV69/OpsnfvZ14KhkTFXP7FgCIzVsPegNTCzI5e0sptBd8Lvq7nV7QaGIuhg/My5TXcAqNdzqnaAIG4PUeJ6Xjd50MjAyYLxYelRYjk1zDsjX/VKeadf0v8mGf9DDfgkRXAfUz6RulQfJyEpeqIB8akvJafKM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YiU6kWI3; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YiU6kWI3" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2e87c66e556so3167025ad.0 for ; Thu, 15 Oct 2026 21:01:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123274; x=1792728074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5Qhe5E4dgThyJhSYyDtuQ9hNBBoGOWOTPXhOMe7iZzE=; b=YiU6kWI38o7n8Ng0a9H5qDIsVqCAnrHCHj1sdVAJsUntfAoVin71Cn3xhsDnYP/Exn pcZYJ/86txoykL0YK/CjwFnX6J9y+wBaG5FO1sKU/6/amBr78Qs8jXJHi1FiptgiM9+M ILBrXV3rcdDaEZinW8tA7y+yGf/RIEj+VDMQm89ey18mr6j+yvxpibG8qGgxaFPvQO6F svObyTy2lSHy+sgyySDEspbm9DJqRqkL0Ce5lJD2BcNfUQSSIiKo3ums+6bpcfBem/Tp IhnWn8kdo1BAmkQMg8YDJlLcmiXHpTpCqqmiZXzE2FFE2Jf4pL6WBF+BjGLoGmoQYu2k Spmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123274; x=1792728074; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=5Qhe5E4dgThyJhSYyDtuQ9hNBBoGOWOTPXhOMe7iZzE=; b=jqBsFRq05W7rD8nkMQ8cN2T5DCO2PMfcm5dIYU60M1XFYQ9Pnz0g92H34YjtW2AigT dhPjsx7L3qcZ82occNIFudV9zqzpDD3Nx/nPFPDJnEeCJ+i4wwPTXHpKeo53wZ3VXcuW oZaFkKLHsYm3Ef9MARaBAzqyrSOc5t700LQ5+96bPZ50ByFDaoGwYg+0hQVFenM04Ask iJNiYlZLO+eFNG0/4iXv2wMpD0xcPXszEUr4kpkjK+37H6rlsHGM5EVbjodqsxoxtmUR iCqlJvpiQp9BkyiNyNCfs0DwCVw1mcuwtNyyl9Sbw98bnaeQkgdjOTisQpBhoAKpNGIk sIsA== X-Forwarded-Encrypted: i=1; AKwUvBxPVXhcL7nvq/orR3LicMCfw22KhHgNp1f/agzPsAFQgjRMN1C5+Fgck7GnOFuEDJ13Lz3FQRXA3bQtig==@vger.kernel.org X-Gm-Message-State: AFq9FYIFNNzlGE3gQMpZuzZ7i05QY4qdaxX19VkgIje9G14vsBrwjZWB FZJSbpH5mA+1w+rtn3rQgDtY/EQwttG7KPGZE66frMko6XWdCIxk2c8q X-Gm-Gg: AYBFou1uFmO+u/mrJJB+mTGkb7sFSZxaZJkHpjQJPFl1Ax79rLZNro4xgr3ZBLK7AWJ msT7+S4QgTU/XOuc/WdczC5XIUJLFKv8Z8faHQ035xY7F9u7kCUJ7FaoNVkFJODkGCcQr3O7NlX X6Kdu62KM1Djn6iZ9cnIFqAURTkgXKQW2lfrOZQixREFnUJSdy7UoVcRtiLsRO3C7atmp2Bltku zEHRxlngpNVVkF6QdwziPBTwaw/UTUH1acBAyy/njhzM3S/RWwXc6KHGSstWh1Ew1Q16rJxMl6B E6RXXSQLdtb3PTXJeElWa0Gpx3jl+FjOj1z6W3KqLMM50v52sKMBJkmX4qJK5xtWC6Ue5jlek+P qf4DmomEs47rR2gFtGWY5CpPKo+VU8yo6WOeJ8IT9ZVeZPsE+0+hWN6qNuRTOxJSQdfaDq2LFam UDVN6AN+iRLktrHly4MGk99BOIOYqm56h9Jv6ypo1ogImkm2uAAMitWOUHCp2nwOwpXa4lvhdPo GYzRNSyzzxvtG8uCdq8IBZIOK8b0C4xtOFo02nyj+d4684mBlrWnWBSqO3oKSO5IkQiQn0zi1nu 4RL4oDgv617Yv98= X-Received: by 2002:a17:90b:39a4:b0:3ac:b764:8521 with SMTP id 98e67ed59e1d1-3acbb9255ccmr1718768a91.38.1792123274359; Thu, 15 Oct 2026 21:01:14 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3acc4872861sm2304450a91.7.2026.10.15.21.01.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:01:13 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 25/25] ASoC: rockchip: rockchip_max98090: Mark the link as started on success Date: Fri, 16 Oct 2026 11:00:48 +0700 Message-ID: <20261016040048.506531-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261015014324.5569-1-phucduc.bui@gmail.com> References: <20261015014324.5569-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from rk_aif1_startup(). ASoC only marks the DAI link as started when .startup() returns 0. This currently has no functional impact, as there is no .shutdown() callback in the relevant snd_soc_ops. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI link is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/rockchip/rockchip_max98090.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/sound/soc/rockchip/rockchip_max98090.c b/sound/soc/rockchip/rockchip_max98090.c index 426506a8e18e..de392b420ebd 100644 --- a/sound/soc/rockchip/rockchip_max98090.c +++ b/sound/soc/rockchip/rockchip_max98090.c @@ -191,12 +191,23 @@ static int rk_aif1_hw_params(struct snd_pcm_substream *substream, static int rk_aif1_startup(struct snd_pcm_substream *substream) { + int ret; /* * Set period size to 240 because pl330 has issue * dealing with larger period in stress testing. */ - return snd_pcm_hw_constraint_minmax(substream->runtime, - SNDRV_PCM_HW_PARAM_PERIOD_SIZE, 240, 240); + ret = snd_pcm_hw_constraint_minmax(substream->runtime, + SNDRV_PCM_HW_PARAM_PERIOD_SIZE, + 240, 240); + if (ret < 0) + return ret; + + /* + * ASoC only marks the DAI link as started when .startup() returns 0. + * Since snd_pcm_hw_constraint_minmax() may return 1, explicitly + * return 0 to ensure the DAI link is correctly marked as started. + */ + return 0; } static const struct snd_soc_ops rk_aif1_ops = { -- 2.43.0