From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 364C735E1D9 for ; Fri, 16 Oct 2026 04:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123850; cv=none; b=W2zZHTvBUmv8lpLGyrCQtsgyv6pXHGjlLCPKfCrCejh8XgqtepUEvhQ877CA9PKjxfYVPYn1ZGzIbDb1KnLLvHswMZFCl05yBmsOd6oSHI2V64yfjdBFW3GryFrit9xFW5pfNjqkg7tgkTrqhtlx58ZytYFzCuiUi7APPjvpeb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123850; c=relaxed/simple; bh=vdLtUhxLS4lGvufa56SD+uGcYjQygq5MJ/eIX5HtXec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JmVchzIdga+9ls8tlXksfKFsmFbGeY7ZCiNYq+9k3aE8Ea9pdC9gFR9tG2FdCs6BN0kOPW3ABTBHTnM331QUu8kZnx7i4bpV+SQy3lHzmtCF0JeW0YOEhiaEl9PBAs1oAOgrh/SB5doMEwBxDpnL2BmKjEmBEiTGBQZK/Wg0cwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OrXREDEy; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OrXREDEy" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2db80fcdf8bso35126055ad.2 for ; Thu, 15 Oct 2026 21:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123848; x=1792728648; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cRXMnaMYG3V2xMcW/3gwqdrm84/mm5oGaOhlRKzj2Og=; b=OrXREDEy4e8LCR6YNk+OfX5+0ZepyfMKD485p+FFBs9iuoNX5695HcxqHjBfUsxjiz tKZdaK62mKivx4RTknU0w4cu2Yq39hfUhn+wzlJyHSZ1BIW9eK1RqpB2DxPY0k0n2MEQ cDSPdezfrQj2AFFDbLP7CPml50PPcPMqHAxKQ+zfeKhR8JsmnVR6P7XxageoaMeLVflP rFn7USMVE6uBbImbYbHcaUmrIv9ejQ9TBd/2zu8hKArHTKSRXLSwgNcGDHhZRqsy6gnr xn748H0ho5iquKqM8GGa4ikw71Db4EBFzNeHiQ1c2S0nPErR76rnXGgSDiN2pXUFvPfe o9Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123848; x=1792728648; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=cRXMnaMYG3V2xMcW/3gwqdrm84/mm5oGaOhlRKzj2Og=; b=NaPYPbHR9NsAXub1/H+w3GpfxMCyuLz4RSu5RJx+AhDvZz+EW1MUp8cDgQ09+LLnnG zA3kIRPHAPmQ3CaThIvDA9/x29UCFvE7Mc3xzPGmZkC5JgxXuhVd1kUVBXWJ5Agx0Oah IG1CGBwuc1OTs1fRNEuNJe+RJSQtaBu3aa5BOShKPljZ8vB32FVqVMzcGVBoQHe5WVyA sT8crO5uZs9z8eFgcQkJq4gt3MXj2GeUoWdMbqwxZVSCQ2ETG0RyVLVtXgGRuFJHxE0F NNvWxmxIiYmyIbwzsQ6f5j3XT/hysvC1UNUZOF0BB7QROOEUb2U9J6FvCryBLam4CLZE ER+w== X-Forwarded-Encrypted: i=1; AKwUvBzGp0GQ4QA7ebIacdHLnA3w+A3U8e62wBuSYk8kJZuUofRpIphTBIaa+7V+aoxiUj014Z104FYgkuBwsg==@vger.kernel.org X-Gm-Message-State: AFq9FYLW8LU8Cdft29a9Em0td8s/fTdd3oa4zOwYQ+gl2i9skAXXe1sU hQu9/fJMRrO5OBLRdc1fqpO2+60Z51DxWT/z1TVGw1bBA+vdsrWo1s3t X-Gm-Gg: AYBFou0Z6yAWPGpXEGjmd4IyyZ1pT6/lo8yM9YSPQXMqF50IaZUIioFDpPUYuaGcDlc SmBAMmbkIemwmkU9CHtsEremXU7crCxloXTRsEUehMej4wTL8/B56HBi0ytRDlQ754ldVeI2SS5 huB0e4PslA2A73F4zufdgn1b6DKvR8oLssTlt8MstbsI7dgDHmFp9nWqfwvvQ5b894QmefM9H// JJy1QmZQQBatGaxcVHegFbWJFYzOAMnkpRI0Lxa2YvRSZuJRIwUS0xNU7WGFwHfeYT+amiwXm0n Yi2EBUjJP8BxeK0V+pFLoXOiq59uBgG1jd4VE78IT2vxMOvB5TsHL9g8nIUrzJuangjPW79vv6s PilBIRVo0ymxqOcr97XRT+dn/v8CaHQOiypgWbCluQKs4ayFPCyg0cKsv7lCFkHQu38LwwYK4IU zsvwcS8tfdHkksUA6s436XHBe+89ulbYGDA1ALIu4mWB+dGMvVJqnqdAGgXR/yRvg9952BPP3/h ZS7YPXOH5YHUSg/f8WLPkTmJlFBUisjczlKM7KclsCeTFt62olPK0ue+89mnSK8lbZ1w89JHX7T DcfFodYh3AlzmA== X-Received: by 2002:a17:903:181:b0:2e9:842d:3c34 with SMTP id d9443c01a7336-2e9842d3dd5mr10658595ad.13.1792123848458; Thu, 15 Oct 2026 21:10:48 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:10:48 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 03/11] ASoC: atmel: Explain component open return value handling Date: Fri, 16 Oct 2026 11:09:38 +0700 Message-ID: <20261016040946.521195-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Add a comment explaining why .open() must return 0 on success to ensure proper rollback handling and prevent future changes from reintroducing the issue. Signed-off-by: bui duc phuc --- sound/soc/atmel/atmel-pcm-pdc.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/atmel/atmel-pcm-pdc.c b/sound/soc/atmel/atmel-pcm-pdc.c index 552bfa30d4ba..4cedf2ad934d 100644 --- a/sound/soc/atmel/atmel-pcm-pdc.c +++ b/sound/soc/atmel/atmel-pcm-pdc.c @@ -295,6 +295,11 @@ static int atmel_pcm_open(struct snd_soc_component *component, } runtime->private_data = prtd; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure .close() is not skipped on rollback. + */ return 0; out: -- 2.43.0