From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3D5E382383 for ; Fri, 16 Oct 2026 04:11:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123899; cv=none; b=Z8QDD4lX/YeOhB1x65SQUQ1S6oG3TxVmQeD/M2KJ1youS5lVB9YeGcJfF+Qw1AWbtymsAyNTU1QiosWriFgZG1gZrwL/qFaxnk3Vb7HTrD1KUw6OpaJhlzO/DZccpWZDHxD1sdBJSsbJER9dUeIqSOO/wEyJR/jPRzhqjqiKXTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1792123899; c=relaxed/simple; bh=uLjOWXpOgCN4Y4ReFAuUHvuVmI9KZ+NG4nVknG5Mu6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mX8oSPocSAew/PTazJu1Dt/iIRfO4ZRT1gkSI3LfpF7uGh0ec7mmhrAc+u3O8J7SIqtY5oFotngyTouULsuqfh4a6ia1gc7St8vdOrcKwSCuHRU0MjopMkH6vxfkAfajwa1o2sIwHF53f78AlNuhZjne34KcwN5iNap327tpoVI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ce2TBOEZ; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ce2TBOEZ" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2e987b4a710so1150725ad.1 for ; Thu, 15 Oct 2026 21:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792123898; x=1792728698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6AfJhOKZbdns69Qk3jxc+qI7b+rXXsiPaDqc4PQO3Hk=; b=ce2TBOEZR1dCHGx/vxoEponfk20xOlHctd83T+o60GbAoEfvSs5Dcjyox9YpV7RtLz 8r50LB2jiBz+Uol70mHs4TgSsx6brR9tiZIeP7lW3z3ngqpLV+AHugRH5pDI7nX8iybk 6IKtlqdV0hiNPozz+SoZUf8ZZpNau/Qhdqn7Q6aUIgbFEORNFChjKv6gu1ksEN9kMbFg t8r6HfozNCb5e+v64//zyyWv66ZU5Sb2KYnpcWjhztM3Lufjkbr3t3oR4+uQpyR1q8kd LG2+nPDSdNgDqrC/VK6V+OCLfuf4TjXuhsPETr3lsL2GtFObIFvAeTYR+dEcbU3hHCHb J+Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792123898; x=1792728698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=6AfJhOKZbdns69Qk3jxc+qI7b+rXXsiPaDqc4PQO3Hk=; b=2tIHPVrAP/sR/DOh77Lsk7eKVbPK/SrdjeSNWQ7wfRFz/E4Ytk7OyUhyu4Ux55M7qs Eq4qbUKY6QhA/87lmKx12mE+7/sxMthYcHSrmfA+0XBkKpLJbJYE6mciH+wxaVVgmK7H Q0wcNZJHfWlhY0a2ezPBtJLF6fRmf8AWZVWiQPIHwY9SAzyLIX6A3t9+K5ERu9aOVvl3 Kog0E3MNYwekFrtUb6xZX4ZB/Q2V7jnM23kFZYxMqoj1uQIYhfvR8B1kniGsT2E9m3f/ pjuoPLvaMVKUS0zTcqcgim00SyyKXJbAwWFRy6T+upmhkOCV83wg5ZFfgJS/RZ7M8DVS FvwA== X-Forwarded-Encrypted: i=1; AKwUvBznDq0u0/ukw0S6yZUSUZZnDCEEDZrhOrSDh0TbHTOygOovW1jvdK163SifPVGMpZ+bXnDZmfJZUdv6Vw==@vger.kernel.org X-Gm-Message-State: AFq9FYJC15jFZkSd6TLbV/HgAErZmYC2BJTcsMPQSU6rzc974PNLsX3R COsYCTdL2XA3ZgfvRPjlVFcqZBgJwK6UREFF2sof78W1RjZzkOZIhACy X-Gm-Gg: AYBFou0c/8BaVzW6gYfCENZ8oGWBgfzOZvJnxYAlipWlNLpwqFPOYK7HgemUKdH92Hi BsOWDm97LS+jtGrKEUkq+kTzxyUNWp3DvNZzzhTDjXTnlVGzbC83+XpmIXFm/noexTJrTdV0DDP C5guDeibq58vU/oXrkdwqp/dYG55cXfeAv8GD9Rl5D7PrHN6XHPspaw1lGXF66bs9U9kp2uYaSk WQN2DXmecsGpcwzT3gSQ38Y4FCgycVVr3ej5pqm0cSxuvNDZOfxCHnBiBqGnAjd0TsauA9gwwid 9cnLtDLmrnyHvefoCEHkMwKWG+M8d8rPL4YbnlX8uFD/JffglAiOmstCkHDG/JDnMrVTrhaM7a8 0uB1tBURQhdgAXvA5c/d6L0CnIgRdauNSZ+a2du8y1Hefad42RhM4m04QaPsbeS/ivdbEvuJuVo d9EoH+doWxi23T39d+XwtdTY1JNTOjUHSxDEoCFlNvtvWzLXA2IHQaQ8KcHRmGu4VCrVaAYzyhv bI5EnMrmlmFUavkyze+/AAeeSBjeZVwg+sMjK/BRVBivdIuua2KORU0fZXN1Hbsdu8czHo+WceN sKt+xY7nvbQPjQ== X-Received: by 2002:a17:902:e54e:b0:2e8:3b2d:c0e1 with SMTP id d9443c01a7336-2e977597291mr13010325ad.41.1792123897928; Thu, 15 Oct 2026 21:11:37 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e97e8ab443sm3815785ad.65.2026.10.15.21.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2026 21:11:37 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 07/11] ASoC: renesas: msiof: Explain component open return value handling Date: Fri, 16 Oct 2026 11:09:42 +0700 Message-ID: <20261016040946.521195-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261016040946.521195-1-phucduc.bui@gmail.com> References: <20261016040946.521195-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Add a comment explaining why .open() must return 0 on success to ensure the component is correctly marked as opened and prevent future changes from reintroducing the issue. Acked-by: Kuninori Morimoto Signed-off-by: bui duc phuc --- sound/soc/renesas/fsi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sound/soc/renesas/fsi.c b/sound/soc/renesas/fsi.c index 88618e4b052d..74e2ea002fbb 100644 --- a/sound/soc/renesas/fsi.c +++ b/sound/soc/renesas/fsi.c @@ -1820,6 +1820,11 @@ static int fsi_pcm_open(struct snd_soc_component *component, if (ret < 0) return ret; + /* + * ASoC only marks the component as opened when .open() returns 0. + * Since snd_pcm_hw_constraint_integer() may return 1, explicitly + * return 0 to ensure the component is correctly marked as opened. + */ return 0; } -- 2.43.0