Re: [PATCH v7] ASoC: tas2783-sdw: add firmware download status check

[Lee Mann <leepaulmann@gmail.com>]

Follow-up with one more data point, which supports the approach in
this patch.

Same PX13, kernel 7.3.3, with two modules swapped:

  - snd-soc-tas2783-sdw: unmodified v7.4-rc1 tas2783-sdw.c/tas2783.h
  - snd-soc-sdca: v7.3.3 plus only the sdca_functions.c fallback from
    SOF PR #5904 (function type for mfg 0x0102 / part 0x0000)

Kernel log:

  acpi device:26: function type not a DisCo constant, using fallback for known peripheral
  acpi device:26: SDCA function SmartAmp (type 1) at 0x1
  acpi device:28: function type not a DisCo constant, using fallback for known peripheral
  acpi device:28: SDCA function SmartAmp (type 1) at 0x1
  slave-tas2783 sdw:0:1:0102:0000:01:8: Found Smart Amp function at index 0
  slave-tas2783 sdw:0:1:0102:0000:01:b: Found Smart Amp function at index 0

speaker-test -c2 -t wav: Front Left from the left speaker, Front Right
from the right speaker. No "Defer on undeferrable control" warnings
(with the same fallback on the v7.3-rc6 driver I saw ~1600 of them
during playback).

So on the PX13 the v7.4 driver works as intended once the ASUS SDCA
function is parsed. The regression is only that the parse fails on
this firmware. Getting the PR #5904 fallback (or an equivalent) into
v7.4 would fix it without bringing back the split. I can test a
posted version.

https://github.com/thesofproject/linux/pull/5904

Thanks,
Lee Mann