Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Gianluca Boiano <morf3089@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Gianluca Boiano <morf3089@gmail.com>,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver
Date: Fri, 20 Nov 2026 01:44:38 +0100	[thread overview]
Message-ID: <20261120004442.1687225-1-morf3089@gmail.com> (raw)
In-Reply-To: <de369f10-e7c6-4528-aa57-56241bf700b3@sirena.org.uk>

On Sun, Jul 19, 2026 at 08:05:19PM +0100, Mark Brown wrote:
> This looks awfully board specific....

v4 adds ti,asi-port, and the driver programs only the selected ASI,
on the pins the datasheet marks as preferred for that port.

> I didn't check but is there room for sharing code with the other
> multi-book TI devices?

Yes. v4 uses tas2781-comlib-i2c for the paged regmap, book/page
switching and per-chip access, and drops the private copy.

> The tas2781 checks to see if there are one or two devices being
> controlled by the driver and rejects a mismatch.  Also, is there some
> overlap in firmware formats here?  Again I didn't actually check.

The header has the same layout as the one tas2781-fmwlib parses
(fixed header, description, device family, device), so v4 uses the
TASDEVICE_DSP_TAS_2557_*
values and rejects an image whose chip count does not match before
installing it. The body differs: TAS2557 images carry a PLL section
and each configuration references a PLL by index, which fmwlib does
not parse, so that part stays in the driver.

> Shouldn't an out of range value be an error?

Yes, the image is rejected in v4.

> Does sense_muted get handled properly for suspend?  The core mutes and
> unmutes playback streams over suspend but not capture.

sense_muted is gone. The I/V sense ADCs feed the DSP's speaker
protection, so v4 keeps them powered and unmuted while the amplifier
plays, as TI's driver does, and sets no_capture_mute.

> This won't actually take effect if the device doesn't power down - you
> should probably not set use_pmdown_time to force a power down/up, though
> that's annoying when the configuration is the same.

v4 applies the change from hw_params() when the group is already
powered and reloads the configuration only if the new rate needs a
different one. use_pmdown_time stays.

Gianluca

      reply	other threads:[~2026-11-20  0:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 23:33 [PATCH v3 0/2] ASoC: codecs: add Texas Instruments TAS2557 smart amplifier driver Gianluca Boiano
2026-07-17 23:33 ` [PATCH v3 1/2] dt-bindings: sound: add Texas Instruments TAS2557 Gianluca Boiano
2026-07-19  8:33   ` Krzysztof Kozlowski
2026-11-20  0:44     ` Gianluca Boiano
2026-07-17 23:34 ` [PATCH v3 2/2] ASoC: codecs: add TAS2557 mono smart amplifier driver Gianluca Boiano
2026-07-18 15:36   ` Markus Elfring
2026-11-20  0:44     ` Gianluca Boiano
2026-07-19 19:05   ` Mark Brown
2026-11-20  0:44     ` Gianluca Boiano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261120004442.1687225-1-morf3089@gmail.com \
    --to=morf3089@gmail.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox