From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A9A77655 for ; Tue, 12 Mar 2024 14:50:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710255023; cv=none; b=Y/NGarcssny2iLjaM4CV+//IJlPKCA9yo7R75X6P0gBTk/hFj7tNryp4GSU/aCDiDXAVfiPPFbFeeLVhQXhZuENSP6/a1FYfTpbgQeQpiAyK+QM+sOsDmykEBotLurzbEqs821QvddMCMv1PYXCOuyU/Fz4muOPKevIpex1YvJ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710255023; c=relaxed/simple; bh=HRKqHTo2coRukof51yfticbZ5DFq9gs/6ILyHCTY6is=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JD1fg7ynHGUEajOWgrQjvhW50f0HCHKDmejEZAvYvZnC80SisuEv0U2MPoLEuEIFCOaFg4fETeMJ5kAix6gaytnwi9eqqrZwJ59LSq2V3CtEFf+xKCHClaVhM/4nQ9VcV7owWqn7u796TOmvr/lOmVUB1f+GKpcDkfrE2q7LKhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=jeYtFwEV; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="jeYtFwEV" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-51320ca689aso4830804e87.2 for ; Tue, 12 Mar 2024 07:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1710255020; x=1710859820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cdxOToZtr3MgG8M5yCGfJbtM/oXC1jGaY0CYXkO7JjE=; b=jeYtFwEVtAOM2nWoEXkkyKq/6O3SPEL1U5DfyvJEJhsSYNHy1fhgGoGUVXndADKtDM TiyUyJx9H8s7ZxcyGIfjxuo+F1CFn8Ig1tU21ogfubtuvbUtiOVCz3VUO0h/xxk4ShyM EdSZisVPU3BE47YiIzff0Xae4W6zWZFdbjVE66zruczCP3zIp92M2cjEdUfnwchCU2hF WvdLIh5n+/SvCFFilqTcz9MQbge/jKf3/8dBcQnTA54R73/NhBs3gxz0CPSwF1ktc1jF 02VX8pXripZGXmlGFeL2WeIAuX6sgpG74h3vnnb5+fZrtsz6KiiEyoOumXW5j+sh6P6X SL7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710255020; x=1710859820; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cdxOToZtr3MgG8M5yCGfJbtM/oXC1jGaY0CYXkO7JjE=; b=plsSWy3etXZy1db2Tk1kvHDO8vrpKtKpFzv5guUI26gpduCBgdiRa9lrRaPP/l9J5K C/bSDo8prJXFL+gW3pGaxjfTJHFmGh6BU63Z7FFFITrz48/4KrANLinRTv06xJPxl5K3 OwDqdQekMARUeteTdHdhcQq/2ICslR5/v3jyyFdHWgmJy+rutYTgw9rvdeyECwkywwE4 2XYyYLFpbsuZJgY7oHoROo3I49lz0WJOYqQuzoih9OiUKWiiL0MbfOWLAGcxrOa5nQOu lLO7XWaItsQtmNJg5I1nRi2aMwJJAq2ujuxizCNRmB9F8lakkTjFXo4aS6xPivXHTt8k JYkg== X-Forwarded-Encrypted: i=1; AJvYcCWOpT75eCzxQ4R/LYsCyg9XsSjFzGQsY9P0egh7K17kcOUCHAGcE3zOAAq/LmQKNqKfYQ5QKZoEQreCIPF+PhLouoHybj+JAynbs7w= X-Gm-Message-State: AOJu0YzawZuVGuodQWQ9E2jOI1gqPLHY4b4dUJZg5cK5J44XfgZE8iWn qdGfLbJlDBfsPC/fjsiLJAu/9UyenVdBtQ9FSwWPYAVBWmWY5jeGauFoCnZW0IM= X-Google-Smtp-Source: AGHT+IF4U7++EP6lI1eUA5YZ5DAJajTZAe48hL6g0In91UMupEHYzfMoae2xpi5b5/CBMmyo7KWbtw== X-Received: by 2002:ac2:51a5:0:b0:512:bf99:7d80 with SMTP id f5-20020ac251a5000000b00512bf997d80mr6373397lfk.1.1710255019673; Tue, 12 Mar 2024 07:50:19 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id u18-20020a05600c19d200b0041316e91c99sm12715808wmq.1.2024.03.12.07.50.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 07:50:19 -0700 (PDT) Message-ID: <253b4b6c-d8ba-40a3-adbb-4455af57d780@baylibre.com> Date: Tue, 12 Mar 2024 15:50:17 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec Content-Language: en-US To: AngeloGioacchino Del Regno Cc: Flora Fu , Liam Girdwood , Lee Jones , Rob Herring , Mark Brown , Matthias Brugger , Conor Dooley , Krzysztof Kozlowski , Catalin Marinas , =?UTF-8?Q?Christian_K=C3=B6nig?= , Sumit Semwal , Takashi Iwai , Jaroslav Kysela , Will Deacon , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Nicolas Belin References: <20240226-audio-i350-v1-0-4fa1cea1667f@baylibre.com> <20240226-audio-i350-v1-12-4fa1cea1667f@baylibre.com> <1641a853-88cb-43a8-bb95-653f5329a682@collabora.com> From: Alexandre Mergnat In-Reply-To: <1641a853-88cb-43a8-bb95-653f5329a682@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/02/2024 16:25, AngeloGioacchino Del Regno wrote: >> +    if (enable) { >> +        /* set gpio mosi mode */ >> +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_CLR, >> GPIO_MODE2_CLEAR_ALL); >> +        regmap_write(priv->regmap, MT6357_GPIO_MODE2_SET, >> GPIO8_MODE_SET_AUD_CLK_MOSI | >> +                                  GPIO9_MODE_SET_AUD_DAT_MOSI0 | >> +                                  GPIO10_MODE_SET_AUD_DAT_MOSI1 | >> +                                  GPIO11_MODE_SET_AUD_SYNC_MOSI); > > Are you sure that you need to write to MODE2_SET *and* to MODE2?! This is downstream code and these registers aren't in my documentation. I've removed the MODE2_SET write and test the audio: it's still working. So I will keep the spurious write removed for v2. :) -- Regards, Alexandre