From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
To: Mark Brown <broonie@kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
<alsa-devel@alsa-project.org>, <linux-arm-msm@vger.kernel.org>,
<linux-sound@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <quic_rohkumar@quicinc.com>,
<quic_pkumpatl@quicinc.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver
Date: Wed, 19 Jun 2024 16:32:44 +0530 [thread overview]
Message-ID: <288156b9-2f72-6929-3422-c3aecb9c2c07@quicinc.com> (raw)
In-Reply-To: <f741630e-f9e8-45e1-b3e2-4866f0baeac2@sirena.org.uk>
On 6/17/2024 5:25 PM, Mark Brown wrote:
> On Sun, Jun 16, 2024 at 04:54:58PM +0200, Christophe JAILLET wrote:
>> Le 11/06/2024 à 09:45, Mohammad Rafi Shaik a écrit :
>
>>> +static void wcd937x_soc_codec_remove(struct snd_soc_component *component)
>>> +{
>>> + struct wcd937x_priv *wcd937x = snd_soc_component_get_drvdata(component);
>>> +
>>> + wcd937x_mbhc_deinit(component);
>>> + free_irq(wcd937x->aux_pdm_wd_int, wcd937x);
>>> + free_irq(wcd937x->hphl_pdm_wd_int, wcd937x);
>>> + free_irq(wcd937x->hphr_pdm_wd_int, wcd937x);
>
>> These irq have been requested wth devm_request_threaded_irq(), so either
>> this free_irq should be removed, or devm_free_irq() should be used if the
>> order is important.
>
> Yes, this should be fixed.
okay, will check and provide the fix.
Thanks & Regards,
Rafi.
next prev parent reply other threads:[~2024-06-19 11:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-11 7:45 [PATCH v6 0/7] ASoC: codecs: wcd937x: add wcd937x audio codec support Mohammad Rafi Shaik
2024-06-11 7:45 ` [PATCH v6 1/7] ASoC: dt-bindings: document wcd937x Audio Codec Mohammad Rafi Shaik
2024-06-11 7:45 ` [PATCH v6 2/7] ASoC: codecs: wcd937x-sdw: add SoundWire driver Mohammad Rafi Shaik
2024-06-16 16:23 ` Markus Elfring
2024-06-11 7:45 ` [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver Mohammad Rafi Shaik
2024-06-16 14:54 ` Christophe JAILLET
2024-06-17 11:55 ` Mark Brown
2024-06-19 11:02 ` Mohammad Rafi Shaik [this message]
2024-06-19 20:45 ` Christophe JAILLET
2024-06-16 15:06 ` [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver - another comment Christophe JAILLET
2024-06-16 16:38 ` [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver Markus Elfring
2024-06-17 11:54 ` Mark Brown
2024-06-17 12:32 ` [v6 " Markus Elfring
2024-06-16 17:26 ` [PATCH v6 " Markus Elfring
2024-06-11 7:45 ` [PATCH v6 4/7] ASoC: codecs: wcd937x: add basic controls Mohammad Rafi Shaik
2024-06-11 7:45 ` [PATCH v6 5/7] ASoC: codecs: wcd937x: add playback dapm widgets Mohammad Rafi Shaik
2024-06-11 7:45 ` [PATCH v6 6/7] ASoC: codecs: wcd937x: add capture " Mohammad Rafi Shaik
2024-06-11 7:45 ` [PATCH v6 7/7] ASoC: codecs: wcd937x: add audio routing and Kconfig Mohammad Rafi Shaik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=288156b9-2f72-6929-3422-c3aecb9c2c07@quicinc.com \
--to=quic_mohs@quicinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_pkumpatl@quicinc.com \
--cc=quic_rohkumar@quicinc.com \
--cc=robh@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox