[PATCH] ALSA: hda: Avoid binding with SOF for SKL/KBL platforms

[PATCH] ALSA: hda: Avoid binding with SOF for SKL/KBL platforms

[Takashi Iwai]

For Intel SKL and KBL platforms, it may be bound with one of three
HD-audio drivers (AVS, SOF and legacy).  AVS is the preferred one when
DMIC is detected, and that's how it's defined in the snd-intel-dspcfg
config table.

But, when AVS driver is disabled (CONFIG_SND_SOC_INTEL_AVS=n), the
device may be bound freely with either SOF or legacy driver.
Before 6.17, the legacy driver took it primarily, but on 6.17, likely
due to the recent code shuffling, SOF driver seems taking it at first,
and fails to probe.  For avoiding the regression, we should enforce to
bind those with the legacy HD-audio drvier when AVS is disabled.

This patch adds the extra two entries in intel-dspcfg table that are
applied only when CONFIG_SND_SOC_INTEL_AVS=n, for binding with the
legacy driver.

Note that there are entries for APL in that config table block, but
APL may be supported by SOF for certain setups, so the choice can't be
exclusive.  Hence this patch includes only SKL and KBL.

Link: https://bugzilla.suse.com/show_bug.cgi?id=1248121
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/hda/core/intel-dsp-config.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/hda/core/intel-dsp-config.c b/sound/hda/core/intel-dsp-config.c
index 00f184917623..c15284742899 100644
--- a/sound/hda/core/intel-dsp-config.c
+++ b/sound/hda/core/intel-dsp-config.c
@@ -116,6 +116,13 @@ static const struct config_entry config_table[] = {
 		.flags = FLAG_SST,
 		.device = PCI_DEVICE_ID_INTEL_HDA_FCL,
 	},
+#else /* AVS disabled; force to legacy as SOF doesn't work for SKL or KBL */
+	{
+		.device = PCI_DEVICE_ID_INTEL_HDA_SKL_LP,
+	},
+	{
+		.device = PCI_DEVICE_ID_INTEL_HDA_KBL_LP,
+	},
 #endif
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
 	{
-- 
2.50.1

Re: [PATCH] ALSA: hda: Avoid binding with SOF for SKL/KBL platforms

[Cezary Rojewski]

On 2025-08-28 4:11 PM, Takashi Iwai wrote:
> For Intel SKL and KBL platforms, it may be bound with one of three
> HD-audio drivers (AVS, SOF and legacy).  AVS is the preferred one when
> DMIC is detected, and that's how it's defined in the snd-intel-dspcfg
> config table.
> 
> But, when AVS driver is disabled (CONFIG_SND_SOC_INTEL_AVS=n), the
> device may be bound freely with either SOF or legacy driver.
> Before 6.17, the legacy driver took it primarily, but on 6.17, likely
> due to the recent code shuffling, SOF driver seems taking it at first,
> and fails to probe.  For avoiding the regression, we should enforce to
> bind those with the legacy HD-audio drvier when AVS is disabled.
> 
> This patch adds the extra two entries in intel-dspcfg table that are
> applied only when CONFIG_SND_SOC_INTEL_AVS=n, for binding with the
> legacy driver.
> 
> Note that there are entries for APL in that config table block, but
> APL may be supported by SOF for certain setups, so the choice can't be
> exclusive.  Hence this patch includes only SKL and KBL.
> 
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1248121
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>   sound/hda/core/intel-dsp-config.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/sound/hda/core/intel-dsp-config.c b/sound/hda/core/intel-dsp-config.c
> index 00f184917623..c15284742899 100644
> --- a/sound/hda/core/intel-dsp-config.c
> +++ b/sound/hda/core/intel-dsp-config.c
> @@ -116,6 +116,13 @@ static const struct config_entry config_table[] = {
>   		.flags = FLAG_SST,
>   		.device = PCI_DEVICE_ID_INTEL_HDA_FCL,
>   	},
> +#else /* AVS disabled; force to legacy as SOF doesn't work for SKL or KBL */
> +	{
> +		.device = PCI_DEVICE_ID_INTEL_HDA_SKL_LP,
> +	},
> +	{
> +		.device = PCI_DEVICE_ID_INTEL_HDA_KBL_LP,
> +	},
>   #endif
>   #if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
>   	{

Thanks for assistance, Takashi, much appreciated. Given the explanation, 
I'm OK with including just SKL/KBL and skipping APL here.

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>