From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Val Packett <val@packett.cool>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: Bhushan Shah <bhushan.shah@machinesoul.in>,
Luca Weiss <luca.weiss@fairphone.com>,
Antoine Bernard <zalnir@proton.me>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 6/6] ASoC: qcom: sm8250: apply codec_fmt to all codec DAIs
Date: Thu, 7 May 2026 09:02:53 +0000 [thread overview]
Message-ID: <2f516258-d71d-4b52-a310-1b6ea11455ed@oss.qualcomm.com> (raw)
In-Reply-To: <20260506204142.659778-7-val@packett.cool>
On 5/6/26 8:33 PM, Val Packett wrote:
> With MI2S and TDM interfaces, multiple codecs typically share one bus.
> All codecs on the bus should receive the same format configuration, so
> apply the codec_fmt to all of them.
>
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> sound/soc/qcom/sm8250.c | 33 ++++++++++++++++++++++-----------
> 1 file changed, 22 insertions(+), 11 deletions(-)
>
> diff --git a/sound/soc/qcom/sm8250.c b/sound/soc/qcom/sm8250.c
> index 9f0f846a14bb..7bfe6d282231 100644
> --- a/sound/soc/qcom/sm8250.c
> +++ b/sound/soc/qcom/sm8250.c
> @@ -167,7 +167,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> struct snd_soc_card *card = rtd->card;
> struct sm8250_snd_data *data = snd_soc_card_get_drvdata(card);
> struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
> - struct snd_soc_dai *codec_dai = snd_soc_rtd_to_codec(rtd, 0);
> + struct snd_soc_dai *codec_dai;
> + int j;
>
> switch (cpu_dai->id) {
> case PRIMARY_MI2S_RX:
> @@ -177,7 +178,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> Q6AFE_LPASS_CLK_ID_PRI_MI2S_IBIT,
> MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> snd_soc_dai_set_fmt(cpu_dai, fmt);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
failures ignored,
Can we add a helper function would be nice here.
--srini
> break;
> case SECONDARY_MI2S_RX:
> codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> @@ -186,7 +188,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> Q6AFE_LPASS_CLK_ID_SEC_MI2S_IBIT,
> MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> snd_soc_dai_set_fmt(cpu_dai, fmt);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case TERTIARY_MI2S_RX:
> codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> @@ -195,7 +198,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> Q6AFE_LPASS_CLK_ID_TER_MI2S_IBIT,
> MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> snd_soc_dai_set_fmt(cpu_dai, fmt);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case QUINARY_MI2S_RX:
> codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> @@ -204,7 +208,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> Q6AFE_LPASS_CLK_ID_QUI_MI2S_IBIT,
> MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> snd_soc_dai_set_fmt(cpu_dai, fmt);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case SENARY_MI2S_RX:
> codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
> @@ -213,7 +218,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> Q6AFE_LPASS_CLK_ID_SEN_MI2S_IBIT,
> MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> snd_soc_dai_set_fmt(cpu_dai, fmt);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case PRIMARY_TDM_RX_0:
> codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> @@ -221,7 +227,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> snd_soc_dai_set_sysclk(cpu_dai,
> Q6AFE_LPASS_CLK_ID_PRI_TDM_IBIT,
> TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case SECONDARY_TDM_RX_0:
> codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> @@ -229,7 +236,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> snd_soc_dai_set_sysclk(cpu_dai,
> Q6AFE_LPASS_CLK_ID_SEC_TDM_IBIT,
> TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case TERTIARY_TDM_RX_0:
> codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> @@ -237,7 +245,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> snd_soc_dai_set_sysclk(cpu_dai,
> Q6AFE_LPASS_CLK_ID_TER_TDM_IBIT,
> TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case QUATERNARY_TDM_RX_0:
> codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> @@ -245,7 +254,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> snd_soc_dai_set_sysclk(cpu_dai,
> Q6AFE_LPASS_CLK_ID_QUAD_TDM_IBIT,
> TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> case QUINARY_TDM_RX_0:
> codec_dai_fmt |= SND_SOC_DAIFMT_IB_NF | SND_SOC_DAIFMT_DSP_B;
> @@ -253,7 +263,8 @@ static int sm8250_snd_startup(struct snd_pcm_substream *substream)
> snd_soc_dai_set_sysclk(cpu_dai,
> Q6AFE_LPASS_CLK_ID_QUIN_TDM_IBIT,
> TDM_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
> - snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> + for_each_rtd_codec_dais(rtd, j, codec_dai)
> + snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
> break;
> default:
> break;
prev parent reply other threads:[~2026-05-07 9:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 20:33 [PATCH v2 0/6] ASoC: qcom: fixes and improvements Val Packett
2026-05-06 20:33 ` [PATCH v2 1/6] ASoC: qcom: qdsp6: q6afe: fix clk vote response type mismatch Val Packett
2026-05-07 0:02 ` Mark Brown
2026-05-07 1:46 ` Val Packett
2026-05-07 2:16 ` Mark Brown
2026-05-07 8:03 ` Konrad Dybcio
2026-05-07 8:23 ` Mark Brown
2026-05-06 20:33 ` [PATCH v2 2/6] ASoC: qcom: qdsp6: q6routing: add Senary MI2S ports Val Packett
2026-05-07 8:31 ` Srinivas Kandagatla
2026-05-06 20:33 ` [PATCH v2 3/6] ASoC: qcom: sm8250: add Senary MI2S RX support Val Packett
2026-05-07 8:34 ` Srinivas Kandagatla
2026-05-06 20:33 ` [PATCH v2 4/6] ASoC: qcom: sm8250: add TDM " Val Packett
2026-05-07 8:51 ` Srinivas Kandagatla
2026-05-07 20:24 ` Val Packett
2026-05-06 20:33 ` [PATCH v2 5/6] ASoC: qcom: sm8250: shut down MI2S/TDM AFE port clocks Val Packett
2026-05-07 8:57 ` Srinivas Kandagatla
2026-05-07 20:44 ` Val Packett
2026-05-06 20:33 ` [PATCH v2 6/6] ASoC: qcom: sm8250: apply codec_fmt to all codec DAIs Val Packett
2026-05-07 9:02 ` Srinivas Kandagatla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f516258-d71d-4b52-a310-1b6ea11455ed@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=bhushan.shah@machinesoul.in \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=perex@perex.cz \
--cc=phone-devel@vger.kernel.org \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=val@packett.cool \
--cc=zalnir@proton.me \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox