From: "Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, linux-sound@vger.kernel.org,
kai.vehmanen@linux.intel.com, ranjani.sridharan@linux.intel.com,
yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev,
seppo.ingalsuo@linux.intel.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/8] ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls
Date: Wed, 17 Dec 2025 14:35:17 +0200 [thread overview]
Message-ID: <329a3007-de85-41c6-9b63-ca79e3bfbdef@linux.intel.com> (raw)
In-Reply-To: <652a147c-2012-469f-b0e0-c73a1385cacb@sirena.org.uk>
On 17/12/2025 14:04, Mark Brown wrote:
> On Mon, Dec 15, 2025 at 04:25:10PM +0200, Peter Ujfalusi wrote:
>
>> Fixes: a062c8899fed ("ASoC: SOF: ipc4-topology: add byte kcontrol support")
>
> Commit: d80b24e6a5a1 ("ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls")
> Fixes tag: Fixes: a062c8899fed ("ASoC: SOF: ipc4-topology: add byte kcontrol support")
> Has these problem(s):
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> a062c8899fed is "ASoC: SOF: ipc4-control: Add support for bytes control
> get and put".
uh, oh, the correct tag for this should have been:
Fixes: a382082ff74b ("ASoC: SOF: ipc4-topology: Add support for TPLG_CTL_BYTES")
but the SHA in tag is also fine as that is the point when this code is first used.
Should I resend the series?
--
Péter
next prev parent reply other threads:[~2025-12-17 12:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 14:25 [PATCH v2 0/8] ASoC: SOF: ipoc4: Support for generic bytes controls Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 1/8] ASoC: SOF: ipc4-control: If there is no data do not send bytes update Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 2/8] ASoC: SOF: ipc4-topology: Correct the allocation size for bytes controls Peter Ujfalusi
2025-12-17 12:04 ` Mark Brown
2025-12-17 12:35 ` Péter Ujfalusi [this message]
2025-12-17 12:37 ` Mark Brown
2025-12-15 14:25 ` [PATCH v2 3/8] ASoC: SOF: ipc4-control: Use the correct size for scontrol->ipc_control_data Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 4/8] ASoC: SOF: ipc4-control: Keep the payload size up to date Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 5/8] ASoC: SOF: ipc4-topology: Set initial param_id for bytes control type Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 6/8] ASoC: SOF: ipc4: Support for sending payload along with LARGE_CONFIG_GET Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 7/8] ASoC: SOF: ipc4: Add definition for generic bytes control Peter Ujfalusi
2025-12-15 14:25 ` [PATCH v2 8/8] ASoC: SOF: ipc4-control: Add support " Peter Ujfalusi
2025-12-19 14:09 ` [PATCH v2 0/8] ASoC: SOF: ipoc4: Support for generic bytes controls Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=329a3007-de85-41c6-9b63-ca79e3bfbdef@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=seppo.ingalsuo@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox