From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CE932E157 for ; Fri, 17 Oct 2025 15:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715361; cv=none; b=rDJnQomhx3isjK7V2DDjSHUvC5X4EioP4Qj4gwCVjx86dqF1mlbzIQpilD6zaaEhoFvQy+TOA1IzCU/RT3Yq00RiKl35vanJDunTs99OV2bSngrrz9C/QtdW9U4+YJ/XkaUudF18jbH2kWG3J+mQAn9L14IfSf2jpsDX85CSXQA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760715361; c=relaxed/simple; bh=K2qsVubYn8CjPdJ5wxrhOx1EatQUzPg4cvi5piJsRvg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=GAR2Fc3UIWnkEocfU3IfdKHUqpc5nelYBcM7sCHuNGfowEAQofduh/s9m+/NJZnyHLSd70kC5+olGg1xPc8IwdPwCwvC/J/ONdzE/wGofNT5uCyVzC+zVYIgyjTuRS0Uu+Gpxim9w0RKHDb0dKV9utQt6p3YcvMqOCQvQbBYqBk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OHR94A4w; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OHR94A4w" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-46e6a689bd0so20038505e9.1 for ; Fri, 17 Oct 2025 08:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760715357; x=1761320157; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=jXEmmH8KoIy+3oXIIcxfKQybPt2IeFDnPMZ3gpQBr8I=; b=OHR94A4wi7UuKhVMy2p0jHbB3azRh7iDoA0SAMo0JnGyTVamlfctEEb5IM9J8yLEGx zz2xkVhJ5cyQOfGqNyWJVmeUDdclYaxJoIUrqIUgG2knhD3PhO/3MwW/wnowhHVESIbB TKncrp0Di3lZZOokMU4xXnlJBeNK7All53/UD6H6QetaYzz76dCL9Lx9RNyIVnSEZLGD 4baLTmyQt0KplV3SpaAtgqnK/6rrz4IJwTeaaVOHCrynn5xSejre7O4Uj+OxAe+orFE3 czCRg3zFr/sMoz/HwIc622Gqixe4Xee4tJWJVrBYjV7rPlpeVRaRR0coA0uO5y+mrdIx TP4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760715357; x=1761320157; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jXEmmH8KoIy+3oXIIcxfKQybPt2IeFDnPMZ3gpQBr8I=; b=N3x0+bdtOWMNxa6s87ATclfZHD7gOGwRb6LNyziub5Fip88uW5c3Eijya6hDPXgn12 vWaLtQKTyiPbUIXjxstYtY1rKJFhrei4jc/m3qG+uC7mRitEYlanovBHTTCuImMrAqZ+ BBrpcs2sf6UA/VtmbS3cNBcRyq7sDA1cLxe9YZPbpTc9RUu76P33p4QU2ls6Q8Vb8BYN EjREuLH/Ihev29MIbncAqQ/UFgDPySkmZC+ot+cMhl8pXgnRGN3D5FIIJcWllu9zy3rJ 5kGFFmomAk7fzBeJPvxWTobTZ8FcsViQYOqct4JwNUuQFBkSbPFt6CdfDOooljtKsBJk 80Ig== X-Forwarded-Encrypted: i=1; AJvYcCVo1N5cioReZwy0MYBBCieAyQhtVUga2yZNMWcrXBVkd767OMmjJqN3CQVI38EtZYpDpLNhcnAqat19QQ==@vger.kernel.org X-Gm-Message-State: AOJu0YzWqvoJbBZ+suBBDPhwHNDQndcY8tmihtdgfk+sdAqpm1SZ+HpR 93tZiEMYMd81G+etyP697lQBper9/Z/AzZjxIKkXbm0yN7KtD217EH+U X-Gm-Gg: ASbGncteN1gV3mJ4fv4iTIM2at+nQjxVjMhZy0GStvIZav8xatJOTa9MBJD7JoXavVr chvErLZyKRlktWhTi0HiWnP6cp95qRgP0Fl+VKdCHFOI8a4RrbE7wpu1+/pt7Q1pjUTRO/h3axC SSOUQnj278FF6WuKc1JefPL/qo+yENuHxejkR8M59AhYa+rtrnobdXCRIsEx4s2gsKn746mSnkp awFD88v9Uzt9Jp6hOUF5s/I5kLz3MqRT9uHnjzp39aBCi3TjzuOdn+xz1TUdVY5W5SbNBPHURqV 9z/6BOAx+HNlm2gBTqqpXIcw/blCKhgShY43UJQJWX6kvFxsEfIe0JyRY3W7L1gWVIXxHeMNkEj mZbyBVKtdLojv3kNKphV5S5ZfvXSGMFIVO65CqQKpAtaax1JhseGGykIlGPpzLt/mgI3JnAyH5E LsoNtedTFGhMAHJc9KCg== X-Google-Smtp-Source: AGHT+IFyT1Ik0zXeCGBE2QwHTLZmpbbOjcSgg1Wptb8qYhrZIBd25XN2NSqPB/D9VelyoqlG3l71LA== X-Received: by 2002:a05:600c:820b:b0:46e:6d5f:f59 with SMTP id 5b1f17b1804b1-47117878465mr37367015e9.4.1760715357144; Fri, 17 Oct 2025 08:35:57 -0700 (PDT) Received: from giga-mm.home ([2a02:1210:8642:2b00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5cfe69sm42472598f8f.32.2025.10.17.08.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Oct 2025 08:35:56 -0700 (PDT) Message-ID: <336e169019bd3eadc475c981abef3db07149a5db.camel@gmail.com> Subject: Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers automatic module loading From: Alexander Sverdlin To: Herve Codina Cc: David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai , Nikita Shubin , Axel Lin , Brian Austin , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni Date: Fri, 17 Oct 2025 17:35:56 +0200 In-Reply-To: <20251017171024.5a16da34@bootlin.com> References: <20251016130340.1442090-1-herve.codina@bootlin.com> <20251016130340.1442090-2-herve.codina@bootlin.com> <60fbaaef249e6f5af602fe4087eab31cd70905de.camel@gmail.com> <20251017083232.31e53478@bootlin.com> <20251017171024.5a16da34@bootlin.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Herve, On Fri, 2025-10-17 at 17:10 +0200, Herve Codina wrote: > > > > > In order to have the I2C or the SPI module loaded automatically, = move > > > > > the MODULE_DEVICE_TABLE(of, ...) the core to I2C and SPI parts. > > > > > Also move cs4271_dt_ids itself from the core part to I2C and SPI = parts > > > > > as both the call to MODULE_DEVICE_TABLE(of, ...) and the cs4271_d= t_ids > > > > > table itself need to be in the same file.=C2=A0=C2=A0=C2=A0=20 > > > >=20 > > > > I'm a bit confused by this change. > > > > What do you have in SYSFS "uevent" entry for the real device?=C2=A0= =20 > > >=20 > > > Here is my uevent content: > > > --- 8<--- > > > # cat /sys/bus/i2c/devices/3-0010/uevent=20 > > > DRIVER=3Dcs4271 > > > OF_NAME=3Dcs4271 > > > OF_FULLNAME=3D/i2c@ff130000/cs4271@10 > > > OF_COMPATIBLE_0=3Dcirrus,cs4271 > > > OF_COMPATIBLE_N=3D1 > > > MODALIAS=3Dof:Ncs4271T(null)Ccirrus,cs4271 > > > #=20 > > > --- 8< ---=C2=A0=20 > >=20 > > that's what I get with SPI-connected CS4271, and this is actually what = I'd > > expect (linux-next as of 2433b8476165): > >=20 > > # cat /sys/bus/spi/devices/spi0.0/uevent > > DRIVER=3Dcs4271 > > OF_NAME=3Dcodec > > OF_FULLNAME=3D/soc/spi@808a0000/codec@0 > > OF_COMPATIBLE_0=3Dcirrus,cs4271 > > OF_COMPATIBLE_N=3D1 > > MODALIAS=3Dspi:cs4271 >=20 > So, this is without my patch applied. this is the modalias of the device, it doesn't depend on your patch series. I'd say that modalias for SPI device is correct but commit c973b8a7dc50 lacks MODULE_DEVICE_TABLE(spi, ...) in the driver. I'd argue that I2C modalias is correct in the driver: # modinfo snd-soc-cs4271-i2c ... alias: i2c:cs4271 But I still have to understand what happened to I2C core. > I don't have any CS4271 connected on SPI bus to perform the same test > with my patch applied. --=20 Alexander Sverdlin.