From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 801932D94BE for ; Mon, 27 Oct 2025 06:02:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761544960; cv=none; b=josSRtArEBRejPuD6C+OHd5rjwj3PLehusEykTd1kQUtfMWer+k4Wob4Ij8JF7T9J3UH2QaG+mMr4ktxe2U1nVCOjcgpcvd5WBequwyo5T80sLdZWlo96b4SIzWuMybyrLdWyprMqvVSVivOTl3l0J1OSuXgIl3kUIFHMxFBFi0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761544960; c=relaxed/simple; bh=wwxjb9DR1LvG1RHmq4IzS3Xkgi6qBkuv3E66RDriplY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=a+nAtEUvtPG7DKmTHWA2FK0HRUrHwW/WyUkmYQ1M8XA5wkgRawhgW8ufpQnRLJfkCaio9miSoGLWkxvBCzC35HSelDNgUcinhay4dmUVsa5bneSLbgFjjxaq8BHlvz7hf5IldTGiTG/C3o+qUwL47ST54FfCVKkZ4QVcB3LUW/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eW3t6yED; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eW3t6yED" Content-Type: text/plain; charset=utf-8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761544944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bj8GkUukbIV/nY1dITAAUkOq2qqZTJboBaZcti6jOVo=; b=eW3t6yEDhpSPFgg2UJi5MB6cQTIbszIT8oDC7AjP4L3JyOp2HpNkvz00n6WHt/U2KGx+Ut RI61OU/Q/LncM/4s6Q3kJevv80jt51KK5SCbahc7PsDAmjBxRYip9U50cYBXHq0aJtDqch gpeQzoAP3Lpd/sOj54YC0svDbY+Y+Xs= Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.100.1.1.5\)) Subject: Re: [PATCH v1 2/2] ALSA: hda/realtek: Add match for ASUS Xbox Ally projects X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Matthew Schwartz In-Reply-To: Date: Sun, 26 Oct 2025 23:01:54 -0700 Cc: Shenghao Ding , Baojun Xu , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <35A5783A-CA60-4B10-8C7B-5820B65307FE@linux.dev> References: <20251026191635.2447593-1-lkml@antheas.dev> <20251026191635.2447593-2-lkml@antheas.dev> To: Antheas Kapenekakis X-Migadu-Flow: FLOW_OUT > On Oct 26, 2025, at 12:19=E2=80=AFPM, Antheas Kapenekakis = wrote: >=20 > On Sun, 26 Oct 2025 at 20:16, Antheas Kapenekakis = wrote: >>=20 >> Bind the realtek codec to TAS2781 I2C audio amps on ASUS Xbox Ally >> projects. While these projects work without a quirk, adding it = increases >> the output volume significantly. >=20 > Also, if you can upstream the firmware files: > TAS2XXX13840.bin > TAS2XXX13841.bin > TAS2XXX13940.bin > TAS2XXX13941.bin This is the firmware at [1], correct? I=E2=80=99m testing the series = with that firmware on my ROG Xbox Ally X, and I found something = interesting. By default, with just your kernel patches and the firmware files hosted = at [1], my unit is loading: tas2781-hda i2c-TXNW2781:00-tas2781-hda.0: Loaded FW: TAS2XXX13840.bin, = sha256: 58cffa36ae23a2d9b2349ecb6c1d4e89627934cd79218f6ada06eaffe6688246 However, with this firmware file, TAS2XXX13840.bin, there is = significant audio clipping above 75% speaker level on my individual = unit. Then, I tried renaming the other firmware file, TAS2XXX13841.bin, into = TAS2XXX13840.bin. Now my unit is loading: tas2781-hda i2c-TXNW2781:00-tas2781-hda.0: Loaded FW: TAS2XXX13840.bin, = sha256: 0fda76e7142cb455df1860cfdb19bb3cb6871128b385595fe06b296a070f4b8c With this firmware file, audio is perfect all the way to 100% speaker = level. If I recall, there have been other ASUS products that required matching = amplifier hardware with firmware correctly, right? It looks like this = might be another case of since it seems my unit is loading the wrong = firmware for its amplifiers. Matt [1]: https://github.com/hhd-dev/hwfirm >=20 > That would be great :) >=20 > Antheas >=20 >> Cc: stable@vger.kernel.org # 6.17 >> Signed-off-by: Antheas Kapenekakis >> --- >> sound/hda/codecs/realtek/alc269.c | 2 ++ >> 1 file changed, 2 insertions(+) >>=20 >> diff --git a/sound/hda/codecs/realtek/alc269.c = b/sound/hda/codecs/realtek/alc269.c >> index 8ad5febd822a..d1ad84eee6d1 100644 >> --- a/sound/hda/codecs/realtek/alc269.c >> +++ b/sound/hda/codecs/realtek/alc269.c >> @@ -6713,6 +6713,8 @@ static const struct hda_quirk = alc269_fixup_tbl[] =3D { >> SND_PCI_QUIRK(0x1043, 0x12f0, "ASUS X541UV", = ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), >> SND_PCI_QUIRK(0x1043, 0x1313, "Asus K42JZ", = ALC269VB_FIXUP_ASUS_MIC_NO_PRESENCE), >> SND_PCI_QUIRK(0x1043, 0x1314, "ASUS GA605K", = ALC285_FIXUP_ASUS_GA605K_HEADSET_MIC), >> + SND_PCI_QUIRK(0x1043, 0x1384, "ASUS RC73XA", = ALC287_FIXUP_TXNW2781_I2C), >> + SND_PCI_QUIRK(0x1043, 0x1394, "ASUS RC73YA", = ALC287_FIXUP_TXNW2781_I2C), >> SND_PCI_QUIRK(0x1043, 0x13b0, "ASUS Z550SA", = ALC256_FIXUP_ASUS_MIC_NO_PRESENCE), >> SND_PCI_QUIRK(0x1043, 0x1427, "Asus Zenbook UX31E", = ALC269VB_FIXUP_ASUS_ZENBOOK), >> SND_PCI_QUIRK(0x1043, 0x1433, "ASUS = GX650PY/PZ/PV/PU/PYV/PZV/PIV/PVV", ALC285_FIXUP_ASUS_I2C_HEADSET_MIC), >> -- >> 2.51.1 >>=20 >>=20 >=20 >=20