From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
Cc: <linux-sound@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v2 0/2] ASoC: codecs: lpass-{wsa,va}-macro: check clk_set_rate() return value
Date: Wed, 15 Jul 2026 15:45:01 +0200 [thread overview]
Message-ID: <367e9b6f-da60-4b59-995d-3f3a07231447@intel.com> (raw)
In-Reply-To: <20260715-xo-sd-codec-wsa-va-clk-set-rate-v2-0-16ca64c2b929@oss.qualcomm.com>
On 7/15/2026 1:55 PM, Ajay Kumar Nandam wrote:
> clk_set_rate() returns 0 on success or a negative errno on failure but
> the WSA and VA macro probe functions are ignoring it. This series adds
> return value checking and bails out of probe on failure.
>
> This mirrors the same fix already posted for the TX and RX macros [1].
>
> [1] https://lore.kernel.org/all/20260707-xo-sd-codec-tx-rx-v2-3-f61b4622f97f@oss.qualcomm.com/
>
> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
> ---
> Changes in v2:
> - Use present tense in commit messages
> - Carry Reviewed-by tag from Konrad
> - Link to v1: https://patch.msgid.link/20260715-xo-sd-codec-wsa-va-clk-set-rate-v1-0-f0c713ff0b4e@oss.qualcomm.com
Not CC'ing reviewers is frowned upon on the list.
Nonetheless, thank you for addressing the comments. For the series:
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2026-07-15 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 11:55 [PATCH v2 0/2] ASoC: codecs: lpass-{wsa,va}-macro: check clk_set_rate() return value Ajay Kumar Nandam
2026-07-15 11:55 ` [PATCH v2 1/2] ASoC: codecs: lpass-wsa-macro: " Ajay Kumar Nandam
2026-07-15 11:55 ` [PATCH v2 2/2] ASoC: codecs: lpass-va-macro: " Ajay Kumar Nandam
2026-07-15 13:45 ` Cezary Rojewski [this message]
2026-07-20 15:01 ` [PATCH v2 0/2] ASoC: codecs: lpass-{wsa,va}-macro: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367e9b6f-da60-4b59-995d-3f3a07231447@intel.com \
--to=cezary.rojewski@intel.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox