Re: [PATCH] ASoC: rt1320: avoid re-initialize in advanced mode

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 9/9/26 11:18, shumingf@realtek.com wrote:
> From: Shuming Fan <shumingf@realtek.com>
> 
> On some machines, speaker protection is enabled.
> We call this advanced mode, which loads the DSP firmware and changes settings
> based on the basic mode, including blind writes.
> The amplifier can retain the advanced mode settings until a POR or power loss occurs.
> Therefore, the driver does not need to switch from basic mode to advanced mode
> when the system performs a warm reboot.
> We only need to check the function_status to determine
> whether the system has undergone a cold or warm reboot.
> 
> Fixes: 9b30521074f0 ("ASoC: rt1320: run the initialisation preset on the first hardware init")
> Signed-off-by: Shuming Fan <shumingf@realtek.com>

LGTM

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

this should also be done for all existing SDCA devices, no?

> ---
>  sound/soc/codecs/rt1320-sdw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c
> index 72af413306fa..444a91755be9 100644
> --- a/sound/soc/codecs/rt1320-sdw.c
> +++ b/sound/soc/codecs/rt1320-sdw.c
> @@ -2470,7 +2470,7 @@ static int rt1320_io_init(struct device *dev, struct sdw_slave *slave)
>  	dev_dbg(dev, "%s amp func_status=0x%x\n", __func__, amp_func_status);
>  
>  	/* initialization write */
> -	if ((amp_func_status & FUNCTION_NEEDS_INITIALIZATION) || !rt1320->first_hw_init) {
> +	if ((amp_func_status & FUNCTION_NEEDS_INITIALIZATION)) {
>  		switch (rt1320->dev_id) {
>  		case RT1320_DEV_ID:
>  			if (rt1320->version_id < RT1320_VC)