From: Neil Armstrong <neil.armstrong@linaro.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema
Date: Fri, 7 Jun 2024 11:22:55 +0200 [thread overview]
Message-ID: <3b46ff8b-3095-4170-ab94-3410cf841383@linaro.org> (raw)
In-Reply-To: <20240606041212.78428-1-animeshagarwal28@gmail.com>
On 06/06/2024 06:12, Animesh Agarwal wrote:
> Convert the dummy SPDIF receiver bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>
> ---
> Changes in v2:
> - Add linux,spdif-dir compatible in existing linux,spdif-dit.yaml
> instead of creating new yaml file specifically for dummy SPDIF receiver.
> - Change file name to support both transmitter and receiver bindings.
> ---
> .../sound/{linux,spdif-dit.yaml => linux,spdif.yaml} | 8 +++++---
> .../devicetree/bindings/sound/spdif-receiver.txt | 10 ----------
> 2 files changed, 5 insertions(+), 13 deletions(-)
> rename Documentation/devicetree/bindings/sound/{linux,spdif-dit.yaml => linux,spdif.yaml} (75%)
> delete mode 100644 Documentation/devicetree/bindings/sound/spdif-receiver.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
> similarity index 75%
> rename from Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
> rename to Documentation/devicetree/bindings/sound/linux,spdif.yaml
> index fe5f0756af2f..0f4893e11ec4 100644
> --- a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
> +++ b/Documentation/devicetree/bindings/sound/linux,spdif.yaml
> @@ -1,10 +1,10 @@
> # SPDX-License-Identifier: GPL-2.0
> %YAML 1.2
> ---
> -$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
> +$id: http://devicetree.org/schemas/sound/linux,spdif.yaml#
> $schema: http://devicetree.org/meta-schemas/core.yaml#
>
> -title: Dummy SPDIF Transmitter
> +title: Dummy SPDIF Transmitter/Receiver
>
> maintainers:
> - Mark Brown <broonie@kernel.org>
> @@ -14,7 +14,9 @@ allOf:
>
> properties:
> compatible:
> - const: linux,spdif-dit
> + enum:
> + - linux,spdif-dit
> + - linux,spdif-dir
>
> "#sound-dai-cells":
> const: 0
> diff --git a/Documentation/devicetree/bindings/sound/spdif-receiver.txt b/Documentation/devicetree/bindings/sound/spdif-receiver.txt
> deleted file mode 100644
> index 80f807bf8a1d..000000000000
> --- a/Documentation/devicetree/bindings/sound/spdif-receiver.txt
> +++ /dev/null
> @@ -1,10 +0,0 @@
> -Device-Tree bindings for dummy spdif receiver
> -
> -Required properties:
> - - compatible: should be "linux,spdif-dir".
> -
> -Example node:
> -
> - codec: spdif-receiver {
> - compatible = "linux,spdif-dir";
> - };
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-06-07 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 4:12 [PATCH v2] ASoC: dt-bindings: linux,spdif: Convert spdif-reciever.txt to dtschema Animesh Agarwal
2024-06-07 9:22 ` Neil Armstrong [this message]
2024-06-10 21:58 ` Rob Herring
2024-06-12 17:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b46ff8b-3095-4170-ab94-3410cf841383@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox