Re: [PATCH 1/3] ASoC: SDCA: Add correct masks whilst reporting SDCA jack status

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 4/29/26 15:10, Charles Keepax wrote:
> On Tue, Apr 28, 2026 at 10:18:17PM +0200, Pierre-Louis Bossart wrote:
>> On 4/27/26 13:59, Charles Keepax wrote:
>>> Currently, all SDCA jacks simply report against a mask of 0xFFFF. This
>>> works fine for system with a single SDCA jack control as the status
>>> reflects that single control at all times. However, if two SDCA
>>> jack controls exist in the system, such as a separate representation for
>>> input and output, then the second control can cancel reports from the
>>> other since it will only report its relevant bits and zero in all other
>>> slots. This is exactly what the mask is for.
>>>
>>> Build up a mask using all the possible states for an SCDA jack control
>>> at registration time and use that mask when reporting a particular jack.
>>> It is worth noting this still doesn't handle cases such as two headphone
>>> jacks as that would require separate ALSA jacks to report to.
>>
>> I couldn't quite get the last sentence. If you have two
>> functions for separate headphones, where would you have a
>> conflict?
> 
> For the SDCA side this is fine, as in we create our controls
> there is enough to distinguish everything.
> 
>> Don't you have separate ALSA jacks created independently by
>> each function?
> 
> For the ALSA jack side we still have a jack object being created at
> the machine driver level. Primarily because the existing jack
> APIs require a card pointer. There is certainly an argument to
> pull this into the class driver itself, such as we did for the
> mic and speaker widgets. Doing so would let us support even more
> topologies however that is definitely a bigger piece of work.

ok, thanks for the explanation. the TODO list seems like a Hilbert hotel, always some way to expand it with new things...

> But either way this change is helpful we should really mask for
> the bits we are reporting.

ack.